5032 commits

Author	SHA1	Message	Date
Robert Müller	2e46460302	Add popup to confirm connecting to friend on non-official server	2023-05-19 15:51:05 +02:00
Robert Müller	1bea7a2cd5	Show race disconnect confirmation when joining friend ... Closes #6622.	2023-05-19 15:16:32 +02:00
Robert Müller	fc3583a18e	Show official server icon in friends list ... Show the official server icon for online friends who are currently on official servers.	2023-05-19 15:15:44 +02:00
Robert Müller	637f7fd736	Reduce duplicate UI spacing code	2023-05-19 15:14:46 +02:00
Robert Müller	b33ce0f37d	Change friend info text to Map | Mode | Country/Ping	2023-05-18 23:06:29 +02:00
Robert Müller	a2cbc7fb24	Render tees for online friends in friends list ... Closes #6614.	2023-05-18 22:03:43 +02:00
Robert Müller	15f839960a	Port friends list UI from 0.7 ... Separate friends list into three groups, which can be expanded and collapsed: online players, online clanmates and offline friends. Friends with the same name/clan are no longer grouped together. Instead, each individual player that is online and has name/clan matching a friend is shown in either the online players or online clanmates group. Friends for which no matching players are found are shown in the offline group. Friends in the friend list can no longer be selected. Instead, left-clicking a friend selects the server that the friend is on. Double-clicking a friend joins the server that they are playing on. Render small X button in top-right corner of every friend list entry to remove the respective friend instead of using one button that removes the selected friend. Change "Add Friend" button to "Add Clan" when only clan is entered. Remove excess empty space from layout. Closes #6326.	2023-05-18 16:46:26 +02:00
bors[bot]	373595dec8	Merge #6608 ... 6608: Support rendering tooltips with multiple lines of text, support overlapping tooltip activation rects, add alpha fade-in for tooltips r=edg-l a=Robyt3 ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-05-18 11:24:25 +00:00
Robert Müller	47fca7683d	Add alpha fade-in for tooltips ... After 0.75 seconds of hovering the tooltip rect without rendering the tooltip, start fading in the tooltip for the remaining 0.25 seconds.	2023-05-18 13:22:52 +02:00
Robert Müller	13ed0e386a	Use const when possible	2023-05-18 12:21:34 +02:00
Robert Müller	fe359e2909	Combine Margin function calls ... Both calls put a margin around the same rect but the intermediate result is never used, so both margins can be combined. The variable `Screen` is also not necessary.	2023-05-18 12:20:53 +02:00
Robert Müller	f60dd0d3c2	Fix name of static variable s_LastLoadRender	2023-05-18 12:19:10 +02:00
Robert Müller	af67130dbd	Use nullptr for unused UI rect splitting parameters	2023-05-18 12:18:22 +02:00
Robert Müller	05f2b19391	Remove unused SLabelProperties Props variable	2023-05-18 12:17:15 +02:00
Robert Müller	31304c4573	Support overlapping tooltip activation rects ... When the activation rects for two tooltips overlap, this always causes the first tooltip to be rendered. This is changed so the last active tooltip is rendered instead, to simplify the usage of the tooltip function.	2023-05-18 12:12:44 +02:00
Robert Müller	ed09bba45a	Support rendering tooltips with multiple lines of text ... Render tooltip text correctly with multiple lines when the maximum tooltip width is limited. Add missing padding when rendering multi-line tooltip. Update doxygen documentation.	2023-05-18 12:12:26 +02:00
bors[bot]	a38dea4454	Merge #6590 ... 6590: Make text containers bit safer r=Robyt3 a=Jupeyy From reading the code I couldn't understand how https://github.com/ddnet/ddnet/issues/5143#issuecomment-1546735484 could happen either (checked = not the case): - [x] teini used an outdated client - [ ] i am blind - [ ] it was a name/clan -plate, scoreboard entry - [ ] it leaked somewhere in text.cpp or similar impl - [ ] it happened because of an outside write. We don't really come further with this, so we should probably at least try it out? `@Robyt3` your opinion? We can still always remove it again ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2023-05-14 19:16:16 +00:00
bors[bot]	cca6d867cb	Merge #6588 #6589 ... 6588: Add default argument to `CDataFileReader/IMap::GetItem` r=def- a=Robyt3 Add default value `nullptr` for `int *pType` and `int *pID` output parameters of `GetItem` functions. Use `nullptr` instead of `0`. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 6589: Fix heap-use-after-free when quitting/restarting r=def- a=Robyt3 Items and particles were also rendered in the client states quitting and restarting, which was causing accesses to the already freed map data. Closes #6387 until further notice. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-05-14 18:58:08 +00:00
Jupeyy	370d37b8fd	Add shared ptr to track usage	2023-05-14 20:21:59 +02:00
Robert Müller	f3e8513477	Fix heap-use-after-free when quitting/restarting ... Items and particles were also rendered in the client states quitting and restarting, which was causing accesses to the already freed map data.	2023-05-14 18:12:47 +02:00
Robert Müller	d08626cf69	Add default argument to CDataFileReader/IMap::GetItem ... Add default value `nullptr` for `int *pType` and `int *pID` output parameters of `GetItem` functions. Use `nullptr` instead of `0`.	2023-05-14 16:39:46 +02:00
bors[bot]	03d17a98ed	Merge #6585 ... 6585: Add client_score_kind field to serverinfo (followup) r=Robyt3 a=edg-l followup on #5960 (fixes conflicts) It specifies whether the scores are to be interpreted as times (string value starting with "time") or as points (string value starting with "points"). ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com> Co-authored-by: Edgar Luque <git@edgarluque.com>	2023-05-14 12:17:55 +00:00
bors[bot]	ada7c4d597	Merge #6497 ... 6497: Fix client crash/hang when launching without data directory r=edg-l a=Robyt3 Closes #4638. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [X] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-05-14 09:43:06 +00:00
Edgar	1ca7870bf2	fix conflicts	2023-05-14 11:22:06 +02:00
bors[bot]	e9d08a15fd	Merge #6560 ... 6560: Replace EntityEx with new netobjs r=edg-l a=trml This is a proposal for replacing EntityEx with new netobjects, like suggested in #5860. - Adds a new DDNetPickup that includes switch number - a new DDNetProjectile that replaces the old one (which is renamed to DDRaceProjectile) - includes switch number, tunezone and velocity/speed (plus a flag that can be used to send velocitiy of player projectiles with full precision) - switch number and subtype is added to DDNetLaser (to distinguish e.g. draggers with different strength) The pr removes EntityEx from the server, but keeps compatibility in the client. <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: trml <trml@users.noreply.github.com>	2023-05-14 08:43:02 +00:00
Edgar	1e319fa279	fix opacity for jumps	2023-05-11 23:04:05 +02:00
Edgar	0db2f6243f	fix nameplate related indicators opacity	2023-05-11 22:23:48 +02:00
Robert Müller	d9307ca756	Use FileExists/fs_is_file instead of opening file ... This is more concise and works more reliable e.g. on Windows. See: https://devblogs.microsoft.com/oldnewthing/20071023-00/?p=24713	2023-05-10 21:04:02 +02:00
bors[bot]	7fff049471	Merge #6575 ... 6575: Replace usages of `atan2f` and `atan2` with `std::atan2` r=def- a=Robyt3 Another leftover from #6372. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-05-09 22:26:22 +00:00
Robert Müller	58184c2d67	Replace usages of atan2f and atan2 with std::atan2 ... Another leftover from #6372.	2023-05-09 22:38:44 +02:00
Jupeyy	0b1960c532	Fix Y Alignment by respecting cursor height independent of character height	2023-05-08 17:49:05 +02:00
Robert Müller	98a8507184	Fix division by zero when using random theme with no themes	2023-05-08 14:04:22 +02:00
bors[bot]	1112c9e6b7	Merge #6566 ... 6566: Allow using rescue (/r) on health pickup r=heinrich5991 a=Robyt3 Check if character is in range of health pickup and don't set rescue position if that's the case, so rescue can be used to get out of the health pickup's freeze effect. The existing `m_Core.m_IsInFreeze` is not set so this should not have any side-effects. Closes #3330. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-05-08 11:31:39 +00:00
Robert Müller	b590eff24e	Add missing HUD text container deletion ... See #5143.	2023-05-07 15:37:08 +02:00
Robert Müller	72c2ed062b	Remove magic number 20.0f from pickup handling	2023-05-07 11:02:50 +02:00
Robert Müller	73091cdd83	Add CPickup::Type and CPickup::Subtype getters	2023-05-07 11:02:50 +02:00
Robert Müller	2596dac47a	Remove dead code	2023-05-07 11:02:50 +02:00
Robert Müller	ce4228e08a	Simplify by calculating broadcast render offset in OnRender ... And ensure that the render offset is recalculated after the window is resized.	2023-05-06 15:57:44 +02:00
Robert Müller	bd20423de2	Wrap long broadcast text instead of stopping ... Instead of stopping when a broadcast line exceeds the screen width, wrap the text to the next line. Otherwise one long line in a broadcast can end the rendering so following lines are skipped.	2023-05-06 15:56:34 +02:00
Robert Müller	5c78093da4	Fade out broadcast in last second, use text container ... Fade the broadcast alpha to zero in the last second that the broadcast is shown. Use text container to support the fade out and to make broadcast rendering more efficient.	2023-05-06 15:55:42 +02:00
Robert Müller	74c1f38ca0	Use str_next_token to reduce duplicate code ... Instead of manually splitting a string at newline characters.	2023-05-06 15:54:33 +02:00
Robert Müller	00ed9d0ecd	Fix horizontal centering of broadcast ... The screen also needs to be mapped when calculating the width of the broadcast text, otherwise the width is not correct and so the text is not correctly centered horizontally. The wrong text width was also being calculated when the text has multiple lines. Now `TextWidth` is used so the width is also correct for multi-line text.	2023-05-06 15:54:33 +02:00
Robert Müller	8617411bfa	Render broadcast only when online or in demo playback	2023-05-06 15:54:32 +02:00
Robert Müller	c2d0835743	Extract CBroadcast::RenderServerBroadcast function	2023-05-06 15:54:32 +02:00
Robert Müller	7afa11e92c	Extract CBroadcast::OnBroadcastMessage function	2023-05-06 15:54:28 +02:00
Robert Müller	6d2e2788e2	Use DefaultTextColor and DefaultTextOutlineColor	2023-05-06 15:22:58 +02:00
Robert Müller	4b2ec2c202	Remove dead code	2023-05-06 15:22:58 +02:00
bors[bot]	e16e271f17	Merge #6562 ... 6562: Fix server password input not being activated automatically, always move cursor to end when selecting all text r=Jupeyy a=Robyt3 ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-05-05 15:10:59 +00:00
Robert Müller	b4a7038fad	Fix server password input not being activated automatically	2023-05-05 16:20:55 +02:00
Robert Müller	1be1c9780c	Always move cursor to end when selecting all text	2023-05-05 16:20:54 +02:00
Robert Müller	a443d99ccf	Remove unused CMenus::setPopup function	2023-05-05 16:08:43 +02:00
Robert Müller	0c32eacbab	Make text container index type-safe ... Use `STextContainerIndex` wrapper instead of `int` for text container index for type-safety. Add missing checks to ensure valid text container index before rendering FPS and finish time text containers.	2023-05-05 15:58:17 +02:00
trml	e10f528215	Add net netobjs for projectile and pickup, extend ddnetlaser, remove EntityEx server-side	2023-05-04 23:43:05 +02:00
Jupeyy	54e013fa1a	Fix alpha fading in hud	2023-05-01 12:33:47 +02:00
Robert Müller	11cb72be32	Fix Ctrl+F not activating search box in browser and tee settings ... Closes #6537.	2023-04-28 17:17:30 +02:00
Robert Müller	abbe2ce1de	Use Height variable to reduce duplicate code	2023-04-27 20:47:56 +02:00
Robert Müller	5cb9902745	Fix variable name m_VictimTextWidth	2023-04-27 20:46:58 +02:00
Robert Müller	be68c5ad7a	Fix client crash on team kill message with invalid team ... The client crashes when a team kill message specifies a team for which no client can be found. This can easily happen when the server sends an unknown team on purpose. It may also happen sporadically during normal gameplay, assuming a team is dissolved or the last team member leaves at the same time as the kill message is received. The crash is fixed by not rendering any tee for these kill messages. The kill message text is always set depending on the team number in the team kill message, regardless of whether the team exists. Closes #6533.	2023-04-27 20:45:30 +02:00
Robert Müller	2e5f37c61b	Don't render switch number and delay for tiles where they are unused	2023-04-26 19:04:56 +02:00
Robert Müller	60c0da7c4d	Use IsValid***Tile functions ... Use the utility function to check if tele/speedup/switch/tune tile indices are valid. Using `IsValidSwitchTile` fixes that the switch number and delay were not updated when selecting freeze, deep freeze, deep unfreeze, live freeze and live unfreeze tiles, as those tiles were missing in the existing condition.	2023-04-26 19:04:56 +02:00
Robert Müller	ebb2e4253d	Port line input and IME support from 0.7 ... Port the line input (UI edit boxes, chat, console) and Input Method Editor (IME) support from upstream. Closes #4397. General ------------------------------ Fix issues with the text input. Closes #4346. Closes #4524. Word skipping (when holding Ctrl) is overhauled to be consistent with the Windows / Firefox experience that I took as reference. Improve usability by not blinking (i.e. always rendering) the caret shortly after is has been moved. UI text input ------------------------------ Fix inconsistent mouse-based left and right scrolling (closes #4347). Support smooth left and right scrolling. Chat ------------------------------ Support keyboard-based text selection of the chat input. Mouse-based selection could be support in the future when we decide to add something like an ingame UI cursor. Support smooth up and down scrolling of the chat input, removing the old hack that offsets the input string to simulate scrolling. Console ------------------------------ Also support mouse-based text selection of the command input. Only text from either the command input or the console log can be selected at the same time. This ensures that Ctrl+C will always copy the text that is currently visually selected in the console. Check for Ctrl+C input event in event handler instead of in render function, to hopefully fix the issue that copying does not work sometimes (closes #5974 until further notice). When Ctrl+C is used to copy text from the console log, the selection is cleared. This should make it more clear when text was copied from the log. Fix an issue that was preventing the console log selection from being cleared, when all log lines are selected. Remove Ctrl+A/E hotkeys that move cursor to beginning/end respectively. Ctrl+A now selectes all text like for all other inputs. Home and End keys can still be used to go the beginning and end. Remove Ctrl+U/K hotkeys that clear everything before/after the cursor respectively. Hold shift and use Home/End to select everything instead. IME support ------------------------------ Render list of IME candidates in the client on Windows, so the candidate list can also be viewed in fullscreen mode. There is no API available to retrieve a candidate list on the other operating systems. Improve composition rendering by underlining the composition text instead of putting it in square brackets. Track active input globally to properly activate and deactivate IME through the SDL functions. Closes #1030. Closes #1008. Password rendering ------------------------------ Fix rendering of passwords containing unicode. Instead of rendering one star character for each UTF-8 `char`, render on star for every unicode codepoint. Show the composition text also for passwords. Without seeing the composition text it's hard to type a password containing those characters. The candidate window exposes the composition anyway. If you don't want to expose your password this way, e.g. while streaming, you could: 1. Use a latin password and switch off the IME for the password input with the IME hotkey. 2. Blank your screen with an external program while you are streaming and entering passwords. 3. Use binds to authenticate in rcon or to set the server browser password. Refactoring ------------------------------ Move all text input logic and general rendering to `CLineInput`. A `CLineInput` is associated with a particular `char` buffer given as a pointer either in the constructor or with `SetBuffer`. The maximum byte size of the buffer must also be specified. The maximum length in unicode codepoints can also be specified separately (e.g. on upstream, name are limited by the number of unicode codepoints instead). Add `CLineInputBuffered`, which is a `CLineInput` that own a `char` buffer of a fixed size, which is specified as a template argument. As `CLineInput` does not own a buffer anymore, this reduces duplicate code for line inputs that need their own buffer. Add `CLineInputNumber` which has additional convenience functions to consider the text as an `int` or `float`, to reduce duplicate code in those cases. In the future we could also add an input filter function so that only numbers can be entered in the number input. Add `CLineInput::SetClipboardLineCallback` to handle the case that multiple lines of text are pasted into a lineinput. This reduces duplicate code, as this behavior was previously implemented separately for chat and console. The behavior is also fixed to be consistent with the console on Windows, so the first line being pasted edits the current input text and then sends it instead of being sent on its own without the existing input text. Add `CalcFontSizeAndBoundingBox` to UI to reduce duplicate code. Expose `CalcAlignedCursorPos` as static member function to reuse it for line input. Dispatch input events to UI inputs through the event handler instead of storing them in a duplicate buffer. Use `size_t` for line input cursor position, length etc. and for `str_utf8_stats`. Add `IButtonColorFunction` to UI to describe a functions that defines colors for the Default, Active and Hovered states of UI elements. Add some default button color functions. Use button color function to reduce duplicate code in scrollbar rendering. Use `vec2` instead of two `floats` to represent the mouse positions in the text renderer. Remove `CaretPosition` again, as it does not calculate the correct Y position near line breaks due to the wrapping being different when not rendering the entire string. Instead, calculate the exact caret position when rending a text container and store the caret position in the text cursor for later use. IME usage guide (Windows) ------------------------------ 1. Install the respective language and the Microsoft-IME keyboard (e.g. for Chinese, Japanese or Korean). 2. Launch the game (or a text editor to first try out the IME). Note that Windows may track the input language separately for every application. You can change this in the Windows input settings so the input language is changed globally. 2. Switch the input language using the hotkey Windows+Space or another hotkey that you configured in the Windows input settings (Alt+Shift is the default, but you should consider disabling it, to avoid accidentally changing the input language while playing). 3. Switch from Latin/English input mode to the respective asian input mode. - Chinese: Use Ctrl+Space to switch between English and Chinese input mode. You can change this hotkey in the IME's settings. - Japanese: Use Ctrl+Space to switch between Alphanumeric and Hiragana/Katakana input mode. You can change this hotkey in the IME's settings. - Korean: Use Right Alt to switch between English and Hangul input mode. You cannot change this hotkey as of yet. - Note that the input mode is also tracked per application, but there is no setting to change this behavior as far as I know, so you'll need to switch for every application separately. 4. Start typing. The underlined text is the current composition text. While a composition is active, you can only edit the composition text. Confirm the composition with Space or by selecting a candidate from the candidate list with the arrow keys. Cancel the composition with Escape or by using Backspace to delete the composition text. Note that not all languages offer a candidate list. SDL version-specific issues ------------------------------ - 2.26.5, 2.24.2, 2.0.22: IME candidates work. But there are minor bugs when moving the composition cursor. - 2.0.18, 2.0.20: IME candidates work. - 2.0.16 (our current version): IME candidates cannot be determined with Windows API. Windows tries to draw the composition window like before, so this does not work in fullscreen mode. - 2.0.8 (upstream 0.7): IME candidates work. But this SDL version is too old for us.	2023-04-23 15:00:29 +02:00
Robert Müller	09462cff67	Use KEY_FIRST and KEY_UNKNOWN instead of 0	2023-04-21 18:47:44 +02:00
Robert Müller	ecc49a699f	Use size_t for number of input events	2023-04-21 18:44:49 +02:00
Robert Müller	2b7f054590	Use const reference to pass CEvent objects ... The size of the `CEvent` class is 140 bytes, so it's more efficient to pass objects by reference.	2023-04-21 18:44:48 +02:00
bors[bot]	cdd19beee4	Merge #6437 ... 6437: Make team kills condensed in killfeed r=heinrich5991 a=VoxelDoesCode For those who still have the killfeed on, I wanted to modernize it, by having team kills become one line instead of a bunch!  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: VoxelDoesCode <dante_n_cedroni@hotmail.com>	2023-04-21 10:37:40 +00:00
VoxelDoesCode	049d89ca41	Simplify NetMsg even more, with help from Fokko ... Quick changes Add m_First one more thing fokko pointed this out at 3 am Final push	2023-04-18 07:51:44 -04:00
bors[bot]	391c127cb3	Merge #6515 ... 6515: Add OnNewSnapshot to component hooks r=heinrich5991 a=ChillerDragon Waste some clock cycles on zero lines code removed :D Downstream client maintainers will love it tho ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: ChillerDragon <ChillerDragon@gmail.com>	2023-04-18 11:33:14 +00:00
Robert Müller	a2c9b752e0	Remove unused CListBox::FilterMatches	2023-04-15 13:07:40 +02:00
ChillerDragon	7c2c5aeee7	Add OnNewSnapshot to component hooks	2023-04-15 12:47:33 +02:00
Robert Müller	c7cea0a37f	Fix incorrect chat background rect width calculation ... The calculation of `m_LongestLineWidth` was adjusted in bf1e757581 so it's really the width of the line and not the X position of the end of the line. This caused the background rects of chat messages to be rendered incorrectly.	2023-04-15 12:17:49 +02:00
bors[bot]	b1f2862cff	Merge #6511 ... 6511: Refactor vertical alignment of UI labels, add more text render convenience functions r=def- a=Robyt3 Should change layout only very little. ### Notes if you are porting this downstream `SLabelProperties::m_AlignVertically` is removed. The usage was previously confusing and inconvenient, as the `SLabelProperties` parameter object was necessary to change the vertical alignment. If `m_AlignVertically == 1` (which is the default value) then the text is vertically centered and this works correctly also for multi-line text, assuming that the correct rect height is specified and the previous fixes have been applied (#6507). If `m_AlignVertically == 0` then the text is somehow more correctly aligned for some UI elements that span only one line in cases where the previous option doesn't work correctly. Other `m_AlignVertically` values besides `0` and `1` are not used. With this PR most text is centered vertically by setting `TEXTALIGN_MIDDLE`. The UI code always uses shorthand constants for combinations of horizontal and vertical alignment, e.g. `TEXTALIGN_MC` for `TEXTALIGN_MIDDLE | TEXTALIGN_CENTER`. To port your own code, I'd recommend replacing all of your usages of `TEXTALIGN_LEFT`, `TEXTALIGN_CENTER` and `TEXTALIGN_RIGHT` with `TEXTALIGN_ML`, `TEXTALIGN_MC` and `TEXTALIGN_MR` respectively. Remove all usages of `m_AlignVertically` and also the `SLabelProperties` variables for which only `m_AlignVertically` was changed. This means all text will be vertically centered and have the same horizontal alignment as before. For some labels the vertical centering does not work correctly though, so you'll have to visually check if any of the texts are misaligned and then manually adjust the alignment or the UI rect position and/or size. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-04-10 17:29:23 +00:00
bors[bot]	4d697c7be3	Merge #6509 ... 6509: Fix client crash when spectating on server with missing game info r=def- a=Robyt3 ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-04-10 17:08:19 +00:00
Robert Müller	301567507f	Fix client crash when spectating on server with missing game info	2023-04-10 17:27:21 +02:00
Robert Müller	8f5708a882	Use TextBoundingBox for tooltip rendering ... Calculate correct height for tooltip and apply consistent padding. Ensure tooltip width and height do not exceed size of screen.	2023-04-10 17:22:10 +02:00
Robert Müller	a6f9fdd6d5	Add function to get caret position to ITextRender ... Add `CaretPosition` function to get position of text caret. Replace some existing usages of `TextWidth`, which would no longer work correctly for multi-line text. Having this function is also useful when porting the upstream UI lineinput.	2023-04-10 17:22:10 +02:00
Robert Müller	9ad2f9f4df	Add functions to get text bounding box to ITextRender ... Add separate `STextBoundingBox` to describe text bounding box (same as on upstream). Add `GetBoundingBoxTextContainer` to get bounding box for a text container. Add `TextBoundingBox` function to get bounding box with old text render interface. Using this function to get the bounding box width and height is cleaner than using `TextWidth`. This function additionally can get the bounding box X and Y position for convenience. Some usages of `TextWidth` are replaced with `TextBoundingBox` to improve readability. It will be useful to have these functions when porting the upstream UI lineinput.	2023-04-10 17:22:10 +02:00
Robert Müller	8507a651d1	Refactor vertical alignment in UI ... Add separate constants `TEXTALIGN_TOP`, `TEXTALIGN_MIDDLE` and `TEXTALIGN_BOTTOM` for vertical alignment. Add shorthand constants for all possible combinations of horizontal and vertical alignment, e.g. `TEXTALIGN_MC` for `TEXTALIGN_MIDDLE | TEXTALIGN_CENTER`. Replace usage of `SLabelProperties::m_AlignVertically` with these constants in all menu and editor code for more convenient and versatile alignment of text. Use combined horizontal-vertical alignment constants for all existing labels. Manually adjust layout for some elements which were initially misaligned with the new implementation. Refactoring: - Use `CORNER_NONE` instead of `0`. - Improve some `CUIRect` variables names and usage.	2023-04-10 17:22:09 +02:00
Robert Müller	76ad9e2e3b	Use Localizable instead of comment with Localize	2023-04-10 16:43:53 +02:00
Robert Müller	430e96346f	Fix inconsistent text wrapping of popup labels ... Round up the calculated text width to prevent inconsistent text wrapping in the popups in cases where the current text width is very close to the maximum line width.	2023-04-09 20:10:44 +02:00
Robert Müller	6decf14137	Use Text instead of TextEx for popup labels ... To reduce duplicate code and ensure that the same flags are used with `TextWidth` and when actually rendering the text.	2023-04-09 20:10:44 +02:00
Robert Müller	9bb9c7ce6b	Replace usages of TextLineCount with TextWidth ... Calculate text height for popups with `TextWidth` instead of using `TextLineCount`, which can be incorrect if the aligned font size differs from the normal one.	2023-04-09 20:10:44 +02:00
Robert Müller	9693d4beac	Fix vertical centering of multi-line UI labels ... Also calculate text height in `TextWidth`. Use calculated text height to verically center UI labels. The text cursor flags (in particular, the `TEXTFLAG_STOP_AT_END` flag) must also be passed to `TextWidth`. Otherwise, for example, when `TEXTFLAG_STOP_AT_END` is missing, the wrong text height is calculated, as text is rendered over multiple lines instead of stopping at the end of the first line. Closes #5396.	2023-04-09 20:10:09 +02:00
Robert Müller	07c59d130b	Minor refactoring of DoLabel functions	2023-04-09 20:10:09 +02:00
Robert Müller	ede3e5631f	Move generic popup handling to UI (port from editor and upstream) ... Support using editor popup rendering in game client. Support unlimited number of popup menus instead of maximum of 8. Fix non-active popups handling key events. Add `Active` parameter to popup function, so key events are only processed by the active (top-most) popup. Previously the "New folder" popup could be confirmed with enter while an error message is shown, which causes multiple error messages to stack. Allow popups to close without closing their child popups. Previously a popup could not open another popup and close itself immediately afterwards, as this was causing the newly opened popup to be closed instead. Support using return/enter keys to confirm binary choice popups and to close message popups for more convenient usage.	2023-04-07 17:16:16 +02:00
Robert Müller	72775f236b	Let CUI::Screen return a const pointer ... Callers should never modify the UI screen.	2023-04-07 11:50:48 +02:00
Valentin Bashkirov	85485d23ce	highlight game type	2023-04-05 20:02:25 +02:00
VoxelDoesCode	df48c44e78	Bring every Font Icon unicode into a namespace ... Fix namespace hopefully	2023-04-03 20:25:28 -04:00
VoxelDoesCode	0dfced4ca4	Bring Team logic into teams.cpp ... MsgPlus -> Msg	2023-04-02 21:40:39 -04:00
Dennis Felsing	5fa2fefd35	Remove unused DoFilter ... Thanks to cheeser0613	2023-04-01 13:39:20 +02:00
Jupeyy	ffe3d26e59	fix start size of freezing flakes particles & vel of player death	2023-03-28 21:33:48 +02:00
bors[bot]	a27dbb1219	Merge #6435 ... 6435: add proof mode for menu backgrounds closes #3009 r=def- a=Marmare314  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: marmare314 <49279081+Marmare314@users.noreply.github.com>	2023-03-27 14:48:18 +00:00
VoxelDoesCode	5b1a716aa2	Simplify KillMsgTeams NetMsg, fixing bugs ... Clang format before squash Split apart OnMessage() before squash forgot something	2023-03-26 23:32:34 -04:00
bors[bot]	b207826df1	Merge #6470 ... 6470: Fix ninja not getting predicted r=heinrich5991 a=Zwelf Fixes #6464 This was regressed by #6246 by the wrong transformation of `if(!m_FreezeTime)` to `if(m_FreezeTime != 0)` instead of the correct `if(m_FreezeTime == 0)`. And take additional measure to never set m_FreezeTime to a negative number in client prediction code. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Zwelf <zwelf@strct.cc>	2023-03-26 14:50:25 +00:00
Zwelf	d40ff12d9a	Fix ninja dash not getting predicted correctly ... Fixes #6464 This was regressed by #6246 by the wrong transformation of `if(!m_FreezeTime)` to `if(m_FreezeTime != 0)` instead of the correct `if(m_FreezeTime == 0)`. And take additional measure to never set m_FreezeTime to a negative number in client prediction code.	2023-03-26 16:42:31 +02:00
Robert Müller	1b19895204	Ensure texture is cleared when rendering MOTD background ... Seems like there are cases where the texture is not cleared when the MOTD background is rendered, so part of the font texture is used for the round rect.	2023-03-26 13:15:36 +02:00
Ravie	20ac914e0e	Tooltip ID	2023-03-25 16:13:29 +01:00
Ravie	eb41ecf3d7	Icon button, tooltip and various fixes	2023-03-25 15:43:25 +01:00
Ravie	705be7c6e3	Implement random skin button	2023-03-25 13:11:47 +01:00
Robert Müller	880ced2de0	Fix dummy tee being able to ping main tee in chat ... Main and dummy tee cannot ping each other anymore. Other main and dummy tees can still ping your own main and dummy tees. We must ensure to only use `m_aLocalIDs[1]` when the dummy is connected, as this ID is not updated when no dummy is connected, so it can refer to another client if you disconnect your dummy and another client subsequently takes its client ID. Closes #3699.	2023-03-23 20:24:28 +01:00
bors[bot]	971b166488	Merge #6439 ... 6439: Refactor `random` functions r=heinrich5991 a=Robyt3 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-03-23 12:56:55 +00:00
Robert Müller	a91b51c8a2	Select language on first start based on user locale ... On first client start (when `cl_show_welcome` is `1`), determine the user locale with `os_locale_str` and initially select the most fitting language for this locale. For this the language index must also be loaded immediately on client launch, before the initial language is loaded.	2023-03-21 21:17:40 +01:00
Robert Müller	481698c7d0	Move CLanguage and LoadLanguageIndexfile to localization ... The `CLanguage` class and `LoadLanguageIndexfile` function are more appropriately located in the file for the other localization functions.	2023-03-21 21:17:40 +01:00
VoxelDoesCode	929675be68	Make team kills condensed in killfeed ... Clang + Formatting test before merge	2023-03-18 23:27:59 -04:00
bors[bot]	22b7e5eaf4	Merge #6438 ... 6438: Fix incorrect tee blood color being shown in settings r=def- a=Robyt3 When the tee color lighting is set to 0, the blood color was shown as black instead of the actual tee blood color. The blood color used ingame is already correct and now matches the color shown in the settings. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-03-18 22:14:29 +00:00
Robert Müller	484df7fc79	Support holding shift for slow mouse with color pickers ... When picking a color with a color picker also support holding shift to move the mouse slowly (at 5% normal speed) like for scrollbars.	2023-03-18 22:24:46 +01:00
Robert Müller	a9ef757475	Add random_float functions with min and max arguments ... Add `random_float(float min, float max)` to generate a random `float` between `min` and `max`. Add `random_float(float max)` to generate a random `float` between `0.0f` and `max`.	2023-03-18 12:09:37 +01:00
Robert Müller	0cf5dd7ad3	Add random_direction function ... Replace existing `RandomDir` with this function. This function was biased towards the corners, as it first generates a random `vec2` with `x` and `y` in `[-0.5f;0.5f]` and then normalizes it, which doesn't result in a uniform distribution of directions. Now the random direction is generated by taking a random angle and then converting it to a direction which is per definition already normalized.	2023-03-18 12:09:37 +01:00
Robert Müller	ea6e267d98	Add random_angle function ... To generate a random angle in the range `[0.0f;2.0f * pi[`. This ensures that the random angle cannot be `2.0f * pi`, which would be identical to the angle `0.0f` and therefore cause the random angle to be less uniformly selected. Note that this first casts `RAND_MAX` to a `float` and then uses `std::nextafter` to get the next larger `float`. Using `RAND_MAX + 1` would cause an integer overflow on systems where `RAND_MAX == INT_MAX` (e.g. Ubuntu and macOS).	2023-03-18 12:07:52 +01:00
Robert Müller	d2bd863c79	Fix incorrect tee blood color being shown in settings ... When the tee color lighting is set to 0, the blood color was shown as black instead of the actual tee blood color. The blood color used ingame is already correct and now matches the color shown in the settings.	2023-03-18 11:09:49 +01:00
marmare314	0cbc725235	fix formatting and include array	2023-03-18 08:07:25 +01:00
marmare314	9537656e57	use array again and consider checkpoints	2023-03-17 19:25:50 +01:00
marmare314	0ce70f863b	add proof mode for menu backgrounds closes #3009	2023-03-17 18:37:55 +01:00
marmare314	fe221dab23	implement draggable layers	2023-03-17 11:28:08 +01:00
bors[bot]	5241c4ce5f	Merge #6425 ... 6425: Don't add duplicate consecutive commands to console history r=heinrich5991 a=Robyt3 Don't add entered command to console history, if the last console history entry is identical to this command. For example, entering the commands `1`, `2`, `3`, `3`, `2`, `1` adds 5 entries to the history, i.e. only one entry for the command `3`. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-03-16 20:29:33 +00:00
Robert Müller	66ad9536fe	Extend CScrollRegion to support scrolling when mouse at edge ... Add `ScrollRelative` function to initiate relative scrolling programmatically, to realise scroll regions that scroll when the mouse is being dragged at the edge. Add `DoEdgeScrolling` to encapsulate all the necessary edge scrolling logic based on the position of the mouse. The edge scrolling starts at a fixed distance from the edges. The scrolling speed is dependent on the distance of the mouse from this border.	2023-03-16 13:07:04 +01:00
Robert Müller	d08f784a97	Don't add duplicate consecutive commands to console history ... Don't add entered command to console history, if the last console history entry is identical to this command. For example, entering the commands `1`, `2`, `3`, `3`, `2`, `1` adds 5 entries to the history, i.e. only one entry for the command `3`.	2023-03-14 23:33:06 +01:00
Robert Müller	128d3e4758	Handle return value of kill_process ... Only clear process handle if the process was actually killed.	2023-03-10 17:59:36 +01:00
Robert Müller	a0c61a1b60	Add INVALID_PROCESS to represent invalid PROCESS value	2023-03-10 17:39:24 +01:00
Robert Müller	4834cfdac9	Rename CServerProcess::Process to CServerProcess::m_Process	2023-03-10 17:38:04 +01:00
Robert Müller	8d225fd3e7	Remove unused CServerProcess members	2023-03-10 17:36:33 +01:00
Robert Müller	e07d9ae724	Use std::size(g_Config.m_SvMotd) instead of magic number 900 ... The size of the `sv_motd` config variable is also `900`.	2023-03-10 00:32:51 +01:00
Robert Müller	de99fecaa0	Use text container for ingame server info MOTD ... Optimize MOTD rendering in ingame menu by caching the text. Use the correct text height based on the aligned font size instead of the original font size, to fix the discrepancy between the scrollable height and the text height.	2023-03-09 23:48:31 +01:00
Robert Müller	c286f32b17	Use text and quad containers for ingame MOTD, refactor variables ... Optimize MOTD rendering by caching the round rect and the text. Align font and rect sizes so exactly 24 lines of text fit in the MOTD rect with margins on all sizes.	2023-03-09 23:04:19 +01:00
Robert Müller	a02738bd2e	Mark CMotd::IsActive as const	2023-03-09 23:04:19 +01:00
Robert Müller	53635deb35	Encapsulate CMotd::m_aServerMotd with getter	2023-03-09 23:04:18 +01:00
bors[bot]	0f5d4d8bec	Merge #6372 ... 6372: Check in CI that no C standard headers are used, replace all usages of C standard headers with C++ headers, replace usages of C math functions r=def- a=Robyt3 Closes #6334. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-03-01 22:34:26 +00:00
Robert Müller	db4ec4a12d	Replace usages of C math functions ... Replacing the C standard headers with the C++ standard headers causes various `error: call to 'floor' promotes float to double [performance-type-promotion-in-math-fn,-warnings-as-errors]`, which are fixed by using the C++ std math functions or our own math functions instead of the C math functions. - Use `absolute` instead of `abs` and `fabs`. - Use `std::floor` instead of `floor` and `floorf`. - Use `std::ceil` instead of `ceil`, `ceilf` and `round_ceil`. - Use `std::round` instead of `round` and `roundf`. - Use `std::sin` instead of `sin` and `sinf`. - Use `std::asin` instead of `asin` and `asinf`. - Use `std::cos` instead of `cos` and `cosf`. - Use `std::acos` instead of `acos` and `acosf`. - Use `std::tan` instead of `tan` and `tanf`. - Use `std::atan` instead of `atan` and `atanf`. - Use `std::pow` instead of `pow` and `powf`. - Use `std::log` instead of `log` and `logf`. - Use `std::log2` instead of `log2` and `log2f`. - Use `std::log10` instead of `log10` and `log10f`. - Use `std::pow` instead of `pow` and `powf`. - Use `std::sqrt` instead of `sqrt` and `sqrtf`. - Use `std::fmod` instead of `fmod` and `fmodf`. - Use `direction(Angle)` instead of `vec2(std::cos(Angle), std::sin(Angle))`. - Use `length(vec2(x, y))` instead of `std::sqrt(x * x + y * y)`. - Remove unused `NormalizeAngular` and `AngularDistance` functions.	2023-03-01 19:26:53 +01:00
Robert Müller	a76fb9b99a	Replace all usages of C standard headers with C++ headers	2023-03-01 19:26:51 +01:00
Robert Müller	24fd7e626d	Fix client crash when cl_chat_old config is used ... The graphics are not initialised when `RebuildChat` is called by `ConchainChatOld`, which causes the client to crash if `cl_chat_old` is present in the user's config or used as a command line argument.	2023-02-28 21:43:21 +01:00
bors[bot]	e992089d02	Merge #6364 ... 6364: Fix incorrect text wrapping in ingame server info r=def- a=Robyt3 The maximum width for the server info and game info text was too small, which previously didn't matter, because the manual newlines broke text wrapping in this case, but with the fix from #6353 this now causes the text to break after the colons already. This is fixed by using the maximum available width for the text instead of a too small magic number (`250.0f`). For completeness, the maximum width for the title texts is unset (`-1.0f`), because they should never wrap, which is consistent with the MOTD title text. Before:  After:  ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-02-26 11:52:18 +00:00
Robert Müller	d1a9f0a76a	Fix erratic smooth scrolling when scroll time is changed ... Remember the maximum animation time when initiating a smooth scroll, so the smooth scrolling does not change erratically when `ui_smooth_scroll_time` is changed while smooth scrolling is in progress.	2023-02-26 12:12:08 +01:00
Robert Müller	ffa4801220	Fix incorrect text wrapping in ingame server info ... The maximum width for the server info and game info text was too small, which previously didn't matter, because the manual newlines broke text wrapping in this case, but with the fix from #6353 this now causes the text to break after the colons already. This is fixed by using the maximum available width for the text instead of a too small magic number (`250.0f`). For completeness, the maximum width for the title texts is unset (`-1.0f`), because they should never wrap, which is consistent with the MOTD title text.	2023-02-26 11:43:55 +01:00
Jupeyy	9530077588	Only call onresize events if actual size changed ... clearify difference between resize and window property change for resolution list	2023-02-25 16:02:38 +01:00
bors[bot]	931ea6d828	Merge #6351 ... 6351: Fix client crash when echoing client message to chat, use em dash for client messages in chat like on upstream r=def- a=Robyt3  ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-02-24 08:25:43 +00:00
Robert Müller	a1821986fa	Align color picker buttons on right side ... Align the color picker selection and reset buttons on the right side instead of the left side dependent on the label width. Closes #6237. The `UseCheckBox` argument is removed and instead `pCheckBoxValue != nullptr` is used.	2023-02-23 22:32:04 +01:00
Robert Müller	541115022a	Fix client crash when echoing client message to chat ... The client crashes when printing a client message to the chat from a config file or from the command line, as the graphics have not been initialized at that point. Closes #6350.	2023-02-23 21:49:56 +01:00
Robert Müller	284f3326a7	Use em dash for client messages in chat like on upstream	2023-02-23 21:49:56 +01:00
heinrich5991	1a2c82c0b1	Mark absolute #includes as absolute	2023-02-23 10:53:16 +01:00
Robert Müller	61bf48c1ed	Add chat message constants from upstream, remove redundant comments ... Add `CLIENT_MSG = -2` and `SERVER_MSG = -1` constants from upstream. Remove comments for self-documenting code.	2023-02-21 20:46:17 +01:00
Robert Müller	8286105804	Use RecreateTextContainer, reorder parameters ... The `RecreateTextContainer` function calls `DeleteTextContainer` and then `CreateTextContainer`. The arguments of `RecreateTextContainer` and `RecreateTextContainerSoft` are reordered so all functions take the text container as their first argument.	2023-02-20 23:39:43 +01:00
Robert Müller	f386eff45c	Remove unused argument of Text/TextWidth/TextLineCount ... The `void *pFontSetV` argument is unused and all invocations except one were already passing `0`, `0x0` or `nullptr` for this argument.	2023-02-20 20:06:17 +01:00
Sedonya_	c0b39628aa	Update menus_browser.cpp	2023-02-17 00:48:31 +05:00
Robert Müller	3280f1824f	Reset graphics container indices after deletion ... Reduce duplicate code and improve correctness by passing indices of quad, buffer and text containers by reference and always setting them to `-1` after they are deleted. Also check if index is `-1` before trying to delete it to reduce duplicate code when calling the methods.	2023-02-15 21:05:15 +01:00
bors[bot]	3fcabec30b	Merge #6328 ... 6328: Remove `bytes_be_to_int` and `int_to_bytes_be`, static assert size of `int` and `unsigned`, refactoring r=heinrich5991 a=Robyt3 Supersedes #6263. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-02-14 22:11:05 +00:00
Alexander Akulich	2ad5c020e0	Add a simpler IServer::SnapNewItem() API based on some more generated data	2023-02-10 23:12:24 +03:00
Robert Müller	218e6f7985	Remove bytes_be_to_int and int_to_bytes_be ... Use `bytes_be_to_uint` and `uint_to_bytes_be` instead. As casting between `int` and `unsigned` preserves the bit representation of the value, it's not necessary to apply additional tricks to convert between `char` arrays and `int`.	2023-02-04 01:24:03 +01:00
bors[bot]	9bd43795c8	Merge #6293 ... 6293: rewrite int64_t to bitset for clients mask r=Robyt3 a=0xfaulty Alternative version for PR [#6292](https://github.com/ddnet/ddnet/pull/6292) with bitset used. I did the naming as I would like, but I can change it if there is a more suitable one, typedef is just for shortening, can be removed. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Valentin Bashkirov <v.bashkirov@dev.tassta.com> Co-authored-by: Valentin Bashkirov <valenteen3d@ya.ru>	2023-01-31 17:06:49 +00:00
Robert Müller	52aa8ac22a	Use str_copy instead of str_format ... Using `str_format` without format arguments is equivalent to `str_copy`, but using the latter is more efficient and readable. As `str_format` also returns the result `str_utf8_fix_truncation`, i.e. the potentially truncated string length, the return value is also added to `str_copy` so existing invocations don't need to be adjusted.	2023-01-28 16:37:33 +01:00
Valentin Bashkirov	79f72a5d55	move typedef to protocol.h	2023-01-26 11:56:48 +01:00
Valentin Bashkirov	1cd9eac7ae	rewrite int64_t to CClientMask	2023-01-24 09:27:29 +01:00
Dennis Felsing	1af3c2274a	More minimal clang-tidy 15 run ... Alternative to #6294 The only remaining problems are: /home/deen/git/ddnet/src/engine/client/backend/glsl_shader_compiler.cpp:22:26: warning: unnecessary temporary object created while calling emplace_back [modernize-use-emplace] m_vDefines.emplace_back(SGLSLCompilerDefine(DefineName, DefineValue)); ^~~~~~~~~~~~~~~~~~~~ ~	2023-01-23 11:20:05 +01:00
Robert Müller	0948a1dc4c	Fix layout of kick/spec vote list items ... The tee and label were overlapping due to a regression from #6240.	2023-01-16 15:37:58 +01:00
Robert Müller	d662c7e9fd	Add tooltip to demo seekbar showing the currently hovered time ... When hovering the demo seekbar, show a tooltip with the time at the hovered position.	2023-01-15 21:31:45 +01:00
Robert Müller	315e52fb99	Refactor demo seekbar width calculation	2023-01-15 21:31:21 +01:00
Jupeyy	c820ac22d3	Merge most entity textures again	2023-01-13 15:25:38 +01:00
Robert Müller	bbd20cde2b	Add ui_smooth_scroll_time variable to adjust smooth scrolling ... This variable adjusts the time for smooth scrolling of all scrollregions and listboxes in the menus and editor. The value `0` disables smooth scrolling entirely.	2023-01-10 18:19:06 +01:00
bors[bot]	1347101a32	Merge #6249 ... 6249: Fix DoLabelStreamed by using offsets, instead of rebuilding when x,y changes r=Robyt3 a=Jupeyy <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2023-01-08 14:43:13 +00:00
Robert Müller	8845a15f14	Allow navigating listboxes when no item is currently selected ... It was no longer possible to navigate listboxes (e.g. the server browser) by using keyboard hotkeys when no item is currently selected due to a regression from #6240. Additionally, it was not possible even before #6240 to start navigating the server browser with the keyboard afer manually clearing the server address input, which is now possible as well.	2023-01-08 14:48:30 +01:00
bors[bot]	bda61e586e	Merge #6251 ... 6251: Always assume there could potentially be a skin in serverbrowser's pl… r=def- a=Jupeyy …ayer list <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2023-01-08 13:09:11 +00:00
Jupeyy	ed1af6edb9	Always assume there could potentially be a skin in serverbrowser's player list	2023-01-08 13:42:18 +01:00
Robert Müller	a0d4a55023	Fix server browser selection not being updated based an address input ... The selected server browser entry was not being updated anymore when the server address input is changed manually by the user or when selecting an entry in the LAN server list and then switching back to the Internet list. Regression from #6240.	2023-01-08 11:06:57 +01:00
Jupeyy	7815be7b75	Fix DoLabelStreamed by using offsets, instead of rebuilding when x,y changes	2023-01-07 11:51:48 +01:00
Jupeyy	1182180e23	Add skin to serverbrowser player list	2023-01-07 09:20:25 +01:00
bors[bot]	73ce7598fa	Merge #6240 ... 6240: Port `CListBox` from upstream, smooth scrolling for all lists r=def- a=Robyt3 Replace existing listbox implementations (`CMenus::UiDoListbox*` and `HandleListInputs` functions) with `CListBox` from upstream. Reimplement additional feature that was already present in ddnet: page up/down, home and end key handling. Affects the following lists: - server browser - see screenshots for scoreboard - server browser scoreboard - before:  - after:  - server browser friends - before:  - after:  - country / region selection popup (server browser filter) - before:  - after:  - player skin list - before:  - after:  - player country / region list - before:  - after:  - theme list - before:  - after:  - assets list - before:  - after:  - graphics resolutions list - before:  - after:  - dropdown menus (e.g. graphics fullscreen mode) - see screenshots for graphics resolutions list - ingame player list - before:  - after:  - before (low number):  - after (low number):  - vote options list - before:  - after:  - kick/specvote lists - before:  - after:  - ghost list - before:  - after:  - language list (in settings and in popup on first launch) - settings: - before:  - after:  - popup: - before:  - after:  - demo browser - before:  - after:  - editor file browser (saving, loading, adding images / sounds) - before:  - after:  - The search / filename input is also improved so navigating a filtered list works correctly by porting the logic from upstream. There are minor changes to the visual appearance of some lists, due to changed margins. The vertical alignment of some list item texts is improved so the text is centered vertically. Closes #5791. ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-01-06 23:40:55 +00:00
bors[bot]	f79412c59c	Merge #6244 #6245 #6246 ... 6244: Minor base refactoring r=def- a=Robyt3 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 6245: Add ingame and browser buttons to copy server info to clipboard r=def- a=Robyt3 Add "Copy info" buttons to server browser and ingame menu to copy the server info of the selected/current server to the clipboard. The margins around the server browser details are improved. Closes #5440. Screenshots: - browser (old):  - browser (new):  - ingame:  ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 6246: Remove dead freeze code r=def- a=Zwelf Remove unused `m_FreezeTime == -1` state Reduces code complexity. Both `g_Config.m_SvFreezeDelay`[[1]] and `GetSwitchDelay(int Index)`[[2]] can only return non-negative numbers, therefore this is currently dead code and can be removed. The last time it was possible to pass a negative number was removed in 561ce64666 (diff-29ffe32916052e1066eed938021aadfeb29f855d7c63d9c1ca3350aceffb79f3L1624) [1]: c8ea372d98/src/engine/shared/config_variables.h (L213) [2]: c8ea372d98/src/game/mapitems.h (L467) ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> Co-authored-by: Zwelf <zwelf@strct.cc>	2023-01-06 22:56:49 +00:00
Zwelf	e4157a744b	Remove unused m_FreezeTime == -1 state ... Reduces code complexity. Both `g_Config.m_SvFreezeDelay`[[1]] and `GetSwitchDelay(int Index)`[[2]] can only return non-negative numbers, therefore this is currently dead code and can be removed. The last time it was possible to pass a negative number was removed in 561ce64666 (diff-29ffe32916052e1066eed938021aadfeb29f855d7c63d9c1ca3350aceffb79f3L1624) [1]: c8ea372d98/src/engine/shared/config_variables.h (L213) [2]: c8ea372d98/src/game/mapitems.h (L467)	2023-01-06 23:09:01 +01:00
Robert Müller	fc7c376738	Add ingame and browser buttons to copy server info to clipboard ... Add "Copy info" buttons to server browser and ingame menu to copy the server info of the selected/current server to the clipboard. The margins around the server browser details are improved. Closes #5440.	2023-01-06 21:23:33 +01:00
Robert Müller	91a23f00cb	Port CListBox from upstream, smooth scrolling for all lists ... Replace existing listbox implementations (`CMenus::UiDoListbox*` and `HandleListInputs` functions) with `CListBox` from upstream. Reimplement additional feature that was already present in ddnet: page up/down, home and end key handling. Affects the following lists: - server browser - server browser scoreboard - server browser friends - country / region selection popup (server browser filter) - player skin list - player country / region list - theme list - assets list - graphics resolutions list - dropdown menus (e.g. graphics fullscreen mode) - ingame player list - vote options list - kick/specvote lists - ghost list - language list (in settings and in popup on first launch) - demo browser - editor file browser (saving, loading, adding images / sounds) - The search / filename input is also improved so navigating a filtered list works correctly by porting the logic from upstream. There are minor changes to the visual appearance of some lists, due to changed margins. The vertical alignment of some list item texts is improved so the text is centered vertically.	2023-01-06 12:46:16 +01:00
Robert Müller	f79daac222	Add page up/down, home, end hotkeys to UI	2023-01-06 00:52:46 +01:00
bors[bot]	f3fca968f1	Merge #6158 ... 6158: Add F-DDrace gametype color r=def- a=fokkonaut Been using this color already since a while. I'd like to keep it.   ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: fokkonaut <35420825+fokkonaut@users.noreply.github.com>	2023-01-04 10:26:06 +00:00
Robert Müller	21636912c0	Refactor team state unpacking	2023-01-03 23:55:26 +01:00
Robert Müller	dfe0ec3385	Restart client race demo when round is restarted	2023-01-03 23:38:37 +01:00
bors[bot]	6d3af742dd	Merge #6180 ... 6180: Implement exact matches in search and exclude strings r=Robyt3 a=def- Thanks to bencie for discussion <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2023-01-03 18:16:03 +00:00
bors[bot]	b252f2e344	Merge #6199 ... 6199: Register protocol and file extensions on client launch on Windows r=def- a=Robyt3 When launching the client on Windows, associate the protocol `ddnet` and the file extensions `.map` and `.demo` with the client executable. See #6072. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2023-01-02 12:58:15 +00:00
Zwelf	e3147ce53d	Simplify ninja code ... Reasoning this change is correct: * `OldPos` is set to `m_Pos` in line 260 * `m_Pos` is not modified in between line 260 and 272 (only `m_Core.m_Pos` gets modified) * Therefore line 269 `Dir = m_Pos - OldPos` is always `vec2(0.0, 0.0)`. * And line 271 `Center = OldPos + Dir * 0.5 = OldPos`. So we can pass `OldPos` to `FindEntities` in line 272. Using `OldPos` here instead of `m_Pos` makes it clear, that we use the position before the move, even though `m_Pos` also still holds the old value.	2022-12-30 18:23:26 +01:00
Robert Müller	a61eec8f1e	Add DDNet settings button to unregister protocol and file extensions ... Add a button to the Miscellaneous DDNet settings to manually unregister the protocol and file extension handlers.	2022-12-29 18:03:08 +01:00
Dennis Felsing	68625dd370	Implement exact matches in search and exclude strings ... Thanks to bencie for discussion	2022-12-23 23:25:11 +01:00
Robert Müller	1eb600f7e0	Render bar below server browser to show loading progression ... Render a slim bar below the server browser listbox to show the loading progression, instead of showing a percentage on the Refresh button, as suggested in https://github.com/ddnet/ddnet/pull/5878#issuecomment-1257227947. The margin around the bottom status elements is removed to make more space and improve the alignment of the elements with the rest of the server browser.	2022-12-21 21:47:31 +01:00
bors[bot]	327f7de09b	Merge #5886 ... 5886: Send laser objects as DDNetLaser with type (fixes #5885) r=heinrich5991 a=fokkonaut This pull request will make the server send the correct lasertype directly. The type determining based on EntitiyEx for that got removed on the clientside as it is not needed anymore when using DDNetLaser. Also, I fixed the NetObject to accept -1 (no owner). That is important in order to be able to render the laser at full opacity for everyone. This does not only make the color determining more consistent as before (compared to entities using EntitiyEx and shotgun/laser using DDNetLaser), but it does also make it entirely more mod-friendly. As an example in my mod I dont use EntitiyEx to save objects in the snapshot, as we still dont have an extended snapshot system, and like this we can still have colors without doubling the amount of objects. Also, this will color the dragger beam aswell as the plasma bullets being shot by the freeze/unfreeze/explosive laser gun correctly. This PR should get applied for the next minor update on client & server. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: fokkonaut <35420825+fokkonaut@users.noreply.github.com>	2022-12-21 00:36:35 +00:00
bors[bot]	c557e61dc2	Merge #6171 ... 6171: Remove unused variable m_Force in CProjectile r=def- a=Zwelf Simplifies the code a bit. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Zwelf <zwelf@strct.cc>	2022-12-20 10:44:07 +00:00
Zwelf	de552c71ca	Remove unused variable m_Force in CProjectile	2022-12-20 11:36:47 +01:00
Patiga	be8f6217ce	Make tileflag names consistent with automappers ... Follow-up to commit a4867d29c6 - `TILEFLAG_FLIP_HORIZONTAL` -> `TILEFLAG_XFLIP` - `TILEFLAG_FLIP_VERTICAL` -> `TILEFLAG_YFLIP` In the previous commit, I pretty much just switched `V` and `H` and changed the naming a little more to break further uses. The reason was that the two flags were called counter-intuitively. Since then, I realized that the auto mapper syntax also already faced this issue and is already using `XFLIP` and `YFLIP`. For more consistency and to reduce the amount of names for these flips, these flags should also be called like that. It also turned out that more things are connected to `V` and `H`. Those letters are shown in the `Info` mode in the editor, and are used extensively by the automapper community. Switching to `X` and `Y` allows keeping backwards compatibility while introducing more intuitive names.	2022-12-19 18:39:36 +01:00
bors[bot]	648b025906	Merge #6163 ... 6163: Add tooltips for the buttons that open directories and files r=Jupeyy a=Robyt3 Closes #5653. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-12-19 10:23:36 +00:00
Robert Müller	3780c74add	Add tooltips for the buttons that open directories and files ... Closes #5653.	2022-12-18 21:58:25 +01:00
Robert Müller	32ce5be301	Fix smooth zooming overshooting the target zoom level ... Ensure that the zoom level with smooth zooming does not exceed the target zoom level. Closes #3747.	2022-12-18 20:58:29 +01:00
Robert Müller	2579f0be2f	Add support for hot-plugging gamecontrollers ... Handle the appropriate SDL events to open new joysticks when they are connected and remove joysticks when they are disconnected. If the active joystick gets disconnected, then the first joystick in the list will be activated as a fallback. If the previously activated joystick gets reconnected, it will be activated again automatically, as it is identified by the GUID stored in the configuration. The stored joystick GUID is only updated when the user manually selects a new joystick in the controls settings or with the console. Closes #6152.	2022-12-18 12:41:17 +01:00
fokkonaut	6e683dd210	Add F-DDrace gametype color	2022-12-18 09:44:05 +01:00
bors[bot]	2d57e0455a	Merge #6142 ... 6142: Adjust no weak prediction to updated server code r=def- a=Jupeyy Tho i didnt see a wrong prediction with hook which probably makes sense, it probs only affects weapons, as thats the main part the server code was updated for ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-12-15 17:45:50 +00:00
Jupeyy	19928aabd2	Adjust no weak prediction to updated server code	2022-12-15 18:36:29 +01:00
bors[bot]	75d07350f6	Merge #6133 ... 6133: Remove spammy log (thanks Skeith) r=Chairn a=def- <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-12-14 16:51:51 +00:00
Dennis Felsing	d5cf3630ae	Remove spammy log (thanks Skeith)	2022-12-14 17:39:18 +01:00
Patiga	a4867d29c6	Make tileflag names consistent and intuitive ... - `TILEFLAG_VFLIP` -> `TILEFLAG_FLIP_HORIZONTAL` - `TILEFLAG_HFLIP` -> `TILEFLAG_FLIP_VERTICAL` According to the native editor, the "Tiled" editor and image search, a horizontal flip should be associated with switching left and right, modifying the x coordinate. I did not just switch the letters `H` and `V` to create compiler errors where the original constants are used. Whenever I was working with tileflags, the naming caused me to have no idea what I was doing. I mostly had to resort to opening the resulting map in the editor to see what the code does. This change aims to make the naming intuitive and also consistent with the map editor.	2022-12-14 13:54:11 +01:00
Jupeyy	5341fc37fd	Minimal changes to default to Vulkan	2022-12-13 19:37:03 +01:00
Jupeyy	870ea8566e	Improve error handling in vulkan ... so it doesn't assert & shows a message box with the error and some tips	2022-12-13 18:11:26 +01:00
Jupeyy	dff876d58c	Add Localizable hint	2022-12-13 17:53:32 +01:00
Dennis Felsing	7c46b5190b	Add button that tells you how to save power	2022-12-08 23:10:02 +01:00
NouaaTW	0bc4e7601e	Colorify BW gamemode	2022-12-07 19:29:40 +01:00
bors[bot]	cf6e89c319	Merge #6035 ... 6035: Fix various issues reported by cppcheck static analyser r=def- a=Robyt3 After generating `compile_commands.json` with cmake, I ran [cppcheck](https://cppcheck.sourceforge.io/) like this: ``` cppcheck --project=compile_commands.json -DWIN64 --suppressions-list=cppcheck.supp --enable=all 2>cppcheck.log ``` With these suppressions in `cppcheck.supp`: ``` cstyleCast useStlAlgorithm unusedFunction variableScope noExplicitConstructor useInitializationList noConstructor uninitMemberVar uninitMemberVarPrivate uninitDerivedMemberVar uninitStructMember uninitvar shadowFunction memleakOnRealloc internalAstError virtualCallInConstructor unknownMacro noOperatorEq noCopyConstructor ``` Many of these occur too often or are false positives. Here is a list of all remaining non-suppressed issues reported by cppcheck: [cppcheck.log](https://github.com/ddnet/ddnet/files/9997663/cppcheck.log) And here is a list of all remaining issues including the suppressed ones: [cppcheck_all.log](https://github.com/ddnet/ddnet/files/9997662/cppcheck_all.log) I couldn't get cppcheck's command line argument to ignore the external folders to work correctly, so I manually removed those entries from the files. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-12-05 20:00:07 +00:00
bors[bot]	2dcef1685b	Merge #6094 ... 6094: Check if ghost is really used bcs IntsToStr returns weird stuff for 0… r=def- a=Jupeyy … integers --- ignore whitespaces ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-12-05 19:34:43 +00:00
Jupeyy	bf9e8a4309	Check if ghost is really used bcs IntsToStr returns weird stuff for 0 integers	2022-12-05 20:11:20 +01:00
Avolicious	59db9ce54b	FIX: parse & colorify gametype Gores correctly	2022-12-05 17:03:43 +01:00
Robert Müller	b852dad9a2	Fix demo name not being shown in demo player ... And slightly increase space for the speed label.	2022-12-04 12:37:09 +01:00
Robert Müller	061f8625f4	Use HandleDemoSeeking for demo skipping ... To ensure that components are reset when skipping and that envelopes are updated immediately.	2022-12-04 12:34:17 +01:00
bors[bot]	acfc7f8c06	Merge #6060 ... 6060: Add buttons+increased length on demo viewbar r=def- a=l-ouis Aimed to add some more controls on the demo view bar: Added tick step buttons and jump to next/prev marker buttons Increased width of demo controls panel so it wasn't as cluttered changed export cut icon to a common export icon instead of the camcorder icon Centered the time multiplier between the buttons it was between  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: louis <louisaltgeer@gmail.com>	2022-12-04 11:09:39 +00:00
Zwelf	2268c08e05	Fix heap-buffer-overflow in DDNetLaser prediction code ... Found while playing the Exit when doing the part at x:35 y:219. Verified that with the fix applied the crash doesn't happen anymore. asan output: ``` ================================================================= ==10996==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62000001de20 at pc 0x5555575208d0 bp 0x7fffffff4710 sp 0x7fffffff4708 READ of size 4 at 0x62000001de20 thread T0 [Detaching after fork from child process 11277] #0 0x5555575208cf in ExtractLaserInfoDDNet(CNetObj_DDNetLaser const*, CGameWorld*) /home/user/.local/bin/ddnet/src/src/game/client/laser_data.cpp:36:27 #1 0x5555575af9c8 in CGameWorld::NetObjAdd(int, int, void const*, CNetObj_EntityEx const*) /home/user/.local/bin/ddnet/src/src/game/client/prediction/gameworld.cpp:493:11 #2 0x5555574bf201 in CGameClient::UpdatePrediction() /home/user/.local/bin/ddnet/src/src/game/client/gameclient.cpp:2452:15 #3 0x5555574aad89 in CGameClient::OnNewSnapshot() /home/user/.local/bin/ddnet/src/src/game/client/gameclient.cpp:1729:3 #4 0x5555569562c7 in CClient::Update() /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:2751:22 #5 0x55555696e4bd in CClient::Run() /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:3260:4 #6 0x5555569caa8b in main /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:4753:11 #7 0x7ffff4ea9d09 in __libc_start_main csu/../csu/libc-start.c:308:16 #8 0x5555560f55c9 in _start (/home/user/.local/bin/ddnet/build-fast/DDNet+0xba15c9) (BuildId: 6d1b5aed4fc199ba75cdc083de5ada540ca4612b) 0x62000001de20 is located 0 bytes after 3488-byte region [0x62000001d080,0x62000001de20) allocated by thread T0 here: #0 0x55555618e36e in __interceptor_malloc (/home/user/.local/bin/ddnet/build-fast/DDNet+0xc3a36e) (BuildId: 6d1b5aed4fc199ba75cdc083de5ada540ca4612b) #1 0x555556382591 in CSnapshotStorage::Add(int, long, int, void*, int, void*) /home/user/.local/bin/ddnet/src/src/engine/shared/snapshot.cpp:518:32 #2 0x55555693aa6e in CClient::ProcessServerPacket(CNetChunk*, int, bool) /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:2088:31 #3 0x55555694b48c in CClient::PumpNetwork() /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:2556:4 #4 0x55555695ca61 in CClient::Update() /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:2868:2 #5 0x55555696e4bd in CClient::Run() /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:3260:4 #6 0x5555569caa8b in main /home/user/.local/bin/ddnet/src/src/engine/client/client.cpp:4753:11 #7 0x7ffff4ea9d09 in __libc_start_main csu/../csu/libc-start.c:308:16 SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/.local/bin/ddnet/src/src/game/client/laser_data.cpp:36:27 in ExtractLaserInfoDDNet(CNetObj_DDNetLaser const*, CGameWorld*) Shadow bytes around the buggy address: 0x62000001db80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x62000001dc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x62000001dc80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x62000001dd00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x62000001dd80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x62000001de00: 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa fa 0x62000001de80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x62000001df00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x62000001df80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x62000001e000: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x62000001e080: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==10996==ABORTING ```	2022-12-04 10:19:35 +01:00
louis	b5eef1b64b	added offset, fix my git issues ... added demomarker offset Revert "why is this here" This reverts commit a8c74b612300d6563b28a2bea733a0d3a7dd7f90. fix	2022-12-03 23:41:50 -06:00
bors[bot]	8d17670c67	Merge #6082 ... 6082: Fix incorrect cursor position after exiting pause/spec r=def- a=Robyt3 The cursor position was not correctly restored when exiting pause or spec, when the mouse was on the left side of the tee (x being negative). This is caused by a calculation introduced in #1637 and #1830 that tries to ensure that the mouse can still be moved if it ends up inside the minimum mouse distance (`cl_mouse_min_distance` and `cl_dyncam_min_distance`). However, this did not consider that the x position can become negative, so the x position was also incorrectly changed when exiting pause. This is fixed by reverting the changes, as this code has become obsolete and has been superseded by #2009 and #3884. The `CControls::ClampMousePos` function, which is called directly after restoring the position, already ensures that mouse is not stuck within the minimum mouse distance. Closes #2591. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [X] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-12-03 22:39:20 +00:00
Robert Müller	c3286ff263	Fix incorrect cursor position after exiting pause/spec ... The cursor position was not correctly restored when exiting pause or spec, when the mouse was on the left side of the tee (x being negative). This is caused by a calculation introduced in #1637 and #1830 that tries to ensure that the mouse can still be moved if it ends up inside the minimum mouse distance (`cl_mouse_min_distance` and `cl_dyncam_min_distance`). However, this did not consider that the x position can become negative, so the x position was also incorrectly changed when exiting pause. This is fixed by reverting the changes, as this code has become obsolete and has been superseded by #2009 and #3884. The `CControls::ClampMousePos` function, which is called directly after restoring the position, already ensures that mouse is not stuck within the minimum mouse distance. Closes #2591.	2022-12-03 22:20:53 +01:00
Robert Müller	5903c25799	Add cancel button to country popup, confirm with list item activation ... Add "Cancel" button to country/region picker popup. It's already possible to cancel with the Escape key, so there should also be a button, which keeps the current selection. Delegate the listbox activation (enter / double click on item) to the popup to confirm it. Enter was previously working but then broken by the logic that ensures that every hotkey is only consumed once. Now both enter and double click confirm the popup. From teeworlds/teeworlds#2961.	2022-12-03 13:52:23 +01:00
Robert Müller	5994812a1c	Rename variable CurSelection to s_CurSelection	2022-12-03 13:52:17 +01:00
Robert Müller	9b719ef61c	Add confirmation popup for resetting controls to defaults ... To avoid accidentally losing all binds.	2022-12-03 13:49:15 +01:00
Robert Müller	a45f833afa	Replace POPUP_SWITCH_SERVER with generic confirmation popup	2022-12-03 13:49:14 +01:00
Robert Müller	cb1d9ccc98	Replace POPUP_REPLACE_VIDEO with generic confirmation popup ... And show the name of the video that will be overwriten in the popup. Make the buttons in `POPUP_RENDER_DEMO` the same height as in all other popups.	2022-12-03 13:49:14 +01:00
Robert Müller	8da68bf52a	Replace POPUP_SOUNDERROR with generic message popup	2022-12-03 13:49:14 +01:00
Robert Müller	620e3e56db	Replace POPUP_DISCONNECT(_DUMMY) with generic confirmation popup	2022-12-03 13:49:14 +01:00
Robert Müller	f4708a3a00	Replace POPUP_REMOVE_FRIEND with generic confirmation popup ... And show the name of the friend or clan that will be removed in the popup.	2022-12-03 13:49:13 +01:00
Robert Müller	dd60c84426	Replace POPUP_DELETE_DEMO with generic confirmation popup ... And show the name of the file that will be deleted in the popup.	2022-12-03 13:49:13 +01:00
Robert Müller	55b576cd7f	Add generic confirm popup to menu, adapt generic message popup ... Add a generic popup to confirm an operation to the menu and revise the generic message popup similar to this. Both popups have a title and a message. The message popup has one button and the confirmation popup has two buttons. For each button a label, the next popup after clicking the button, and a custom button handler can be set. From teeworlds/teeworlds#2598.	2022-12-03 13:49:12 +01:00
Robert Müller	faa9f27808	Declare variables as const when possible ... According to cppcheck's `constVariable` error: ``` src\engine\client\backend\opengl\opengl_sl.cpp:74:43: style: Variable 'Define' can be declared as reference to const [constVariable] for(CGLSLCompiler::SGLSLCompilerDefine &Define : pCompiler->m_vDefines) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:2149:12: style: Variable 'GraphicThreadCommandBuffer' can be declared as reference to const [constVariable] auto &GraphicThreadCommandBuffer = m_vvThreadDrawCommandBuffers[i + 1][m_CurImageIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:3192:9: style: Variable 'BufferObject' can be declared as reference to const [constVariable] auto &BufferObject = m_vBufferObjects[BufferObjectIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:3200:10: style: Variable 'DescrSet' can be declared as reference to const [constVariable] auto &DescrSet = m_vTextures[State.m_Texture].m_VKStandard3DTexturedDescrSet; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:3810:13: style: Variable 'Mode' can be declared as reference to const [constVariable] for(auto &Mode : vPresentModeList) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:3818:13: style: Variable 'Mode' can be declared as reference to const [constVariable] for(auto &Mode : vPresentModeList) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6511:10: style: Variable 'DescrSet' can be declared as reference to const [constVariable] auto &DescrSet = m_vTextures[pCommand->m_State.m_Texture].m_aVKStandardTexturedDescrSets[AddressModeIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6555:10: style: Variable 'DescrSet' can be declared as reference to const [constVariable] auto &DescrSet = m_vTextures[pCommand->m_State.m_Texture].m_VKStandard3DTexturedDescrSet; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6660:9: style: Variable 'MemBlock' can be declared as reference to const [constVariable] auto &MemBlock = m_vBufferObjects[BufferIndex].m_BufferObject.m_Mem; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6799:9: style: Variable 'BufferObject' can be declared as reference to const [constVariable] auto &BufferObject = m_vBufferObjects[BufferObjectIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6808:10: style: Variable 'DescrSet' can be declared as reference to const [constVariable] auto &DescrSet = m_vTextures[pCommand->m_State.m_Texture].m_aVKStandardTexturedDescrSets[AddressModeIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6902:9: style: Variable 'BufferObject' can be declared as reference to const [constVariable] auto &BufferObject = m_vBufferObjects[BufferObjectIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6907:9: style: Variable 'TextTextureDescr' can be declared as reference to const [constVariable] auto &TextTextureDescr = m_vTextures[pCommand->m_TextTextureIndex].m_VKTextDescrSet; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6961:9: style: Variable 'BufferObject' can be declared as reference to const [constVariable] auto &BufferObject = m_vBufferObjects[BufferObjectIndex]; ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6970:10: style: Variable 'DescrSet' can be declared as reference to const [constVariable] auto &DescrSet = m_vTextures[State.m_Texture].m_aVKStandardTexturedDescrSets[AddressModeIndex]; ^ src\game\client\components\hud.cpp:178:8: style: Variable 'aFlagCarrier' can be declared as const array [constVariable] int aFlagCarrier[2] = { ^ src\game\client\components\hud.cpp:519:16: style: Variable 's_aTextWidth' can be declared as const array [constVariable] static float s_aTextWidth[5] = {s_TextWidth0, s_TextWidth00, s_TextWidth000, s_TextWidth0000, s_TextWidth00000}; ^ src\game\client\components\killmessages.cpp:305:30: style: Variable 'Client' can be declared as reference to const [constVariable] CGameClient::CClientData &Client = GameClient()->m_aClients[m_aKillmsgs[r].m_KillerID]; ^ src\game\client\components\killmessages.cpp:314:30: style: Variable 'Client' can be declared as reference to const [constVariable] CGameClient::CClientData &Client = GameClient()->m_aClients[m_aKillmsgs[r].m_VictimID]; ^ src\game\client\components\menus_ingame.cpp:243:12: style: Variable 'pInfoByName' can be declared as reference to const [constVariable] for(auto &pInfoByName : m_pClient->m_Snap.m_apInfoByName) ^ src\game\client\components\menus_ingame.cpp:530:12: style: Variable 'pInfoByName' can be declared as reference to const [constVariable] for(auto &pInfoByName : m_pClient->m_Snap.m_apInfoByName) ^ src\game\client\components\players.cpp:767:44: style: Variable 'CharacterInfo' can be declared as reference to const [constVariable] CGameClient::CSnapState::CCharacterInfo &CharacterInfo = m_pClient->m_Snap.m_aCharacters[i]; ^ src\game\client\components\spectator.cpp:122:27: style: Variable 'Snap' can be declared as reference to const [constVariable] CGameClient::CSnapState &Snap = pSelf->m_pClient->m_Snap; ^ src\game\client\components\spectator.cpp:221:12: style: Variable 'pInfo' can be declared as reference to const [constVariable] for(auto &pInfo : m_pClient->m_Snap.m_apInfoByDDTeamName) ^ src\game\client\gameclient.cpp:2220:15: style: Variable 'OwnClientData' can be declared as reference to const [constVariable] CClientData &OwnClientData = m_aClients[ownID]; ^ src\game\client\gameclient.cpp:2227:16: style: Variable 'cData' can be declared as reference to const [constVariable] CClientData &cData = m_aClients[i]; ^ src\game\client\prediction\entities\character.cpp:397:11: style: Variable 'aSpreading' can be declared as const array [constVariable] float aSpreading[] = {-0.185f, -0.070f, 0, 0.070f, 0.185f}; ^ src\game\client\prediction\entities\laser.cpp:53:9: style: Variable 'HitPos' can be declared as reference to const [constVariable] vec2 &HitPos = pHit->Core()->m_Pos; ^ src\game\editor\auto_map.cpp:507:18: style: Variable 'Index' can be declared as reference to const [constVariable] for(auto &Index : pRule->m_vIndexList) ^ src\game\editor\auto_map.cpp:518:18: style: Variable 'Index' can be declared as reference to const [constVariable] for(auto &Index : pRule->m_vIndexList) ^ src\game\editor\editor.cpp:118:12: style: Variable 'Item' can be declared as reference to const [constVariable] for(auto &Item : vList) ^ src\game\editor\editor.cpp:2983:11: style: Variable 'aAspects' can be declared as const array [constVariable] float aAspects[] = {4.0f / 3.0f, 16.0f / 10.0f, 5.0f / 4.0f, 16.0f / 9.0f}; ^ src\game\editor\editor.cpp:3141:15: style: Variable 's_aShift' can be declared as const array [constVariable] static int s_aShift[] = {24, 16, 8, 0}; ^ src\engine\server\server.cpp:2807:14: style: Variable 'Client' can be declared as reference to const [constVariable] for(auto &Client : m_aClients) ^ src\engine\server\sql_string_helpers.cpp:51:6: style: Variable 'aTimes' can be declared as const array [constVariable] int aTimes[7] = ^ src\test\secure_random.cpp:24:6: style: Variable 'BOUNDS' can be declared as const array [constVariable] int BOUNDS[] = {2, 3, 4, 5, 10, 100, 127, 128, 129}; ^ ```	2022-11-29 23:32:32 +01:00
Robert Müller	aa321cd887	Move index check before usage, use std::size ... According to cppchecker's `arrayIndexThenCheck` error: ``` src\game\client\race.cpp:24:30: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] for(int i = 0; isdigit(pStr[i]) && i < 3; i++) ^ ```	2022-11-29 23:32:31 +01:00
Robert Müller	98706d79d4	Mark parameters as const when possible ... According to cppchecker's `constParameter` error: ``` src\engine\gfx\image_manipulation.cpp:7:58: style: Parameter 'pSrc' can be declared as pointer to const [constParameter] static void Dilate(int w, int h, int BPP, unsigned char *pSrc, unsigned char *pDest, unsigned char AlphaThreshold = TW_DILATE_ALPHA_THRESHOLD) ^ src\engine\gfx\image_manipulation.cpp:58:67: style: Parameter 'pSrc' can be declared as pointer to const [constParameter] static void CopyColorValues(int w, int h, int BPP, unsigned char *pSrc, unsigned char *pDest) ^ src\engine\shared\network_conn.cpp:241:42: style: Parameter 'Addr' can be declared as reference to const [constParameter] void CNetConnection::DirectInit(NETADDR &Addr, SECURITY_TOKEN SecurityToken, SECURITY_TOKEN Token, bool Sixup) ^ src\base\system.cpp:4060:71: style: Parameter 'random' can be declared as pointer to const [constParameter] void generate_password(char *buffer, unsigned length, unsigned short *random, unsigned random_length) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:263:38: style: Parameter 'AllocatedMemory' can be declared as reference to const [constParameter] void Free(SMemoryHeapQueueElement &AllocatedMemory) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:1708:47: style: Parameter 'ImgExtent' can be declared as reference to const [constParameter] static size_t ImageMipLevelCount(VkExtent3D &ImgExtent) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:2801:29: style: Parameter 'Image' can be declared as reference to const [constParameter] void ImageBarrier(VkImage &Image, size_t MipMapBase, size_t MipMapCount, size_t LayerBase, size_t LayerCount, VkFormat Format, VkImageLayout OldLayout, VkImageLayout NewLayout) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6495:46: style: Parameter 'ExecBuffer' can be declared as reference to const [constParameter] void Cmd_Clear(SRenderCommandExecuteBuffer &ExecBuffer, const CCommandBuffer::SCommand_Clear *pCommand) ^ src\game\client\components\skins.cpp:83:72: style: Parameter 'pImg' can be declared as pointer to const [constParameter] static void CheckMetrics(CSkin::SSkinMetricVariable &Metrics, uint8_t *pImg, int ImgWidth, int ImgX, int ImgY, int CheckWidth, int CheckHeight) ^ src\game\client\prediction\entities\character.h:106:37: style: Parameter 'pNewInput' can be declared as pointer to const [constParameter] void SetInput(CNetObj_PlayerInput *pNewInput) ^ src\game\client\prediction\gameworld.cpp:245:106: style: Parameter 'pNotThis' can be declared as pointer to const [constParameter] CCharacter *CGameWorld::IntersectCharacter(vec2 Pos0, vec2 Pos1, float Radius, vec2 &NewPos, CCharacter *pNotThis, int CollideWith, class CCharacter *pThisOnly) ^ src\game\client\prediction\gameworld.cpp:245:151: style: Parameter 'pThisOnly' can be declared as pointer to const [constParameter] CCharacter *CGameWorld::IntersectCharacter(vec2 Pos0, vec2 Pos1, float Radius, vec2 &NewPos, CCharacter *pNotThis, int CollideWith, class CCharacter *pThisOnly) ^ src\game\client\prediction\gameworld.cpp:283:116: style: Parameter 'pNotThis' can be declared as pointer to const [constParameter] std::list<class CCharacter *> CGameWorld::IntersectedCharacters(vec2 Pos0, vec2 Pos1, float Radius, class CEntity *pNotThis) ^ src\game\client\ui.cpp:522:180: style: Parameter 'pReadCursor' can be declared as pointer to const [constParameter] void CUI::DoLabel(CUIElement::SUIElementRect &RectEl, const CUIRect *pRect, const char *pText, float Size, int Align, const SLabelProperties &LabelProps, int StrLen, CTextCursor *pReadCursor) ^ src\game\client\ui_scrollregion.cpp:23:86: style: Parameter 'pParams' can be declared as pointer to const [constParameter] void CScrollRegion::Begin(CUIRect *pClipRect, vec2 *pOutOffset, CScrollRegionParams *pParams) ^ src\game\server\scoreworker.h:239:29: style: Parameter 'aTimeCp' can be declared as const array [constParameter] void Set(float Time, float aTimeCp[NUM_CHECKPOINTS]) ^ src\game\server\score.cpp:135:80: style: Parameter 'aTimeCp' can be declared as const array [constParameter] void CScore::SaveScore(int ClientID, float Time, const char *pTimestamp, float aTimeCp[NUM_CHECKPOINTS], bool NotEligible) ^ src\game\server\teeinfo.cpp:40:57: style: Parameter 'pUseCustomColors' can be declared as pointer to const [constParameter] CTeeInfo::CTeeInfo(const char *apSkinPartNames[6], int *pUseCustomColors, int *pSkinPartColors) ^ src\game\server\teeinfo.cpp:40:80: style: Parameter 'pSkinPartColors' can be declared as pointer to const [constParameter] CTeeInfo::CTeeInfo(const char *apSkinPartNames[6], int *pUseCustomColors, int *pSkinPartColors) ^ ```	2022-11-29 23:32:31 +01:00
Robert Müller	0f2590801d	Clarify operator precedence ... According to cppcheck's `clarifyCalculation` error: ``` src\game\client\components\hud.cpp:196:49: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] float ImageSize = GameFlags & GAMEFLAG_FLAGS ? 16.0f : Split; ^ src\game\editor\layer_tiles.cpp:544:94: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] m_pTiles[y * m_Width + x].m_Flags ^= m_pTiles[y * m_Width + x].m_Flags & TILEFLAG_ROTATE ? TILEFLAG_HFLIP : TILEFLAG_VFLIP; ^ src\game\editor\layer_tiles.cpp:560:94: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] m_pTiles[y * m_Width + x].m_Flags ^= m_pTiles[y * m_Width + x].m_Flags & TILEFLAG_ROTATE ? TILEFLAG_VFLIP : TILEFLAG_HFLIP; ^ ```	2022-11-29 23:32:30 +01:00
Robert Müller	f46c9f9079	Remove redundant conditional expression before assignment ... According to cppcheck's `duplicateConditionalAssign` error: ``` src\game\client\gameclient.cpp:1439:39: style: The statement 'if (m_aFlagDropTick[TEAM_RED]!=0) m_aFlagDropTick[TEAM_RED]=0' is logically equivalent to 'm_aFlagDropTick[TEAM_RED]=0'. [duplicateConditionalAssign] else if(m_aFlagDropTick[TEAM_RED] != 0) ^ src\game\client\gameclient.cpp:1440:32: note: Assignment 'm_aFlagDropTick[TEAM_RED]=0' m_aFlagDropTick[TEAM_RED] = 0; ^ src\game\client\gameclient.cpp:1439:39: note: Condition 'm_aFlagDropTick[TEAM_RED]!=0' is redundant else if(m_aFlagDropTick[TEAM_RED] != 0) ^ src\game\client\gameclient.cpp:1446:40: style: The statement 'if (m_aFlagDropTick[TEAM_BLUE]!=0) m_aFlagDropTick[TEAM_BLUE]=0' is logically equivalent to 'm_aFlagDropTick[TEAM_BLUE]=0'. [duplicateConditionalAssign] else if(m_aFlagDropTick[TEAM_BLUE] != 0) ^ src\game\client\gameclient.cpp:1447:33: note: Assignment 'm_aFlagDropTick[TEAM_BLUE]=0' m_aFlagDropTick[TEAM_BLUE] = 0; ^ src\game\client\gameclient.cpp:1446:40: note: Condition 'm_aFlagDropTick[TEAM_BLUE]!=0' is redundant else if(m_aFlagDropTick[TEAM_BLUE] != 0) ^ ```	2022-11-29 23:32:30 +01:00
Robert Müller	19bf435d6a	Remove redundant assignments ... According to cppcheck's `redundantInitialization` and `redundantAssignment` errors: ``` src\game\client\ui.cpp:456:5: style: Redundant initialization for 'tw'. The initialized value is overwritten before it is read. [redundantInitialization] tw = TextRender()->TextWidth(0, Size, pText, -1, LabelProps.m_MaxWidth, &AlignedSize, &MaxCharacterHeightInLine); ^ src\game\client\ui.cpp:454:11: note: tw is initialized float tw = std::numeric_limits<float>::max(); ^ src\game\client\ui.cpp:456:5: note: tw is overwritten tw = TextRender()->TextWidth(0, Size, pText, -1, LabelProps.m_MaxWidth, &AlignedSize, &MaxCharacterHeightInLine); ^ src\game\client\ui.cpp:529:5: style: Redundant initialization for 'tw'. The initialized value is overwritten before it is read. [redundantInitialization] tw = TextRender()->TextWidth(0, Size, pText, -1, LabelProps.m_MaxWidth, &AlignedSize, &MaxCharacterHeightInLine); ^ src\game\client\ui.cpp:527:11: note: tw is initialized float tw = std::numeric_limits<float>::max(); ^ src\game\client\ui.cpp:529:5: note: tw is overwritten tw = TextRender()->TextWidth(0, Size, pText, -1, LabelProps.m_MaxWidth, &AlignedSize, &MaxCharacterHeightInLine); ^ src\game\editor\editor.cpp:6051:19: style: Variable 'm_Map.m_Modified' is reassigned a value before the old one has been used. [redundantAssignment] m_Map.m_Modified = false; ^ src\game\editor\editor.cpp:6046:19: note: m_Map.m_Modified is assigned m_Map.m_Modified = false; ^ src\game\editor\editor.cpp:6051:19: note: m_Map.m_Modified is overwritten m_Map.m_Modified = false; ^ src\game\client\prediction\entities\character.cpp:1148:36: style: Variable 'm_LatestInput' is reassigned a value before the old one has been used. [redundantAssignment] m_LatestPrevInput = m_LatestInput = m_PrevInput = m_SavedInput = m_Input; ^ src\game\client\prediction\entities\character.cpp:1134:16: note: m_LatestInput is assigned m_LatestInput = m_LatestPrevInput = m_PrevInput = m_Input = m_SavedInput; ^ src\game\client\prediction\entities\character.cpp:1148:36: note: m_LatestInput is overwritten m_LatestPrevInput = m_LatestInput = m_PrevInput = m_SavedInput = m_Input; ^ src\game\client\prediction\entities\character.cpp:1148:20: style: Variable 'm_LatestPrevInput' is reassigned a value before the old one has been used. [redundantAssignment] m_LatestPrevInput = m_LatestInput = m_PrevInput = m_SavedInput = m_Input; ^ src\game\client\prediction\entities\character.cpp:1134:36: note: m_LatestPrevInput is assigned m_LatestInput = m_LatestPrevInput = m_PrevInput = m_Input = m_SavedInput; ^ src\game\client\prediction\entities\character.cpp:1148:20: note: m_LatestPrevInput is overwritten m_LatestPrevInput = m_LatestInput = m_PrevInput = m_SavedInput = m_Input; ^ src\game\client\prediction\entities\character.cpp:1148:50: style: Variable 'm_PrevInput' is reassigned a value before the old one has been used. [redundantAssignment] m_LatestPrevInput = m_LatestInput = m_PrevInput = m_SavedInput = m_Input; ^ src\game\client\prediction\entities\character.cpp:1134:50: note: m_PrevInput is assigned m_LatestInput = m_LatestPrevInput = m_PrevInput = m_Input = m_SavedInput; ^ src\game\client\prediction\entities\character.cpp:1148:50: note: m_PrevInput is overwritten m_LatestPrevInput = m_LatestInput = m_PrevInput = m_SavedInput = m_Input; ^ ```	2022-11-29 23:32:29 +01:00
Robert Müller	4197e8d0b0	Fix bool being assigned to float variable ... According to cppcheck's `assignBoolToFloat` error: ``` src\game\client\components\menus_settings.cpp:634:13: style: Boolean value assigned to floating point variable. [assignBoolToFloat] Highlight = (m_Dummy) ? g_Config.m_ClDummyDefaultEyes == CurrentEyeEmote : g_Config.m_ClPlayerDefaultEyes == CurrentEyeEmote; ^ src\game\client\gameclient.cpp:320:23: style: Boolean value assigned to floating point variable. [assignBoolToFloat] m_LastDummyConnected = false; ^ src\game\client\gameclient.cpp:563:23: style: Boolean value assigned to floating point variable. [assignBoolToFloat] m_LastDummyConnected = false; ^ ```	2022-11-29 23:32:28 +01:00
Robert Müller	65aa584b9f	Remove redundant conditional expressions ... According to cppcheck's `redundantCondition` and `multiCondition` errors: ``` src\engine\client\backend\glsl_shader_compiler.cpp:70:39: style: Redundant condition: The condition '*(pBuff+1)' is redundant since '*(pBuff+1) == 'i'' is sufficient. [redundantCondition] if(*pBuff == ' ' && *(pBuff + 1) && *(pBuff + 1) == 'i' && *(pBuff + 2) == 'n') ^ src\engine\client\backend\glsl_shader_compiler.cpp:98:45: style: Redundant condition: The condition '*(pBuff+1)' is redundant since '*(pBuff+1) == 'u'' is sufficient. [redundantCondition] else if(*pBuff == 'o' && *(pBuff + 1) && *(pBuff + 1) == 'u' && *(pBuff + 2) == 't') ^ src\game\client\gameclient.cpp:1665:62: style: Redundant condition: m_aShowOthers[g_Config.m_ClDummy]!=SHOW_OTHERS_NOT_SET. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] if(m_aShowOthers[g_Config.m_ClDummy] == SHOW_OTHERS_NOT_SET || (m_aShowOthers[g_Config.m_ClDummy] != SHOW_OTHERS_NOT_SET && m_aShowOthers[g_Config.m_ClDummy] != g_Config.m_ClShowOthers)) ^ src\game\client\prediction\entities\projectile.cpp:104:34: style: Redundant condition: pTargetChr. '!A || (A && B)' is equivalent to '!A || B' [redundantCondition] if(m_Explosive && (!pTargetChr || (pTargetChr && (!m_Freeze || (m_Type == WEAPON_SHOTGUN && Collide))))) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6588:11: style: Expression is always true because 'else if' condition is opposite to previous condition at line 6578. [multiCondition] else if(!pCommand->m_ByResize) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6578:14: note: first condition if(pCommand->m_ByResize) ^ src\engine\client\backend\vulkan\backend_vulkan.cpp:6588:11: note: else if condition is opposite to first condition else if(!pCommand->m_ByResize) ^ ```	2022-11-29 23:32:28 +01:00
Robert Müller	8e675878b0	Remove redundant null-checks ... According to cppcheck's `nullPointerRedundantCheck` check: ``` src\game\client\components\menus_settings.cpp:729:8: warning: Either the condition 'pSkinToBeSelected==0' is redundant or there is possible null pointer dereference: pSkinToBeSelected. [nullPointerRedundantCheck] if((pSkinToBeSelected->GetName()[0] == 'x' && pSkinToBeSelected->GetName()[1] == '_')) ^ src\game\client\components\menus_settings.cpp:732:25: note: Assuming that condition 'pSkinToBeSelected==0' is not redundant if(pSkinToBeSelected == 0) ^ src\game\client\components\menus_settings.cpp:729:8: note: Null pointer dereference if((pSkinToBeSelected->GetName()[0] == 'x' && pSkinToBeSelected->GetName()[1] == '_')) ^ src\game\editor\editor.cpp:5034:19: warning: Either the condition 'pEnvelope' is redundant or there is possible null pointer dereference: pEnvelope. [nullPointerRedundantCheck] float EndTime = pEnvelope->EndTime(); ^ src\game\editor\editor.cpp:5056:7: note: Assuming that condition 'pEnvelope' is not redundant if(pEnvelope) ^ src\game\editor\editor.cpp:5034:19: note: Null pointer dereference float EndTime = pEnvelope->EndTime(); ^ src\game\editor\editor.cpp:5038:3: warning: Either the condition 'pEnvelope' is redundant or there is possible null pointer dereference: pEnvelope. [nullPointerRedundantCheck] pEnvelope->FindTopBottom(s_ActiveChannels); ^ src\game\editor\editor.cpp:5056:7: note: Assuming that condition 'pEnvelope' is not redundant if(pEnvelope) ^ src\game\editor\editor.cpp:5038:3: note: Null pointer dereference pEnvelope->FindTopBottom(s_ActiveChannels); ^ src\game\editor\editor.cpp:5039:15: warning: Either the condition 'pEnvelope' is redundant or there is possible null pointer dereference: pEnvelope. [nullPointerRedundantCheck] float Top = pEnvelope->m_Top; ^ src\game\editor\editor.cpp:5056:7: note: Assuming that condition 'pEnvelope' is not redundant if(pEnvelope) ^ src\game\editor\editor.cpp:5039:15: note: Null pointer dereference float Top = pEnvelope->m_Top; ^ src\game\editor\editor.cpp:5040:18: warning: Either the condition 'pEnvelope' is redundant or there is possible null pointer dereference: pEnvelope. [nullPointerRedundantCheck] float Bottom = pEnvelope->m_Bottom; ^ src\game\editor\editor.cpp:5056:7: note: Assuming that condition 'pEnvelope' is not redundant if(pEnvelope) ^ src\game\editor\editor.cpp:5040:18: note: Null pointer dereference float Bottom = pEnvelope->m_Bottom; ^ src\game\editor\editor.cpp:5081:23: warning: Either the condition 'pEnvelope' is redundant or there is possible null pointer dereference: pEnvelope. [nullPointerRedundantCheck] for(int c = 0; c < pEnvelope->m_Channels; c++) ^ src\game\editor\editor.cpp:5056:7: note: Assuming that condition 'pEnvelope' is not redundant if(pEnvelope) ^ src\game\editor\editor.cpp:5081:23: note: Null pointer dereference for(int c = 0; c < pEnvelope->m_Channels; c++) ^ ```	2022-11-29 23:32:27 +01:00
Robert Müller	e134e4e488	Remove redundant conditions (always either true or false) ... According to cppcheck's `knownConditionTrueFalse` error: ``` src\base\system.cpp:1776:11: style: The comparison 'bytes == 0' is always true. [knownConditionTrueFalse] if(bytes == 0 && sock->ipv4sock >= 0) ^ src\base\system.cpp:1742:14: note: 'bytes' is assigned value '0' here. int bytes = 0; ^ src\base\system.cpp:1776:11: note: The comparison 'bytes == 0' is always true. if(bytes == 0 && sock->ipv4sock >= 0) ^ src\game\editor\io.cpp:887:33: style: Condition 'pSoundsItem->m_Version>=1' is always true [knownConditionTrueFalse] if(pSoundsItem->m_Version >= 1) ^ src\game\editor\io.cpp:874:33: note: Assuming that condition 'pSoundsItem->m_Version<1' is not redundant if(pSoundsItem->m_Version < 1 || pSoundsItem->m_Version > CMapItemLayerSounds::CURRENT_VERSION) ^ src\game\editor\io.cpp:887:33: note: Condition 'pSoundsItem->m_Version>=1' is always true if(pSoundsItem->m_Version >= 1) ^ src\game\editor\io.cpp:914:33: style: Condition 'pSoundsItem->m_Version>=1' is always true [knownConditionTrueFalse] if(pSoundsItem->m_Version >= 1) ^ src\game\editor\io.cpp:901:33: note: Assuming that condition 'pSoundsItem->m_Version<1' is not redundant if(pSoundsItem->m_Version < 1 || pSoundsItem->m_Version > CMapItemLayerSounds::CURRENT_VERSION) ^ src\game\editor\io.cpp:914:33: note: Condition 'pSoundsItem->m_Version>=1' is always true if(pSoundsItem->m_Version >= 1) ^ src\engine\client\backend\opengl\backend_opengl.cpp:207:68: style: Condition '*pStr=='\0'' is always false [knownConditionTrueFalse] else if(LastWasNumber && (*pStr == '.' || *pStr == ' ' || *pStr == '\0')) ^ src\game\client\components\maplayers.cpp:851:110: style: Condition 'DoTextureCoords' is always true [knownConditionTrueFalse] mem_copy_special(pUploadData + sizeof(vec2), pTmpTileTexCoords, sizeof(vec3), vtmpTiles.size() * 4, (DoTextureCoords ? (sizeof(vec2)) : 0)); ^ src\game\client\components\maplayers.cpp:849:11: note: Assuming that condition 'DoTextureCoords' is not redundant if(DoTextureCoords) ^ src\game\client\components\maplayers.cpp:851:110: note: Condition 'DoTextureCoords' is always true mem_copy_special(pUploadData + sizeof(vec2), pTmpTileTexCoords, sizeof(vec3), vtmpTiles.size() * 4, (DoTextureCoords ? (sizeof(vec2)) : 0)); ^ src\game\client\prediction\gameworld.cpp:567:5: style: Condition 'm_pParent' is always true [knownConditionTrueFalse] if(m_pParent && m_pParent->m_pChild && m_pParent->m_pChild != this) ^ src\game\client\components\menu_background.cpp:271:7: style: Condition 'NeedImageLoading' is always true [knownConditionTrueFalse] if(NeedImageLoading) ^ src\game\client\components\menu_background.cpp:268:23: note: Assignment 'NeedImageLoading=true', assigned value is 1 NeedImageLoading = true; ^ src\game\client\components\menu_background.cpp:271:7: note: Condition 'NeedImageLoading' is always true if(NeedImageLoading) ^ src\game\editor\editor.cpp:4991:6: style: Condition 'pEnvelope' is always true [knownConditionTrueFalse] if(pEnvelope) ^ ```	2022-11-29 23:32:26 +01:00
Robert Müller	fd208eaa1a	Remove redundant variable assignments ... The assigned values are never used, so the assignments can be removed or variable scopes can be reduced. According to cppcheck's `unreadVariable` error.	2022-11-29 23:32:26 +01:00
Robert Müller	0a0ddf2145	Pass parameters by const reference instead of value when possible ... According to cppcheck's `passedByValue` error.	2022-11-29 23:32:25 +01:00
Robert Müller	78876abd46	Remove unused members CColumn::m_Flags	2022-11-29 23:32:23 +01:00
Robert Müller	0688355d7b	Fix key reader text flashing for one frame, refactoring ... The key reader was displaying the old key for a frame. It now shows the new key immediately without flashing the old one after changing a bind. Refactoring: - The if-branches are restructured to be the same as on upstream. - The function `GetKeyBindModifiersName` can be called without an additional check, because it returns an empty string when no modifier is pressed. - The unused parameter `Checked` of the `DoButton_KeySelect` function is removed. From teeworlds/teeworlds#2877.	2022-11-29 22:25:47 +01:00
bors[bot]	2333f8e353	Merge #6058 ... 6058: Fix invalid demo cutting, Add slice highlighting r=Chairn a=VoxelDoesCode Before, you could place an end slice before the beginning, creating a "zero second" demo, which doesn't play in client, and renders a corrupt file. I implemented a check where if the playhead is before the beginning slice, it won't place an end slice, and vice versa. I also added highlighting in between the slices, so that it's easier to see.  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: VoxelDoesCode <bluheadcat@gmail.com>	2022-11-22 10:24:48 +00:00
VoxelDoesCode	cc2e40dd90	Reset slice markers if invalid	2022-11-21 20:19:58 -05:00
louis	d791fa3412	Modified layout ... Player count right justified Heart on left, number of friends below heart Slightly reduced space for server name column	2022-11-20 13:26:53 -06:00
louis	739c77d3d7	Added threshold, skips to end/beginning ... Threshold makes skipping multiple times in a row consistent If no markers ahead or behind, will skip to beginning or end	2022-11-20 12:12:00 -06:00
louis	1609422c95	fix clang format ... removed blankspace	2022-11-20 08:52:01 -06:00
louis	615f8e9354	Update menus_browser.cpp ... Added friend counter, changed alignment of player count indicator	2022-11-20 01:37:14 -06:00
louis	23287528ab	Update menus_demo.cpp	2022-11-19 22:00:20 -06:00
louis	a1680b30f7	Update menus_demo.cpp ... fix clang style	2022-11-19 17:32:47 -06:00
louis	74c6c5c960	Add buttons+increased length ... Added tick step buttons and jump to next/prev marker buttons Increased width of demo controls panel Centered the time multiplier	2022-11-19 16:36:57 -06:00
VoxelDoesCode	0761f4a8ae	Fix invalid demo cutting, Add slice highlighting ... Remove option (again)	2022-11-19 15:36:54 -05:00
Robert Müller	ab9b6c2b80	Allow both shift keys to be used for all hotkeys ... Handle both shift keys in some cases where only the left shift key was previously supported. The `CChat::m_ReverseTAB` variable is removed because it's unnecessary.	2022-11-15 21:17:55 +01:00
Robert Müller	04be9d6e72	Add IInput::ShiftIsPressed and IInput::AltIsPressed ... To avoid duplicate code when checking for both right and left shift or alt keys.	2022-11-15 21:17:55 +01:00
Dennis Felsing	3fff1fdc82	Don't cast write parameter for FindEntities ... I think at the point where you use (CEntity **) apPlayersInRange the compiler says this is a totally different value than apPlayersInRange since they have a different type. And then it reorders the inlined FindEntities code to be run afterwards, thus leading to undefined behavior and crashes.	2022-11-09 23:08:00 +01:00
Robert Müller	2d1d7b9562	Replace duplicate condition with a check for empty string	2022-11-06 16:25:24 +01:00
Robert Müller	4d0cd7f807	Use traditional casts instead of functional-style casts	2022-11-06 11:52:21 +01:00
bors[bot]	571b0b36de	Merge #5770 ... 5770: Fix physics change by weak hook fix (fixes #5769) r=def- a=fokkonaut <!-- What is the motivation for the changes of this pull request --> fixes #5769 ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: fokkonaut <35420825+fokkonaut@users.noreply.github.com> Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-11-01 10:29:53 +00:00
def	a237ee5f6d	Improve callvote arguments by making them more specific ... Should make it a bit clearer how to call a vote from F1	2022-10-29 14:45:24 +02:00
Robert Müller	6c8fa6b4f0	Rename variable aBuf to pBuf, use size_t for buffer size	2022-10-27 22:21:08 +02:00
Robert Müller	d551617c34	Use str_copy instead of str_format with format "%s" ... Using `str_format(aBuf, sizeof(aBuf), "%s", pStr)` is equivalent to `str_copy(aBuf, pStr, sizeof(aBuf))`. Using `str_copy` is more readable and also more efficient as there is no overhead from parsing the format string and from passing varargs.	2022-10-27 21:42:14 +02:00
Jupeyy	3b2dd73614	Rename config var to no weak only	2022-10-27 17:51:30 +02:00
Rafael Fontenelle	cd14660307	Fix misspellings	2022-10-25 13:51:56 -03:00
Robert Müller	6ef3adaa23	Fix long demo names being truncated in popups and UI ... Use `IO_MAX_PATH_LENGTH` for all demo filenames and paths, so long demo names and demo names containing many unicode characters are not so easily truncated in the cut, rename and render dialogs. Use combination of `str_endswith` and `str_append` to append file extensions, instead of using `str_comp_nocase` and `str_format`. Thereby only support creating demos and video files with lower case file extension, as only demo files with lower case file extension are shown in the client anyway.	2022-10-24 20:42:52 +02:00
Robert Müller	b486028838	Remove dead code ... The `PopupMessage` was never shown, as the next line activates `POPUP_REPLACE_VIDEO` which immediates overrides the message popup.	2022-10-24 20:18:09 +02:00
Robert Müller	997af452d0	Fix crash when cutting a demo opened from command line ... When playing a demo without opening the demo menu first, i.e. from command line argument or with `play` command from the main menu, clicking the demo slice button crashes the game, as the code tries to use the filename of the currently selected demo while there is no demo selected, i.e. `m_DemolistSelectedIndex == -1`. Also, when using the play command after opening the demo menu, the initial filename selected for cutting was incorrectly set to the currently selected demo. This is fixed by getting the name of the current demo file from the demo player instead, when cutting a demo. Though the cut demo will be saved to the last demo folder selected (or the demos directory) instead of being saved to the same directory as the original demo.	2022-10-24 20:14:04 +02:00
Robert Müller	3c1cd89ae6	Append file extension before checking for identical cut demo filename ... The file extension needs to be appended to the cut demo name before checking whether the name matches the currently playing file, otherwise the "Please use a different name" error message is not shown and instead the "File already exists" question is shown.	2022-10-24 19:53:42 +02:00
Robert Müller	be45604354	Fix demo file not being closed after showing error message ... When entering the name of an existing demo file into the Slice demo dialog and pressing the Ok button twice, the file handle that's used for checking for the demo file's existence is not closed, hence the cut demo file cannot be deleted until the client is closed.	2022-10-24 19:48:44 +02:00
heinrich5991	623a8935fb	Add client_score_kind field to serverinfo ... It specifies whether the scores are to be interpreted as times (string value starting with "time") or as points (string value starting with "points").	2022-10-20 00:43:38 +02:00
Jupeyy	b70fc39571	fix skin click ptr	2022-10-19 20:18:43 +02:00
Robert Müller	c78f71b2b9	Fix client crash when server does not send gameinfo	2022-10-15 19:43:26 +02:00
bors[bot]	6c3d0e999b	Merge #5933 #5941 ... 5933: Inline `Is(GameType)` functions and remove support for legacy 64 player info protocol r=def- a=heinrich5991 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5941: Get away from vector for skins r=def- a=Jupeyy most of the time it uses the index just to get the skin, downloaded skins change the index. Now its simply a heap object and downloaded skins load directly. Also the loading might be a bit faster bcs it had a loop lookup .Also O(1) lookup not 100% tested. also fixes a bug with favorite skins hopefully ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com> Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-10-12 22:08:17 +00:00
Jupeyy	a804c3ca5b	Get away from vector for skins ... most of the time it uses the index just to get the skin, downloaded skins change the index. Now its simply a heap object and downloaded skins load directly. Also the loading might be a bit faster bcs it had a loop lookup Also O(1) lookup	2022-10-12 22:32:36 +02:00
heinrich5991	a97a597592	Inline Is(GameType) functions ... They are used for two purposes, coloring gametypes in the serverbrowser and enabling backward compatibility. These are independent, we shouldn't add more stuff to the backward compatibility, hence I split them up and inlined them.	2022-10-11 16:05:46 +02:00
bors[bot]	8de0247d00	Merge #5909 ... 5909: Add favorite skins r=def- a=Jupeyy Advantages: - my friend fokkonaut can mark his favorite vanilla skins - u can mark skin db skins which auto download if not loaded untested, bad code, maybe buggy. but still want feedback :)  ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-10-10 14:42:18 +00:00
bors[bot]	6d7df66448	Merge #5918 ... 5918: Constify snap more (inspired by upstream) r=Robyt3 a=ChillerDragon Incorporate const added in those upstream commits: d86d576217 e6b8518b49 ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: ChillerDragon <ChillerDragon@gmail.com>	2022-10-09 13:53:05 +00:00
ChillerDragon	9982a7bad3	Constify snap more (inspired by upstream) ... Incorporate const added in those upstream commits: d86d576217 e6b8518b49	2022-10-09 15:12:12 +02:00
bors[bot]	b7da20826d	Merge #5919 ... 5919: Tweak the running visuals r=def- a=VoxelDoesCode Sorry for putting this off for so long. Turns out animating with raw code is harder than you'd think. https://user-images.githubusercontent.com/95713843/194726134-40925aea-6ec4-40ae-9597-b80a28d1b6a2.mp4 ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: VoxelDoesCode <bluheadcat@gmail.com>	2022-10-08 22:58:13 +00:00
VoxelDoesCode	fc09212d43	Tweak the running visuals	2022-10-08 16:07:15 -04:00
bors[bot]	665f829759	Merge #5915 ... 5915: Don't overlap menu + debug messages (fixes #5914) r=Robyt3 a=def-  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-10-07 18:48:08 +00:00
Dennis Felsing	774f7a6f33	Don't overlap menu + debug messages (fixes #5914)	2022-10-07 19:03:20 +02:00
def	317b2df7c0	Support multiple values to search/exclude (fixes #4119)	2022-10-07 18:21:14 +02:00
Dennis Felsing	c4463a3848	Only show ingame hint in Game tab ... Since it looks ugly overlaid over the other tabs	2022-10-06 18:38:32 +02:00
Jupeyy	fbc4c9cd6e	Add favorite skins	2022-10-05 19:23:03 +02:00
def	361622ec37	Add help text at bottom left when menu is open	2022-10-03 00:11:01 +02:00
def	9e5d830e34	Revert ingame menu close button ... Even I got confused by it and accidentally hit power off button. Left side seems not popular for close either (#5888) Since opening the menu requires Escape, players can probably figure out Escape to close it again. > Revert "Don't show home button ingame" > > This reverts commit d3ff903d44. > > Revert "Move home button to very right so it is consistent with close button ingame (fixes #5881)" > > This reverts commit 9cc08cc9d3. > > Revert "Add close button to close ingame menu" > > This reverts commit cfcfb7b3f0.	2022-10-02 23:59:48 +02:00
Robert Müller	98848cde70	Use str_comp_filenames to sort maps and demos again ... This means that digit characters in filenames will be comparsed as numbers instead of being compared as individual digits. The use of this function was previously (d2f5714042) removed as it did not sort names case insensitively, whereas now it does.	2022-09-30 14:48:53 +02:00
Robert Müller	3176032a7b	Fix spelling seperate -> separate	2022-09-29 18:54:40 +02:00
fokkonaut	900417b84d	Send laser objects as DDNetLaser with type (fixes #5885)	2022-09-27 13:25:20 +02:00
Dennis Felsing	d3ff903d44	Don't show home button ingame ... Broken in #5882	2022-09-27 13:03:16 +02:00
def	9cc08cc9d3	Move home button to very right so it is consistent with close button ingame (fixes #5881)	2022-09-26 19:02:41 +02:00
bors[bot]	0f6594f10b	Merge #5875 ... 5875: Move `src/game/bezier.cpp/h` to `src/base/bezier.cpp/h` r=def- a=Robyt3 As those functions are not game specific per se, they can be part of base instead. Closes #3334. <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-09-24 19:17:10 +00:00
bors[bot]	fdf29b5197	Merge #5861 ... 5861: Add close button to close ingame menu r=Jupeyy a=def- Suggested by cheeser0613 since new players don't know that Escape is the only way to close it again   I'm not sure if I prefer it on left or right side. Left side is like the start menu button, right side is like Windows bar. ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-09-24 19:00:28 +00:00
Robert Müller	727b147268	Move src/game/bezier.cpp/h to src/base/bezier.cpp/h ... As those functions are not game specific per se, they can be part of base instead. Closes #3334.	2022-09-24 20:53:59 +02:00
Robert Müller	9625a4e521	Fix skin prefix button container being used for multiple buttons ... This meant that only the first skin prefix button could be activated. Regression from #5633.	2022-09-24 17:43:53 +02:00
Lukas Kitsche	599eb18245	fix linting, will be squashed later	2022-09-24 00:56:43 +02:00
Lukas Kitsche	43aae1bd82	move refresh logic of browsertab into helper function	2022-09-23 19:59:18 +02:00
Lukas Kitsche	e5f3943f6e	refresh serverbrowser when disconnecting / abort	2022-09-22 20:55:19 +02:00
Dennis Felsing	cfcfb7b3f0	Add close button to close ingame menu ... Suggested by cheeser0613 since new players don't know that Escape is the only way to close it again	2022-09-22 09:49:54 +02:00
bors[bot]	069e5a7c9d	Merge #5848 #5851 ... 5848: Remove cl_http_map_download r=heinrich5991 a=def-  Causes problems with GER3 ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5851: Respect reserved slots in old serverinfo r=heinrich5991 a=def- Noticed in https://github.com/ddnet/ddnet/pull/5850 that reserved slots were not respected <!-- What is the motivation for the changes of this pull request? --> <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-09-18 11:40:11 +00:00
def	9f4e883906	Remove cl_http_map_download	2022-09-18 01:03:15 +02:00
bors[bot]	e61b850364	Merge #5843 ... 5843: Laser menu tweaks; Changed some default colors r=def- a=VoxelDoesCode fixes #5841  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: VoxelDoesCode <bluheadcat@gmail.com>	2022-09-17 22:16:26 +00:00
VoxelDoesCode	71b073a45f	New SG Laser default, Reset to defaults	2022-09-17 17:11:53 -04:00
Robert Müller	d34b7a4ea5	Refactor color picker variable names and color conversion	2022-09-17 13:12:12 +02:00
Robert Müller	4fb98f4ec2	Fix UI elements behind color picker background being selectable ... Is was previously possible activate UI elements behind an active color picker when hovering the background of the color picker but not the color picker UI elements.	2022-09-17 13:12:12 +02:00
VoxelDoesCode	4c7a29b430	Add Reset All button	2022-09-16 21:06:20 -04:00
VoxelDoesCode	5915d5531d	Laser menu tweaks; Changed Freeze laser color	2022-09-16 18:28:36 -04:00
VoxelDoesCode	fb15a7c2a4	Running and AFK anim. states	2022-09-16 12:30:05 +02:00
Dennis Felsing	9a2835c9dd	Update translations via script, new German translations ... New English text for marking the beginning/end of a cut	2022-09-15 14:38:08 +02:00
fokkonaut	5deeb299fa	Add DDNetLaser to have more info about a laser shot	2022-09-15 01:01:32 +02:00
VoxelDoesCode	03b90f4f3d	Added new cl colors and tweaked the settings menu ... Merging of DoLaserPreview and static int fix Replace if else statement with switch function Adjusted RenderDropDown header to match static int cbuttoncontainer fix, potential bugs	2022-09-15 01:01:04 +02:00
Jupeyy	f59f79e02f	Move skin info after the settings (settings can cause reload -> skin is invalid)	2022-09-10 15:03:59 +02:00
Robert Müller	e7c3ce186f	Port CUI::ConsumeHotkey from upstream ... Move hotkey/input handling from `CMenus` to `CUI`. Using the `ConsumeHotkey` method ensures that each hotkey is only handled once. By also handling the mouse scroll wheel as hotkeys, this fixes the scroll keys activating scroll regions while the controls binder is active.	2022-08-31 21:43:57 +02:00
def	c479230d71	Use new ddnet.org domain	2022-08-30 10:09:06 +02:00
bors[bot]	3478146ea5	Merge #5784 ... 5784: Suppress more events while skipping in demos, reset specifics components before long skips in demo r=def- a=Robyt3 Closes #5779. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-08-29 21:47:28 +00:00
Jupeyy	d2295ff94e	refind skins after reload	2022-08-29 18:28:59 +02:00
Robert Müller	c6cc45471a	Allow spectator mode to be changed while demo is paused ... By updating and rendering the current tick again when changing the spectator mode while the demo playback is paused. Refactoring: Extract `IDemoPlayer::ETickOffset`, `IDemoPlayer::SeekTick` and `CMenus::DemoSeekTick`.	2022-08-28 17:52:49 +02:00
Robert Müller	c0472b3177	Reset specific components before long skips in demo ... Only reset what has to be reset instead of using `CGameClient::OnReset`, which would reset a lot more and cause other issues (client freezing while skipping) that would first need to be solved.	2022-08-28 15:39:30 +02:00
Robert Müller	b2fbfac4d1	Suppress more events while skipping in demos: ... - chat messages - kill messages - sounds - stats - air jump effects	2022-08-28 15:20:50 +02:00
Robert Müller	1da597ff1a	Fix automatic demo rewind not working when menu is not active	2022-08-28 12:26:20 +02:00
Robert Müller	3dc577f24e	Fix demo seeking not working anymore when menu is not active	2022-08-28 12:23:03 +02:00
Robert Müller	7cbca53d48	Deactivate "Follow" spectator mode in global server demos ... As there is no spectator to follow, the follow mode does not work in global server demos. Player server demos are unaffected and support the follow mode.	2022-08-27 17:48:04 +02:00
Robert Müller	939b3e5538	Fix free-view button state when following a free-view spectator ... When following a spectator that is using free-view mode, the free-view button was active at the same time as the follow button.	2022-08-27 17:45:56 +02:00
bors[bot]	8ac260a3a9	Merge #5777 ... 5777: Add period/comma hotkeys to skip one tick forward/backward, various other improvements to demo skipping r=Jupeyy a=Robyt3 Mostly from upstream https://github.com/teeworlds/teeworlds/pull/2904, with some more fixes and refactorings. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-08-27 12:40:09 +00:00
bors[bot]	b42627f807	Merge #5748 ... 5748: Remove the need for sprite icon images; update Icons file r=Jupeyy a=VoxelDoesCode It felt like that it was very unoptimized to have two images for the demo buttons. Initially, I wanted to merge it into one image, but it was a much better choice to have it so that we use the Icons font file for the sprites instead. Turns out, considering how the typeface is rendered, it looks much smoother and crisper. The contrast between the squares and the symbols is much clearer alongside! Before the change:  After the change:  Note that there is a few compromises that had to be made with the limited symbol choices. As of publishing this there is not a symbol for a crossed out keyboard, but I hope the eye works just fine for now. ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: VoxelDoesCode <bluheadcat@gmail.com>	2022-08-27 12:24:36 +00:00
Robert Müller	a24ac108ce	Always suppress events and update envelopes when skipping	2022-08-27 13:23:06 +02:00
Robert Müller	bf16875a6f	Add period/comma hotkeys to skip one tick forward/backward	2022-08-27 12:49:32 +02:00
Robert Müller	d6628fe028	Rename variable LastSpeedChange to s_LastSpeedChange	2022-08-27 12:49:32 +02:00
Robert Müller	091f3b3e34	Rename variable PrevAmount to s_PrevAmount	2022-08-27 12:49:32 +02:00
VoxelDoesCode	20e70b3172	Demo Tooltips, in courtesy of Chairn	2022-08-26 02:07:58 -04:00
VoxelDoesCode	0392f6655d	Added an icon for Parent Directories	2022-08-25 18:44:27 -04:00
VoxelDoesCode	216d4421ce	Clang Format	2022-08-24 16:17:04 -04:00
Robert Müller	638559b648	Refactor scrollable controls settings using CScrollRegion ... Replace hacky usage of `UiDoListboxStart` with `CScrollRegion`.	2022-08-23 10:08:46 +02:00
Robert Müller	7c496dd5b4	Make ingame server info MOTD scrollable using CScrollRegion	2022-08-23 10:08:46 +02:00
Robert Müller	f451a33361	Port CScrollRegion from upstream with some minor refactorings ... Co-authored-by: LordSk <lordskelethom@gmail.com>	2022-08-23 10:01:28 +02:00
Robert Müller	9cbca642ea	Rename CUIElement::Get to Rect ... This makes it clear that the method is a getter for the rects.	2022-08-23 10:01:27 +02:00
Robert Müller	991b045a11	Remove unused CUIElement::m_ElementTime	2022-08-23 10:01:26 +02:00
bors[bot]	49bed71932	Merge #5696 ... 5696: Add option for parallax-aware zoom r=def- a=Fireball-Teeworlds ## How this works Currently we have parallax X and Y parameters that control how far away a layer feels. Currently it's only taken into account for camera moving sideways. This pull request makes zoom behave as if the camera was moving closer or further away, taking into account the distance to the layer. In order to provide flexibility, this behaviour is using a separate parallax value, similar to how we have separate values for X and Y. Para Zoom will default to the minimum of parallax X, Y, clamped to be between 0 and 100. This seems to look well on most maps. This pull request also introduces two new features to the Editor: * Controls for configuring per-group Para Zoom value. If Custom Zoom is set to No, Para Zoom will automatically keep following to the default value described above, so that people new to the feature don't have to figure out how it works. * Zoom button that previews the zoom behavior (next to Proof at the top). ## Editor Screenshots ### Para Zoom controls   ### Zoom Button   ## In-Game Screenshots Video: https://youtu.be/W7eXQN0gRFI This is an older version of the pull request that had an option to disable the new behaviour. The current version can only be disabled in map editor for a particular map. ### Springlobe 3 With new feature:  Without:  ### Beyond Dreams With new feature:  Without:  ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [X] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [X] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [X] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Fireball <fireball.teeworlds@gmail.com>	2022-08-22 21:15:41 +00:00
Robert Müller	d3c9311156	Replace POPUP_PURE with generic PopupMessage	2022-08-21 13:25:06 +02:00
Jupeyy	6e5c5cba8f	Filter vanilla only skins at loading already	2022-08-20 14:39:25 +02:00
Jupeyy	d1b8d53619	Auto refresh skins when changing related settings	2022-08-20 13:42:28 +02:00
VoxelDoesCode	fa98ad1e36	Remove the need for file_icons.png	2022-08-19 01:05:02 -04:00
VoxelDoesCode	1807bb7b1e	Update icons and clean up	2022-08-17 20:28:24 -04:00
VoxelDoesCode	470ee65db9	DoButton_Sprite > DoButtonFontIcon	2022-08-17 04:28:09 -04:00
VoxelDoesCode	a1617dcf56	Replace all images with unicode chars	2022-08-17 03:58:13 -04:00
Robert Müller	f0b0d4c163	Improve "couldn't open..." error messages by listing target	2022-08-16 17:35:47 +02:00
Robert Müller	f0c74f72ba	Smooth console completion scrolling	2022-08-15 23:20:37 +02:00
bors[bot]	4826eb1df0	Merge #5730 ... 5730: Move `CUIRect` to separate file, move `CRenderTools::DrawUIRect/4` to `CUIRect::Draw/4`, merge `CUIEx` into `CUI` r=def- a=Robyt3 Adopt UI refactorings from upstream: - move `CUIRect` into a separate file - this allows some includes of `ui.h` to be removed, most importantly in `render.h` - move `CRenderTools::DrawUIRect/4` to `CUIRect::Draw/4` - this object orientied calling style makes it easier to write the code The `CUIEx` class is merged into the `CUI` class, as there is no need for two different UI classes anymore. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-08-14 11:55:24 +00:00
c0d3d3v	780c4db7dd	do an int check for m_FreezeEnd instad of float, becuase it is int	2022-08-13 15:43:38 +02:00
c0d3d3v	0aa46b54ea	small fix for #5729	2022-08-12 22:38:13 +02:00
Robert Müller	51fb3e9a22	Merge CUIEx class into CUI ... There is no need to separate the UI in two classes anymore, as the dependency on `CRenderTools` has been removed.	2022-08-12 19:59:19 +02:00
Robert Müller	95550fd6a9	Move CRenderTools::DrawUIRect/4 to CUIRect::Draw/4 ... Use `ColorRGBA` instead of `vec4` for `Draw4`.	2022-08-12 19:37:08 +02:00
Robert Müller	7b390808bc	Replace ui.h include with ui_rect.h, organize other includes	2022-08-12 19:37:08 +02:00
Robert Müller	680dd052d7	Add documentation for CUIRect::Inside	2022-08-12 19:37:07 +02:00
Robert Müller	49164dfcdf	Improve argument names of CUIRect::Inside	2022-08-12 19:37:07 +02:00
Robert Müller	b50309dd5c	Move CUIRect class into its own files	2022-08-12 19:37:07 +02:00
Robert Müller	4005b82743	Move CRenderTools::DrawUIElRect to CUIElement::SUIElementRect::Draw ... This method draws a particular UI element rectangle so it should be a member method.	2022-08-12 17:42:05 +02:00
Robert Müller	2a21cd6eab	Move all DrawRect* methods from CRenderTools to IGraphics ... As the methods do not depend on any game components they are moved to the engine graphics interface.	2022-08-12 17:42:05 +02:00
Robert Müller	7b20009980	Move CUI::CORNER_* enum to IGraphics::CORNER_* ... Entirely automatic replacement in preparation for moving rect drawing methods from `CRenderTools` to `IGraphics`.	2022-08-12 17:42:04 +02:00
Robert Müller	237fdc76db	Move CRenderTools::DrawCircle to IGraphics::DrawCircle ... As this method does not depend on any game components it is be moved to the engine graphics interface.	2022-08-12 17:42:03 +02:00
Robert Müller	967c92f5d6	Encapsulate CGraph member variables ... Make the member variables private and add `SetMin` to replace a usage of the member variables in `CDebugHud`. For completeness/symmetry, `SetMax` is also added.	2022-08-12 16:13:23 +02:00
Robert Müller	b314db5454	Use CGraph::MAX_VALUES instead of magic value in debughud	2022-08-12 16:13:02 +02:00
Robert Müller	8e0a935d5c	Combine CGraph::ScaleMin and ScaleMax into Scale ... As the methods are always called at the same time, they can be combined. This also improves the performance, as the array only needs to be iterated once.	2022-08-12 16:12:55 +02:00
Robert Müller	e99f7ab106	Extract StrCopyUntilSpace and use existing str_* functions ... Minor refactoring to reduce duplicate code. Eventually this method could be extended to handle completion for other arguments except the first one.	2022-08-11 19:30:54 +02:00
Robert Müller	33bb576202	Show completion options for tune params in console ... Currently supports `tune`, `tune_reset` and `toggle_tune`. For `tune_zone` the tune name is the second argument, so this is more difficult to handle.	2022-08-11 10:11:03 +02:00
Robert Müller	047c88d797	Refactor console completion input handling according to upstream	2022-08-11 10:08:59 +02:00
Robert Müller	f3eb93b83a	Extend IConsole::PossibleCommands, add index to callback ... `PossibleCommands` now passes the item index to the callback and returns the total number of items. Add `EmptyPossibleCommandCallback` as default parameter.	2022-08-11 10:08:06 +02:00
Robert Müller	680abb6405	Encapsulate CTuningParams::ms_apNames with CTuningParams::Name	2022-08-11 10:07:45 +02:00
Robert Müller	85a41f46dc	Allow tune command to list current tuning parameter value ... Extend `tune` so the current value of a given tuning variable is printed if no new value is given, so it works like commands in the console. For example `tune player_collision` will print the current value of the variable, whereas `tune player_collision 0` will change the value like before.	2022-08-11 10:04:52 +02:00
Robert Müller	e3bb8bc370	Allow tune_reset to reset a single tune ... Extend `tune_reset` so a single tuning value can be reset to default. For example `tune_reset player_collision` will reset just the `player_collision` tuning, whereas `tune_reset` will reset all to defaults like before.	2022-08-11 10:00:26 +02:00
Robert Müller	54aff02286	Add success/error message to dump_(local|remote)_console commands	2022-08-11 09:52:19 +02:00
Robert Müller	43fdeb8468	Rename tune_dump to tunes, improve descriptions	2022-08-11 09:48:41 +02:00
Robert Müller	ca31b495a9	Rename dump_binds command to binds, fix typo in description	2022-08-11 09:48:34 +02:00
Dennis Felsing	d003cc6ee2	Use current backlog page instead of old (fixes #5719) ... Better fix by Robyt3	2022-08-10 17:27:24 +02:00
Fireball	5d886d80f8	Parallax Zoom: use CMapItemGroupEx to store parallax value	2022-08-10 03:05:23 +01:00
Robert Müller	a8e3ac1184	Minor refactoring: use int64_t instead of long long	2022-08-09 18:48:06 +02:00
Robert Müller	1e6fd63204	Rename variables id to KeyID	2022-08-09 18:48:04 +02:00
bors[bot]	57849a128c	Merge #5717 ... 5717: Check fully transparent quads with negative alpha r=def- a=Jupeyy fixes #5716 Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-08-09 15:49:32 +00:00
Jupeyy	bc865ab087	Check transparency even for negative alpha	2022-08-09 17:44:09 +02:00
bors[bot]	f8fca99e62	Merge #5642 ... 5642: Option to remove weak hook & bounce r=def- a=Jupeyy Fixes #5641 server side only ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-08-09 13:59:21 +00:00
Dennis Felsing	614a5b35bc	Easter egg	2022-08-08 16:37:17 +02:00
Fireball	a90c86e9a5	Parallax-aware zoom ... How this works: parallax values configure perceived distance from camera when it's moving along x and y axes. Assume that zoom is moving the camera away and scale layers accordingly, with background layers (furtherst away) changing the least. New per-ItemGroup (LayerGroup) setting allows to set the new parallax value independently from the other two. This can be used to do tricks like on Time Shop zoom correctly or make it feel like the camera is changing the field of view at the same time as moving in space.	2022-08-05 00:40:58 +01:00
Jupeyy	88c4b69301	Add an option to remove weak hook & bounce	2022-07-21 17:04:16 +02:00
Robert Müller	95636da6d9	Fix out of bounds access with highlighted messages in server demos ... ``` src/game/client/components/chat.cpp:795:89: runtime error: index -1 out of bounds for type 'CClientData [64]' #0 0x55c133fd047a in CChat::AddLine(int, int, char const*) src/game/client/components/chat.cpp:795 #1 0x55c133fc80b5 in CChat::OnMessage(int, void*) src/game/client/components/chat.cpp:570 #2 0x55c134677688 in CGameClient::OnMessage(int, CUnpacker*, int, bool) src/game/client/gameclient.cpp:770 #3 0x55c133c282d2 in CClient::OnDemoPlayerMessage(void*, int) src/engine/client/client.cpp:2627 #4 0x55c134ccdcba in CDemoPlayer::DoTick() src/engine/shared/demo.cpp:679 #5 0x55c134cdac81 in CDemoPlayer::Update(bool) src/engine/shared/demo.cpp:1007 #6 0x55c133c2a08b in CClient::Update() src/engine/client/client.cpp:2686 #7 0x55c133c4c9eb in CClient::Run() src/engine/client/client.cpp:3296 #8 0x55c133cbd64f in main src/engine/client/client.cpp:4761 ```	2022-07-21 15:32:11 +02:00
Robert Müller	b4eee122dd	Fix null pointer access in maplayers when the snapshot has no game info ... ``` src/game/client/components/maplayers.cpp:98:112: runtime error: member access within null pointer of type 'const struct CNetObj_GameInfo' #0 0x55d84eea9e1e in CMapLayers::EnvelopeEval(int, int, ColorRGBA&, void*) src/game/client/components/maplayers.cpp:98 #1 0x55d84f518082 in CRenderTools::ForceRenderQuads(CQuad*, int, int, void (*)(int, int, ColorRGBA&, void*), void*, float) src/game/client/render_map.cpp:112 #2 0x55d84f517ac7 in CRenderTools::RenderQuads(CQuad*, int, int, void (*)(int, int, ColorRGBA&, void*), void*) src/game/client/render_map.cpp:98 #3 0x55d84eee10b0 in CMapLayers::OnRender() src/game/client/components/maplayers.cpp:1839 #4 0x55d84f34b915 in CGameClient::OnRender() src/game/client/gameclient.cpp:640 #5 0x55d84e8d44c2 in CClient::Render() src/engine/client/client.cpp:1222 #6 0x55d84e92d1a0 in CClient::Run() src/engine/client/client.cpp:3370 #7 0x55d84e99964f in main src/engine/client/client.cpp:4761 ```	2022-07-21 15:28:31 +02:00
Jupeyy	2240ad2966	Fix spelling	2022-07-19 18:22:44 +02:00
Robert Müller	c6cf0004a9	Fix names of static variables in settings menus	2022-07-18 21:51:46 +02:00
ChillerDragon	1347860b2c	Adapt upstreams CButtonContainer	2022-07-18 10:23:03 +02:00
Alexander Akulich	04ff8f13c2	Menu: Fix a typo in loading state text	2022-07-14 23:40:23 +03:00
Alexander Akulich	9e4098f3a5	prediction/entity: Add GetPos() (sync the API with server/entity)	2022-07-14 23:40:23 +03:00
Alexander Akulich	5169369809	prediction/entity: Sync ID getter name with the server/entity	2022-07-14 23:40:23 +03:00
bors[bot]	96896ddf5c	Merge #5619 ... 5619: Make UI inputs more secure r=def- a=C0D3D3V fixes #3560 finally :) what a dream xD This in addition also fixes an input bug, if you hold a mouse button on an input and then open f1 it no longer presses that button. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-07-14 16:17:55 +00:00
c0d3d3v	27a4c494e9	Make UI inputs more secure	2022-07-11 18:56:36 +02:00
bors[bot]	abc9929d35	Merge #5615 ... 5615: Fix Text Alignments in Popups r=def- a=blueskyGH Fixed the alignment issues in Popups. Examples: Before   After   Its my first PR for actual code. Please indulge me. :) We still need to get rid of the "ExtraAlign" variable and only use TextWidth(). But somehow TextWidth() doesn't work properly in this case. Hopefully a more experienced collaborator can have a look at these lines: bbca48aa5b (diff-3aebb8cc835bb888d687b51e9dcfc0cda5326d89fd1c97ff83d85c00b82ed116L1656-R1657) ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: blueskyGH <108560485+blueskyGH@users.noreply.github.com>	2022-07-11 16:11:57 +00:00
blueskyGH	381394cfff	Fix Text Alignments in Popups	2022-07-11 15:47:48 +02:00
c0d3d3v	e3fc71d051	Rename "NoSomething" to "SomethingDisabled"	2022-07-11 13:40:01 +02:00
c0d3d3v	ebfc053809	Remove even more redundant variables to avoid inconsistent states. Fix another swap bug.	2022-07-11 13:39:52 +02:00
bors[bot]	a3001f3bd1	Merge #5205 ... 5205: Allow multiple addresses per server in the serverbrowser r=def- a=heinrich5991 Support is incomplete for `leak_ip_address_to_all_servers` (will only ping the first address of each server) and for the `leak_ip` setting (which will also only ping the first address of each server). Fixes #5158. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com>	2022-07-10 23:31:21 +00:00
bors[bot]	9e1b6cd1e9	Merge #5613 ... 5613: Search in $PATH for server executable (fixes #5594) r=heinrich5991 a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-07-10 23:08:57 +00:00
def	aa788e228c	Search in $PATH for server executable (fixes #5594)	2022-07-10 23:59:28 +02:00
Robert Müller	ec4175277e	Fix readability-container-data-pointer	2022-07-10 21:42:57 +02:00
Robert Müller	072b9ebaba	Use DrawRoundRectExt instead of DrawRoundRect and remove the latter	2022-07-10 17:19:35 +02:00
Robert Müller	cc0f64cc29	Use DrawRect instead of DrawRoundRect in CStatboard ... To reduce duplicate code.	2022-07-10 17:19:34 +02:00
Robert Müller	992e5d0d07	Use DrawRect instead of DrawRoundRect in CMotd ... To reduce duplicate code.	2022-07-10 17:19:34 +02:00
Robert Müller	ab4a4aeb75	Use DrawRect instead of DrawRoundRect in CMenus ... To reduce duplicate code.	2022-07-10 17:19:34 +02:00
Robert Müller	0c10b64ee5	Use DrawRect instead of DrawRoundRect in CConsole ... To reduce duplicate code.	2022-07-10 17:19:33 +02:00
Robert Müller	b571fdf93c	Use DrawRect instead of DrawRoundRect/Ext in CScoreboard ... To reduce duplicate code.	2022-07-10 17:19:33 +02:00
Robert Müller	76c9d86016	Use DrawRect instead of DrawRoundRect/Ext in CHud ... To reduce duplicate code.	2022-07-10 17:19:33 +02:00
Robert Müller	e042a22d1e	Use DrawRect instead of DrawRoundRect/Ext in CSpectator ... To reduce duplicate code.	2022-07-10 17:19:33 +02:00
Robert Müller	a0ef36847b	Add CRenderTools::DrawRect/4 and make DrawUIRect/4 delegates ... So usages of `DrawRoundRect/Ext` can more easily be replaced with `DrawRect/4` and so the basic draw methods can be moved to the engine graphics without depending on the `CUIRect` class.	2022-07-10 17:19:32 +02:00
Robert Müller	ebf6ce4d27	More efficient CreateRoundRectQuadContainer with CORNER_NONE ... By adding an additional case that only creates a single quad when no corners / rounding are used, like in `DrawRoundRectExt4`.	2022-07-10 17:19:32 +02:00
Robert Müller	a9787b15e3	Merge CRenderTools::DrawUIRect4NoRounding into DrawUIRect4 ... As this is a special case the methods can be merged to reduce the number of public methods.	2022-07-10 17:19:32 +02:00
heinrich5991	8996d152ab	Allow multiple connect addresses ... This allows the client to connect to servers that have both an IPv4 and an IPv6 address, even if the client is only connected to one of the two. The one faster to answer will be picked. Timeout codes are now generated based on *all* of the server's addresses. Fixes #5158.	2022-07-10 16:57:10 +02:00
heinrich5991	6600024f24	Allow multiple addresses per server in the serverbrowser ... Support is incomplete for `leak_ip_address_to_all_servers` (will only ping the first address of each server) and for the `leak_ip` setting (which will also only ping the first address of each server).	2022-07-10 16:52:07 +02:00
Robert Müller	0d29e6fe3f	Rename variable HoverTime -> m_HoverTime	2022-07-10 15:40:17 +02:00
Robert Müller	fb1919b9be	Fix spaces around documentation comments in tooltip.h	2022-07-10 15:40:17 +02:00
Robert Müller	35483177e8	Use else-if instead of duplicating condition	2022-07-10 15:40:17 +02:00
bors[bot]	e9f95dbefd	Merge #5598 ... 5598: Fix the HUD bug I intoduced with #5592 r=def- a=C0D3D3V The bug was, if you spectate other players, the jump display and weapon display was broken. Use for weapon and jump display now render information instead of the predicted data, so that these Displays are also correct if you spectate other players. This is necessary since with https://github.com/ddnet/ddnet/pull/5592 this information is no longer present in the predicted character (if the character is not predicted) ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-07-09 22:13:18 +00:00
Alexander Akulich	6d9284adc1	Port some code to str_copy() template	2022-07-09 19:40:58 +03:00
Alexander Akulich	0d72b62daf	Replace 3.14159265f with 'pi' from math.h	2022-07-09 19:19:21 +03:00
Alexander Akulich	9faea2ff6e	client/menus_ingame: Fix a warning about struct padding ... Excessive padding in 'struct CColumn' (8 padding bytes, where 0 is optimal).	2022-07-09 19:16:46 +03:00
Alexander Akulich	dd94d662ca	client/settings: Use CUI::CORNER enum keys where appropriate	2022-07-09 19:16:46 +03:00
c0d3d3v	57995693ad	Use for weapon and jump display now render information instead of the ... predicted data, so that these display are also correct if you spectate other players. This is necessery since with https://github.com/ddnet/ddnet/pull/5592 this information is no longer present in the predicted character (if the chracter is not predicted)	2022-07-09 16:03:16 +02:00
bors[bot]	e2f7f53bc8	Merge #5591 ... 5591: (A bit) safer interface for text containers r=def- a=Jupeyy For #5143 Maybe it helps identifying the problem earlier, maybe not^^ ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-07-09 09:47:48 +00:00
bors[bot]	5345e55b94	Merge #5545 ... 5545: Format name accordingly r=heinrich5991 a=Chairn I think i got almost all the misstyped name. I did let some because they made sense to me. I think, only generated code remains to be formatted (and src/base and websockets, but those seems to have an exception). ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Chairn <chairn.nq@hotmail.fr>	2022-07-08 23:08:02 +00:00
c0d3d3v	1dacb3366b	rename ReadCharacterCore back to Read; Do not overwrite predicted ... CharacterCore with Snap Data	2022-07-08 21:47:51 +02:00
Jupeyy	c6589f3a5e	(A bit) safer interface for text containers	2022-07-08 19:19:37 +02:00
Chairn	a69dc599a9	Huge variable naming format ... Fix pointer and pointer array variable naming Huge renaming to match our rules Used regex: (?!(return|delete)\b)\b\w+ (m_|ms_|g_|gs_|s_)[^a]\w+\[ (?!(return|delete)\b)\b\w+ (?!(m_|ms_|g_|gs_|s_))[^a]\w+\[ Further format static variables Format almost all pointer names accordingly Used regex: (?!(return)\b)\b\w+ \*(?!(m_p|p|s_p|m_ap|s_ap|g_p|g_ap|ap|gs_ap|ms_ap|gs_p|ms_p))\w+\b[^:\(p] clang-format Fix CI fail Fix misnamed non pointer as pointer and non array as array Used regex: (?!(return|delete)\b)\b\w+ (m_|ms_|g_|gs_|s_)p\w+\b (?!return\b)\b\w+ (ms_|m_|g_|gs_|s_)a\w+\b[^\[] clang-format Revert to SCREAMING_SNAKE_CASE and reinstate dead code	2022-07-08 18:01:29 +02:00
Robert Müller	85c78a9149	Use for-each loop in CHud::ResetHudContainers to reduce duplicate code	2022-07-08 16:53:35 +02:00
bors[bot]	66ab84a5fa	Merge #5544 ... 5544: Replaced float array with appropriate struct (vec or color) r=def- a=Chairn I mostly touched the code in the graphic part for array of 2 floats into vec2. For color, i replaced array of 4 floats with ColorRGBA where it made sense. I had to change the logic order in `src/engine/client/graphics_threaded.cpp:1113` due to operator= from vec2 to vec3. I didn't see any visual change. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Chairn <chairn.nq@hotmail.fr>	2022-07-07 12:30:29 +00:00
bors[bot]	e9eeb24c17	Merge #5345 #5519 #5572 ... 5345: Add Integration test to pr template r=heinrich5991 a=def- 5519: Library updates (2022-06-27) r=heinrich5991 a=def- Should probably wait until after 16.2 release with them. Vulkan 1.3.204.1 -> 1.3.216.0 curl 7.81.0 -> 7.84.0 FFmpeg 5.0 -> 5.0.1 freetype 2.11.1 -> 2.12.1 SQLite3 3.37.2 -> 3.39.0 <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5572: Also make gameclient aware that snapshots have been purged (fixes #5571) r=heinrich5991 a=def- Recreates SnapEntities internally <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de> Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-07-07 10:41:22 +00:00
bors[bot]	a591fea1b2	Merge #5550 ... 5550: Time checkpoints changes r=def- a=C0D3D3V Fixes #5348 The checkpoint mechanic was last time updated here af44a79b03 and CNetMsg_Sv_DDRaceTime was introduced here: 86365bedcd The whole design of `CNetMsg_Sv_DDRaceTime` is basically pretty bad, and it was only tired to copy the old broadcast behaviour (that we still have for vanilla client). We are basically only sending floats (multiplied by 100) instead of using our integer ticks. Thats also the reason why checkpoints, close to the start (closer than one second), were not displayed (because it was forgotten to multiply m_time by 100 and so it was rounded to 0). This PR adds a workaround for the problems, but this Net message is just designed wrong and should maybe in the future get updated to use ticks instead of rounded floats. This PR allows to trigger Time Checkpoints in arbitrary order. This PR does not make checkpoints unskippable, because we currently have no way to do this, and we have no effect tile that is not skippable (except probably solid blocks). ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-07-06 15:49:59 +00:00
c0d3d3v	e6f1ef90de	send correct time diff on finish ... send record when player joins or changes name minor cleanup	2022-07-06 17:43:20 +02:00
Dennis Felsing	ef9299c88d	Also make gameclient aware that snapshots have been purged (fixes #5571) ... Recreates SnapEntities internally	2022-07-06 15:42:05 +02:00
c0d3d3v	ae80287c1b	Update checkpoint diff display to use time format with hours:minutes:centisecs ... Add time diff to finish display. Increase time the finish time display is displayed to 6 sec. Allow to trigger time checkpoints out of order	2022-07-06 15:14:29 +02:00
Chairn	32318a7c90	Reworked color system ... Removed duplicate structs. Replaced 4 floats array with appropriate struct where applicable	2022-07-06 11:39:51 +02:00
Chairn	27da8391dc	Replace 2 floats array with vec2 where it makes sense	2022-07-06 11:39:43 +02:00
Jupeyy	edc79e48cc	Fix skindownload by only allowing move assignments	2022-07-04 18:24:34 +02:00
c0d3d3v	a961151b32	Show also +0.00 split, and checkpoints close to start (<1sec)	2022-07-03 13:31:54 +02:00
c0d3d3v	f5519d1d88	Fix HUD on server we think that they are DDRace, but they are not	2022-07-01 13:13:06 +02:00
c0d3d3v	0bfb854a0e	Rename TILE_CHECKPOINT_XXX to TILE_TIME_CHECKPOINT_XXX	2022-06-30 23:41:40 +02:00
Robert Müller	d9b0304adb	Use sizeof instead of constant	2022-06-30 19:46:33 +02:00
Robert Müller	d5594d8bd6	Fix variable name EntitesAreMasked -> EntitiesAreMasked	2022-06-30 19:45:10 +02:00
Robert Müller	3c7847a8d9	Fix variable name WasUnknwon -> WasUnknown	2022-06-30 19:44:29 +02:00
luk	1c340daeaa	fix typo and comment	2022-06-30 17:04:29 +02:00
bors[bot]	5e7ec64292	Merge #5486 ... 5486: Switch to loading screen, when map creation takes too long r=def- a=Jupeyy Same as #4941 It doesn't directly fix the issue described in #5478, it does however not trigger it anymore. it's still a bug in our code unrelated to this. This just triggered the UB from the issue as `@ardadem` confirmed, SDL received a SDL_QUIT (`[2022-06-23 20:26:31][test]: sdl closed my client, but why xd`) Now we have a confirmed case that making the window unresponsive can create weird behavior. Similar to the other pr switch to a loading screen after 500ms (this time without menu background map tho, since the menu background map calls the same code). We really need some fancy loading screen for such situations, even tho they are rare xD ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-06-30 14:36:58 +00:00
bors[bot]	5e0eada302	Merge #5517 ... 5517: Add APPEARANCE Settings page r=def- a=C0D3D3V This could potentially also be added to 16.2 I also renamed `cl_ddrace_hud` to `cl_showhud_ddrace` and ` cl_show_jumps_indicator` to `cl_showhud_jumps_indicator` I guess that fits better the pattern of the other configs.     ### for the following 3 tabs there is now room to add a preview in future     I changed some of the texts ... so please look at them carefully ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-06-30 13:03:17 +00:00
c0d3d3v	cee071e3f1	The appearance settings page has been revised to look more like the general and DDNet settings page	2022-06-30 14:17:07 +02:00
bors[bot]	2bd1273657	Merge #5514 ... 5514: Update menu music state when the config variables change via console, various refactoring r=heinrich5991 a=Robyt3 Also update the background music when `snd_enable` or `snd_enable_music` change via console or bind. Closes #2911. For this purpose, add `IsPlaying` method to engine sound and client sound component to check whether a specific sound sample is already playing. Various refactoring in engine sound. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-06-30 11:07:07 +00:00
Chairn	96e9364fb0	Fix more unsafe define	2022-06-29 23:52:03 +02:00
c0d3d3v	a26285c052	Add cl_nameplates_strong to settings page	2022-06-29 16:28:27 +02:00
c0d3d3v	281c766117	Add APPEARANCE Settings page	2022-06-29 16:28:19 +02:00
bors[bot]	1743b7ce67	Merge #5210 ... 5210: Move ddnet character display info in ddnet character r=def- a=C0D3D3V - I also added the default value mechanic for Net Objects that have set `validate_size=False` - I removed the ramp value from the snap, because currently all maps use the default tuning parameters for it - I renamed `m_FreezeTick` to `m_FreezeStart` - Added Extended Net Objects to the debug HUD (Also added a Headline):  (out of range) is in the screenshot the old DDNetCharacterDisplayInfo fixes #5455 ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-06-29 11:35:37 +00:00
c0d3d3v	59436b5e6d	Add default values to extended Net Objects	2022-06-27 01:11:19 +02:00
c0d3d3v	07cfda5593	remove rampvalue from ddnetcharacter	2022-06-27 01:10:37 +02:00
c0d3d3v	df52df9d4a	move DDNetCharacterDisplayInfo to DDNetCharacter ... - add default value option to NetworkValues - rename m_FreezeTick to m_FreezeStart	2022-06-27 01:10:25 +02:00
def	4733cdc769	Abort skin downloads too (fixes #5505)	2022-06-27 00:39:00 +02:00
Robert Müller	9390ae99b2	Fix OOB access when stopping a sound that has invalid samples	2022-06-26 22:43:32 +02:00
Robert Müller	9932bd76fb	Update menu music state when the config variables change via console	2022-06-26 22:43:32 +02:00
Robert Müller	525527feb7	Add IsPlaying to sounds client component	2022-06-26 22:43:32 +02:00
Robert Müller	8eb1f6888d	Refactoring: use CGameWorld::Clear in CGameWorld::CopyWorld	2022-06-26 12:51:17 +02:00
Jupeyy	b62894dad4	Switch to loading screen, when map creation takes too long	2022-06-26 11:56:56 +02:00
Robert Müller	2df4c4c668	Fix heap-use-after-free in CGameWorld::RemoveEntity ... Entities have a pointer to their parent entity. If the parent entity is freed first, then freeing the child will cause access to the already freed parent. This is fixed by adding a child pointer and clearing the child and parent pointers when either child or parent is freed.	2022-06-26 11:28:23 +02:00
bors[bot]	1e31db257f	Merge #5420 ... 5420: Improvments for new HUD r=def- a=C0D3D3V for testing set `#define CLIENT_VERSIONNR 16020` Some of the changes are only available in the next version Impressions: https://youtu.be/E770vGp4KKY Implements a few of the recommendations from https://github.com/ddnet/ddnet/issues/5159 and Discord - removes all player capability messages send by the server, that are now displayed in the HUD - ~~remove `cl_ddrace_hud` and cl_show_freeze_bars~~, - Added option `cl_freezebars_alpha_inside_freeze` setting to change the opacity if the player is inside a freeze tile (default visible 100%) - Added option `cl_show_jumps_indicator` - We send now the real weapon the player is holding if he is frozen -> for that we added a new particle "snow flakes" or frozen flakes :D that are spawned over the tees body, to indicate he is frozen. -> new extras.png asset (+ corresponding asset tab, that can potentially be used for all sorts of extras for our mod, e.g. material particles, but in the future maybe also for other mods using a similar structure like it is for entities) - stars are no longer send to new clients, because it is duplication to the freezebar, and we decided to not allow to disable it - also ninja stars are no longer send. They are not vanilla, and we now have a ninja bar in the new HUD. - display target angle from 0 to 360 (looks mirrored on the x-axis to the normal trigonometry circle, but that is just how the world coordinates are) - dummy action display is increased in size ( but only the border margin :D not the icons. so the icons are still the same size as the icons on the left side) - allow the server to also show old HUD elements (see https://github.com/ddnet/ddnet/pull/5427 for screenshots) fixes #5149 fixes #198 closes #5159 fixes #2252 ~~(But not clear if we should also display the weapon, still investigating)~~ - we do no longer display a weapon inside freeze, instead we have nice freeze particles ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-06-26 07:57:33 +00:00
Robert Müller	fb91881765	Move CMenus::DoIcon to CRenderTools::RenderIcon ... As this method only renders and doesn't provide an interactive element, the naming `Render` as well as the placement in `CRenderTools` fits better. This also allows the method to be used in the editor.	2022-06-25 17:15:55 +02:00
Robert Müller	25ad47bed2	Use DoIcon for ingame player GUI icons	2022-06-25 16:57:25 +02:00
Robert Müller	87cb948166	Clamp number of demo timeline markers to valid range	2022-06-25 16:57:25 +02:00
Robert Müller	5184cf5523	Add greyed out demo icon for invalid or not loaded demos	2022-06-25 16:57:24 +02:00
Robert Müller	f727199060	Render demo file icon in name column, remove DoIcon centering	2022-06-25 16:36:09 +02:00
c0d3d3v	4281df2429	Add new textures by ravie; Also add no gun hit for teleport gun	2022-06-25 16:05:38 +02:00
Robert Müller	97e36fa4be	Add optional color parameter to DoIcon	2022-06-25 13:43:40 +02:00
Robert Müller	a530ce89d6	Rename DoButton_Icon to DoIcon and remove unused return value ... As the function renders an icon and not a button.	2022-06-25 13:38:04 +02:00
c0d3d3v	dd1cdfcf2c	Add to some of the Sprite Arrays the array prefix	2022-06-25 10:39:39 +02:00
Dennis Felsing	83267ed0a7	Update src/game/client/components/console.cpp ... Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-06-25 01:19:40 +02:00
Dennis Felsing	5dd2e5083b	Update src/game/client/components/console.cpp ... Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-06-25 01:19:32 +02:00
Dennis Felsing	8933ae8357	Try to fix dump_local_console (fixes #5488) ... Untested, but my hunch is that by not cutting off the last part the text file will be correctly recognized as valid utf8	2022-06-24 16:47:23 +02:00
Robert Müller	81e24ce8e8	Only enable UI editbox hotkeys when UI is enabled ... Fixes hotkeys triggering console input and UI editbox input at the same time when the console is open and a UI editbox is selected.	2022-06-21 17:19:03 +02:00
Robert Müller	2add5d5c3c	Organize game-client and editor includes	2022-06-17 20:32:56 +02:00
Robert Müller	4949645663	Organize game-shared includes	2022-06-17 17:39:25 +02:00
Robert Müller	0a4b1b9a7b	Organize generated protocol includes	2022-06-17 17:39:24 +02:00
effyn	6691d71da7	Gender-neutral language	2022-06-16 15:12:25 -07:00
Lukas Kitsche	379d93ae7b	no goals hud when empty	2022-06-16 16:28:50 +02:00
c0d3d3v	781f2e7b57	add cl_show_jumps_indicator option	2022-06-15 22:05:44 +02:00
c0d3d3v	f28b71d5cc	allow the server to also show old HUD elements (by @fokkonaut)	2022-06-15 22:05:43 +02:00
c0d3d3v	977d7d952c	Increase the size of dummy actions	2022-06-15 22:05:43 +02:00
c0d3d3v	6e8efa9204	Use 0 to 260 degree in Angle display, and do not display decimals of speed in debughd	2022-06-15 22:05:43 +02:00
c0d3d3v	44478b13ba	Add Opacity option for freeze bars inside freeze	2022-06-15 22:05:43 +02:00
c0d3d3v	51133dee2e	Add freezing snow flakes effect and fix 50HZ timer + add 10Hz Timer to particle system	2022-06-15 22:05:40 +02:00
c0d3d3v	2475e844e0	Add extras texture + asset tab	2022-06-15 22:03:52 +02:00
c0d3d3v	5cd0cc6040	send the weapon the player is really holding (except for ninjajetpack) ... and render ninja skin in client if player is frozen Do stll change the emote if a player with normal emote is freezed	2022-06-15 22:01:46 +02:00
c0d3d3v	bba5027cea	show freezebar also inside freeze	2022-06-15 22:01:45 +02:00
Chairn	c9345e7d32	More vector naming format	2022-06-15 19:37:37 +02:00
Dennis Felsing	34d3ddd9c2	Rename joystick to controller (settings, configs) (fixes #5419) ... Also added one Localize	2022-06-15 13:05:14 +02:00
bors[bot]	9bac36f87c	Merge #5415 ... 5415: Also set mouse settings to defaults r=def- a=Robyt3 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-06-14 22:15:37 +00:00
Robert Müller	518bed35ab	Also set mouse settings to defaults	2022-06-14 23:41:21 +02:00
Robert Müller	1a04efe180	Use DoScrollbarOption for mouse sens., name settings consistently	2022-06-14 23:27:42 +02:00
bors[bot]	89e0450359	Merge #5374 ... 5374: Joystick support 🕹️ r=def- a=Robyt3 Port all the joystick support from vanilla: - Joystick controls - support for up to 12 axis (we are using the low level SDL interface so we don't differentiate between X/Y axis, sliders etc.) - two axis can be used for X and Y cursor movement - cursor input ingame can be relative or absolute - support for binding up to 12 joystick buttons - support for binding up to 2 hats (each has 8 directions) - support for binding axis movement to controls (so you can move with one control stick and aim with the other) - multiple joysticks can be connected at the same time, but only one can be actively used, the selected joystick will be remembered based on a GUID - Joystick UI integration - allow moving the UI cursor with the specified joystick axis - change `CComponent::OnMouseMove` to `OnCursorMove` to handle joystick separately with its own sensitivity settings - remove premultiplied mousesens everywhere - Joystick settings menu (also: separate mouse and movement settings)    Other changes: - Remove the old unused joystick implementation (with config variable `inp_joystick`). - Remove an unused parameter. - Add `CUIEx::DoScrollbarOption` and `IScrollbarScale` - renders label, current value and scrollbar - with linear and logarithmic scale implementations - used for the sensitivity and tolerance settings - could eventually be used for most scrollbar settings to reduce duplicate code - has flags for: - `SCROLLBAR_OPTION_INFINITE`: The scrollbar can be moved all the way to the right for another value that represents ∞. Internally this value is 0. - `SCROLLBAR_OPTION_NOCLAMPVALUE`: The scrollbar allows values outside the specified min/max range, e.g. the sensitivity settings can technically be as high as 100000 when set with the console. - Add `CUIEx::DoScrollbarOptionLabeled` - a `DoScrollbarOption` for selecting from a finite number of options with a scrollbar - used for switching between relative and absolute input - might see more use in the future Reference: https://github.com/teeworlds/teeworlds/pulls?q=is%3Apr+joystick ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [X] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-06-14 18:01:11 +00:00
bors[bot]	caf889d04a	Merge #5406 ... 5406: Remove namespace tw r=Jupeyy a=heinrich5991 It didn't have a clear role, it just acted as a distinguisher between two functions with the same name. Rename `tw::time_get` to `time_get_nanoseconds` and delete the old `time_get_nanoseconds`. Move `CCmdlineFix` and the typed `net_socket_read_wait` function to the global namespace. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com>	2022-06-14 17:46:17 +00:00
Robert Müller	ac543deabd	Remove cl_nameplates_ha and cl_nameplates_ha_size	2022-06-13 22:05:36 +02:00
Robert Müller	e72e276e35	Allow out of range (joystick sens.) values with DoScrollbarOption	2022-06-13 20:41:49 +02:00
Robert Müller	58e1e3981c	Add joystick settings to menu, split mouse and movement settings	2022-06-13 20:41:19 +02:00
Robert Müller	8f5dc3fa01	Add CUIEx::DoScrollbarOptionLabeled	2022-06-13 20:41:19 +02:00
Robert Müller	08edc457aa	Add CUIEx::DoScrollbarOption and IScrollbarScale	2022-06-13 20:41:17 +02:00
Robert Müller	0cbd2ab4df	Remove unused DoSettingsControlsButtons parameter ScopeView	2022-06-13 20:40:37 +02:00
Robert Müller	55d48db711	Integrate joystick with game controls and menus/editor UI	2022-06-13 20:40:37 +02:00
Robert Müller	de76fbfb6a	Remove existing joystick implementation	2022-06-13 20:40:36 +02:00
ChillerDragon	3667061b68	Use nullptr in generated and editor ... -Wzero-as-null-pointer-constant	2022-06-13 18:28:13 +02:00
heinrich5991	b3a3604c36	Remove namespace tw ... It didn't have a clear role, it just acted as a distinguisher between two functions with the same name. Rename `tw::time_get` to `time_get_nanoseconds` and delete the old `time_get_nanoseconds`. Move `CCmdlineFix` and the typed `net_socket_read_wait` function to the global namespace.	2022-06-13 18:07:29 +02:00
bors[bot]	5a7fa108a6	Merge #5393 ... 5393: Remove `ui_scale`: r=def- a=Robyt3 - remove config variable `ui_scale` - remove `CUI::Scale` - remove `CUI::SetScale` - remove `CUI::DoLabelScaled` - remove `CUIRect::Scale` - use `CUI::DoLabel` instead of `CUI::DoLabelScaled` - remove usages of `CUI::Scale()` and `CUIRect::Scale()`, or use 1.0f instead Closes #5062. Closes #5358. Closes #5390. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-06-13 13:02:21 +00:00
Jupeyy	2710fe85be	Add community skin option to client	2022-06-12 18:21:29 +02:00
Robert Müller	ffff4435c4	Remove ui_scale: ... - remove config variable `ui_scale` - remove `CUI::Scale` - remove `CUI::SetScale` - remove `CUI::DoLabelScaled` - remove `CUIRect::Scale` - use `CUI::DoLabel` instead of `CUI::DoLabelScaled` - remove usages of `CUI::Scale()` and `CUIRect::Scale()`, or use 1.0f instead	2022-06-12 10:40:19 +02:00
Chairn	14f7f2e041	Remaining formatting and fix github code scanning	2022-06-11 22:03:23 +02:00
Chairn	01edaec628	Format vector variables names (fixes #5209)	2022-06-11 21:38:49 +02:00
c0d3d3v	24e1fa9a73	change m_ZeroEnergyBounceInLastTick to bool	2022-06-10 17:46:32 +02:00
c0d3d3v	c579e2637f	let lasers bounce with zero energy for one tick	2022-06-10 15:16:41 +02:00
Robert Müller	9a17617a28	Let IInput::MouseRelative return true if mouse was moved	2022-06-06 22:06:56 +02:00
bors[bot]	b554039740	Merge #5320 ... 5320: Fix prediction input timing r=def- a=trml Fixes #5307 by updating the prediction to use the new input handling from #5032, and also removed some now no longer used code. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: trml <trml@users.noreply.github.com>	2022-06-04 22:37:03 +00:00
bors[bot]	36d0c0dcb4	Merge #5334 ... 5334: fix pixel porridge in freeze and ninja bar r=Jupeyy a=C0D3D3V fixes #5319 ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-06-03 16:31:26 +00:00
c0d3d3v	c33e0c124e	fix pixel porridge in freeze and ninja bar	2022-06-03 18:27:30 +02:00
bors[bot]	537be53fc2	Merge #5329 ... 5329: Let the names in the mini score hud overflow to the left r=def- a=C0D3D3V ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-06-03 12:48:50 +00:00
c0d3d3v	090ae5e170	Let the names in the mini score hud overflow to the left	2022-06-03 13:57:39 +02:00
trml	455b17e957	Update prediction to use new input handling	2022-06-02 22:35:10 +02:00
bors[bot]	c31d3e5fde	Merge #5301 ... 5301: Avoid unnecessary copy leading to crash r=C0D3D3V a=Learath2 <!-- What is the motivation for the changes of this pull request --> Reported by kiwq#4737 on Discord. This issue was revealed by the addition of a `std::set` into `CCharacterCore`, I'm unsure why the copy constructor of `std::set` didn't work. It might be a good idea to check and see if there is a further underlying issue `@C0D3D3V.` <details> <summary>Backtrace</summary> ```c++ #0 __gnu_cxx::new_allocator<std::_Rb_tree_node<int> >::construct<int, int const&> (this=0x7fffffff95e8, __p=0x555558935fd0) at /usr/include/c++/10.2/ext/new_allocator.h:150 No locals. #1 0x0000555555831100 in std::allocator_traits<std::allocator<std::_Rb_tree_node<int> > >::construct<int, int const&> (__a=..., __p=0x555558935fd0) at /usr/include/c++/10.2/bits/alloc_traits.h:512 No locals. #2 0x00005555558306b7 in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_construct_node<int const&> (this=0x7fffffff95e8, __node=0x555558935fb0) at /usr/include/c++/10.2/bits/stl_tree.h:618 No locals. #3 0x0000555555830727 in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_create_node<int const&> (this=0x7fffffff95e8) at /usr/include/c++/10.2/bits/stl_tree.h:635 __tmp = 0x555558935fb0 #4 0x000055555583055c in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_Alloc_node::operator()<int const&> (this=0x7fffffff92d0, __arg=<error reading variable>) at /usr/include/c++/10.2/bits/stl_tree.h:552 No locals. #5 0x000055555582fcd1 in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_clone_node<std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_Alloc_node> (this=0x7fffffff95e8, __x=0xffffffc100000000, __node_gen=...) at /usr/include/c++/10.2/bits/stl_tree.h:662 __tmp = 0x7fffeb7a3a10 #6 0x000055555582f188 in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_Alloc_node> (this=0x7fffffff95e8, __x=0xffffffc100000000, __p=0x7fffffff95f0, __node_gen=...) at /usr/include/c++/10.2/bits/stl_tree.h:1881 __top = 0x7fffeb7a3a10 #7 0x000055555582e294 in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy<std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_Alloc_node> (this=0x7fffffff95e8, __x=..., __gen=...) at /usr/include/c++/10.2/bits/stl_tree.h:897 __root = 0x7fffffff95e8 #8 0x000055555582d41d in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_M_copy (this=0x7fffffff95e8, __x=...) at /usr/include/c++/10.2/bits/stl_tree.h:908 __an = {_M_t = `@0x7fffffff95e8}` #9 0x000055555582c1f2 in std::_Rb_tree<int, int, std::_Identity<int>, std::less<int>, std::allocator<int> >::_Rb_tree (this=0x7fffffff95e8, __x=...) at /usr/include/c++/10.2/bits/stl_tree.h:946 No locals. #10 0x0000555555828912 in std::set<int, std::less<int>, std::allocator<int> >::set (this=0x7fffffff95e8) at /usr/include/c++/10.2/bits/stl_set.h:223 No locals. #11 0x0000555555828a4b in CCharacterCore::CCharacterCore (this=0x7fffffff9598) at /home/ant/ddnet/src/game/gamecore.h:203 No locals. #12 0x000055555582b426 in CGameClient::CClientData::CClientData (this=0x7fffffff9500) at /home/ant/ddnet/src/game/client/gameclient.h:338 No locals. #13 0x000055555581b3f1 in CGameClient::IntersectCharacter (this=0x7fffeb496010, HookPos=..., NewPos=..., NewPos2=..., ownID=-2) at /home/ant/ddnet/src/game/client/gameclient.cpp:2195 Distance = 0 ClosestID = -1 OwnClientData = {m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0, m_aName = '\000' <repeats 15 times>, m_aClan = '\000' <repeats 11 times>, m_Country = 0, m_aSkinName = '\000' <repeats 63 times>, m_SkinColor = 1156586, m_Team = 2324, m_Emoticon = 5316, m_EmoticonStartFraction = 1.19110369e-42, m_EmoticonStartTick = -672, m_Solo = 126, m_Jetpack = 4, m_NoCollision = false, m_EndlessHook = false, m_EndlessJump = false, m_NoHammerHit = false, m_NoGrenadeHit = false, m_NoLaserHit = false, m_NoShotgunHit = false, m_NoHookHit = false, m_Super = false, m_HasTelegunGun = false, m_HasTelegunGrenade = 255, m_HasTelegunLaser = 255, m_FreezeEnd = 0, m_DeepFrozen = false, m_LiveFrozen = false, m_Predicted = {m_pWorld = 0x14c700000911, m_pCollision = 0xffffff02ffffffe0, m_pTeleOuts = 0x1, m_Pos = {{x = 0, u = 0}, {y = 0, v = 0}}, m_Vel = {{x = 0, u = 0}, {y = 1.40129846e-45, v = 1.40129846e-45}}, m_HookPos = {{x = 1.62071238e-39, u = 1.62071238e-39}, {y = 6.88766221e-41, v = 6.88766221e-41}}, m_HookDir = {{x = 0, u = 0}, {y = 2.80259693e-45, v = 2.80259693e-45}}, m_HookTeleBase = {{x = 0, u = 0}, {y = 6.44597294e-44, v = 6.44597294e-44}}, m_HookTick = 1, m_HookState = 0, m_HookedPlayer = 0, m_AttachedPlayers = {_M_t = { _M_impl = {<std::allocator<std::_Rb_tree_node<int> >> = {<__gnu_cxx::new_allocator<std::_Rb_tree_node<int> >> = {<No data fields>}, <No data fields>}, <std::_Rb_tree_key_compare<std::less<int> >> = {_M_key_compare = {<std::binary_function<int, int, bool>> = {<No data fields>}, <No data fields>}}, <std::_Rb_tree_header> = {_M_header = {_M_color = std::_S_red, _M_parent = 0x0, _M_left = 0x7fffffff95f0, _M_right = 0x7fffffff95f0}, _M_node_count = 0}, <No data fields>}}}, m_ActiveWeapon = 0, m_aWeapons = {{ m_AmmoRegenStart = 0, m_Ammo = -1, m_Ammocost = 0, m_Got = 23}, {m_AmmoRegenStart = 1479, m_Ammo = 2865, m_Ammocost = -253, m_Got = 218}, {m_AmmoRegenStart = 1, m_Ammo = 0, m_Ammocost = 0, m_Got = false}, {m_AmmoRegenStart = 5, m_Ammo = 0, m_Ammocost = 0, m_Got = false}, {m_AmmoRegenStart = 0, m_Ammo = 1, m_Ammocost = 12918599, m_Got = 255}, { m_AmmoRegenStart = 1702519144, m_Ammo = 84, m_Ammocost = 0, m_Got = false}}, m_Ninja = {m_ActivationDir = {{x = 0, u = 0}, {y = 0, v = 0}}, m_ActivationTick = 0, m_CurrentMoveTime = -1, m_OldVelAmount = 1935961199}, m_NewHook = 99, m_Jumped = 108, m_JumpedTotal = 0, m_Jumps = 0, m_Direction = 0, m_Angle = 0, m_Input = {m_Direction = 0, m_TargetX = 0, m_TargetY = 0, m_Jump = 0, m_Fire = 0, m_Hook = 0, m_PlayerFlags = 0, m_WantedWeapon = 0, m_NextWeapon = 0, m_PrevWeapon = 0}, m_TriggeredEvents = 0, m_Id = 0, m_pReset = false, m_LastVel = {{x = -nan(0x7fffff), u = -nan(0x7fffff)}, {y = 0, v = 0}}, m_Colliding = 0, m_LeftWall = false, m_Solo = false, m_Jetpack = false, m_NoCollision = false, m_EndlessHook = false, m_EndlessJump = false, m_NoHammerHit = false, m_NoGrenadeHit = false, m_NoLaserHit = 103, m_NoShotgunHit = 166, m_NoHookHit = 17, m_Super = false, m_HasTelegunGun = false, m_HasTelegunGrenade = false, m_HasTelegunLaser = false, m_FreezeTick = -343988384, m_FreezeEnd = 32767, m_IsInFreeze = 96, m_DeepFrozen = 10, m_LiveFrozen = 122, m_Tuning = {static ms_apNames = {0x5555559e9dec "ground_control_speed", 0x5555559e9e01 "ground_control_accel", 0x5555559e9e16 "ground_friction", 0x5555559e9e26 "ground_jump_impulse", 0x5555559e9e3a "air_jump_impulse", 0x5555559e9e4b "air_control_speed", 0x5555559e9e5d "air_control_accel", 0x5555559e9e6f "air_friction", 0x5555559e9e7c "hook_length", 0x5555559e9e88 "hook_fire_speed", 0x5555559e9e98 "hook_drag_accel", 0x5555559e9ea8 "hook_drag_speed", 0x5555559e9eb8 "gravity", 0x5555559e9ec0 "velramp_start", 0x5555559e9ece "velramp_range", 0x5555559e9edc "velramp_curvature", 0x5555559e9eee "gun_curvature", 0x5555559e9efc "gun_speed", 0x5555559e9f06 "gun_lifetime", 0x5555559e9f13 "shotgun_curvature", 0x5555559e9f25 "shotgun_speed", 0x5555559e9f33 "shotgun_speeddiff", 0x5555559e9f45 "shotgun_lifetime", 0x5555559e9f56 "grenade_curvature", 0x5555559e9f68 "grenade_speed", 0x5555559e9f76 "grenade_lifetime", 0x5555559e9f87 "laser_reach", 0x5555559e9f93 "laser_bounce_delay", 0x5555559e9fa6 "laser_bounce_num", 0x5555559e9fb7 "laser_bounce_cost", 0x5555559e9fc9 "laser_damage", 0x5555559e9fd6 "player_collision", 0x5555559e9fe7 "player_hooking", 0x5555559e9ff6 "jetpack_strength", 0x5555559ea007 "shotgun_strength", 0x5555559ea018 "explosion_strength", 0x5555559ea02b "hammer_strength", 0x5555559ea03b "hook_duration", 0x5555559ea049 "hammer_fire_delay", 0x5555559ea05b "gun_fire_delay", 0x5555559ea06a "shotgun_fire_delay", 0x5555559ea07d "grenade_fire_delay", 0x5555559ea090 "laser_fire_delay", 0x5555559ea0a1 "ninja_fire_delay", 0x5555559ea0b2 "hammer_hit_fire_delay"}, m_GroundControlSpeed = {m_Value = 32767}, m_GroundControlAccel = {m_Value = 0}, m_GroundFriction = {m_Value = 0}, m_GroundJumpImpulse = {m_Value = 1151303680}, m_AirJumpImpulse = {m_Value = 1160581120}, m_AirControlSpeed = {m_Value = -1149239296}, m_AirControlAccel = {m_Value = 0}, m_AirFriction = {m_Value = 1151303680}, m_HookLength = {m_Value = 1160581120}, m_HookFireSpeed = {m_Value = -1082130432}, m_HookDragAccel = {m_Value = -1130364928}, m_HookDragSpeed = {m_Value = 0}, m_Gravity = {m_Value = 0}, m_VelrampStart = {m_Value = 19}, m_VelrampRange = {m_Value = 0}, m_VelrampCurvature = {m_Value = -1}, m_GunCurvature = {m_Value = 0}, m_GunSpeed = {m_Value = 0}, m_GunLifetime = {m_Value = 0}, m_ShotgunCurvature = {m_Value = 0}, m_ShotgunSpeed = {m_Value = 0}, m_ShotgunSpeeddiff = {m_Value = 0}, m_ShotgunLifetime = {m_Value = 0}, m_GrenadeCurvature = {m_Value = -26800}, m_GrenadeSpeed = {m_Value = 32767}, m_GrenadeLifetime = {m_Value = -26800}, m_LaserReach = {m_Value = 32767}, m_LaserBounceDelay = {m_Value = 0}, m_LaserBounceNum = {m_Value = 0}, m_LaserBounceCost = {m_Value = 0}, m_LaserDamage = {m_Value = 0}, m_PlayerCollision = {m_Value = -1}, m_PlayerHooking = {m_Value = 0}, m_JetpackStrength = {m_Value = 1}, m_ShotgunStrength = {m_Value = 0}, m_ExplosionStrength = {m_Value = -1}, m_HammerStrength = {m_Value = 0}, m_HookDuration = {m_Value = 1}, m_HammerFireDelay = {m_Value = 0}, m_GunFireDelay = {m_Value = -1}, m_ShotgunFireDelay = {m_Value = 0}, m_GrenadeFireDelay = {m_Value = 0}, m_LaserFireDelay = {m_Value = 0}, m_NinjaFireDelay = {m_Value = -1}, m_HammerHitFireDelay = {m_Value = 0}}, m_pTeams = 0x0, m_MoveRestrictions = -1}, m_PrevPredicted = {m_pWorld = 0x0, m_pCollision = 0xffffffff, m_pTeleOuts = 0x0, m_Pos = {{x = 0, u = 0}, {y = 0, v = 0}}, m_Vel = {{x = 0, u = 0}, {y = 0, v = 0}}, m_HookPos = {{x = 0, u = 0}, {y = 0, v = 0}}, m_HookDir = {{x = 0, u = 0}, {y = 2.80259693e-45, v = 2.80259693e-45}}, m_HookTeleBase = {{x = 0, u = 0}, {y = 1.52881662e-42, v = 1.52881662e-42}}, m_HookTick = 0, m_HookState = -111, m_HookedPlayer = -230, m_AttachedPlayers = {_M_t = {_M_impl = {<std::allocator<std::_Rb_tree_node<int> >> = {<__gnu_cxx::new_allocator<std::_Rb_tree_node<int> >> = {<No data fields>}, <No data fields>}, <std::_Rb_tree_key_compare<std::less<int> >> = {_M_key_compare = {<std::binary_function<int, int, bool>> = {<No data fields>}, <No data fields>}}, <std::_Rb_tree_header> = {_M_header = {_M_color = std::_S_red, _M_parent = 0x0, _M_left = 0x3b00000000, _M_right = 0xffff9800}, _M_node_count = 0}, <No data fields>}}}, m_ActiveWeapon = 1, m_aWeapons = {{m_AmmoRegenStart = 0, m_Ammo = 0, m_Ammocost = 0, m_Got = 209}, {m_AmmoRegenStart = 1156711, m_Ammo = 1, m_Ammocost = 1000, m_Got = 200}, {m_AmmoRegenStart = 50, m_Ammo = 1320, m_Ammocost = 1200, m_Got = 244}, {m_AmmoRegenStart = 150, m_Ammo = 95, m_Ammocost = 38000, m_Got = 64}, {m_AmmoRegenStart = 300, m_Ammo = 1500, m_Ammocost = 50, m_Got = 216}, {m_AmmoRegenStart = 200000, m_Ammo = 140, m_Ammocost = 0, m_Got = 224}}, m_Ninja = {m_ActivationDir = {{x = 2.80259693e-43, u = 2.80259693e-43}, {y = 0, v = 0}}, m_ActivationTick = 50000, m_CurrentMoveTime = 0, m_OldVelAmount = 20}, m_NewHook = 188, m_Jumped = 100000, m_JumpedTotal = 200, m_Jumps = 80000, m_Direction = 15000, m_Angle = 100000, m_Input = {m_Direction = 0, m_TargetX = 500, m_TargetY = 100, m_Jump = 100, m_Fire = 0, m_Hook = 1000, m_PlayerFlags = 600, m_WantedWeapon = 100, m_NextWeapon = 125, m_PrevWeapon = 12500}, m_TriggeredEvents = 12500, m_Id = 50000, m_pReset = 80, m_LastVel = {{x = 1.12103877e-40, u = 1.12103877e-40}, {y = 1.12103877e-40, v = 1.12103877e-40}}, m_Colliding = 32000, m_LeftWall = 208, m_Solo = 42, m_Jetpack = 127, m_NoCollision = 235, m_EndlessHook = 255, m_EndlessJump = 127, m_NoHammerHit = false, m_NoGrenadeHit = false, m_NoLaserHit = false, m_NoShotgunHit = false, m_NoHookHit = false, m_Super = false, m_HasTelegunGun = false, m_HasTelegunGrenade = false, m_HasTelegunLaser = false, m_FreezeTick = -343988384, m_FreezeEnd = 32767, m_IsInFreeze = 96, m_DeepFrozen = 10, m_LiveFrozen = 122, m_Tuning = {static ms_apNames = {0x5555559e9dec "ground_control_speed", 0x5555559e9e01 "ground_control_accel", 0x5555559e9e16 "ground_friction", 0x5555559e9e26 "ground_jump_impulse", 0x5555559e9e3a "air_jump_impulse", 0x5555559e9e4b "air_control_speed", 0x5555559e9e5d "air_control_accel", 0x5555559e9e6f "air_friction", 0x5555559e9e7c "hook_length", 0x5555559e9e88 "hook_fire_speed", 0x5555559e9e98 "hook_drag_accel", 0x5555559e9ea8 "hook_drag_speed", 0x5555559e9eb8 "gravity", 0x5555559e9ec0 "velramp_start", 0x5555559e9ece "velramp_range", 0x5555559e9edc "velramp_curvature", 0x5555559e9eee "gun_curvature", 0x5555559e9efc "gun_speed", 0x5555559e9f06 "gun_lifetime", 0x5555559e9f13 "shotgun_curvature", 0x5555559e9f25 "shotgun_speed", 0x5555559e9f33 "shotgun_speeddiff", 0x5555559e9f45 "shotgun_lifetime", 0x5555559e9f56 "grenade_curvature", 0x5555559e9f68 "grenade_speed", 0x5555559e9f76 "grenade_lifetime", 0x5555559e9f87 "laser_reach", 0x5555559e9f93 "laser_bounce_delay", 0x5555559e9fa6 "laser_bounce_num", 0x5555559e9fb7 "laser_bounce_cost", 0x5555559e9fc9 "laser_damage", 0x5555559e9fd6 "player_collision", 0x5555559e9fe7 "player_hooking", 0x5555559e9ff6 "jetpack_strength", 0x5555559ea007 "shotgun_strength", 0x5555559ea018 "explosion_strength", 0x5555559ea02b "hammer_strength", 0x5555559ea03b "hook_duration", 0x5555559ea049 "hammer_fire_delay", 0x5555559ea05b "gun_fire_delay", 0x5555559ea06a "shotgun_fire_delay", 0x5555559ea07d "grenade_fire_delay", 0x5555559ea090 "laser_fire_delay", 0x5555559ea0a1 "ninja_fire_delay", 0x5555559ea0b2 "hammer_hit_fire_delay"}, m_GroundControlSpeed = {m_Value = 32767}, m_GroundControlAccel = {m_Value = 0}, m_GroundFriction = {m_Value = 0}, m_GroundJumpImpulse = {m_Value = 1151303680}, m_AirJumpImpulse = {m_Value = 1160581120}, m_AirControlSpeed = {m_Value = -1149239296}, m_AirControlAccel = {m_Value = 0}, m_AirFriction = {m_Value = 1151303680}, m_HookLength = {m_Value = 1160581120}, m_HookFireSpeed = {m_Value = -1082130432}, m_HookDragAccel = {m_Value = -1130364928}, m_HookDragSpeed = {m_Value = 0}, m_Gravity = {m_Value = 0}, m_VelrampStart = {m_Value = 19}, m_VelrampRange = {m_Value = 0}, m_VelrampCurvature = {m_Value = -1}, m_GunCurvature = {m_Value = 0}, m_GunSpeed = {m_Value = 0}, m_GunLifetime = {m_Value = 0}, m_ShotgunCurvature = {m_Value = 0}, m_ShotgunSpeed = {m_Value = 5}, m_ShotgunSpeeddiff = {m_Value = 0}, m_ShotgunLifetime = {m_Value = 0}, m_GrenadeCurvature = {m_Value = -26240}, m_GrenadeSpeed = {m_Value = 32767}, m_GrenadeLifetime = {m_Value = -26240}, m_LaserReach = {m_Value = 32767}, m_LaserBounceDelay = {m_Value = 0}, m_LaserBounceNum = {m_Value = 0}, m_LaserBounceCost = {m_Value = 0}, m_LaserDamage = {m_Value = 0}, m_PlayerCollision = {m_Value = -1}, m_PlayerHooking = {m_Value = 0}, m_JetpackStrength = {m_Value = 1}, m_ShotgunStrength = {m_Value = 0}, m_ExplosionStrength = {m_Value = -1}, m_HammerStrength = {m_Value = 0}, m_HookDuration = {m_Value = 1}, m_HammerFireDelay = {m_Value = 0}, m_GunFireDelay = {m_Value = -1}, m_ShotgunFireDelay = {m_Value = 0}, m_GrenadeFireDelay = {m_Value = 0}, m_LaserFireDelay = {m_Value = 0}, m_NinjaFireDelay = {m_Value = -1}, m_HammerHitFireDelay = {m_Value = 0}}, m_pTeams = 0x0, m_MoveRestrictions = -1}, m_SkinInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = 0}, m_BodyOutline = {m_Id = 0}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = 0}, m_Hands = {m_Id = 0}, m_HandsOutline = {m_Id = 0}, m_Eyes = {{m_Id = 0}, {m_Id = 0}, {m_Id = 0}, {m_Id = 0}, {m_Id = -256}, {m_Id = 0}}}, m_ColorableRenderSkin = {m_Body = {m_Id = 0}, m_BodyOutline = {m_Id = 2}, m_Feet = {m_Id = 0}, m_FeetOutline = {m_Id = 1091}, m_Hands = {m_Id = 0}, m_HandsOutline = {m_Id = -111}, m_Eyes = {{m_Id = -230}, {m_Id = 0}, {m_Id = 0}, {m_Id = 0}, {m_Id = 0}, {m_Id = 0}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = 0}, m_Height = {m_Value = 0}, m_OffsetX = {m_Value = 0}, m_OffsetY = {m_Value = 59}, m_MaxWidth = {m_Value = 0}, m_MaxHeight = {m_Value = 0}}, m_Feet = {m_Width = {m_Value = 0}, m_Height = {m_Value = 0}, m_OffsetX = {m_Value = 1}, m_OffsetY = {m_Value = 0}, m_MaxWidth = {m_Value = 0}, m_MaxHeight = {m_Value = 0}}}, m_CustomColoredSkin = 209, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 1.62089735e-39, r = 1.62089735e-39, h = 1.62089735e-39}, {y = 1.40129846e-45, g = 1.40129846e-45, s = 1.40129846e-45}, {z = 1.40129846e-42, b = 1.40129846e-42, l = 1.40129846e-42, v = 1.40129846e-42}, {w = 2.80259693e-43, a = 2.80259693e-43}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 7.00649232e-44, r = 7.00649232e-44, h = 7.00649232e-44}, {y = 1.84971397e-42, g = 1.84971397e-42, s = 1.84971397e-42}, {z = 1.68155816e-42, b = 1.68155816e-42, l = 1.68155816e-42, v = 1.68155816e-42}, {w = 7.00649232e-43, a = 7.00649232e-43}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 2.1019477e-43, r = 2.1019477e-43, h = 2.1019477e-43}, {y = 1.33123354e-43, g = 1.33123354e-43, s = 1.33123354e-43}, {z = 5.32493416e-41, b = 5.32493416e-41, l = 5.32493416e-41, v = 5.32493416e-41}, {w = 1.12103877e-41, a = 1.12103877e-41}}, <No data fields>}, m_Size = 4.20389539e-43, m_GotAirJump = 1500, m_ShineDecoration = 50}, m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = 55000}, m_BodyOutline = {m_Id = 200000}, m_Feet = {m_Id = 140}, m_FeetOutline = {m_Id = 0}, m_Hands = {m_Id = 140000}, m_HandsOutline = {m_Id = 200}, m_Eyes = {{m_Id = 0}, {m_Id = 50000}, {m_Id = 0}, {m_Id = 20}, {m_Id = 700}, {m_Id = 100000}}}, m_ColorableRenderSkin = {m_Body = {m_Id = 200}, m_BodyOutline = {m_Id = 80000}, m_Feet = {m_Id = 15000}, m_FeetOutline = {m_Id = 100000}, m_Hands = {m_Id = 0}, m_HandsOutline = {m_Id = 500}, m_Eyes = {{m_Id = 100}, {m_Id = 100}, {m_Id = 0}, {m_Id = 1000}, {m_Id = 600}, {m_Id = 100}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = 125}, m_Height = {m_Value = 12500}, m_OffsetX = {m_Value = 12500}, m_OffsetY = {m_Value = 50000}, m_MaxWidth = {m_Value = 50000}, m_MaxHeight = {m_Value = 80000}}, m_Feet = {m_Width = {m_Value = 80000}, m_Height = {m_Value = 32000}, m_OffsetX = {m_Value = -343987504}, m_OffsetY = {m_Value = 32767}, m_MaxWidth = {m_Value = 0}, m_MaxHeight = {m_Value = 384}}}, m_CustomColoredSkin = 102, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 4.09039022e-42, r = 4.09039022e-42, h = 4.09039022e-42}, {y = 4.09179152e-42, g = 4.09179152e-42, s = 4.09179152e-42}, {z = 4.09319281e-42, b = 4.09319281e-42, l = 4.09319281e-42, v = 4.09319281e-42}, {w = 4.09459411e-42, a = 4.09459411e-42}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 4.09599541e-42, r = 4.09599541e-42, h = 4.09599541e-42}, {y = 4.09739671e-42, g = 4.09739671e-42, s = 4.09739671e-42}, {z = 4.09879801e-42, b = 4.09879801e-42, l = 4.09879801e-42, v = 4.09879801e-42}, {w = 4.10019931e-42, a = 4.10019931e-42}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 4.10160061e-42, r = 4.10160061e-42, h = 4.10160061e-42}, {y = 4.1030019e-42, g = 4.1030019e-42, s = 4.1030019e-42}, {z = 4.1044032e-42, b = 4.1044032e-42, l = 4.1044032e-42, v = 4.1044032e-42}, {w = 4.1058045e-42, a = 4.1058045e-42}}, <No data fields>}, m_Size = 4.1072058e-42, m_GotAirJump = 2932, m_ShineDecoration = 2933}, m_Angle = 4.11140969e-42, m_Active = 119, m_ChatIgnore = 11, m_EmoticonIgnore = false, m_Friend = false, m_Foe = 120, m_AuthLevel = 2937, m_Afk = 122, m_Paused = 11, m_Spec = false, m_SwitchStates = {false, 123, 11, false, false, 124, 11, false, false, 125, 11, false, false, 63, false, false, false, 64, false, false, false, 17, false, false, false, 17, false, false, false, 96, false, false, false, 96, false, false, false, 30, false, false, false, 17, false, false, false, 18, false, false, false, 8, false, false, false, 64, false, false, false, 32, false, false, false, true, false, false, false, 77, 169, 64, 63, 248, 26, 24, 63, 81, 89, 145, 62, false, false, 128, 63, 108, 173, 38, 63, 58, 105, 24, 63, 13, 222, 46, 63, false, false, 128, 63, false, false, 128, 63, false, false, 128, 63, false, false, 128, 63, false, false, 128, 63, false, false, 128, 66, true, false, false, false, false, false, false, false, 102, 11, false, false, 103, 11, false, false, 104, 11, false, false, 105, 11, false, false, 106, 11, false, false, 107, 11, false, false, 108, 11, false, false, 109, 11, false, false, 110, 11, false, false, 111, 11, false, false, 112, 11, false, false, 113, 11, false, false, 114, 11, false, false, 115, 11, false, false, 116, 11, false, false, 117, 11, false, false, 118, 11, false, false, 119, 11, false, false, 120, 11, false...}, m_Snapped = {<CNetObj_CharacterCore> = {m_Tick = 8, m_X = 64, m_Y = 32, m_VelX = 1, m_VelY = 1061202253, m_Angle = 1058544376, m_Direction = 1049712977, m_Jumped = 1065353216, m_HookedPlayer = 1059499372, m_HookState = 1058564410, m_HookTick = 1060036109, m_HookX = 1065353216, m_HookY = 1065353216, m_HookDx = 1065353216, m_HookDy = 1065353216}, m_PlayerFlags = 1065353216, m_Health = 1115684864, m_Armor = 1, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 1, m_AttackTick = 1699636480}, m_Evolved = {<CNetObj_CharacterCore> = {m_Tick = 0, m_X = 0, m_Y = 0, m_VelX = 0, m_VelY = 0, m_Angle = 0, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = 0, m_HookState = 0, m_HookTick = 0, m_HookX = 0, m_HookY = 0, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 0}, m_RenderCur = {<CNetObj_CharacterCore> = {m_Tick = 0, m_X = 0, m_Y = 0, m_VelX = 0, m_VelY = 0, m_Angle = 0, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = 0, m_HookState = 0, m_HookTick = 0, m_HookX = 0, m_HookY = 0, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 0}, m_RenderPrev = {<CNetObj_CharacterCore> = {m_Tick = 0, m_X = 0, m_Y = 0, m_VelX = 0, m_VelY = 0, m_Angle = 0, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = 0, m_HookState = 0, m_HookTick = 0, m_HookX = 0, m_HookY = 0, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 0}, m_RenderPos = {{x = 1.62072219e-39, u = 1.62072219e-39}, {y = 1.78805684e-42, v = 1.78805684e-42}}, m_IsPredicted = 209, m_IsPredictedLocal = 10, m_SmoothStart = {4294967295, 1091}, m_SmoothLen = {-4294967296, 81604378624}, m_PredPos = {{{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fff00), u = -nan(0x7fff00)}, {y = -nan(0x7ffffb), v = -nan(0x7ffffb)}}, {{x = 1.40129846e-45, u = 1.40129846e-45}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 7.00649232e-45, u = 7.00649232e-45}, {y = 7.00649232e-45, v = 7.00649232e-45}}, {{x = 1.61979873e-39, u = 1.61979873e-39}, {y = 1.62072219e-39, v = 1.62072219e-39}}, {{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fffff), u = -nan(0x7fffff)}, {y = 0, v = 0}}, {{x = 1.52881662e-42, u = 1.52881662e-42}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = -nan(0x7fffff), v = -nan(0x7fffff)}}, {{x = 0, u = 0}, {y = 2.66246708e-44, v = 2.66246708e-44}}, {{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fff00), u = -nan(0x7fff00)}, {y = -nan(0x7ffffb), v = -nan(0x7ffffb)}}, {{x = 1.40129846e-45, u = 1.40129846e-45}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 7.00649232e-45, u = 7.00649232e-45}, {y = 7.00649232e-45, v = 7.00649232e-45}}, {{x = 1.61979873e-39, u = 1.61979873e-39}, {y = 1.62072219e-39, v = 1.62072219e-39}}, {{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fffff), u = -nan(0x7fffff)}, {y = 0, v = 0}}, {{x = 1.52881662e-42, u = 1.52881662e-42}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = -nan(0x7fffff), v = -nan(0x7fffff)}}, {{x = 0, u = 0}, {y = 2.66246708e-44, v = 2.66246708e-44}}, {{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fff00), u = -nan(0x7fff00)}, {y = -nan(0x7ffffb), v = -nan(0x7ffffb)}}, {{x = 1.40129846e-45, u = 1.40129846e-45}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 7.00649232e-45, u = 7.00649232e-45}, {y = 7.00649232e-45, v = 7.00649232e-45}}, {{x = 1.61979873e-39, u = 1.61979873e-39}, {y = 1.62071938e-39, v = 1.62071938e-39}}, {{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fffff), u = -nan(0x7fffff)}, {y = 0, v = 0}}, {{x = 1.52881662e-42, u = 1.52881662e-42}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = -nan(0x7fffff), v = -nan(0x7fffff)}}, {{x = 0, u = 0}, {y = 2.66246708e-44, v = 2.66246708e-44}}, {{x = 1.78805684e-42, u = 1.78805684e-42}, {y = 3.88019545e-42, v = 3.88019545e-42}}, {{x = -nan(0x7fff00), u = -nan(0x7fff00)}, {y = -nan(0x7ffffb), v = -nan(0x7ffffb)}}, {{x = 1.40129846e-45, u = 1.40129846e-45}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 7.00649232e-45, u = 7.00649232e-45}, {y = 7.00649232e-45, v = 7.00649232e-45}}, {{x = 1.61979873e-39, u = 1.61979873e-39}, {y = 1276, v = 1276}}, {{x = 2769, u = 2769}, {y = 1.40129846e-45, v = 1.40129846e-45}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 0, u = 0}, {y = 0, v = 0}}, {{x = 1276, u = 1276}, {y = 2769, v = 2769}} <repeats 156 times>}, m_PredTick = {1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1151303680, 1160581120, 1156400, 1156401, 1156402, 1156403, 1156404, 1156405, 1156406, 1156407, 1156408, 1156409, 1156410, 1156411, 1156412, 1156413, 1156414, 1156415, 1156416, 1156417, 1156418, 1156419, 1156420, 1156421, 1156422, 1156423, 1156424, 1156425, 1156426, 1156427, 1156428, 1156429, 1156430, 1156431, 1156432, 1156433, 1156434, 1156435, 1156436, 1156437, 1156438, 1156439, 1156440, 1156441, 1156442, 1156443, 1156444, 1156445, 1156446, 1156447, 1156448, 1156449, 1156450, 1156451, 1156452, 1156453, 1156454, 1156455, 1156456, 1156457, 1156458, 1156459, 1156460, 1156461, 1156462, 1156463, 1156464, 1156465, 1156466, 1156467, 1156468, 1156469, 1156470, 1156471, 1156472, 1156473, 1156474, 1156475, 1156476, 1156477, 1156478, 1156479, 1156480, 1156481, 1156482, 1156483, 1156484, 1156485, 1156486, 1156487, 1156488, 1156489, 1156490, 1156491, 1156492, 1156493, 1156494, 1156495, 1156496, 1156497, 1156498, 1156499, 1156500, 1156501, 1156502, 1156503, 1156504, 1156505, 1156506, 1156507, 1156508, 1156509, 1156510, 1156511}, m_SpecCharPresent = 160, m_SpecChar = {{x = 1.62061989e-39, u = 1.62061989e-39}, {y = 1.62062129e-39, v = 1.62062129e-39}}} #14 0x00005555557e981d in CPlayers::RenderHookCollLine (this=0x7fffeb79a748, pPrevChar=0x7fffffffbd00, pPlayerChar=0x7fffffffbca0, ClientID=-2, Intra=0.36924991) at /home/ant/ddnet/src/game/client/components/players.cpp:216 TeleNr = 0 FinishPos = {{x = 1221.93494, u = 1221.93494}, {y = 2458.29639, v = 2458.29639}} NewPos = {{x = 1221.93494, u = 1221.93494}, {y = 2458.29639, v = 2458.29639}} Hit = 0 ExDirection = {{x = -0.154127821, u = -0.154127821}, {y = 0.988050938, v = 0.988050938}} InitPos = {{x = 1240.73853, u = 1240.73853}, {y = 2337.75415, v = 2337.75415}} HookCollColor = {<color4_base<ColorRGBA>> = {{x = 0.996078432, r = 0.996078432, h = 0.996078432}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 1, a = 1}}, <No data fields>} OldPos = {{x = 1234.26514, u = 1234.26514}, {y = 2379.2522, v = 2379.2522}} DoBreak = false AlwaysRenderHookColl = true RenderHookCollPlayer = false RenderHookCollVideo = true Prev = {<CNetObj_CharacterCore> = {m_Tick = 415760, m_X = 1240, m_Y = 2330, m_VelX = 281, m_VelY = 0, m_Angle = 441, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = -1, m_HookState = 0, m_HookTick = 0, m_HookX = 1239, m_HookY = 2321, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 415734} Player = {<CNetObj_CharacterCore> = {m_Tick = 415762, m_X = 1242, m_Y = 2351, m_VelX = 254, m_VelY = 0, m_Angle = 443, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = -1, m_HookState = 0, m_HookTick = 0, m_HookX = 1241, m_HookY = 2340, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 1156559} Local = false OtherTeam = false Alpha = 0.379999995 IntraTick = 0.36924991 Angle = 1.725541 Direction = {{x = -0.154127821, u = -0.154127821}, {y = 0.988050938, v = 0.988050938}} Position = {{x = 1240.73853, u = 1240.73853}, {y = 2337.75415, v = 2337.75415}} #15 0x0000555555731e03 in CGhost::OnRender (this=0x7fffeb79f5b0) at /home/ant/ddnet/src/game/client/components/ghost.cpp:374 CurPos = 54 PrevPos = 53 TickDiff = 2 IntraTick = 0.36924991 RenderInfo = 0x7fffeb79f5d0 GhostTick = 415761 Player = {<CNetObj_CharacterCore> = {m_Tick = 415762, m_X = 1242, m_Y = 2351, m_VelX = 254, m_VelY = 0, m_Angle = 443, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = -1, m_HookState = 0, m_HookTick = 0, m_HookX = 1241, m_HookY = 2340, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 1156559} Prev = {<CNetObj_CharacterCore> = {m_Tick = 415760, m_X = 1240, m_Y = 2330, m_VelX = 281, m_VelY = 0, m_Angle = 441, m_Direction = 0, m_Jumped = 0, m_HookedPlayer = -1, m_HookState = 0, m_HookTick = 0, m_HookX = 1239, m_HookY = 2321, m_HookDx = 0, m_HookDy = 0}, m_PlayerFlags = 0, m_Health = 0, m_Armor = 0, m_AmmoCount = 0, m_Weapon = 0, m_Emote = 0, m_AttackTick = 415734} GhostNinjaRenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = 248, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 4.59163468e-41, r = 4.59163468e-41, h = 4.59163468e-41}, {y = -3.02677571e+26, g = -3.02677571e+26, s = -3.02677571e+26}, {z = 4.59163468e-41, b = 4.59163468e-41, l = 4.59163468e-41, v = 4.59163468e-41}, {w = -3.08316077e+26, a = -3.08316077e+26}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0} Ghost = `@0x7fffeb79f5d0:` {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = 2846}, m_BodyOutline = {m_Id = 2847}, m_Feet = {m_Id = 2848}, m_FeetOutline = {m_Id = 2849}, m_Hands = {m_Id = 2850}, m_HandsOutline = {m_Id = 2851}, m_Eyes = {{m_Id = 2852}, {m_Id = 2853}, {m_Id = 2854}, {m_Id = 2855}, {m_Id = 2856}, {m_Id = 2857}}}, m_ColorableRenderSkin = {m_Body = {m_Id = 2858}, m_BodyOutline = {m_Id = 2859}, m_Feet = {m_Id = 2860}, m_FeetOutline = {m_Id = 2861}, m_Hands = {m_Id = 2862}, m_HandsOutline = {m_Id = 2863}, m_Eyes = {{m_Id = 2864}, {m_Id = 2865}, {m_Id = 2866}, {m_Id = 2867}, {m_Id = 2868}, {m_Id = 2869}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = 67}, m_Height = {m_Value = 69}, m_OffsetX = {m_Value = 15}, m_OffsetY = {m_Value = 12}, m_MaxWidth = {m_Value = 96}, m_MaxHeight = {m_Value = 96}}, m_Feet = {m_Width = {m_Value = 30}, m_Height = {m_Value = 18}, m_OffsetX = {m_Value = 18}, m_OffsetY = {m_Value = 8}, m_MaxWidth = {m_Value = 64}, m_MaxHeight = {m_Value = 32}}}, m_CustomColoredSkin = true, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0.667352855, r = 0.667352855, h = 0.667352855}, {y = 0.470265955, g = 0.470265955, s = 0.470265955}, {z = 0.577485919, b = 0.577485919, l = 0.577485919, v = 0.577485919}, {w = 1, a = 1}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 0.958477497, r = 0.958477497, h = 0.958477497}, {y = 0.570934296, g = 0.570934296, s = 0.570934296}, {z = 0.725951612, b = 0.725951612, l = 0.725951612, v = 0.725951612}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 64, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = -185079314, m_Skin1 = -487591808, m_Skin2 = -2139062144, m_Skin3 = -2139062144, m_Skin4 = -2139062144, m_Skin5 = -2139062272, m_UseCustomColor = 1, m_ColorBody = 15651463, m_ColorFeet = 16777215}, m_Path = {m_ChunkSize = 1500, m_NumItems = 74676, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x555556de4110, _M_finish = 0x555556de42a0, _M_end_of_storage = 0x555556de42a0}, <No data fields>}}, <No data fields>}}, m_StartTick = 415652, m_aPlayer = "Yumiko\000\000\000\000\000\000\000\000\000", m_PlaybackPos = 54} __for_range = `@0x7fffeb79f5d0:` {{m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = 2846}, m_BodyOutline = {m_Id = 2847}, m_Feet = {m_Id = 2848}, m_FeetOutline = {m_Id = 2849}, m_Hands = {m_Id = 2850}, m_HandsOutline = {m_Id = 2851}, m_Eyes = {{m_Id = 2852}, {m_Id = 2853}, {m_Id = 2854}, {m_Id = 2855}, {m_Id = 2856}, {m_Id = 2857}}}, m_ColorableRenderSkin = {m_Body = {m_Id = 2858}, m_BodyOutline = {m_Id = 2859}, m_Feet = {m_Id = 2860}, m_FeetOutline = {m_Id = 2861}, m_Hands = {m_Id = 2862}, m_HandsOutline = {m_Id = 2863}, m_Eyes = {{m_Id = 2864}, {m_Id = 2865}, {m_Id = 2866}, {m_Id = 2867}, {m_Id = 2868}, {m_Id = 2869}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = 67}, m_Height = {m_Value = 69}, m_OffsetX = {m_Value = 15}, m_OffsetY = {m_Value = 12}, m_MaxWidth = {m_Value = 96}, m_MaxHeight = {m_Value = 96}}, m_Feet = {m_Width = {m_Value = 30}, m_Height = {m_Value = 18}, m_OffsetX = {m_Value = 18}, m_OffsetY = {m_Value = 8}, m_MaxWidth = {m_Value = 64}, m_MaxHeight = {m_Value = 32}}}, m_CustomColoredSkin = true, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0.667352855, r = 0.667352855, h = 0.667352855}, {y = 0.470265955, g = 0.470265955, s = 0.470265955}, {z = 0.577485919, b = 0.577485919, l = 0.577485919, v = 0.577485919}, {w = 1, a = 1}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 0.958477497, r = 0.958477497, h = 0.958477497}, {y = 0.570934296, g = 0.570934296, s = 0.570934296}, {z = 0.725951612, b = 0.725951612, l = 0.725951612, v = 0.725951612}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 64, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = -185079314, m_Skin1 = -487591808, m_Skin2 = -2139062144, m_Skin3 = -2139062144, m_Skin4 = -2139062144, m_Skin5 = -2139062272, m_UseCustomColor = 1, m_ColorBody = 15651463, m_ColorFeet = 16777215}, m_Path = {m_ChunkSize = 1500, m_NumItems = 74676, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x555556de4110, _M_finish = 0x555556de42a0, _M_end_of_storage = 0x555556de42a0}, <No data fields>}}, <No data fields>}}, m_StartTick = 415652, m_aPlayer = "Yumiko\000\000\000\000\000\000\000\000\000", m_PlaybackPos = 54}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}, {m_RenderInfo = {m_OriginalRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_ColorableRenderSkin = {m_Body = {m_Id = -1}, m_BodyOutline = {m_Id = -1}, m_Feet = {m_Id = -1}, m_FeetOutline = {m_Id = -1}, m_Hands = {m_Id = -1}, m_HandsOutline = {m_Id = -1}, m_Eyes = {{m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}, {m_Id = -1}}}, m_SkinMetrics = {m_Body = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}, m_Feet = {m_Width = {m_Value = -2147483648}, m_Height = {m_Value = -2147483648}, m_OffsetX = {m_Value = 2147483647}, m_OffsetY = {m_Value = 2147483647}, m_MaxWidth = {m_Value = -2147483648}, m_MaxHeight = {m_Value = -2147483648}}}, m_CustomColoredSkin = false, m_BloodColor = {<color4_base<ColorRGBA>> = {{x = 0, r = 0, h = 0}, {y = 0, g = 0, s = 0}, {z = 0, b = 0, l = 0, v = 0}, {w = 0, a = 0}}, <No data fields>}, m_ColorBody = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_ColorFeet = {<color4_base<ColorRGBA>> = {{x = 1, r = 1, h = 1}, {y = 1, g = 1, s = 1}, {z = 1, b = 1, l = 1, v = 1}, {w = 1, a = 1}}, <No data fields>}, m_Size = 1, m_GotAirJump = 1, m_ShineDecoration = 0}, m_Skin = {m_Skin0 = 0, m_Skin1 = 0, m_Skin2 = 0, m_Skin3 = 0, m_Skin4 = 0, m_Skin5 = 0, m_UseCustomColor = 0, m_ColorBody = 0, m_ColorFeet = 0}, m_Path = {m_ChunkSize = 1500, m_NumItems = 0, m_lChunks = {<std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >> = {_M_impl = {<std::allocator<CGhostCharacter*>> = {<__gnu_cxx::new_allocator<CGhostCharacter*>> = {<No data fields>}, <No data fields>}, <std::_Vector_base<CGhostCharacter*, std::allocator<CGhostCharacter*> >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>}}, m_StartTick = -1, m_aPlayer = '\000' <repeats 15 times>, m_PlaybackPos = 0}} __for_begin = 0x7fffeb79f5d0 __for_end = 0x7fffeb79ff50 PlaybackTick = 109 #16 0x0000555555812833 in CGameClient::OnRender (this=0x7fffeb496010) at /home/ant/ddnet/src/game/client/gameclient.cpp:611 i = 18 #17 0x00005555556735a1 in CClient::Render (this=0x7ffff0893010) at /home/ant/ddnet/src/engine/client/client.cpp:1191 No locals. #18 0x000055555567c013 in CClient::Run (this=0x7ffff0893010) at /home/ant/ddnet/src/engine/client/client.cpp:3246 AdditionalTime = 0 Now = 28182967481 IsRenderActive = true AsyncRenderOld = true GfxRefreshRate = 0 Now = {__r = 28182951522} SleepTimeInNanoSeconds = {__r = 0} Slept = false Seed = 500091216 LastD = false LastE = false LastG = false LastTime = {__r = 28182951522} LastRenderTime = 28182967481 #19 0x000055555568492e in main (argc=1, argv=0x7fffffffe518) at /home/ant/ddnet/src/engine/client/client.cpp:4555 Silent = false RandInitFailed = false apLoggers = {<std::_Vector_base<std::shared_ptr<ILogger>, std::allocator<std::shared_ptr<ILogger> > >> = {_M_impl = {<std::allocator<std::shared_ptr<ILogger> >> = {<__gnu_cxx::new_allocator<std::shared_ptr<ILogger> >> = {<No data fields>}, <No data fields>}, <std::_Vector_base<std::shared_ptr<ILogger>, std::allocator<std::shared_ptr<ILogger> > >::_Vector_impl_data> = {_M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}, <No data fields>}}, <No data fields>} pFutureFileLogger = {<std::__shared_ptr<CFutureLogger, (__gnu_cxx::_Lock_policy)2>> = {<std::__shared_ptr_access<CFutureLogger, (__gnu_cxx::_Lock_policy)2, false, false>> = {<No data fields>}, _M_ptr = 0x555555bd0af0, _M_refcount = {_M_pi = 0x555555bd0ae0}}, <No data fields>} pFutureConsoleLogger = {<std::__shared_ptr<CFutureLogger, (__gnu_cxx::_Lock_policy)2>> = {<std::__shared_ptr_access<CFutureLogger, (__gnu_cxx::_Lock_policy)2, false, false>> = {<No data fields>}, _M_ptr = 0x555555be66d0, _M_refcount = {_M_pi = 0x555555be66c0}}, <No data fields>} pFutureAssertionLogger = {<std::__shared_ptr<CFutureLogger, (__gnu_cxx::_Lock_policy)2>> = {<std::__shared_ptr_access<CFutureLogger, (__gnu_cxx::_Lock_policy)2, false, false>> = {<No data fields>}, _M_ptr = 0x555555be6740, _M_refcount = {_M_pi = 0x555555be6730}}, <No data fields>} pClient = 0x7ffff0893010 pKernel = 0x555555bf7a30 pEngine = 0x555555bf8450 pConsole = 0x555555bd1260 pStorage = 0x555555c1fde0 pConfigManager = 0x555555bff450 pEngineSound = 0x555555bff900 pEngineInput = 0x555555c22600 pEngineTextRender = 0x7ffff0071010 pEngineMap = 0x555555bb6790 pDiscord = 0x555555bb61f0 pSteam = 0x555555bb5cb0 File = 0x0 Restarting = false ``` </details> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Learath <learath2@gmail.com>	2022-06-02 20:04:33 +00:00
Robert Müller	23c0b6a4e4	Fix wrong iterator being used for inserting into vector	2022-06-02 21:11:02 +02:00
c0d3d3v	809309cd09	drop small NETOBJTYPE_SWITCHSTATE	2022-06-02 15:40:55 +02:00
trml	882ddae201	Send switch timing info in extended switch state netobject	2022-06-02 01:04:34 +02:00
trml	548de3804e	Rename NumSwitchers to HighestSwitchNumber and remove most references	2022-06-02 00:57:11 +02:00
trml	66c0c1e692	Send timer info for switchers and predict switch state changes	2022-06-02 00:57:09 +02:00
trml	95c4c2db1c	Move switch state to gamecore	2022-06-02 00:51:25 +02:00
trml	940205b3cc	Simplify switch state using NetArray	2022-06-02 00:46:17 +02:00
Robert Müller	70907f422a	Use insert with initializer-list instead of reserving space	2022-06-01 21:29:44 +02:00
Learath	210b19042d	Avoid unnecessary copy leading to crash	2022-06-01 19:52:34 +02:00
Robert Müller	7c17051a3a	Replace CGameClient::CStack with std::vector<class CComponent *>	2022-06-01 14:16:09 +02:00
bors[bot]	b623c3c124	Merge #5284 ... 5284: add ellipsis again r=heinrich5991 a=C0D3D3V   `@Jupeyy` can you please test if this also decreases the fps significant more than without this PR? without ellipsis (and name in mini score hud flows over the left border):  with ellipsis:  ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-06-01 10:05:57 +00:00
Robert Müller	7474ca201f	Remove dead code	2022-05-31 19:32:07 +02:00
c0d3d3v	0914c1260b	add ellipsis again	2022-05-31 12:20:45 +02:00
bors[bot]	760cb99574	Merge #5271 ... 5271: Time out for POST requests too (hopefully fixes #5198) r=heinrich5991 a=def- Untested because the issue is sporadic. But I think it makes sense to have a timeout even if this is not the root cause. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-05-31 08:01:38 +00:00
c0d3d3v	5065bab8b5	fix swap does not swap no collision and no hook ... - remove duplicated variable for no collision and no hook	2022-05-30 19:33:42 +02:00
Robert Müller	91d2ba1865	Organize game-client includes	2022-05-29 21:24:43 +02:00
Robert Müller	c2f92c1e13	Organize game-shared includes	2022-05-29 20:02:22 +02:00
def	3e60cd83d0	Time out for POST requests too (hopefully fixes #5198)	2022-05-29 19:15:36 +02:00
Alexander Akulich	a39bbc702b	Introduce and use constexpr CCharacterCore::PhysicalSize	2022-05-28 21:46:44 +03:00
Alexander Akulich	deb2e8752f	Sync prediction impl with server CCharacter::IsGrounded()	2022-05-28 21:46:07 +03:00
Alexander Akulich	a023671ecd	prediction/entity: Sync constructor signature, add GetProximityRadius()	2022-05-28 21:28:47 +03:00
bors[bot]	ab28267e30	Merge #5265 ... 5265: Cleanup prediction entity handling a little r=def- a=trml I looked over the remaining code for creating/removing entities in the prediction, and only ended up making some smaller changes: - More consistent use of InsertEntity/RemoveEntity/Destroy - Fixed one instance in gameclient.cpp where an entity was removed but not deleted (could potentially have been a memory leak) - Removed some old code for retaining information about the characters after they left the snapshot (the client should only rely on the snapshot for prediction of players) ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: trml <trml@users.noreply.github.com>	2022-05-28 12:48:10 +00:00
trml	c5595209fe	Fix and slightly cleanup creation/destruction/insertion of predicted entities	2022-05-28 13:37:59 +02:00
bors[bot]	ccf0622984	Merge #5252 ... 5252: Use std::vector instead of array, remove base/tl/array.h, algorithm.h, allocator.h, range.h r=def- a=Robyt3 Replaces all usages of `array` with `std::vector`. I adjusted variable names of variables I changed to use the `v` prefix. Not so in the editor however, as there are already many changes due to clang-tidy enforcing the use of for-each loops. This allows us to remove all remaining `base/tl` headers except `threading.h`. Clang-tidy now finds `clang-analyzer-cplusplus.NewDelete` (Use of memory after it is freed), which is also fixed here, though it appears to be a false-positive. This last remaining usages of `goto` are also removed. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-05-28 10:56:21 +00:00
c0d3d3v	04f1bbf59f	reintroduce shotgun bug	2022-05-28 00:58:33 +02:00
trml	85e86772b2	Don't keep track of characters in the predicted gameworld that are not in the snapshot and require pred characters to be alive	2022-05-28 00:07:31 +02:00
bors[bot]	59acac221c	Merge #5254 #5257 ... 5254: Fix ingame menu button behavior when holding mouse button r=def- a=Robyt3 Fixes the following behavior: 1. Player is ingame and the ingame menu is opened with Esc 2. A mouse button is held down on one of the ingame menu buttons (e.g. the spectate button) 3. The ingame menu is closed without moving the mouse away from the button 4. The mouse button is released while ingame 5. The menu is opened again - Current behavior: The hovered button is immediately activated, as soon as the menu opens, due to the released mouse state being handled as a click. - Fixed behavior: The button is not activated. Instead another call to `FinishCheck` is added so it's also called when the menu is not active, to clear the active UI item in that case. As well as the following: 1. The menu is closed while the mouse cursor is hovering over a button. 2. The mouse button is pressed and held while the menu is closed. 3. The menu is opened again. - Current behavior: The menu button is already held down and when the player releases the mouse button it will immediately be activated. - Fixed behavior: The button is not activated immediately, by clearing the hot item and next hot item variables in `FinishCheck`. The latter behavior can still occur when entering the editor instead of closing the ingame menu. Closes #3560. Closes #5229. The first two commits are identical to upstream https://github.com/teeworlds/teeworlds/pull/3158, where those issues also exist. The last commit adapts upstream behavior so buttons can only become hot when the mouse is not pressed. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5257: Refactoring: Move CMenus::UseMouseButtons to CUI::SetEnabled, extract CRenderTools::RenderCursor r=def- a=Robyt3 Adopt changes from upstream. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-05-27 18:37:17 +00:00
Robert Müller	fccfbd5b70	Extract CRenderTools::RenderCursor	2022-05-27 19:43:12 +02:00
Robert Müller	caa23bcfdd	Move CMenus::UseMouseButtons to CUI::SetEnabled	2022-05-27 19:43:12 +02:00
Robert Müller	31930951f0	Only allow buttons to be become hot while the mouse is not pressed	2022-05-27 19:07:56 +02:00
Robert Müller	910f01cbf2	Fix ingame menu buttons when mouse is held ingame and released in menu	2022-05-27 19:07:56 +02:00
Robert Müller	a0a0fa1322	Fix ingame menu buttons when mouse is held and released ingame	2022-05-27 17:45:30 +02:00
Robert Müller	ce54a0d075	Use std::vector<CMenuImage> instead of array	2022-05-27 16:31:18 +02:00
Robert Müller	24ad383211	Use std::vector<CSourceQueueEntry> instead of array	2022-05-27 16:31:18 +02:00
Robert Müller	b9c52f7e31	Use SetActiveItem(nullptr) instead of SetActiveItem(0)	2022-05-27 11:59:14 +02:00
Robert Müller	2b02bd449b	Prevent lock of UI ... Co-authored-by: oy <tom_adams@web.de>	2022-05-27 11:53:05 +02:00
bors[bot]	7348bf4d56	Merge #5246 ... 5246: Use std::vector instead of sorted_array, remove base/tl/sorted_array.h r=def- a=heinrich5991 This replaces all usages of `sorted_array` with `std::vector`. This requires the following general changes: - `add_unsorted` is replaced with `push_back`. - `add` is replaced with `push_back` and subsequent `sort` or `stable_sort` must be ensured. - In some cases, immediately sorting the entire list after adding an item was unavoidable. Previously items were added at the correct position, which was O(N) because all items after the inserted one had to be moved in any case. - `sort_range` is replaced with `sort` or `stable_sort`. - `size` returns a `size_t` instead of `int`, so to fix sign comparison warnings, casts are added where necessary or types of loop variables are changed to `size_t` where possible. For-each loops are also used where possible / where required by clang-tidy. - `find_binary` is replaced with `std::equal_range`. This can only find items of the same type, so some wrappers, that only have the relevant fields set, need to be created for searching. In terms of behavior, this should not change anything, except maybe `CLocalizationDatabase` for the better. As far as I understand it, at lot of the code there was not doing anything. It assumes that binary search can return a range of multiple entries, but the equality/comparison function is based on hash and context hash. This means that any item in this range will match the given hash and context hash already, so all of the following checks are redundant. I changed this to first do a lookup with the hash and context hash and if that fails do another lookup with the default context hash. I have also already replaced `base/tl/array.h` with `std::vector`, removing all of `base/tl` except `threading.h`. I'll make a separate PR later because this caused a lot more changes especially in the editor that I first want to test and review myself. Naming of `array`/`sorted_array`/`std::vector` variables was rather inconsistent (sometimes prefix `a` or `l` is used), so ~~I chose to not use any prefix for all new `std::vector`s~~ heinrich5991 left them as-is. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-05-27 08:51:55 +00:00
bors[bot]	61c81fa0f2	Merge #5240 ... 5240: Fix crash when graphics init failed (fixes #5237) r=heinrich5991 a=def- ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-05-26 22:17:15 +00:00
Robert Müller	de1de5e7bd	Use emplace_back for CFriendItem	2022-05-27 00:14:07 +02:00
Robert Müller	476af1286d	Use emplace_back for CCommand, fix member variable names	2022-05-27 00:13:26 +02:00
Robert Müller	a76cdb254e	Use std::vector<CDownloadSkin> instead of sorted_array	2022-05-27 00:03:13 +02:00
Robert Müller	0859da7e6a	Use std::vector<CSkin> instead of sorted_array	2022-05-27 00:03:13 +02:00
Robert Müller	5cc76d286f	Use std::vector<CGhostItem> instead of sorted_array	2022-05-27 00:03:13 +02:00
Robert Müller	b24f318450	Use std::vector<CFriendItem> instead of sorted_array	2022-05-27 00:03:13 +02:00
Robert Müller	359093cab8	Use std::vector<CDemoItem> instead of sorted_array	2022-05-27 00:03:13 +02:00
Robert Müller	96c97d5bb7	Use std::vector for assets menu list items instead of sorted_array	2022-05-26 23:49:30 +02:00
Robert Müller	2ea0c49f8b	Use std::vector<CCommand> instead of sorted_array	2022-05-26 23:49:30 +02:00
Robert Müller	0032f6f2c2	Use std::vector<CCountryFlag> instead of sorted_array	2022-05-26 23:49:27 +02:00
Robert Müller	295c395c8c	Use std::vector<CUISkin> instead of sorted_array	2022-05-26 23:47:37 +02:00
Robert Müller	97dd8105fd	Use std::vector<CLanguage> instead of sorted_array	2022-05-26 23:42:06 +02:00
Robert Müller	9b2f0fe3c4	Remove unused includes of base/tl/array.h and sorted_array.h	2022-05-26 23:42:06 +02:00
bors[bot]	e63b8e2bb5	Merge #5183 ... 5183: render allways the nameplate of a specchar (or the real player) r=def- a=C0D3D3V fokkonaut uses spec chars in addition to normal players in his mod, so the names should also be displayed in addition to the player name ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-05-26 21:06:19 +00:00
trml	2402edcb8a	Remove predicted character from gameworld before calling base class destructor	2022-05-26 19:08:46 +02:00
Dennis Felsing	ac2657bfce	Fix crash when graphics init failed (fixes #5237)	2022-05-26 13:04:39 +02:00
bors[bot]	3b81157013	Merge #5231 ... 5231: Fix windows crash r=def- a=C0D3D3V Fixes #5226 I tested it in a Windows VM. `@sjrc6` is it correct that `TempCore` is this way zero initialized, can you check that maybe in the debugger? I do not want to change the behaviour, even tho the core is read in two lines later with `TempCore.ReadCharacter(pCharacter);` ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-05-26 08:57:22 +00:00
c0d3d3v	62cad6ba51	use value initialization in Evolve lambda	2022-05-26 08:26:27 +02:00
Dennis Felsing	68bcd21eff	asan+ubsan clean	2022-05-26 01:22:14 +02:00
Dennis Felsing	604142da3a	Try other fix for tautological	2022-05-26 00:37:33 +02:00
bors[bot]	00c167148d	Merge #5194 ... 5194: Revert Ellipsis (alternative to #5193) r=heinrich5991 a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-05-25 14:46:16 +00:00
Chairn	0076edf499	Remove useless setting	2022-05-25 00:12:38 +02:00
bors[bot]	03f95108b4	Merge #5063 ... 5063: Reworked Draggers and Turrets AND show always hooks if they are in the field of view r=def- a=C0D3D3V Fixes #3622, #4723 #4798 and #5054 Here you can find a comparison video with 16.0.3: https://youtu.be/bYwLB1cEMI8 This now also includes the changes from https://github.com/ddnet/ddnet/pull/4980 So please also see my monologue here: https://github.com/ddnet/ddnet/pull/4980 Physic that got changed by this PR: - Solo players are not included in the calculation of the next team players to the dragger/turrets. This does not affect any map. - Turrets get switched correctly if players are solo - Plasma bullets fired by turrets on solo player only explode for solo players and the other way around (except if they unsolo) - Plasma bullets can no longer be intercepted by other teams - Turrets can shot now independently at the speed of sv_plasma_per_sec for every team and every solo player This should be tested by some more players before it get merged! This reduces the use of snap id's tested here: https://youtu.be/G3nVtdH0--Q from 16000 to 69 test with the new dragger: https://youtu.be/mzNrDHP7HQs I did not add the terminal of the server because you basically see no change in the used snap ids The videos are with cl_predict off Comparison of the new turrets: https://streamable.com/8us8lk left old turrets, right the new ones We should delete ranks on (that where made after 13 Jun 2019): https://ddnet.tw/maps/Increase-32-Your-32-Speed https://ddnet.tw/maps/Fall-32-into-32-the-32-Future https://ddnet.tw/maps/turboSeks ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [only on 3 maps] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-05-24 18:26:08 +00:00
Robert Müller	0c518baef4	Fix pos1 only scrolling up one page in console	2022-05-23 19:24:56 +02:00
c0d3d3v	bf2d3d59ff	do not render freezebar if you are not freezed	2022-05-23 12:12:46 +02:00
def	0c8bf5c3aa	Revert "Ellipsis at end in scoreboard and hud" ... This reverts commit f278399bd1.	2022-05-22 23:04:32 +02:00
c0d3d3v	f07d773492	Add a set of Players that are attached to a Tee	2022-05-22 21:59:51 +02:00
c0d3d3v	71c9a49776	revert to double explotion plasma bullets if the bullet hits obstacle ... and player at the same time	2022-05-22 21:59:51 +02:00
c0d3d3v	87893ceca7	Move MapScreenToGroup from 3 classes to render.cpp; Rename MapscreenToWorld to MapScreenToWorld	2022-05-22 21:59:43 +02:00
bors[bot]	344eeaf8aa	Merge #5192 ... 5192: Add missing nanosecond conversions r=def- a=Jupeyy fixes #5191 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-05-22 18:27:57 +00:00
bors[bot]	85ce4fc0a8	Merge #5185 ... 5185: Fix pickups moving on their own (fixes #5137) r=C0D3D3V a=def- Supersedes #5181 Objects should be initialized fully, otherwise they are super easy to misuse and get weird undefined behavior that happens rarely. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-05-22 14:32:21 +00:00
Jupeyy	2677949e58	Add missing nanosecond conversions	2022-05-22 16:08:11 +02:00
def	c4377bb7d9	Always initialize vec2/3/4 ... Because no tools can detect it uninitialized well, tried Memory Sanitizer (needs all libs including libc++ compiled with it), valgrind (only detects in LTO build), compiler warnings. Might be related to unions.	2022-05-22 12:18:32 +02:00
bors[bot]	1738b0d51b	Merge #5032 ... 5032: Make input handling teehistorian friendly r=def- a=Zwelf Makes input handling more reproducible during respawn. Still WIP, because I haven't tested this particular patch (only a different one with the same effect). ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [x] Tested in combination with possibly related configuration options - [x] swap - [x] using timeout protection - [x] reconnecting - [x] respawning - [x] chat keeps movement - [x] pause keeps movement - [x] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Zwelf <zwelf@strct.cc>	2022-05-22 09:57:44 +00:00
Zwelf	4a39c846c3	Fix comments	2022-05-22 10:39:18 +02:00
bors[bot]	38c8b5b019	Merge #5182 ... 5182: Fix chat prediction r=def- a=C0D3D3V reported by nori https://cdn.discordapp.com/attachments/293493549758939136/977531792389177364/recording.mp4 I have somehow made the condition wrong xD although I had written correctly in the PR what it should do. also i noticed that teeworlds does not allow you to hold the hook while chatting, but we have allowed this since 2014.... ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-05-21 20:50:20 +00:00
Zwelf	38c7a921d5	Already use second input	2022-05-21 21:34:30 +02:00
c0d3d3v	ad06a05d7b	render allways the nameplate of a specchar	2022-05-21 19:22:50 +02:00
c0d3d3v	71669e3427	release hook in mods that do not allow inputs while chatting	2022-05-21 18:52:14 +02:00
c0d3d3v	2cb47583b8	fix condition of BugDDRaceInput, do only reset innputs on non ddnet mods	2022-05-21 18:17:10 +02:00
def	2818c6e17c	Fix HUD rebase (thanks to bencie for report)	2022-05-21 11:37:46 +02:00
c0d3d3v	9c97995679	Fix Spezial Jumps for players with 0, 1 and -1 Jumps ... - Add some more documentation to the code - reverted early ground jump to keep physics	2022-05-20 21:37:05 +02:00
bors[bot]	e7140caf8b	Merge #5064 ... 5064: Add HTTP masterserver registering and HTTP masterserver r=def- a=heinrich5991 Registering ----------- The idea is that game servers push their server info to the masterservers every 15 seconds or when the server info changes, but not more than once per second. The game servers do not support the old registering protocol anymore, the backward compatibility is handled by the masterserver. The register call is a HTTP POST to a URL like `https://master1.ddnet.tw/ddnet/15/register` and looks like this: ```http POST /ddnet/15/register HTTP/1.1 Address: tw-0.6+udp://connecting-address.invalid:8303 Secret: 81fa3955-6f83-4290-818d-31c0906b1118 Challenge-Secret: 81fa3955-6f83-4290-818d-31c0906b1118:tw0.6/ipv6 Info-Serial: 0 { "max_clients": 64, "max_players": 64, "passworded": false, "game_type": "TestDDraceNetwork", "name": "My DDNet server", "map": { "name": "dm1", "sha256": "0b0c481d77519c32fbe85624ef16ec0fa9991aec7367ad538bd280f28d8c26cf", "size": 5805 }, "version": "0.6.4, 16.0.3", "clients": [] } ``` The `Address` header declares that the server wants to register itself as a `tw-0.6+udp` server, i.e. a server speaking a Teeworlds-0.6-compatible protocol. The free-form `Secret` header is used as a server identity, the server list will be deduplicated via this secret. The free-form `Challenge-Secret` is sent back via UDP for a port forward check. This might have security implications as the masterserver can be asked to send a UDP packet containing some user-controlled bytes. This is somewhat mitigated by the fact that it can only go to an attacker-controlled IP address. The `Info-Serial` header is an integer field that should increase each time the server info (in the body) changes. The masterserver uses that field to ensure that it doesn't use old server infos. The body is a free-form JSON object set by the game server. It should contain certain keys in the correct form to be accepted by clients. The body is optional if the masterserver already confirmed the reception of the info with the given `Info-Serial`. Not shown in this payload is the `Connless-Token` header that is used for Teeworlds 0.7 style communication. Also not shown is the `Challenge-Token` that should be included once the server receives the challenge token via UDP. The masterserver responds with a `200 OK` with a body like this: ``` {"status":"success"} ``` The `status` field can be `success` if the server was successfully registered on the masterserver, `need_challenge` if the masterserver wants the correct `Challenge-Token` header before the register process is successful, `need_info` if the server sent an empty body but the masterserver doesn't actually know the server info. It can also be `error` if the request was malformed, only in this case an HTTP status code except `200 OK` is sent. Synchronization --------------- The masterserver keeps state and outputs JSON files every second. ```json { "servers": [ { "addresses": [ "tw-0.6+udp://127.0.0.1:8303", "tw-0.6+udp://[::1]:8303" ], "info_serial": 0, "info": { "max_clients": 64, "max_players": 64, "passworded": false, "game_type": "TestDDraceNetwork", "name": "My DDNet server", "map": { "name": "dm1", "sha256": "0b0c481d77519c32fbe85624ef16ec0fa9991aec7367ad538bd280f28d8c26cf", "size": 5805 }, "version": "0.6.4, 16.0.3", "clients": [] } } ] } ``` `servers.json` (or configured by `--out`) is a server list that is compatible with DDNet 15.5+ clients. It is a JSON object containing a single key `servers` with a list of game servers. Each game server is represented by a JSON object with an `addresses` key containing a list of all known addresses of the server and an `info` key containing the free-form server info sent by the game server. The free-form `info` JSON object re-encoded by the master server and thus canonicalized and stripped of any whitespace characters outside strings. ```json { "kind": "mastersrv", "now": 1816002, "secrets": { "tw-0.6+udp://127.0.0.1:8303": { "ping_time": 1811999, "secret": "42d8f991-f2fa-46e5-a9ae-ebcc93846feb" }, "tw-0.6+udp://[::1]:8303": { "ping_time": 1811999, "secret": "42d8f991-f2fa-46e5-a9ae-ebcc93846feb" } }, "servers": { "42d8f991-f2fa-46e5-a9ae-ebcc93846feb": { "info_serial": 0, "info": { "max_clients": 64, "max_players": 64, "passworded": false, "game_type": "TestDDraceNetwork", "name": "My DDNet server", "map": { "name": "dm1", "sha256": "0b0c481d77519c32fbe85624ef16ec0fa9991aec7367ad538bd280f28d8c26cf", "size": 5805 }, "version": "0.6.4, 16.0.3", "clients": [] } } } } ``` `--write-dump` outputs a JSON file compatible with `--read-dump-dir`, this can be used to synchronize servers across different masterservers. `--read-dump-dir` is also used to ingest servers from the backward compatibility layer that pings each server for their server info using the old protocol. The `kind` field describe that this is `mastersrv` output and not from a `backcompat`. This is used for prioritizing `mastersrv` information over `backcompat` information. The `now` field contains an integer describing the current time in milliseconds relative an unspecified epoch that is fixed for each JSON file. This is done instead of using the current time as the epoch for better compression of non-changing data. `secrets` is a map from each server address and to a JSON object containing the last ping time (`ping_time`) in milliseconds relative to the same epoch as before, and the server secret (`secret`) that is used to unify server infos from different addresses of the same logical server. `servers` is a map from the aforementioned `secret`s to the corresponding `info_serial` and `info`. ```json [ "tw-0.6+udp://127.0.0.1:8303", "tw-0.6+udp://[::1]:8303" ] ``` `--write-addresses` outputs a JSON file containing all addresses corresponding to servers that are registered to HTTP masterservers. It does not contain the servers that are obtained via backward compatibility measures. This file can be used by an old-style masterserver to also list new-style servers without the game servers having to register there. An implementation of this can be found at https://github.com/heinrich5991/teeworlds/tree/mastersrv_6_backcompat for Teeworlds 0.5/0.6 masterservers and at https://github.com/heinrich5991/teeworlds/tree/mastersrv_7_backcompat for Teeworlds 0.7 masterservers. All these JSON files can be sent over the network in an efficient way using https://github.com/heinrich5991/twmaster-collect. It establishes a zstd-compressed TCP connection authenticated by a string token that is sent in plain-text. It watches the specified file and transmits it every time it changes. Due to the zstd-compression, the data sent over the network is similar to the size of a diff. Implementation -------------- The masterserver implementation was done in Rust. The current gameserver register implementation doesn't support more than one masterserver for registering. Co-authored-by: heinrich5991 <heinrich5991@gmail.com>	2022-05-20 17:01:20 +00:00
c0d3d3v	bd9a04b1d2	fix HUD assets Tab	2022-05-20 17:35:22 +02:00
heinrich5991	6b65ccb945	Add HTTP masterserver registering and HTTP masterserver ... Registering ----------- The idea is that game servers push their server info to the masterservers every 15 seconds or when the server info changes, but not more than once per second. The game servers do not support the old registering protocol anymore, the backward compatibility is handled by the masterserver. The register call is a HTTP POST to a URL like `https://master1.ddnet.tw/ddnet/15/register` and looks like this: ```json POST /ddnet/15/register HTTP/1.1 Address: tw-0.6+udp://connecting-address.invalid:8303 Secret: 81fa3955-6f83-4290-818d-31c0906b1118 Challenge-Secret: 81fa3955-6f83-4290-818d-31c0906b1118:tw0.6/ipv6 Info-Serial: 0 { "max_clients": 64, "max_players": 64, "passworded": false, "game_type": "TestDDraceNetwork", "name": "My DDNet server", "map": { "name": "dm1", "sha256": "0b0c481d77519c32fbe85624ef16ec0fa9991aec7367ad538bd280f28d8c26cf", "size": 5805 }, "version": "0.6.4, 16.0.3", "clients": [] } ``` The `Address` header declares that the server wants to register itself as a `tw-0.6+udp` server, i.e. a server speaking a Teeworlds-0.6-compatible protocol. The free-form `Secret` header is used as a server identity, the server list will be deduplicated via this secret. The free-form `Challenge-Secret` is sent back via UDP for a port forward check. This might have security implications as the masterserver can be asked to send a UDP packet containing some user-controlled bytes. This is somewhat mitigated by the fact that it can only go to an attacker-controlled IP address. The `Info-Serial` header is an integer field that should increase each time the server info (in the body) changes. The masterserver uses that field to ensure that it doesn't use old server infos. The body is a free-form JSON object set by the game server. It should contain certain keys in the correct form to be accepted by clients. The body is optional if the masterserver already confirmed the reception of the info with the given `Info-Serial`. Not shown in this payload is the `Connless-Token` header that is used for Teeworlds 0.7 style communication. Also not shown is the `Challenge-Token` that should be included once the server receives the challenge token via UDP. The masterserver responds with a `200 OK` with a body like this: ``` {"status":"success"} ``` The `status` field can be `success` if the server was successfully registered on the masterserver, `need_challenge` if the masterserver wants the correct `Challenge-Token` header before the register process is successful, `need_info` if the server sent an empty body but the masterserver doesn't actually know the server info. It can also be `error` if the request was malformed, only in this case an HTTP status code except `200 OK` is sent. Synchronization --------------- The masterserver keeps state and outputs JSON files every second. ```json { "servers": [ { "addresses": [ "tw-0.6+udp://127.0.0.1:8303", "tw-0.6+udp://[::1]:8303" ], "info_serial": 0, "info": { "max_clients": 64, "max_players": 64, "passworded": false, "game_type": "TestDDraceNetwork", "name": "My DDNet server", "map": { "name": "dm1", "sha256": "0b0c481d77519c32fbe85624ef16ec0fa9991aec7367ad538bd280f28d8c26cf", "size": 5805 }, "version": "0.6.4, 16.0.3", "clients": [] } } ] } ``` `servers.json` (or configured by `--out`) is a server list that is compatible with DDNet 15.5+ clients. It is a JSON object containing a single key `servers` with a list of game servers. Each game server is represented by a JSON object with an `addresses` key containing a list of all known addresses of the server and an `info` key containing the free-form server info sent by the game server. The free-form `info` JSON object re-encoded by the master server and thus canonicalized and stripped of any whitespace characters outside strings. ```json { "kind": "mastersrv", "now": 1816002, "secrets": { "tw-0.6+udp://127.0.0.1:8303": { "ping_time": 1811999, "secret": "42d8f991-f2fa-46e5-a9ae-ebcc93846feb" }, "tw-0.6+udp://[::1]:8303": { "ping_time": 1811999, "secret": "42d8f991-f2fa-46e5-a9ae-ebcc93846feb" } }, "servers": { "42d8f991-f2fa-46e5-a9ae-ebcc93846feb": { "info_serial": 0, "info": { "max_clients": 64, "max_players": 64, "passworded": false, "game_type": "TestDDraceNetwork", "name": "My DDNet server", "map": { "name": "dm1", "sha256": "0b0c481d77519c32fbe85624ef16ec0fa9991aec7367ad538bd280f28d8c26cf", "size": 5805 }, "version": "0.6.4, 16.0.3", "clients": [] } } } } ``` `--write-dump` outputs a JSON file compatible with `--read-dump-dir`, this can be used to synchronize servers across different masterservers. `--read-dump-dir` is also used to ingest servers from the backward compatibility layer that pings each server for their server info using the old protocol. The `kind` field describe that this is `mastersrv` output and not from a `backcompat`. This is used for prioritizing `mastersrv` information over `backcompat` information. The `now` field contains an integer describing the current time in milliseconds relative an unspecified epoch that is fixed for each JSON file. This is done instead of using the current time as the epoch for better compression of non-changing data. `secrets` is a map from each server address and to a JSON object containing the last ping time (`ping_time`) in milliseconds relative to the same epoch as before, and the server secret (`secret`) that is used to unify server infos from different addresses of the same logical server. `servers` is a map from the aforementioned `secret`s to the corresponding `info_serial` and `info`. ```json [ "tw-0.6+udp://127.0.0.1:8303", "tw-0.6+udp://[::1]:8303" ] ``` `--write-addresses` outputs a JSON file containing all addresses corresponding to servers that are registered to HTTP masterservers. It does not contain the servers that are obtained via backward compatibility measures. This file can be used by an old-style masterserver to also list new-style servers without the game servers having to register there. An implementation of this can be found at https://github.com/heinrich5991/teeworlds/tree/mastersrv_6_backcompat for Teeworlds 0.5/0.6 masterservers and at https://github.com/heinrich5991/teeworlds/tree/mastersrv_7_backcompat for Teeworlds 0.7 masterservers. All these JSON files can be sent over the network in an efficient way using https://github.com/heinrich5991/twmaster-collect. It establishes a zstd-compressed TCP connection authenticated by a string token that is sent in plain-text. It watches the specified file and transmits it every time it changes. Due to the zstd-compression, the data sent over the network is similar to the size of a diff. Implementation -------------- The masterserver implementation was done in Rust. The current gameserver register implementation doesn't support more than one masterserver for registering.	2022-05-20 08:58:32 +02:00
bors[bot]	8b31dbb108	Merge #5155 ... 5155: Remove cl_show_console and -c / --console command line options, attach to existing console r=heinrich5991 a=Robyt3 Alternative to #5154. Closes #5150. If you want to open the client with a console window, instead create a new shortcut with the following target: ``` cmd /c "C:\path\to\your\DDNet.exe" ``` You can change the icon of the shortcut to the DDNet icon in the properties of the shortcut file. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-05-20 06:49:41 +00:00
c0d3d3v	f5ff227561	fix inputs on vanilla server if chat is open	2022-05-19 23:18:14 +02:00
Robert Müller	2ebaa76194	Remove cl_show_console and -c / --console cmdline options	2022-05-19 21:24:19 +02:00
c0d3d3v	789d7d81fc	keep input if chat is closed	2022-05-19 19:50:51 +02:00
def	f278399bd1	Ellipsis at end in scoreboard and hud	2022-05-18 23:46:11 +02:00
Jupeyy	3c597aff95	Switch to nanoseconds	2022-05-18 18:05:41 +02:00
bors[bot]	53d77e86b2	Merge #5119 ... 5119: Use STUN to determine UDP connectivity and show diagnostics r=def- a=heinrich5991 These diagnostics are supposed to guide the user to problem resolution. They're displayed if no packet is received from the server within one second of connecting. No message if we don't have STUN servers. "Trying to determine UDP connectivity..." if no answer has been received from the STUN server yet and it hasn't timed out yet. "UDP seems to be filtered." if the STUN request has timed out. "UDP and TCP IP addresses seem to be different. Try disabling VPN, proxy or network accelerators." if the STUN request has returned an IP address different from the one obtained via HTTP from info2.ddnet.tw. "No answer from server yet." otherwise, if the STUN request has returned no interesting data, indicating that it's likely the game server's fault. ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com>	2022-05-18 07:43:55 +00:00
heinrich5991	4fb050ccb7	Use STUN to determine UDP connectivity and show diagnostics ... These diagnostics are supposed to guide the user to problem resolution. They're displayed if no packet is received from the server within one second of connecting. No message if we don't have STUN servers. "Trying to determine UDP connectivity..." if no answer has been received from the STUN server yet and it hasn't timed out yet. "UDP seems to be filtered." if the STUN request has timed out. "UDP and TCP IP addresses seem to be different. Try disabling VPN, proxy or network accelerators." if the STUN request has returned an IP address different from the one obtained via HTTP from info2.ddnet.tw. "No answer from server yet." otherwise, if the STUN request has returned no interesting data, indicating that it's likely the game server's fault.	2022-05-18 09:21:31 +02:00
heinrich5991	407644deef	Change IClient::ServerAddress to give the actual server address ... Previously, it'd take the string entered by the user, before applying its transformations. Add `IClient::ConnectAddressString` for the old behavior.	2022-05-18 09:20:53 +02:00
bors[bot]	3d6e683fdd	Merge #5133 #5138 ... 5133: Fix IPO build problems r=heinrich5991 a=def- `@Kaffeine` Windows x86-64 with MinGW worked, previously: ``` -rwxr-xr-x 1 deen deen 755K May 15 11:38 config_retrieve.exe* -rwxr-xr-x 1 deen deen 756K May 15 11:38 config_store.exe* -rwxr-xr-x 1 deen deen 2.8M May 15 11:38 DDNet.exe* -rwxr-xr-x 1 deen deen 2.1M May 15 11:38 DDNet-Server.exe* -rwxr-xr-x 1 deen deen 761K May 15 11:38 dilate.exe* -rwxr-xr-x 1 deen deen 763K May 15 11:38 map_convert_07.exe* -rwxr-xr-x 1 deen deen 756K May 15 11:38 map_diff.exe* -rwxr-xr-x 1 deen deen 761K May 15 11:38 map_extract.exe* ``` Now: ``` -rwxr-xr-x 1 deen deen 256K May 16 00:26 config_retrieve.exe* -rwxr-xr-x 1 deen deen 282K May 16 00:26 config_store.exe* -rwxr-xr-x 1 deen deen 2.8M May 16 00:26 DDNet.exe* -rwxr-xr-x 1 deen deen 2.0M May 16 00:26 DDNet-Server.exe* -rwxr-xr-x 1 deen deen 271K May 16 00:26 dilate.exe* -rwxr-xr-x 1 deen deen 289K May 16 00:26 map_convert_07.exe* -rwxr-xr-x 1 deen deen 261K May 16 00:26 map_diff.exe* -rwxr-xr-x 1 deen deen 278K May 16 00:26 map_extract.exe* ``` ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5138: No gold preference (fixes #5136) r=heinrich5991 a=def- `@Kaffeine` lld is used on some systems, we also have instructions for mold in readme, both are faster than gold. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de> Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-05-18 07:12:29 +00:00
Chairn	583d6e6c01	Mark virtual function as override using a script: ... while IFS= read -r line; do file=${line%%:*}; lineno=$(echo $line | cut -d':' -f2); echo "Treating $file line $lineno"; sed -i -e "${lineno}s/virtual //" -e "${lineno}s/);\$/) override;/" -e "${lineno}s/)\$/) override/" -e "${lineno}s/const\$/const override/" -e "${lineno}s/) {/) override {/" -e "${lineno}s/) const {/) const override {/" -e "${lineno}s/const;$/const override;/" "$file"; done < a	2022-05-17 23:47:32 +02:00
bors[bot]	47874fb57f	Merge #5085 ... 5085: New DDRace HUD r=def- a=C0D3D3V If you want to test this PR, you have to test it on a Server that includes this PR too. Textures are made by Ravie Here a showcase video with most parts shown: https://youtu.be/gPTVj-s3pgc Added to the new HUD - A display of the weapons available to the player - The weapon the player is carrying is highlighted - Indicators for the special abilities of the player (Endless Hook, Endless Jumps, Jetpack, Teleport Weapons) - Indicators for abilities taken away from the player (Deep/Life Freeze, No Hook, No Weapons collision, No Collision) - Control indicators for dummy controls (dummy hammer, dummy copy) (bottom right) - Jump indicator (max 10 jumps ar displayed, and greyed out as soon as a jump is used) - Ninja status bar that indicates how long a player is capable of using ninja (next to the ninja sword) - Freeze status bar that indicates the thawing time of a player (below player) - Movement Information can be displayed in a clean way above the mini score HUD (Position, Speed, Target Angle) - Indicator if you are in practice mode The complete HUD also works for players you spectate I Added a new NetObj since the predicted values are not perfect and would make the display of the information a lot less good: DDNetCharacterDisplayInfo that contains the following information ``` NetIntRange("m_JumpedTotal", -2, 255), NetTick("m_NinjaActivationTick"), NetTick("m_FreezeTick"), NetBool("m_IsInFreeze"), NetBool("m_IsInPracticeMode"), NetIntAny("m_TargetX"), # used for the Movement Information display NetIntAny("m_TargetY"), NetIntAny("m_RampValue"), ``` So if someone has an idea what data we could also need in the client for making the display more nice, now is the right moment to add more data to this network object. A few screenshots: Assets Tab:  HUD Settings:  Mini Debug HUD:  Speed.X is calculated using the players ramp vaule ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de> Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-05-16 22:23:08 +00:00
c0d3d3v	d6833b6fd6	fix jump display	2022-05-16 23:17:19 +02:00
c0d3d3v	796b2add95	Fix Weapon Shields rendering and Clean up Sprite Offsets in items.cpp	2022-05-16 15:31:46 +02:00
def	dc03f410ad	Disable IPO on mingw win32 ... /usr/lib/gcc/i686-w64-mingw32/11.2.0/../../../../i686-w64-mingw32/bin/ld: /usr/lib/gcc/i686-w64-mingw32/11.2.0/../../../../i686-w64-mingw32/bin/ld: DWARF error: could not find variable specification at offset 378 /usr/lib/gcc/i686-w64-mingw32/11.2.0/../../../../i686-w64-mingw32/lib/../lib/libstdc++.a(string-inst.o): in function `ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag': /build/mingw-w64-gcc/src/build-i686-w64-mingw32/i686-w64-mingw32/libstdc++-v3/include/bits/basic_string.tcc:206: multiple definition of `void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>(char*, char*, std::forward_iterator_tag)'; glsl_shader_compiler.cpp.obj (symbol from plugin):(.gnu.linkonce.t._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag+0x0): first defined here ...	2022-05-16 10:12:43 +02:00
def	bbb1b42bb5	Fix -Walloc-size-larger-than= in maplayers.cpp ... Fails on Linux x86 with IPO: In member function '_ZN10CMapLayers17STileLayerVisuals4InitEjj.part.18', inlined from 'OnMapLoad' at /ddnet-source-steam/src/game/client/components/maplayers.cpp:301:6: /ddnet-source-steam/src/game/client/components/maplayers.cpp:312:74: warning: argument 1 value '4294967295' exceeds maximum object size 2147483647 [-Walloc-size-larger-than=] m_pBorderTop = new CMapLayers::STileLayerVisuals::STileVisual[Width - 2]; ^	2022-05-16 00:53:55 +02:00
bors[bot]	a041ff8aed	Merge #5069 ... 5069: Some HTTP fixes factored out of the HTTP masterserver PR r=def- a=heinrich5991 CC #5064 Co-authored-by: heinrich5991 <heinrich5991@gmail.com>	2022-05-15 22:20:11 +00:00
bors[bot]	61cca6ca16	Merge #5131 ... 5131: Remove base/tl/base.h r=heinrich5991 a=Robyt3 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-05-15 20:11:13 +00:00
Robert Müller	aeb8790649	Remove base/tl/base.h	2022-05-15 20:36:16 +02:00
Robert Müller	f634f66008	Fix memory leaks in auto stat CSV output, refactoring ... And fix stringop-overflow warning: In function 'str_copy', inlined from 'FormatStats' at src\game\client\components\statboard.cpp:541:10: src\base\system.cpp:2524:16: warning: 'strncat' specified bound depends on the length of the source argument [-Wstringop-overflow=] 2524 | strncat(dst, src, dst_size - 1); | ^ src\game\client\components\statboard.cpp: In member function 'FormatStats': src\base\system.cpp:2557:27: note: length computed here 2557 | return (int)strlen(str); | ^	2022-05-15 20:24:26 +02:00
Robert Müller	52100dbbe7	Use qualified std::swap only	2022-05-15 19:25:36 +02:00
bors[bot]	3d244b728d	Merge #5122 ... 5122: Cleanup CRenderTools r=heinrich5991 a=Robyt3 ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com>	2022-05-14 17:41:04 +00:00
Robert Müller	51d0d76e11	Rename parameters id -> Id	2022-05-14 19:08:43 +02:00
bors[bot]	92be4a67d7	Merge #4959 ... 4959: Revert "CGameClient::LoadMapSettings: Load the default tuning params … r=heinrich5991 a=def- …by default" This reverts commit 754562ce0b. This breaks rendering for ddnet mode, thanks to cheeser0613 for report `@Kaffeine` I'd prefer to have it working with DDNet instead of vanilla. A fix that doesn't break DDNet demos would be welcome. ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-05-14 16:31:54 +00:00
Robert Müller	25c4270cb4	Fix comments	2022-05-14 13:44:12 +02:00
Robert Müller	485d61d4f8	Use std::swap	2022-05-14 13:43:26 +02:00
Robert Müller	1690a9703d	Rename variable cs -> ColorScale	2022-05-14 13:40:46 +02:00
Robert Müller	3708abe8e0	Remove CRenderTools' pointers to CUI and CGameClient	2022-05-14 13:31:07 +02:00
def	0f2d464dbf	Update tooltip text after changing language ... Thanks to cheeser0613 for report	2022-05-14 12:49:12 +02:00
def	cfe8cce91d	Add translation string "Adjust the opacity..." ... Reported by cheeser0613	2022-05-14 11:05:32 +02:00
Robert Müller	fc93ba0539	Remove unused DoButtonLogic pText argument	2022-05-14 00:26:15 +02:00
Robert Müller	ca091d87b2	Support nesting editboxes, pickers and scrollbars in clipping areas	2022-05-13 21:39:25 +02:00
Robert Müller	1e8278ca95	Smooth clipping when scrolling in controls settings	2022-05-13 21:38:02 +02:00
Robert Müller	8c7cdb5936	Rename UiDoGetButtons to DoSettingsControlsButtons	2022-05-13 21:38:01 +02:00
Robert Müller	60347fde1a	Use MouseHovered instead of clipping manually	2022-05-13 21:38:01 +02:00
Robert Müller	7bda9d4118	Fix variable spelling CheckAble -> Checkable	2022-05-13 20:46:54 +02:00
Robert Müller	8d12529f1e	Move variable declaration	2022-05-13 20:46:54 +02:00
Robert Müller	cae2b49ed6	Reuse MouseInside variable	2022-05-13 20:46:54 +02:00
Robert Müller	0f6572ebf6	Rename static variables ButtonUsed -> s_ButtonUsed	2022-05-13 20:46:54 +02:00
Robert Müller	6241c8483d	Use bool instead of int with MouseInside	2022-05-13 20:46:50 +02:00
Robert Müller	a248822ea5	Add CUI:MouseHovered and MouseInsideClip	2022-05-13 20:24:10 +02:00
Robert Müller	1855b4aea1	Support nested CUI clipping regions	2022-05-13 20:20:04 +02:00
heinrich5991	40bd85b552	Refactor HTTP code to no longer use inheritance ... This gives us the same API interface for all different request types (HEAD, GET, POST).	2022-05-13 09:16:15 +02:00
heinrich5991	1b233ab95c	Add the HTTP client methods to the server	2022-05-13 09:04:39 +02:00
Tater	b6a9389fe8	Render tees in skin selector with default emote	2022-05-12 17:17:19 -05:00
c0d3d3v	fa2ac1bb64	Merge branch 'master' into New_HUD ... * master: (87 commits) Remove base/tl/string.h Replace remaining usage of base/tl/string with std::string Remove unused includes of base/tl/string.h Store localized strings in a CHeap instead of using tl/string.h Mark methods as const Add CHeap::StoreString method Rules are chat responses too Add margins to demo slice popup, decrease error font size, UI scaling Remove redundant parameters which are overridden later Use Margin instead of both VMargin and HMargin Move variable declaration Only output messages intended for chat to the user of a chat command Remove unused chat response variables Don't print the first "Waiting for score threads to complete" fix usage of undefined behavior for default eyes remove duplicate HOOK_RETRACTED assignment do not send swap request notification to complete team 0 make swap messages more personal Move ninja shield to other position (fixes #5047) do not release the hooks if you swap ...	2022-05-10 19:03:09 +02:00
c0d3d3v	0c4dfb694c	Add Options for new HUD ... - Change FontSize of MovementInfo to 6 and add a little morre padding at the sides	2022-05-10 18:41:46 +02:00
Robert Müller	a1d092be27	Replace remaining usage of base/tl/string with std::string	2022-05-07 00:17:29 +02:00
Robert Müller	dee7393555	Remove unused includes of base/tl/string.h	2022-05-07 00:02:43 +02:00
Robert Müller	3e1cfcd306	Store localized strings in a CHeap instead of using tl/string.h	2022-05-07 00:02:43 +02:00
Robert Müller	cc9ed7e9d3	Add margins to demo slice popup, decrease error font size, UI scaling	2022-05-01 12:03:56 +02:00
Robert Müller	f4642472b2	Remove redundant parameters which are overridden later	2022-05-01 11:40:26 +02:00
Robert Müller	a1614e4709	Use Margin instead of both VMargin and HMargin	2022-05-01 11:40:21 +02:00
Robert Müller	e291a3a70c	Move variable declaration	2022-05-01 11:38:58 +02:00
bors[bot]	567aeb7d9e	Merge #5049 ... 5049: do not release the hooks if you swap r=C0D3D3V a=C0D3D3V Needs more testing, but first test looks good https://streamable.com/ypra11 ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-04-30 20:09:20 +00:00
c0d3d3v	a289503411	remove duplicate HOOK_RETRACTED assignment	2022-04-30 21:41:13 +02:00
Edgar	4b25f8d63e	fix tooltips rendering when they shouldn't, fixes #5035	2022-04-30 10:05:28 +02:00
Dennis Felsing	1376dc2aa7	Revert "Get rid of optional, not available on Debian9 build" ... This reverts commit 4e3d5c5626. Should work again with clang++-7 and libc++-7. See 2534d627ac	2022-04-30 01:01:39 +02:00
Robert Müller	da44ecd6eb	Fix flashing colors in console when scrolling up continuously	2022-04-29 17:51:10 +02:00
bors[bot]	ca4b6222da	Merge #5013 ... 5013: Unify logging infrastructure between `IConsole` and `dbg_msg` r=def- a=heinrich5991 This makes the "black console window" less important on Windows (or anywhere else, for that matter), lets you see logs from other threads in the f1 console, and removes the distinction between `IConsole::Print` and `dbg_msg`. Co-authored-by: heinrich5991 <heinrich5991@gmail.com>	2022-04-29 14:17:07 +00:00
Jupeyy	53cb36bbe7	Fix wrong quad offset for (not caused by transparent) flushes	2022-04-29 15:51:25 +02:00
heinrich5991	fa4bcd5ec0	Unify logging infrastructure between IConsole and dbg_msg ... This makes the "black console window" less important on Windows (or anywhere else, for that matter), lets you see logs from other threads in the f1 console, and removes the distinction between `IConsole::Print` and `dbg_msg`.	2022-04-29 15:21:26 +02:00
bors[bot]	98bf721587	Merge #4726 #4727 #4728 #4880 #5022 ... 4726: Display super with "super" string in scoreboard (fixes #4724) r=heinrich5991 a=def- instead of showing the number 64 Alternative to https://github.com/ddnet/ddnet/pull/4725 <!-- What is the motivation for the changes of this pull request --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4727: Increase MAX_IDS to 32k (fixes #4723) r=heinrich5991 a=def- Not sure I like it, otherwise we have to edit Game City. Maybe we should fail this in map editor already instead of allowing to create a map which requires > MAX_IDS <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4728: Implement shields that remove specific weapon (fixes #4572) r=heinrich5991 a=def- Thanks to Cellegen for graphics. Functionality works, still a bit buggy sprite display (see screenshot), maybe someone can quickly spot what I'm doing wrong <img width="898" alt="Screenshot 2022-02-18 at 00 50 14" src="https://user-images.githubusercontent.com/2335377/154591108-d89cb475-daaf-4a6a-9748-17160a1e71a2.png"> ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4880: Add mysql to github workflow in ubuntu 20.04 r=heinrich5991 a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5022: Use std::clamp r=heinrich5991 a=def- Not sure if we want to, there are some easy functions like this we could take from stdlib now <!-- What is the motivation for the changes of this pull request --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de> Co-authored-by: Jupeyy <jupjopjap@gmail.com>	2022-04-29 00:30:17 +00:00
Dennis Felsing	6a7c7ff4cc	Use std::gcd	2022-04-28 17:01:53 +02:00
Jupeyy	b8da817716	Return the quad offset of the first added quad, when adding new quads	2022-04-28 16:50:18 +02:00
Dennis Felsing	298287fb4e	Implement shields that remove specific weapon (fixes #4572) ... Thanks to Cellegen for graphics. Functionality works, still a bit buggy sprite display, maybe someone can quickly spot what I'm doing wrong	2022-04-28 16:49:32 +02:00
Dennis Felsing	15b8dc8d64	Remove dots in tooltip texts	2022-04-28 16:46:18 +02:00
Dennis Felsing	3ca86ee128	Display super with "super" string in scoreboard (fixes #4724) ... instead of showing the number 64	2022-04-28 16:40:20 +02:00
bors[bot]	a8b842277a	Merge #5019 ... 5019: remove cl_predict_ddrace r=heinrich5991 a=C0D3D3V Since most of the predict code is only ddrace relevant anyway, I would suggest removing the cl_predict_ddrace option instead of checking if m_WorldConfig.m_PredictDDRace is set everywhere ddrace stuff is predicted. in case of conflicts with physics from other mods, the check on m_WorldConfig.m_PredictDDRace must however be implemented in the appropriate places (for example for the freeze and unfreeze functions). But since there are currently no conflicts apparently, this is sufficient for now. fixes the bug I reported here: https://discord.com/channels/252358080522747904/293493549758939136/968114944878989363 `@trml` what do you think about this? ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-04-28 12:34:04 +00:00
bors[bot]	6cce22d056	Merge #4813 #4905 ... 4813: Don't allow infinite shotgun bounce (fixes #4809) r=heinrich5991 a=def- I hope this kind of physic isn't used anywhere, I couldn't trigger it without being stuck in wall. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4905: Fix move_sqlite (fixes #4902) r=heinrich5991 a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-04-28 12:11:05 +00:00
c0d3d3v	1a162c08be	remove unnecessary loop over the possible modifier combinations	2022-04-28 08:45:25 +02:00
bors[bot]	e3eeec762d	Merge #4997 ... 4997: Add option to change default eyes when joining server r=def- a=sjrc6 Risky Feat suggested this idea to me, I also thought it was good so I implemented it. If you press one of the eyes in the settings it will change which eyes you get when you join a server. It saves a separate variable for dummy/player. It will also change your eyes anytime you press one of them, but only if you are playing as the same Tee whose eyes you are trying to change. If someone could figure out the best way to make it change the opposite Tees eyes as well that would be nice but I don't think it's necessary. It also changes the "Your Skin:" Tee eyes on the left if you have one selected. I had to change the cl_run_on_join code a bit, I tested and I don't think it should ever break anything but it might be good for someone to double check.  ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [x] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Tater <Mr.Potatooh@gmail.com>	2022-04-27 07:42:59 +00:00
bors[bot]	3d183fc16d	Merge #5027 ... 5027: Fix tooltip locations after window resize (fixes #5026) r=edg-l a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-04-27 06:05:59 +00:00
Tater	70311d5d4f	Add option for default eyes when joining server	2022-04-26 19:47:38 -05:00
Dennis Felsing	c174274edc	Fix tooltip locations after window resize (fixes #5026)	2022-04-27 01:00:23 +02:00
Jupeyy	b23e60c077	Allow onfly FSAA change under Vulkan	2022-04-26 21:09:55 +02:00
c0d3d3v	bc80d83ec9	fix WalkTime for negativ positions	2022-04-26 09:58:31 +02:00
c0d3d3v	68036e6a19	remove cl_predict_ddrace	2022-04-25 15:57:10 +02:00
bors[bot]	1dea02d456	Merge #5018 ... 5018: fix dummy hammer interval, this became incorrect after a few days r=def- a=C0D3D3V Reported by Konsti here: https://discord.com/channels/252358080522747904/293493549758939136/967073772836376586 I have tested the change on Justfly with my dummy :D since it is exactly the same interval as before it should not change any Physics. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [x] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de>	2022-04-25 13:17:01 +00:00
c0d3d3v	2f4ccb94de	fix dummy hammer interval, this became incorrect after a few days	2022-04-25 14:10:32 +02:00
bors[bot]	9be59a990b	Merge #4678 ... 4678: Ignore F5 key press when ingame menu is open r=heinrich5991 a=def- Since ghost menu and browser use F5 already to refresh, and having a bind on it, would cause both actions at once. I believe it makes sense to have this special handling only for F5, other F-keys don't have this problem since we don't use them in any menus. <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Dennis Felsing <dennis@felsin9.de>	2022-04-24 23:04:58 +00:00
Dennis Felsing	394b2a02e0	Remove cl_show_quads bind	2022-04-24 12:28:04 +02:00
heinrich5991	103b663662	Rename Act → Cur, some "actual" → "current" ... Seems like it got introduced by means of the false friend "actual" ≠ "aktuell" = "current".	2022-04-23 00:42:37 +02:00
Dennis Felsing	4e3d5c5626	Get rid of optional, not available on Debian9 build	2022-04-19 09:56:28 +02:00
Edgar	646162eb09	make super ignore livefreeze, fix #4973	2022-04-18 15:40:39 +02:00
bors[bot]	c39448ca53	Merge #5000 ... 5000: Inform about client restart when changing GPU r=Jupeyy a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: def <dennis@felsin9.de>	2022-04-18 08:22:18 +00:00
def	87b7550a4a	Inform about client restart when changing GPU	2022-04-18 10:16:24 +02:00
bors[bot]	fdcb1576bd	Merge #4946 #4993 #4998 #4999 ... 4946: Better forced viewport handling r=def- a=Jupeyy For #4939 For the performance warnings refering `vkCmdClearAttachments` ignore them, because this function is only called when: - clear color is changed(open/close editor, switch between entities) to directly flush a clear with the new color - ~~a viewport is used that is "worse" than 5:4 (I don't really want to switch to non renderpass clear completly, since it *can* improve performance -- https://community.arm.com/arm-community-blogs/b/graphics-gaming-and-vr-blog/posts/vulkan-samples "Therefore, avoid using LOAD_OP_LOAD and vkCmdClearAttachments and use LOAD_OP_CLEAR or LOAD_OP_DONT_CARE whenever possible.")~~ thinking about it, maybe i can also drop this call now, since its dynamic viewport anyway ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4993: Unselect text after ctrl-u r=Jupeyy a=def- <!-- What is the motivation for the changes of this pull request --> ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4998: Refactor tooltips and add some more r=def- a=edg-l Refactored tooltips so they render last, otherwise stuff rendered after the call is overlapped. Also renamed "Alpha" to "Opacity" which is more clear to non-devs. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4999: Respect GPU type better r=def- a=Jupeyy fixes #4994 ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com> Co-authored-by: def <dennis@felsin9.de> Co-authored-by: Edgar Luque <git@edgarluque.com>	2022-04-18 08:06:49 +00:00
Edgar	eba7a14cb4	add missing end new lines	2022-04-18 09:55:50 +02:00
Edgar	fbbcbb6d2f	remove designated initializers because we live in 2017	2022-04-18 09:44:13 +02:00
Edgar	74286d1dd4	format code	2022-04-18 09:34:21 +02:00
Edgar	faab2ded74	Refactor tooltips to render last, add some tooltips	2022-04-18 09:34:05 +02:00
def	041c565534	Unselect text after ctrl-u	2022-04-18 00:22:11 +02:00
Noa	482d45484b	fix gun sounds for blockworlds servers	2022-04-16 19:36:25 +02:00
bors[bot]	e81ebfb0bb	Merge #4964 #4984 #4985 ... 4964: allow freecam to center on world border r=def- a=C0D3D3V fixes #4953 I think the 200 units or 6.25 blocks more should not bother anyone.  under some circumstances, it will only move to x=1 (or in blocks 0.03) but this should be negligible. ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [x] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4984: Don't read from backend if Init failed r=def- a=Jupeyy fixes #4981 This `bug` should not create any uninitended behavior, since these values get reinitialized after the backend creation worked ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 4985: Close sockets r=def- a=ChillerDragon https://github.com/ddnet/ddnet/pull/4970 Fixes ``` Direct leak of 205848 byte(s) in 1 object(s) allocated from: #0 0x4a200d in malloc (/home/runner/work/ddnet/ddnet/san/DDNet-Server+0x4a200d) #1 0xc7fe3f in net_udp_create /home/runner/work/ddnet/ddnet/src/base/system.cpp:1640:41 #2 0xbf2d0b in CNetServer::Open(NETADDR, CNetBan*, int, int) /home/runner/work/ddnet/ddnet/src/engine/shared/network_server.cpp:55:13 #3 0x568cdc in CServer::Run() /home/runner/work/ddnet/ddnet/src/engine/server/server.cpp:2448:60 #4 0x5a922b in main /home/runner/work/ddnet/ddnet/src/engine/server/server.cpp:3718:21 #5 0x7ff75f52c0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x240b2) ``` ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: c0d3d3v <c0d3d3v@mag-keinen-spam.de> Co-authored-by: Jupeyy <jupjopjap@gmail.com> Co-authored-by: ChillerDrgon <ChillerDragon@gmail.com>	2022-04-15 20:37:18 +00:00
bencie	5401364813	Update voting.cpp ... fix console help text for callvote parameters	2022-04-15 18:16:28 +02:00
c0d3d3v	9dc2141ded	remove shadow variables ... fix GetDigitsIndex Parameters remove unused y addidion in debughud	2022-04-14 14:46:22 +02:00
c0d3d3v	a9c8b344a2	Player position, speed and angle can now be displayed in the HUD. ... - Added RenderMovementInformation() to the HUD - Use m_Width instead of recalculating the display width each time in hud.cpp - Reworked Debug HUD: - Display velspeed.x*ramp and velspeed.y instead of velspeed*ramp - Show unit of speed - The graph for the velspeed.x*ramp behavior (if dbg_tuning is active) is now nicer and usable. A second graph zooming in on the turning point has been added. - The velspeed.x*ramp graph will be redrawn only when new tuning parameters are added - The target angle used to draw the tees is now calculated using the m_TargetX, m_TargetY in DDNetCharacterDisplayInfo if available. - Added m_TargetX, m_TargetY and m_RampValue to DDNetCharacterDisplayInfo Snap (m_RampValue has a precision of one thousandth) - Added CGraph::InsertAt() to create static Graphs - Added "assets/hud" to initial created Directories - Added Settings to hide Dummy Action HUD and Player Movement HUD cl_showhud_dummy_actions, cl_showhud_player_position, cl_showhud_player_speed, cl_showhud_player_angle - Added Pointer to m_PrevExtendedDisplayInfo, for calculation of interpolated Angle in Player Rendering - Added GetDigitsIndex(int Value, float Max); to hud.cpp	2022-04-14 13:42:19 +02:00
c0d3d3v	be75b80520	Render Dummy Actions on the right side of the screen ... - Render Practice Mode next to the other player effects - Make Recording Notification Position more symetric	2022-04-14 13:40:45 +02:00
c0d3d3v	940047fb8e	Add Practice Mode Symbol next to the timer ... - Add new hud.png - expand DDNetCharacterDisplayInfo with m_IsInPracticeMode	2022-04-14 13:40:45 +02:00
c0d3d3v	ef468e8181	remove constant scaling factors and constant y offset ... - move weapons above jumps - move effects up if no jumps are available	2022-04-14 13:40:45 +02:00
c0d3d3v	6159b181e3	use QuadsSetSubsetFree also for freeze bar ... - set the proportions of the used area of the end pieces for the progress indicator as constants. - do not manipulate the position and length within the render function	2022-04-14 13:40:44 +02:00
c0d3d3v	670da66ec1	add vertical ninja bar	2022-04-14 13:40:44 +02:00
c0d3d3v	a4b6558ff6	load CNetObj_DDNetCharacterDisplayInfo into CCharacter	2022-04-14 13:40:44 +02:00