edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 10:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move index check before usage, use std::size

Browse source 
According to cppchecker's `arrayIndexThenCheck` error:

```
src\game\client\race.cpp:24:30: style: Array index 'i' is used before limits check. [arrayIndexThenCheck]
  for(int i = 0; isdigit(pStr[i]) && i < 3; i++)
                             ^
```
This commit is contained in:
Robert Müller 2022-11-13 15:53:54 +01:00
parent 98706d79d4
commit aa321cd887
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/game/client/race.cpp
View file

@ -21,7 +21,7 @@ int CRaceHelper::TimeFromSecondsStr(const char *pStr)
{
pStr++;
static const int s_aMult[3] = {100, 10, 1};
for(int i = 0; isdigit(pStr[i]) && i < 3; i++)
for(size_t i = 0; i < std::size(s_aMult) && isdigit(pStr[i]); i++)
Time += (pStr[i] - '0') * s_aMult[i];
}
return Time;