mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-11 02:28:18 +00:00
8d17670c67
6082: Fix incorrect cursor position after exiting pause/spec r=def- a=Robyt3 The cursor position was not correctly restored when exiting pause or spec, when the mouse was on the left side of the tee (x being negative). This is caused by a calculation introduced in #1637 and #1830 that tries to ensure that the mouse can still be moved if it ends up inside the minimum mouse distance (`cl_mouse_min_distance` and `cl_dyncam_min_distance`). However, this did not consider that the x position can become negative, so the x position was also incorrectly changed when exiting pause. This is fixed by reverting the changes, as this code has become obsolete and has been superseded by #2009 and #3884. The `CControls::ClampMousePos` function, which is called directly after restoring the position, already ensures that mouse is not stuck within the minimum mouse distance. Closes #2591. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [X] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
|---|---|---|
| .. | ||
| components | ||
| prediction | ||
| animstate.cpp | ||
| animstate.h | ||
| component.cpp | ||
| component.h | ||
| gameclient.cpp | ||
| gameclient.h | ||
| laser_data.cpp | ||
| laser_data.h | ||
| lineinput.cpp | ||
| lineinput.h | ||
| projectile_data.cpp | ||
| projectile_data.h | ||
| race.cpp | ||
| race.h | ||
| render.cpp | ||
| render.h | ||
| render_map.cpp | ||
| skin.h | ||
| ui.cpp | ||
| ui.h | ||
| ui_rect.cpp | ||
| ui_rect.h | ||
| ui_scrollregion.cpp | ||
| ui_scrollregion.h | ||