ddnet/.clang-tidy

# Why we disabled individual checks:
#
# clang-analyzer-optin.cplusplus.UninitializedObject
#   TODO: Occurs commonly in graphics_threaded.h
# clang-analyzer-optin.cplusplus.VirtualCall
#   Occurs very commonly all over
# clang-analyzer-optin.performance.Padding
#   Too annoying to always align for perfect padding
# clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
#   TODO: Requires C11 to fix
# modernize-use-override,
#   TODO: modernize-use-override.IgnoreDestructors not supported on ubuntu-latest yet for CI
# misc-unused-parameters
#   TODO: Many changes
# readability-static-accessed-through-instance,
#   Crashes: https://github.com/llvm/llvm-project/issues/53359
# misc-use-anonymous-namespace
#   We don't want to use anonymous namespaces instead of static functions.
# bugprone-suspicious-realloc-usage
#   We generally don't handle memory allocation failures.

Checks: >
  -*,
  bugprone-*,
  -bugprone-assignment-in-if-condition,
  -bugprone-branch-clone,
  -bugprone-easily-swappable-parameters,
  -bugprone-implicit-widening-of-multiplication-result,
  -bugprone-incorrect-roundings,
  -bugprone-integer-division,
  -bugprone-macro-parentheses,
  -bugprone-narrowing-conversions,
  -bugprone-parent-virtual-call,
  -bugprone-reserved-identifier,
  -bugprone-suspicious-include,
  -bugprone-unhandled-self-assignment,
  -bugprone-suspicious-realloc-usage,
  clang-analyzer-*,
  -clang-analyzer-optin.cplusplus.UninitializedObject,
  -clang-analyzer-optin.cplusplus.VirtualCall,
  -clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
  -clang-analyzer-optin.performance.Padding,
  -clang-analyzer-osx.cocoa.RetainCount,
  -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
  -clang-analyzer-security.insecureAPI.rand,
  cppcoreguidelines-avoid-goto,
  cppcoreguidelines-interfaces-global-init,
  cppcoreguidelines-slicing,
  cppcoreguidelines-virtual-class-destructor,
  misc-*,
  -misc-const-correctness,
  -misc-no-recursion,
  -misc-non-private-member-variables-in-classes,
  -misc-static-assert,
  -misc-unused-parameters,
  -misc-use-anonymous-namespace,
  modernize-avoid-bind,
  modernize-concat-nested-namespaces,
  modernize-deprecated-headers,
  modernize-deprecated-ios-base-aliases,
  modernize-loop-convert,
  modernize-make-unique,
  modernize-make-shared,
  modernize-redundant-void-arg,
  modernize-replace-auto-ptr,
  modernize-replace-disallow-copy-and-assign-macro,
  modernize-replace-random-shuffle,
  modernize-shrink-to-fit,
  modernize-unary-static-assert,
  modernize-use-bool-literals,
  modernize-use-emplace,
  modernize-use-equals-default,
  modernize-use-equals-delete,
  modernize-use-transparent-functors,
  modernize-use-uncaught-exceptions,
  readability-*,
  -readability-braces-around-statements,
  -readability-convert-member-functions-to-static,
  -readability-else-after-return,
  -readability-function-cognitive-complexity,
  -readability-function-size,
  -readability-identifier-length,
  -readability-identifier-naming,
  -readability-implicit-bool-conversion,
  -readability-isolate-declaration,
  -readability-magic-numbers,
  -readability-make-member-function-const,
  -readability-named-parameter,
  -readability-non-const-parameter,
  -readability-simplify-boolean-expr,
  -readability-static-accessed-through-instance,
  -readability-suspicious-call-argument,
  -readability-uppercase-literal-suffix,
  performance-*,
  -performance-no-int-to-ptr,
  portability-*,
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00			`# Why we disabled individual checks:`
			`#`
			`# clang-analyzer-optin.cplusplus.UninitializedObject`
			`# TODO: Occurs commonly in graphics_threaded.h`
			`# clang-analyzer-optin.cplusplus.VirtualCall`
			`# Occurs very commonly all over`
			`# clang-analyzer-optin.performance.Padding`
			`# Too annoying to always align for perfect padding`
			`# clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,`
			`# TODO: Requires C11 to fix`
Add override in code behind CONF_DISCORD, disable clang-tidy check 2022-05-17 21:51:51 +00:00			`# modernize-use-override,`
			`# TODO: modernize-use-override.IgnoreDestructors not supported on ubuntu-latest yet for CI`
Enable most clang-tidy misc-* checks 2020-11-05 10:47:07 +00:00			`# misc-unused-parameters`
			`# TODO: Many changes`
Add more readability checks 2022-01-22 16:34:23 +00:00			`# readability-static-accessed-through-instance,`
			`# Crashes: https://github.com/llvm/llvm-project/issues/53359`
Add suppression for clang-tidy `misc-use-anonymous-namespace` We don't want to use anonymous namespaces instead of static functions. 2023-10-05 20:11:38 +00:00			`# misc-use-anonymous-namespace`
			`# We don't want to use anonymous namespaces instead of static functions.`
Add suppression for clang-tidy `bugprone-suspicious-realloc-usage` We generally don't handle memory allocation failures. 2023-10-05 20:33:52 +00:00			`# bugprone-suspicious-realloc-usage`
			`# We generally don't handle memory allocation failures.`
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00
			`Checks: >`
			`-*,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`bugprone-*,`
More minimal clang-tidy 15 run Alternative to #6294 The only remaining problems are: /home/deen/git/ddnet/src/engine/client/backend/glsl_shader_compiler.cpp:22:26: warning: unnecessary temporary object created while calling emplace_back [modernize-use-emplace] m_vDefines.emplace_back(SGLSLCompilerDefine(DefineName, DefineValue)); ^~~~~~~~~~~~~~~~~~~~ ~ 2023-01-23 10:19:19 +00:00			`-bugprone-assignment-in-if-condition,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`-bugprone-branch-clone,`
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~ 2022-01-22 12:24:45 +00:00			`-bugprone-easily-swappable-parameters,`
			`-bugprone-implicit-widening-of-multiplication-result,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`-bugprone-incorrect-roundings,`
			`-bugprone-integer-division,`
			`-bugprone-macro-parentheses,`
			`-bugprone-narrowing-conversions,`
			`-bugprone-parent-virtual-call,`
Update .clang-tidy file to 11 2020-12-22 11:28:37 +00:00			`-bugprone-reserved-identifier,`
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~ 2022-01-22 12:24:45 +00:00			`-bugprone-suspicious-include,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`-bugprone-unhandled-self-assignment,`
Add suppression for clang-tidy `bugprone-suspicious-realloc-usage` We generally don't handle memory allocation failures. 2023-10-05 20:33:52 +00:00			`-bugprone-suspicious-realloc-usage,`
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00			`clang-analyzer-*,`
			`-clang-analyzer-optin.cplusplus.UninitializedObject,`
			`-clang-analyzer-optin.cplusplus.VirtualCall,`
Quiet clang-tidy on macOS 2022-01-23 18:04:01 +00:00			`-clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,`
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00			`-clang-analyzer-optin.performance.Padding,`
Quiet clang-tidy on macOS 2022-01-23 18:04:01 +00:00			`-clang-analyzer-osx.cocoa.RetainCount,`
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00			`-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,`
Fix any_of 2022-01-23 17:56:37 +00:00			`-clang-analyzer-security.insecureAPI.rand,`
Enable less controversial cppcoreguidelines clang-tidy checks 2022-05-26 10:13:36 +00:00			`cppcoreguidelines-avoid-goto,`
			`cppcoreguidelines-interfaces-global-init,`
			`cppcoreguidelines-slicing,`
			`cppcoreguidelines-virtual-class-destructor,`
Enable most clang-tidy misc-* checks 2020-11-05 10:47:07 +00:00			`misc-*,`
More minimal clang-tidy 15 run Alternative to #6294 The only remaining problems are: /home/deen/git/ddnet/src/engine/client/backend/glsl_shader_compiler.cpp:22:26: warning: unnecessary temporary object created while calling emplace_back [modernize-use-emplace] m_vDefines.emplace_back(SGLSLCompilerDefine(DefineName, DefineValue)); ^~~~~~~~~~~~~~~~~~~~ ~ 2023-01-23 10:19:19 +00:00			`-misc-const-correctness,`
Update .clang-tidy file to 11 2020-12-22 11:28:37 +00:00			`-misc-no-recursion,`
Enable most clang-tidy misc-* checks 2020-11-05 10:47:07 +00:00			`-misc-non-private-member-variables-in-classes,`
			`-misc-static-assert,`
			`-misc-unused-parameters,`
Add suppression for clang-tidy `misc-use-anonymous-namespace` We don't want to use anonymous namespaces instead of static functions. 2023-10-05 20:11:38 +00:00			`-misc-use-anonymous-namespace,`
Add some more modernize-* checks 2022-02-14 23:23:19 +00:00			`modernize-avoid-bind,`
			`modernize-concat-nested-namespaces,`
Add modernize-deprecated-headers 2022-02-14 23:22:52 +00:00			`modernize-deprecated-headers,`
Add some more modernize-* checks 2022-02-14 23:23:19 +00:00			`modernize-deprecated-ios-base-aliases,`
Enable modernize-loop-convert clang-tidy check and run clang-format afterwards https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html 2020-10-26 13:11:11 +00:00			`modernize-loop-convert,`
Enable modernize-make-unique clang-tidy check 2022-02-14 23:05:46 +00:00			`modernize-make-unique,`
Add more clang-tidy modernize-* checks 2022-02-14 23:09:48 +00:00			`modernize-make-shared,`
			`modernize-redundant-void-arg,`
			`modernize-replace-auto-ptr,`
			`modernize-replace-disallow-copy-and-assign-macro,`
			`modernize-replace-random-shuffle,`
			`modernize-shrink-to-fit,`
Add modernize-unary-static-assert 2022-02-14 23:18:05 +00:00			`modernize-unary-static-assert,`
Add modernize-use-bool-literals 2022-02-14 23:12:52 +00:00			`modernize-use-bool-literals,`
Add modernize-use-emplace 2022-02-14 23:15:06 +00:00			`modernize-use-emplace,`
Add modernize-use-equals-default 2022-02-14 23:17:57 +00:00			`modernize-use-equals-default,`
Add modernize-use-equals-delete 2022-02-14 23:19:41 +00:00			`modernize-use-equals-delete,`
Add some more modernize-* checks 2022-02-14 23:23:19 +00:00			`modernize-use-transparent-functors,`
			`modernize-use-uncaught-exceptions,`
Turn around readability: use all, exclude some 2022-01-22 21:50:49 +00:00			`readability-*,`
			`-readability-braces-around-statements,`
Fix any_of 2022-01-23 17:56:37 +00:00			`-readability-convert-member-functions-to-static,`
			`-readability-else-after-return,`
Turn around readability: use all, exclude some 2022-01-22 21:50:49 +00:00			`-readability-function-cognitive-complexity,`
			`-readability-function-size,`
			`-readability-identifier-length,`
			`-readability-identifier-naming,`
			`-readability-implicit-bool-conversion,`
			`-readability-isolate-declaration,`
			`-readability-magic-numbers,`
			`-readability-make-member-function-const,`
			`-readability-named-parameter,`
			`-readability-non-const-parameter,`
More minimal clang-tidy 15 run Alternative to #6294 The only remaining problems are: /home/deen/git/ddnet/src/engine/client/backend/glsl_shader_compiler.cpp:22:26: warning: unnecessary temporary object created while calling emplace_back [modernize-use-emplace] m_vDefines.emplace_back(SGLSLCompilerDefine(DefineName, DefineValue)); ^~~~~~~~~~~~~~~~~~~~ ~ 2023-01-23 10:19:19 +00:00			`-readability-simplify-boolean-expr,`
Add more readability checks 2022-01-22 16:34:23 +00:00			`-readability-static-accessed-through-instance,`
Turn around readability: use all, exclude some 2022-01-22 21:50:49 +00:00			`-readability-suspicious-call-argument,`
			`-readability-uppercase-literal-suffix,`
Enable clang-tidy performance-* checks 2020-11-05 10:34:20 +00:00			`performance-*,`
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~ 2022-01-22 12:24:45 +00:00			`-performance-no-int-to-ptr,`
Add portability-* clang-tidy checks 2022-05-26 10:18:56 +00:00			`portability-*,`