ddnet/.clang-tidy

# Why we disabled individual checks:
#
# clang-analyzer-optin.cplusplus.UninitializedObject
#   TODO: Occurs commonly in graphics_threaded.h
# clang-analyzer-optin.cplusplus.VirtualCall
#   Occurs very commonly all over
# clang-analyzer-optin.performance.Padding
#   Too annoying to always align for perfect padding
# clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
#   TODO: Requires C11 to fix
# misc-unused-parameters
#   TODO: Many changes
# readability-static-accessed-through-instance,
#   Crashes: https://github.com/llvm/llvm-project/issues/53359

Checks: >
  -*,
  bugprone-*,
  -bugprone-branch-clone,
  -bugprone-easily-swappable-parameters,
  -bugprone-implicit-widening-of-multiplication-result,
  -bugprone-incorrect-roundings,
  -bugprone-integer-division,
  -bugprone-macro-parentheses,
  -bugprone-narrowing-conversions,
  -bugprone-parent-virtual-call,
  -bugprone-reserved-identifier,
  -bugprone-suspicious-include,
  -bugprone-unhandled-self-assignment,
  clang-analyzer-*,
  -clang-analyzer-optin.cplusplus.UninitializedObject,
  -clang-analyzer-optin.cplusplus.VirtualCall,
  -clang-analyzer-optin.performance.Padding,
  -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
  misc-*,
  -misc-no-recursion,
  -misc-non-private-member-variables-in-classes,
  -misc-static-assert,
  -misc-unused-parameters,
  modernize-loop-convert,
  readability-avoid-const-params-in-decls,
  readability-const-return-type,
  readability-container-data-pointer,
  readability-qualified-auto,
  readability-container-size-empty,
  readability-delete-null-pointer,
  readability-inconsistent-declaration-parameter-name,
  readability-misleading-indentation,
  readability-misplaced-array-index,
  readability-redundant-access-specifiers,
  readability-redundant-control-flow,
  readability-redundant-declaration,
  readability-redundant-function-ptr-dereference,
  readability-redundant-member-init,
  readability-redundant-preprocessor,
  readability-redundant-smartptr-get,
  readability-redundant-string-cstr,
  readability-redundant-string-init,
  readability-simplify-boolean-expr,
  readability-simplify-subscript-expr,
  -readability-static-accessed-through-instance,
  readability-static-definition-in-anonymous-namespace,
  readability-string-compare,
  readability-uniqueptr-delete-release,
  readability-use-anyofallof,
  performance-*,
  -performance-no-int-to-ptr,
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00			`# Why we disabled individual checks:`
			`#`
			`# clang-analyzer-optin.cplusplus.UninitializedObject`
			`# TODO: Occurs commonly in graphics_threaded.h`
			`# clang-analyzer-optin.cplusplus.VirtualCall`
			`# Occurs very commonly all over`
			`# clang-analyzer-optin.performance.Padding`
			`# Too annoying to always align for perfect padding`
			`# clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,`
			`# TODO: Requires C11 to fix`
Enable most clang-tidy misc-* checks 2020-11-05 10:47:07 +00:00			`# misc-unused-parameters`
			`# TODO: Many changes`
Add more readability checks 2022-01-22 16:34:23 +00:00			`# readability-static-accessed-through-instance,`
			`# Crashes: https://github.com/llvm/llvm-project/issues/53359`
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00
			`Checks: >`
			`-*,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`bugprone-*,`
			`-bugprone-branch-clone,`
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~ 2022-01-22 12:24:45 +00:00			`-bugprone-easily-swappable-parameters,`
			`-bugprone-implicit-widening-of-multiplication-result,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`-bugprone-incorrect-roundings,`
			`-bugprone-integer-division,`
			`-bugprone-macro-parentheses,`
			`-bugprone-narrowing-conversions,`
			`-bugprone-parent-virtual-call,`
Update .clang-tidy file to 11 2020-12-22 11:28:37 +00:00			`-bugprone-reserved-identifier,`
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~ 2022-01-22 12:24:45 +00:00			`-bugprone-suspicious-include,`
Add most bugprone checks 2020-11-04 18:03:10 +00:00			`-bugprone-unhandled-self-assignment,`
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy. 2020-10-12 10:53:11 +00:00			`clang-analyzer-*,`
			`-clang-analyzer-optin.cplusplus.UninitializedObject,`
			`-clang-analyzer-optin.cplusplus.VirtualCall,`
			`-clang-analyzer-optin.performance.Padding,`
			`-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,`
Enable most clang-tidy misc-* checks 2020-11-05 10:47:07 +00:00			`misc-*,`
Update .clang-tidy file to 11 2020-12-22 11:28:37 +00:00			`-misc-no-recursion,`
Enable most clang-tidy misc-* checks 2020-11-05 10:47:07 +00:00			`-misc-non-private-member-variables-in-classes,`
			`-misc-static-assert,`
			`-misc-unused-parameters,`
Enable modernize-loop-convert clang-tidy check and run clang-format afterwards https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html 2020-10-26 13:11:11 +00:00			`modernize-loop-convert,`
Add readability-avoid-const-params-in-decls 2022-01-22 12:44:22 +00:00			`readability-avoid-const-params-in-decls,`
Enable readability-const-return-type, readability-container-data-pointer, readability-delete-null-pointer 2022-01-22 12:47:37 +00:00			`readability-const-return-type,`
			`readability-container-data-pointer,`
Enable readability-qualified-auto clang-tidy check https://clang.llvm.org/extra/clang-tidy/checks/readability-qualified-auto.html 2020-10-26 10:28:18 +00:00			`readability-qualified-auto,`
Add readability-container-size-empty 2022-01-22 12:54:25 +00:00			`readability-container-size-empty,`
Enable readability-const-return-type, readability-container-data-pointer, readability-delete-null-pointer 2022-01-22 12:47:37 +00:00			`readability-delete-null-pointer,`
Enable readability-inconsistent-declaration-parameter-name 2022-01-22 13:12:59 +00:00			`readability-inconsistent-declaration-parameter-name,`
Add some further readability checks, mostly redundancy /media/ddnet/src/engine/server/databases/sqlite.cpp:232:55: warning: the address of ‘char* sqlite3_expanded_sql(sqlite3_stmt*)’ will never be NULL [-Waddress] 232 \| if(m_pStmt != nullptr && sqlite3_expanded_sql != nullptr) \| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ 2022-01-22 13:27:29 +00:00			`readability-misleading-indentation,`
			`readability-misplaced-array-index,`
			`readability-redundant-access-specifiers,`
			`readability-redundant-control-flow,`
			`readability-redundant-declaration,`
			`readability-redundant-function-ptr-dereference,`
			`readability-redundant-member-init,`
			`readability-redundant-preprocessor,`
			`readability-redundant-smartptr-get,`
Add more readability checks 2022-01-22 16:34:23 +00:00			`readability-redundant-string-cstr,`
			`readability-redundant-string-init,`
			`readability-simplify-boolean-expr,`
			`readability-simplify-subscript-expr,`
			`-readability-static-accessed-through-instance,`
			`readability-static-definition-in-anonymous-namespace,`
			`readability-string-compare,`
			`readability-uniqueptr-delete-release,`
			`readability-use-anyofallof,`
Enable clang-tidy performance-* checks 2020-11-05 10:34:20 +00:00			`performance-*,`
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~ 2022-01-22 12:24:45 +00:00			`-performance-no-int-to-ptr,`