edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-09-19 17:14:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
ddnet/.clang-tidy

64 lines
2.2 KiB
Plaintext
Raw Normal View History

Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy.
2020-10-12 10:53:11 +00:00
# Why we disabled individual checks:
#
# clang-analyzer-optin.cplusplus.UninitializedObject
# TODO: Occurs commonly in graphics_threaded.h
# clang-analyzer-optin.cplusplus.VirtualCall
# Occurs very commonly all over
# clang-analyzer-optin.performance.Padding
# Too annoying to always align for perfect padding
# clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
# TODO: Requires C11 to fix
Enable most clang-tidy misc-* checks
2020-11-05 10:47:07 +00:00
# misc-unused-parameters
# TODO: Many changes
Add more readability checks
2022-01-22 16:34:23 +00:00
# readability-static-accessed-through-instance,
# Crashes: https://github.com/llvm/llvm-project/issues/53359
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy.
2020-10-12 10:53:11 +00:00
Checks: >
-*,
Add most bugprone checks
2020-11-04 18:03:10 +00:00
bugprone-*,
-bugprone-branch-clone,
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~
2022-01-22 12:24:45 +00:00
-bugprone-easily-swappable-parameters,
-bugprone-implicit-widening-of-multiplication-result,
Add most bugprone checks
2020-11-04 18:03:10 +00:00
-bugprone-incorrect-roundings,
-bugprone-integer-division,
-bugprone-macro-parentheses,
-bugprone-narrowing-conversions,
-bugprone-parent-virtual-call,
Update .clang-tidy file to 11
2020-12-22 11:28:37 +00:00
-bugprone-reserved-identifier,
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~
2022-01-22 12:24:45 +00:00
-bugprone-suspicious-include,
Add most bugprone checks
2020-11-04 18:03:10 +00:00
-bugprone-unhandled-self-assignment,
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy.
2020-10-12 10:53:11 +00:00
clang-analyzer-*,
-clang-analyzer-optin.cplusplus.UninitializedObject,
-clang-analyzer-optin.cplusplus.VirtualCall,
Quiet clang-tidy on macOS
2022-01-23 18:04:01 +00:00
-clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy.
2020-10-12 10:53:11 +00:00
-clang-analyzer-optin.performance.Padding,
Quiet clang-tidy on macOS
2022-01-23 18:04:01 +00:00
-clang-analyzer-osx.cocoa.RetainCount,
Add clang-tidy to CI and enable clang-analyzer checks The actual work will be fixing those or at least NOLINT(clang-analyzer-optin.cplusplus.VirtualCall) them so we can enable this. Disable checks that we don't want. Exclude external directory from clang-tidy.
2020-10-12 10:53:11 +00:00
-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
Fix any_of
2022-01-23 17:56:37 +00:00
-clang-analyzer-security.insecureAPI.rand,
Enable most clang-tidy misc-* checks
2020-11-05 10:47:07 +00:00
misc-*,
Update .clang-tidy file to 11
2020-12-22 11:28:37 +00:00
-misc-no-recursion,
Enable most clang-tidy misc-* checks
2020-11-05 10:47:07 +00:00
-misc-non-private-member-variables-in-classes,
-misc-static-assert,
-misc-unused-parameters,
Enable modernize-loop-convert clang-tidy check and run clang-format afterwards https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html
2020-10-26 13:11:11 +00:00
modernize-loop-convert,
Enable modernize-make-unique clang-tidy check
2022-02-14 23:05:46 +00:00
modernize-make-unique,
Turn around readability: use all, exclude some
2022-01-22 21:50:49 +00:00
readability-*,
-readability-braces-around-statements,
Fix any_of
2022-01-23 17:56:37 +00:00
-readability-convert-member-functions-to-static,
-readability-else-after-return,
Turn around readability: use all, exclude some
2022-01-22 21:50:49 +00:00
-readability-function-cognitive-complexity,
-readability-function-size,
-readability-identifier-length,
-readability-identifier-naming,
-readability-implicit-bool-conversion,
-readability-isolate-declaration,
-readability-magic-numbers,
-readability-make-member-function-const,
-readability-named-parameter,
-readability-non-const-parameter,
Add more readability checks
2022-01-22 16:34:23 +00:00
-readability-static-accessed-through-instance,
Turn around readability: use all, exclude some
2022-01-22 21:50:49 +00:00
-readability-suspicious-call-argument,
-readability-uppercase-literal-suffix,
Enable clang-tidy performance-* checks
2020-11-05 10:34:20 +00:00
performance-*,
Disable or fix some spammy new clang-tidy 13 warnings src/engine/client/backend/opengles/opengles_sl_program.cpp:10:11: warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include] ^ src/engine/graphics.h:330:67: warning: 2 adjacent parameters of 'CFreeformItem' of similar type ('float') are easily swapped by mistake [bugprone-easily-swappable-parameters] CFreeformItem(float x0, float y0, float x1, float y1, float x2, float y2, float x3, float y3) : ^~~~~~~~~~~~~~~~~~ src/game/editor/layer_tiles.cpp:1802:14: warning: result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t' [bugprone-implicit-widening-of-multiplication-result] mem_zero(&m_pSwitchTile[y * m_Width], o * sizeof(CSwitchTile)); ^ src/game/server/entities/plasma.cpp:100:152: warning: operator has equivalent nested operands [misc-redundant-expression] if(SnapPlayer && SnapPlayer->GetTeam() != TEAM_SPECTATORS && !SnapPlayer->IsPaused() && SnapChar && SnapChar && SnapChar->Team() != m_ResponsibleTeam && SnapPlayer->m_ShowOthers != 1) ~~~~~~~~ ~~~~~~~~ ^ src/game/editor/editor.cpp:4295:38: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if(m_FilePreviewImageInfo.m_Width > Preview.w) ^ ~~~~~~~~~
2022-01-22 12:24:45 +00:00
-performance-no-int-to-ptr,
Reference in a new issue Copy permalink