Add override in code behind CONF_DISCORD, disable clang-tidy check

.clang-tidy

@@ -8,6 +8,8 @@
 #   Too annoying to always align for perfect padding
 # clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
 #   TODO: Requires C11 to fix
+# modernize-use-override,
+#   TODO: modernize-use-override.IgnoreDestructors not supported on ubuntu-latest yet for CI
 # misc-unused-parameters
 #   TODO: Many changes
 # readability-static-accessed-through-instance,
@@ -57,7 +59,6 @@ Checks: >
   modernize-use-emplace,
   modernize-use-equals-default,
   modernize-use-equals-delete,
-  modernize-use-override,
   modernize-use-transparent-functors,
   modernize-use-uncaught-exceptions,
   readability-*,
@@ -79,7 +80,3 @@ Checks: >
   -readability-uppercase-literal-suffix,
   performance-*,
   -performance-no-int-to-ptr,
-
-CheckOptions:
-  - key:             modernize-use-override.IgnoreDestructors
-    value:           true

src/engine/client/discord.cpp

@@ -56,15 +56,15 @@ public:
 		m_pActivityManager = m_pCore->get_activity_manager(m_pCore);
 		return false;
 	}
-	void Update()
+	void Update() override
 	{
 		m_pCore->run_callbacks(m_pCore);
 	}
-	void ClearGameInfo()
+	void ClearGameInfo() override
 	{
 		m_pActivityManager->clear_activity(m_pActivityManager, 0, 0);
 	}
-	void SetGameInfo(NETADDR ServerAddr, const char *pMapName)
+	void SetGameInfo(NETADDR ServerAddr, const char *pMapName) override
 	{
 		DiscordActivity Activity;
 		mem_zero(&Activity, sizeof(DiscordActivity));

src/test/aio.cpp

@@ -12,7 +12,7 @@ protected:
 	CTestInfo m_Info;
 	bool Delete;
 
-	void SetUp()
+	void SetUp() override
 	{
 		IOHANDLE File = io_open(m_Info.m_aFilename, IOFLAG_WRITE);
 		ASSERT_TRUE(File);

src/test/jobs.cpp

@@ -32,7 +32,7 @@ protected:
 class CJob : public IJob
 {
 	std::function<void()> m_JobFunction;
-	void Run() { m_JobFunction(); }
+	void Run() override { m_JobFunction(); }
 
 public:
 	CJob(std::function<void()> &&JobFunction) :

src/test/score.cpp

@@ -202,7 +202,7 @@ TEST_P(SingleScore, TimesDoesntExist)
 
 struct TeamScore : public Score
 {
-	void SetUp()
+	void SetUp() override
 	{
 		CSqlTeamScoreData teamScoreData;
 		str_copy(teamScoreData.m_aMap, "Kobra 3", sizeof(teamScoreData.m_aMap));