mirror of
https://github.com/ddnet/ddnet.git
synced 2024-09-22 02:24:17 +00:00
502711541e
3804: HiDPI-aware Resolution List r=def- a=TsFreddie This is a version of https://github.com/teeworlds/teeworlds/pull/2827 Which gives you a resolution list that allows you to select appropriate window size (which is saved in config and used to initialize videos), while showing the canvas size (which is the drawing resolution), at least on MacOS. This also fixes incorrect clips that happens without HiDPI enabled, because `Graphics()->ScreenWidth()` (in canvas size) was reported incorrectly before, which is now fixed. Also, I noticed that `m_DesktopScreenWidth` and `m_DesktopScreenHeight` (in window size in MacOS) is used incorrectly or differently from what it was used during initialization: * During initialization, DesktopScreenWidth is the "screen width of your desktop", but it was used as the "game window size on your desktop" when checking whether to resize window. I added a separate window size calculation to use during resize. Also, god, I hope SDL's different sizes and stuff is reported consistently at least in Wayland or X, so please test. I know in Windows they are always in pixel/canvas size so it might not be a huge issue there. ## Checklist - [x] Tested the change ~~ingame~~ on MacOS - [ ] Provided screenshots if it is a visual change - [x] Tested in combination with possibly related configuration options (again, on MacOS, with both HiDPI and non-HiDPI settings) - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Freddie Wang <tsfreddiewang@gmail.com> |
||
|---|---|---|
| .. | ||
| background.cpp | ||
| background.h | ||
| binds.cpp | ||
| binds.h | ||
| broadcast.cpp | ||
| broadcast.h | ||
| camera.cpp | ||
| camera.h | ||
| chat.cpp | ||
| chat.h | ||
| console.cpp | ||
| console.h | ||
| controls.cpp | ||
| controls.h | ||
| countryflags.cpp | ||
| countryflags.h | ||
| damageind.cpp | ||
| damageind.h | ||
| debughud.cpp | ||
| debughud.h | ||
| effects.cpp | ||
| effects.h | ||
| emoticon.cpp | ||
| emoticon.h | ||
| flow.cpp | ||
| flow.h | ||
| ghost.cpp | ||
| ghost.h | ||
| hud.cpp | ||
| hud.h | ||
| items.cpp | ||
| items.h | ||
| killmessages.cpp | ||
| killmessages.h | ||
| mapimages.cpp | ||
| mapimages.h | ||
| maplayers.cpp | ||
| maplayers.h | ||
| mapsounds.cpp | ||
| mapsounds.h | ||
| menu_background.cpp | ||
| menu_background.h | ||
| menus.cpp | ||
| menus.h | ||
| menus_browser.cpp | ||
| menus_demo.cpp | ||
| menus_ingame.cpp | ||
| menus_settings.cpp | ||
| menus_settings_assets.cpp | ||
| menus_start.cpp | ||
| motd.cpp | ||
| motd.h | ||
| nameplates.cpp | ||
| nameplates.h | ||
| particles.cpp | ||
| particles.h | ||
| players.cpp | ||
| players.h | ||
| race_demo.cpp | ||
| race_demo.h | ||
| scoreboard.cpp | ||
| scoreboard.h | ||
| skins.cpp | ||
| skins.h | ||
| sounds.cpp | ||
| sounds.h | ||
| spectator.cpp | ||
| spectator.h | ||
| statboard.cpp | ||
| statboard.h | ||
| voting.cpp | ||
| voting.h | ||