mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-10 01:58:19 +00:00
71b3c8a35b
We assume that `char` is `signed` in various places in the code. In particular, the `Str.StrToInts` test will fail when `char` is not `signed` and names containing special characters will be displayed incorrectly on servers. Therefore, the compiler flag `-fsigned-char` is set unconditionally instead of only for ARM and ARM64, as we expect `char` to be `signed` on all architectures. A static assertion is added to ensure at compile time that `char` is `signed` independently from the flag added in `CMakeLists.txt`. This is necessary at least for ARM, ARM64, PPC, PPC64, and PPC64LE. According to some sources, `char` may also be `unsigned` by default when compiling for Android, although this could not be confirmed with the current Android NDK using Clang. For the PowerPC architectures, Compiler Explorer can be used to confirm that `char` is not `signed` by default by checking whether the static assertion compiles (see https://godbolt.org/z/9rn5Mrf59) and that the assembly is different with the `-fsigned-char` flag (see https://godbolt.org/z/138zTj3Wa). Closes #8386. |
||
|---|---|---|
| .. | ||
| android | ||
| antibot | ||
| base | ||
| engine | ||
| game | ||
| macos | ||
| masterping | ||
| mastersrv | ||
| rust-bridge | ||
| steam | ||
| test | ||
| tools | ||