mirror of
https://github.com/ddnet/ddnet.git
synced 2024-10-21 00:08:19 +00:00
6a53d72b35
6721: Improve selection popups and dropdown menus, add dropdown menus to select screen and active controller r=def- a=Robyt3 Screenshots: - Controls settings: - Before: ![controls old](https://github.com/ddnet/ddnet/assets/23437060/8907c38a-d483-4766-84ad-49464b9760a0) - After: ![controls new](https://github.com/ddnet/ddnet/assets/23437060/f021e961-ce90-4557-aef0-a1e1a4bc7ca4) - Graphics settings (collapsed): - Before: ![graphics_collapsed old](https://github.com/ddnet/ddnet/assets/23437060/d895c8d8-a72f-4da2-aa57-93d5f08be648) - After: ![graphics_collapsed new](https://github.com/ddnet/ddnet/assets/23437060/e594a599-1210-4ba0-87f2-b2a824043dc4) - Graphics settings (expanded): - Before: ![graphics_expanded old](https://github.com/ddnet/ddnet/assets/23437060/cce1d8cb-4dff-4d43-a9f0-af2dbfeff27d) - After: ![graphics_expanded_1 new](https://github.com/ddnet/ddnet/assets/23437060/c99c24cb-3398-4a80-9b99-3281ed62f6a7) ![graphics_expanded_2 new](https://github.com/ddnet/ddnet/assets/23437060/83fc2522-0da6-40d8-ad2b-3e3159b74308) ![graphics_expanded_3 new](https://github.com/ddnet/ddnet/assets/23437060/b00b30c4-411b-43a0-97f0-ecd47ebea516) - The maximum dropdown menu height is limited to 40% of the screen height. The content will begin to scroll if this is exceeded: ![scrolling](https://github.com/ddnet/ddnet/assets/23437060/ac576819-f24f-4fed-82cd-a05d87f9ad71) - If there is not enough space below the dropdown button to open the dropdown menu popup, then the popup opens to the top instead: ![alignment](https://github.com/ddnet/ddnet/assets/23437060/2f61ea30-996d-4def-8f5d-300b5008c666) ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [X] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
---|---|---|
.. | ||
background.cpp | ||
background.h | ||
binds.cpp | ||
binds.h | ||
broadcast.cpp | ||
broadcast.h | ||
camera.cpp | ||
camera.h | ||
chat.cpp | ||
chat.h | ||
console.cpp | ||
console.h | ||
controls.cpp | ||
controls.h | ||
countryflags.cpp | ||
countryflags.h | ||
damageind.cpp | ||
damageind.h | ||
debughud.cpp | ||
debughud.h | ||
effects.cpp | ||
effects.h | ||
emoticon.cpp | ||
emoticon.h | ||
flow.cpp | ||
flow.h | ||
freezebars.cpp | ||
freezebars.h | ||
ghost.cpp | ||
ghost.h | ||
hud.cpp | ||
hud.h | ||
items.cpp | ||
items.h | ||
killmessages.cpp | ||
killmessages.h | ||
mapimages.cpp | ||
mapimages.h | ||
maplayers.cpp | ||
maplayers.h | ||
mapsounds.cpp | ||
mapsounds.h | ||
menu_background.cpp | ||
menu_background.h | ||
menus.cpp | ||
menus.h | ||
menus_browser.cpp | ||
menus_demo.cpp | ||
menus_ingame.cpp | ||
menus_settings.cpp | ||
menus_settings_assets.cpp | ||
menus_start.cpp | ||
motd.cpp | ||
motd.h | ||
nameplates.cpp | ||
nameplates.h | ||
particles.cpp | ||
particles.h | ||
players.cpp | ||
players.h | ||
race_demo.cpp | ||
race_demo.h | ||
scoreboard.cpp | ||
scoreboard.h | ||
skins.cpp | ||
skins.h | ||
sounds.cpp | ||
sounds.h | ||
spectator.cpp | ||
spectator.h | ||
statboard.cpp | ||
statboard.h | ||
tooltips.cpp | ||
tooltips.h | ||
voting.cpp | ||
voting.h |