edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-11 02:28:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
ddnet/src/engine/shared
History
bors[bot] 719e3e4385
Merge #5264 #5266 
5264: Prevent users from setting port 1-1023 r=Jupeyy a=def-

Following user report that they set cl_port 1 and it didn't work

<!-- What is the motivation for the changes of this pull request -->

## Checklist

- [x] Tested the change ingame
- [ ] Provided screenshots if it is a visual change
- [ ] Tested in combination with possibly related configuration options
- [ ] Written a unit test if it works standalone, system.c especially
- [ ] Considered possible null pointers and out of bounds array indexing
- [ ] Changed no physics that affect existing maps
- [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional)


5266: Use std::make_unique (fixes #5166) r=Jupeyy a=def-

No idea why clang-tidy's modernize-... didn't work

<!-- What is the motivation for the changes of this pull request -->

## Checklist

- [ ] Tested the change ingame
- [ ] Provided screenshots if it is a visual change
- [ ] Tested in combination with possibly related configuration options
- [ ] Written a unit test if it works standalone, system.c especially
- [ ] Considered possible null pointers and out of bounds array indexing
- [ ] Changed no physics that affect existing maps
- [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional)


Co-authored-by: def <dennis@felsin9.de>
2022-05-28 16:01:32 +00:00
..
assertion_logger.cpp Use std::make_unique (fixes #5166) 2022-05-28 14:46:55 +02:00
assertion_logger.h Unify logging infrastructure between IConsole and dbg_msg 2022-04-29 15:21:26 +02:00
compression.cpp Use std::size instead of sizeof(a) / sizeof(a[0]) 2022-03-30 18:55:04 +02:00
compression.h Add size checks to CVariableInt::Pack and ::Unpack 2022-03-05 20:49:55 +01:00
config.cpp Sync the config file replacement to disk before renaming 2022-02-01 02:33:20 +01:00
config.h Mark virtual function as override using a script: 2022-05-17 23:47:32 +02:00
config_variables.h Prevent users from setting port 1-1023 2022-05-28 13:42:28 +02:00
console.cpp Extract CConsole::TraverseChain, fix toggle with multiple chains 2022-05-20 19:41:31 +02:00
console.h Extract CConsole::TraverseChain, fix toggle with multiple chains 2022-05-20 19:41:31 +02:00
csv.cpp Add a simple CSV writer for Python's "excel" csv dialect 2020-06-23 09:11:59 +02:00
csv.h Fix some variable name's style 2020-11-08 17:15:48 +01:00
datafile.cpp Remove some useless conditions around free 2022-03-01 23:19:49 +01:00
datafile.h Fix duplicate uuid index in maps edited by tools 2021-05-03 12:02:18 +02:00
demo.cpp Fix some uninitialized variables, found with valgrind 2022-05-22 12:18:49 +02:00
demo.h Switch to nanoseconds 2022-05-18 18:05:41 +02:00
econ.cpp Fix some uninitialized variables, found with valgrind 2022-05-22 12:18:49 +02:00
econ.h Fix some uninitialized variables, found with valgrind 2022-05-22 12:18:49 +02:00
engine.cpp Unify logging infrastructure between IConsole and dbg_msg 2022-04-29 15:21:26 +02:00
fifo.cpp Fix clang-format 2022-02-15 00:32:04 +01:00
fifo.h Make use of IO_MAX_PATH_LENGTH 2021-09-13 12:14:50 +02:00
filecollection.cpp Add more readability checks 2022-01-22 17:45:25 +01:00
filecollection.h Make use of IO_MAX_PATH_LENGTH 2021-09-13 12:14:50 +02:00
global_uuid_manager.cpp Move teehistorian UUIDs into engine 2018-01-11 16:01:13 +01:00
http.cpp Make sure we don't accidentally initialize libcurl in a thread 2022-05-23 17:21:27 +02:00
http.h Use std::make_unique (fixes #5166) 2022-05-28 14:46:55 +02:00
huffman.cpp Move declaration of loop variable 2022-04-02 13:35:24 +02:00
huffman.h Mark CHuffman::Compress and ::Decompress as const 2022-04-02 13:35:24 +02:00
image_manipulation.cpp Remove alpha threshold from map_optmize 2022-05-28 09:15:08 +02:00
image_manipulation.h Remove alpha threshold from map_optmize 2022-05-28 09:15:08 +02:00
jobs.cpp Allow more precise Destroy call to Job pool 2022-03-12 13:52:13 +01:00
jobs.h Allow more precise Destroy call to Job pool 2022-03-12 13:52:13 +01:00
json.cpp Run clang-format 2020-09-26 21:50:15 +02:00
json.h Run clang-format 2020-09-26 21:50:15 +02:00
kernel.cpp Enable clang-tidy's modernize-use-override (fixes #5139) 2022-05-17 20:33:29 +02:00
linereader.cpp Add modernize-use-bool-literals 2022-02-15 00:12:52 +01:00
linereader.h Don't access out of bounds in linereader (fixes #4308) 2021-11-07 01:10:34 +01:00
map.cpp Fix clang-format 2022-02-15 00:32:04 +01:00
map.h Mark virtual function as override using a script: 2022-05-17 23:47:32 +02:00
masterserver.cpp Add HTTP masterserver registering and HTTP masterserver 2022-05-20 08:58:32 +02:00
masterserver.h Add HTTP masterserver registering and HTTP masterserver 2022-05-20 08:58:32 +02:00
memheap.cpp Add CHeap::StoreString method 2022-05-06 23:21:26 +02:00
memheap.h Add CHeap::StoreString method 2022-05-06 23:21:26 +02:00
netban.cpp Enable -Wshadow=local 2022-03-20 13:24:34 +01:00
netban.h Enable readability-inconsistent-declaration-parameter-name 2022-01-22 14:12:59 +01:00
network.cpp Added external linkage instead of static const 2022-04-03 01:12:27 +02:00
network.h Add HTTP masterserver registering and HTTP masterserver 2022-05-20 08:58:32 +02:00
network_client.cpp Use STUN to determine UDP connectivity and show diagnostics 2022-05-18 09:21:31 +02:00
network_conn.cpp Add modernize-use-bool-literals 2022-02-15 00:12:52 +01:00
network_console.cpp Remove unused Flags argument in network code 2022-03-04 19:33:06 +01:00
network_console_conn.cpp Move NETSOCKET behind a pointer so it can grow 2022-03-04 19:33:06 +01:00
network_server.cpp Add HTTP masterserver registering and HTTP masterserver 2022-05-20 08:58:32 +02:00
network_stun.cpp Fix some uninitialized variables, found with valgrind 2022-05-22 12:18:49 +02:00
packer.cpp Add size checks to CVariableInt::Pack and ::Unpack 2022-03-05 20:49:55 +01:00
packer.h Run clang-format 2020-09-26 21:50:15 +02:00
protocol.h make spectators team independent 2022-03-14 13:25:47 +01:00
protocol_ex.cpp Run clang-format 2020-09-26 21:50:15 +02:00
protocol_ex.h Only use configured prediction margin on servers with predictable/synced weapon input 2022-01-11 01:30:05 +01:00
protocol_ex_msgs.h Add some checksum functions to the client 2022-01-31 21:31:26 +01:00
ringbuffer.cpp Add modernize-use-bool-literals 2022-02-15 00:12:52 +01:00
ringbuffer.h Fix some variable name's style 2020-11-08 17:15:48 +01:00
serverinfo.cpp Remove a couple of game/-includes from the engine code 2022-05-13 09:04:39 +02:00
serverinfo.h Support 128 players in serverbrowser 2022-01-02 13:41:59 +01:00
snapshot.cpp Add size checks to CVariableInt::Pack and ::Unpack 2022-03-05 20:49:55 +01:00
snapshot.h Remove unnecessary trailing semicolons after method declarations 2022-03-08 20:01:26 +01:00
storage.cpp Enable clang-tidy's modernize-use-override (fixes #5139) 2022-05-17 20:33:29 +02:00
stun.cpp Use STUN to determine UDP connectivity and show diagnostics 2022-05-18 09:21:31 +02:00
stun.h Add bare-bones STUN protocol support 2022-05-18 09:20:54 +02:00
teehistorian_ex.cpp Run clang-format 2020-09-26 21:50:15 +02:00
teehistorian_ex.h Run clang-format 2020-09-26 21:50:15 +02:00
teehistorian_ex_chunks.h Record player switch in teehistorian 2022-05-21 21:37:17 +02:00
uuid_manager.cpp Use std::vector<CName> instead of array, adjust variable name 2022-05-27 16:31:18 +02:00
uuid_manager.h Use std::vector<CName> instead of array, adjust variable name 2022-05-27 16:31:18 +02:00
video.cpp uint64 -> uint64_t, int64 -> int64_t 2021-06-24 17:19:17 +02:00
video.h Multithreaded video rendering 2022-03-20 18:03:33 +01:00
websockets.cpp Minor clang-tidy fix with -DWEBSOCKETS=ON -DUPNP=ON 2022-05-19 18:57:49 +02:00
websockets.h Make sure headers compile standalone 2020-09-26 21:50:27 +02:00