mirror of
https://github.com/ddnet/ddnet.git
synced 2024-09-21 18:14:19 +00:00
17c06423d2
6711: Improve color picker popup in settings (use new popup system, add alpha support, support mouse locking) r=def- a=Robyt3 Use the popup system ported from the editor to reimplement the color picker popup. - Before: ![screenshot_2023-06-05_21-57-46](https://github.com/ddnet/ddnet/assets/23437060/52d6adfa-7d62-4323-b6df-8d18a26b6cc6) - After: ![screenshot_2023-06-05_21-57-26](https://github.com/ddnet/ddnet/assets/23437060/773115db-178c-48ab-a750-35b136a4fb30) Remove special handling necessary for the hard-coded color picker. Add alpha support to the color picker popup. Support locking mouse position when dragging value selectors also in menus (color pickers), which improves usability of value selectors. Previously this was only supported in the editor. Replace large HSLA scrollbar color picker for UI color setting with inline color picker popup: - Before: ![screenshot_2023-06-05_21-57-57](https://github.com/ddnet/ddnet/assets/23437060/bb6cee4d-5438-40a3-b602-90abccc959ee) - After: ![screenshot_2023-06-05_21-57-01](https://github.com/ddnet/ddnet/assets/23437060/e0a565a6-2956-403f-9fc0-4ab11a764400) ## Checklist - [X] Tested the change ingame - [X] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 6712: Fix crash when enabling `dbg_dummies` on running server r=def- a=Robyt3 The server normally needs to be reloaded to spawn the debug dummies, so this code was not checking if a debug dummy player exists. Decreasing the number of debug dummies while the server is running also causes them to simply not be snapped instead of completely destroying them. For debugging any number of dummies can be useful, so the maximum number of debug dummies is increased to the maximum number of clients. See #6702. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [X] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
---|---|---|
.. | ||
components | ||
prediction | ||
animstate.cpp | ||
animstate.h | ||
component.cpp | ||
component.h | ||
gameclient.cpp | ||
gameclient.h | ||
laser_data.cpp | ||
laser_data.h | ||
lineinput.cpp | ||
lineinput.h | ||
pickup_data.cpp | ||
pickup_data.h | ||
projectile_data.cpp | ||
projectile_data.h | ||
race.cpp | ||
race.h | ||
render.cpp | ||
render.h | ||
render_map.cpp | ||
skin.h | ||
ui.cpp | ||
ui.h | ||
ui_listbox.cpp | ||
ui_listbox.h | ||
ui_rect.cpp | ||
ui_rect.h | ||
ui_scrollregion.cpp | ||
ui_scrollregion.h |