ddnet/src/engine/client
Robert Müller b89e4e8770 Finish CHttpRequest::OnCompletion before updating State()
Ensure that the `CHttpRequest::OnCompletion` function has finished before updating the state which is visible to other threads. Otherwise, threads may try to access the result of a completed HTTP request, before the result has been initialized/updated in the `OnCompletion` function.

Fixes warning due to invalid texture width/height being shown for downloaded skins, because the texture was loaded before the image data was initialized. Closes #7818.

Regression from #7683. Before this, the `OnCompletion` function could also modify the HTTP request's state, which was used to check if loading the skin PNG failed. Instead of doing this, a separate check is added for the skin download task to check that the PNG was loaded successfully.
2024-01-21 14:53:33 +01:00
..
backend Add color palette and pipette to editor 2023-12-30 13:17:30 +01:00
backend_sdl.cpp changed GFX → Gfx 2023-12-13 15:46:49 +01:00
backend_sdl.h changed GFX → Gfx 2023-12-13 15:46:49 +01:00
blocklist_driver.cpp Huge variable naming format 2022-07-08 18:01:29 +02:00
blocklist_driver.h Add Intel as vendor to the block list on windows 2021-05-06 12:23:40 +02:00
checksum.h Add some checksum functions to the client 2022-01-31 21:31:26 +01:00
client.cpp Add time scale to debug graphs for constant scrolling speed 2024-01-17 20:43:19 +01:00
client.h Use curl-multi 2023-12-18 20:06:43 +01:00
demoedit.cpp Port some code to str_copy() template 2022-07-09 19:40:58 +03:00
demoedit.h Mark virtual function as override using a script: 2022-05-17 23:47:32 +02:00
discord.cpp Fix discord build 2023-12-15 00:55:26 +01:00
favorites.cpp Make less headers depend on <base/system.h> 2023-12-11 23:52:23 +01:00
friends.cpp Add templated str_append function for arrays with fixed size 2023-06-14 00:04:01 +02:00
friends.h Organize engine-client includes 2022-06-17 17:46:43 +02:00
ghost.cpp Small fixes for cl_race_ghost_strict_map 2023-10-28 14:54:35 +02:00
ghost.h Make less headers depend on <base/system.h> 2023-12-11 23:52:23 +01:00
graph.cpp Add time scale to debug graphs for constant scrolling speed 2024-01-17 20:43:19 +01:00
graph.h Add time scale to debug graphs for constant scrolling speed 2024-01-17 20:43:19 +01:00
graphics_defines.h Replace all usages of C standard headers with C++ headers 2023-03-01 19:26:51 +01:00
graphics_threaded.cpp Merge pull request #7744 from Robyt3/Editor-Color-Palette-Pipette 2024-01-13 22:55:16 +00:00
graphics_threaded.h Merge pull request #7744 from Robyt3/Editor-Color-Palette-Pipette 2024-01-13 22:55:16 +00:00
input.cpp Check for invalid unicode in filenames etc. on Windows 2023-12-01 20:27:03 +01:00
input.h Replace static variables in MouseRelative with member variable 2023-10-15 20:36:59 +02:00
keynames.h Regenerate key lists with latest SDL version 2023-05-30 23:39:47 +02:00
notifications.cpp Add INotifications kernel interface 2023-12-16 18:15:43 +01:00
notifications.h Add INotifications kernel interface 2023-12-16 18:15:43 +01:00
serverbrowser.cpp Merge pull request #7683 from Learath2/dd_pr_curlmultifinal 2024-01-15 21:54:24 +00:00
serverbrowser.h Use curl-multi 2023-12-18 20:06:43 +01:00
serverbrowser_http.cpp Fix some clang-tidy issues and UB 2024-01-12 23:27:49 +03:00
serverbrowser_http.h Use curl-multi 2023-12-18 20:06:43 +01:00
serverbrowser_ping_cache.cpp Make less headers depend on <base/system.h> 2023-12-11 23:52:23 +01:00
serverbrowser_ping_cache.h Make less headers depend on <base/system.h> 2023-12-11 23:52:23 +01:00
smooth_time.cpp Properly initialize all CClient member variables 2023-12-02 18:33:46 +01:00
smooth_time.h Make prediction margin take effect immediately 2023-11-19 19:52:39 +01:00
sound.cpp Optimize allocation of sound sample indices 2023-12-29 13:07:04 +01:00
sound.h Optimize allocation of sound sample indices 2023-12-29 13:07:04 +01:00
sqlite.cpp Make use of IO_MAX_PATH_LENGTH 2021-09-13 12:14:50 +02:00
steam.cpp Make less headers depend on <base/system.h> 2023-12-11 23:52:23 +01:00
text.cpp Fix multi-line text selection not rendered correctly anymore 2024-01-13 23:21:13 +01:00
updater.cpp Finish CHttpRequest::OnCompletion before updating State() 2024-01-21 14:53:33 +01:00
updater.h Fix some clang-tidy issues and UB 2024-01-12 23:27:49 +03:00
video.cpp Fix readability-make-member-function-const 2023-12-14 23:38:03 +01:00
video.h Fix readability-make-member-function-const 2023-12-14 23:38:03 +01:00
warning.cpp Fix warning title being uninitialized in some cases 2024-01-16 20:12:25 +01:00