mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-10 01:58:19 +00:00
9a89e58a16
See also Jupeyy's explanation in https://github.com/ddnet/ddnet/issues/4294 for why we want to ignore this: > sadly components have no OnDestruct on anything like that > so aslong it doesn't actually leak it's just non destructed memory So it's something we allocate once for the entire client lifetime from my understanding. ================================================================= ==421461==ERROR: LeakSanitizer: detected memory leaks Direct leak of 411760 byte(s) in 10 object(s) allocated from: #0 0x55eaf0c08a29 in malloc (/media/ddnet/integration_test/DDNet+0x736a29) #1 0x55eaf0de9f72 in CCommandProcessorFragment_OpenGL2::Cmd_CreateBufferObject(CCommandBuffer::SCommand_CreateBufferObject const*) /media/ddnet/src/engine/client/backend/opengl/backend_opengl.cpp:1898:25 #2 0x55eaf0dd82f5 in CCommandProcessorFragment_OpenGL::RunCommand(CCommandBuffer::SCommand const*) /media/ddnet/src/engine/client/backend/opengl/backend_opengl.cpp #3 0x55eaf0f73229 in CCommandProcessor_SDL_GL::RunBuffer(CCommandBuffer*) /media/ddnet/src/engine/client/backend_sdl.cpp:246:20 #4 0x55eaf0f70568 in CGraphicsBackend_Threaded::ThreadFunc(void*) /media/ddnet/src/engine/client/backend_sdl.cpp:75:25 #5 0x55eaf0d679d7 in thread_run(void*) /media/ddnet/src/base/system.cpp:686:2 #6 0x7f08b788c54c (/usr/lib/libc.so.6+0x8c54c) SUMMARY: AddressSanitizer: 411760 byte(s) leaked in 10 allocation(s).
50 lines
1.7 KiB
YAML
50 lines
1.7 KiB
YAML
name: Check ASan & UBSan
|
|
|
|
on:
|
|
push:
|
|
branches-ignore:
|
|
- master
|
|
- staging.tmp
|
|
- trying.tmp
|
|
- staging-squash-merge.tmp
|
|
pull_request:
|
|
|
|
jobs:
|
|
check-clang-san:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
submodules: true
|
|
|
|
- name: Prepare linux
|
|
run: |
|
|
sudo apt-get update -y
|
|
sudo apt-get install pkg-config cmake ninja-build libfreetype6-dev libnotify-dev libsdl2-dev libsqlite3-dev libavcodec-dev libavformat-dev libavutil-dev libswresample-dev libswscale-dev libx264-dev libvulkan-dev glslang-tools spirv-tools -y
|
|
- name: Build with ASan and UBSan
|
|
run: |
|
|
mkdir san
|
|
cd san
|
|
export CC=clang
|
|
export CXX=clang++
|
|
export CXXFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer"
|
|
export CFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer"
|
|
cmake -DCMAKE_BUILD_TYPE=Debug -DHEADLESS_CLIENT=ON ..
|
|
make -j"$(nproc)"
|
|
- name: Run server and headless client with ASan and UBSan
|
|
run: |
|
|
cd san
|
|
export UBSAN_OPTIONS=suppressions=../ubsan.supp:log_path=./SAN:print_stacktrace=1:halt_on_errors=0
|
|
export ASAN_OPTIONS=log_path=./SAN:print_stacktrace=1:check_initialization_order=1:detect_leaks=1:halt_on_errors=0
|
|
export LSAN_OPTIONS=suppressions=../lsan.supp
|
|
./DDNet "cl_download_skins 0;quit" || true
|
|
./DDNet-Server shutdown || true
|
|
if test -n "$(find . -maxdepth 1 -name 'SAN.*' -print -quit)"
|
|
then
|
|
cat ./SAN.*
|
|
exit 1
|
|
fi
|
|
- name: Run integration tests with ASan and UBSan
|
|
run: |
|
|
scripts/integration_test.sh san
|