mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-13 03:28:19 +00:00
e2cb24b7d9
3669: Local ranking info viewable in-game r=def- a=houseme-kyle The feature is based on the issue below: https://github.com/ddnet/ddnet/issues/3655 The main concern was the impact it would have if we had to double our ranking/point commands to support it. I took the feedback into account and combined the info into one command. The PR is in draft as I don't want to implement it for the remaining commands before getting thoughts on the approach taken. **Feature** Display local stats alongside global while using the same commands **Implementation** - /rank, /top5 etc to display their local position alongside global. - Top 5 changed to top 3 due to space limitations - Message limit increased by 1 - Don't show "requested by" when the request was made by the same individual **Reason for feature** - Foster growth in the smaller communities as they compete amongst each other in their own leaderboard - The names become more relevant to all communities as they can better relate to the names displayed **TODO** ~- Tested with production sqlite data but not MySQL storage~ ~- Expand concept to other relevant ranking commands~ (Example of NovaShock who is the top player in South Africa)   ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [x] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: houseme-kyle <kyle@houseme.co.za> Co-authored-by: Kyle Bradley <kyle@house.me> Co-authored-by: = <=> |
||
|---|---|---|
| .. | ||
| client | ||
| editor | ||
| server | ||
| bezier.cpp | ||
| bezier.h | ||
| collision.cpp | ||
| collision.h | ||
| ddracechat.h | ||
| ddracecommands.h | ||
| gamecore.cpp | ||
| gamecore.h | ||
| layers.cpp | ||
| layers.h | ||
| localization.cpp | ||
| localization.h | ||
| mapbugs.cpp | ||
| mapbugs.h | ||
| mapbugs_list.h | ||
| mapitems.cpp | ||
| mapitems.h | ||
| mapitems_ex.cpp | ||
| mapitems_ex.h | ||
| mapitems_ex_types.h | ||
| prng.cpp | ||
| prng.h | ||
| teamscore.cpp | ||
| teamscore.h | ||
| tuning.h | ||
| variables.h | ||
| version.h | ||
| voting.h | ||
