Dennis Felsing
d265057591
Merge pull request #8278 from Robyt3/Client-Move-Resize-Fixes
...
Revert screen mode config variables when change not accepted, update screen index config variable after moving window
2024-04-28 15:18:16 +00:00
Dennis Felsing
b3bd831cde
Merge pull request #8279 from Robyt3/Base-FutureLogger-Leak
...
Add no-op logger to fix leak of `CFutureLogger` pending messages
2024-04-28 15:17:53 +00:00
Robert Müller
938d264c43
Fix wrong server address used in password popup when redirected
...
Always use the server address from the network client to reconnect to the correct server after being disconnected due to wrong password. The password popup is only shown after being disconnected, so the server address of the network client should always the address of the server which the client should reconnect to with the password. Using `ui_server_address` was causing the wrong address to be used after being redirected to another server and if the config variable is changed while the password popup is open.
Closes #8260 .
2024-04-28 17:05:28 +02:00
Robert Müller
d2139e4bec
Use net_addr_str
directly to format address including port
2024-04-28 16:45:56 +02:00
Robert Müller
b3bcfd39bc
Add no-op logger to fix leak of CFutureLogger
pending messages
...
Fix leak of pending future logger log messages if the future logger is not set, in particular when the `logfile` config variable is not set or the file could not be opened, by setting a logger that discards all log messages in this case.
Closes #8265 .
2024-04-28 16:32:24 +02:00
Robert Müller
e4dddb95ce
Update screen index config variable after moving window
...
The wrong screen was shown in the settings when moving the window to another screen while in windowed mode.
2024-04-28 15:29:05 +02:00
Robert Müller
86bf5424e3
Revert screen mode config variables when change not accepted
...
When changing the screen width, height or refresh rate config variables to 0 or negative values, which are not allowed by the backend, automatically revert the config variables to the actual values again to ensure that the config variables stay in sync with the state of the window. This fixes the client crashing in the graphics settings when setting the screen width and height to 0 via the console, which causes a division by zero when calculating the aspect ratio.
2024-04-28 15:25:31 +02:00
Dennis Felsing
516315e0e2
Merge pull request #8273 from Robyt3/Sound-Various-Fixes
...
Fix crashes and memory leaks related to editor map sounds and opus file decoding, refactoring
2024-04-27 15:45:55 +00:00
Dennis Felsing
a36ae188a8
Merge pull request #8274 from Robyt3/Server-ChangeMap-Argument
...
Make `change_map` parameter non-optional
2024-04-27 15:45:31 +00:00
Robert Müller
4f94316c72
Make change_map
parameter non-optional
...
The command confusingly assumed the empty string if no argument was passed.
2024-04-27 13:45:51 +02:00
BuildTools
a9e75a9ab2
Correct Finnish translations
2024-04-27 14:34:52 +03:00
Robert Müller
9cf3094934
Also check for incorrect sample index with assertion
...
Ensure the sample being allocated is not currently used also by checking its next free sample index.
2024-04-27 13:11:35 +02:00
Robert Müller
d06f6d3370
Handle failure of op_pcm_total
function
...
According to the documentation, this function returns `0` on success and a negative number (error code) otherwise, which would cause an allocation of an invalid size.
2024-04-27 13:11:35 +02:00
Robert Müller
d0e27fdcd4
Fix memory leak of opus file structure
...
We were not calling `op_free` for `OggOpusFile *` after decoding opus files.
2024-04-27 13:04:05 +02:00
Robert Müller
cfb5b15222
Log error code if opus file cannot be opened
2024-04-27 13:03:58 +02:00
Robert Müller
51012bcc1b
Fix potential out-of-bounds writes on invalid opus files
...
The third parameter of the `op_read` function specifies the remaining size of the buffer, but we always passed the total size of the buffer without respecting the position at which the data is written into the buffer.
2024-04-27 13:03:18 +02:00
Robert Müller
4d37775c17
Only change sample variables when it was decoded successfully
...
Avoid changing the sample member variables until the sample was decoded successfully.
2024-04-27 13:02:36 +02:00
Robert Müller
1153507216
Fix double-free when reading opus file fails
...
Set the data pointer of the sample only when the sample has been loaded successfully, so the invalid sample data is not freed again when decoding fails.
2024-04-27 13:02:23 +02:00
Robert Müller
941a302c4d
Ensure editor preview image and sound are unloaded properly
...
The preview image was previously not unloaded and the preview state was not reset.
2024-04-27 13:01:56 +02:00
Robert Müller
3b0d9cd6c9
Fix editor crash with sound preview when sound is not valid
...
This happens if a sound could not be loaded successfully.
2024-04-27 13:01:26 +02:00
Robert Müller
690912e209
Fix invalid sound index used when loading external sound fails
...
This should be highly unlikely because external sound mapres were never supported by the editor.
2024-04-27 13:00:54 +02:00
Dennis Felsing
c22ba00b59
Merge pull request #8270 from Robyt3/Image-size_t
...
Use `size_t` for `CImageInfo::m_Width` and `m_Height`
2024-04-27 04:37:28 +00:00
Dennis Felsing
17ae602d6b
Merge pull request #8268 from Robyt3/Snapshot-Print-Warning-Fix
...
Fix warning because of incorrect format argument for `size_t`
2024-04-27 04:36:41 +00:00
BuildTools
c745964efa
Correct Finnish translations
2024-04-26 22:21:36 +03:00
Robert Müller
c5a0d850d2
Use size_t
for CImageInfo::m_Width
and m_Height
2024-04-26 21:12:39 +02:00
BuildTools
7f3543f629
Update Finnish language file
2024-04-26 21:54:50 +03:00
BuildTools
479d0ea264
Update Finnish language file
2024-04-26 21:42:51 +03:00
Robert Müller
caccf05455
Fix warning because of incorrect format argument for size_t
2024-04-26 19:59:47 +02:00
Dennis Felsing
0eb319a951
Merge pull request #8263 from ChillerDragon/pr_line_author
...
Use LineAuthor variable to cleanup chat code
2024-04-25 17:11:04 +00:00
Robert Müller
0cedcdc3a7
Merge pull request #8236 from ChillerDragon/pr_delta_dump
...
Add delta debug dump
2024-04-25 16:05:26 +00:00
Dennis Felsing
3825eb7480
Merge pull request #8257 from GokturkTalha/patch-4
...
Add Azerbaijanese translation
2024-04-25 02:13:49 +00:00
Dennis Felsing
708a9c4024
Merge pull request #8258 from GokturkTalha/patch-5
...
Update Turkish translations
2024-04-25 02:12:45 +00:00
Dennis Felsing
8fb0052e9e
Merge pull request #8259 from n0Ketchp/patch-18
...
Update spanish.txt
2024-04-25 02:11:13 +00:00
ChillerDragon
1937145fdb
Use LineAuthor variable to cleanup chat code
2024-04-25 09:43:29 +08:00
ChillerDragon
29f6cc67db
Add delta debug dump
2024-04-25 08:44:49 +08:00
Talha Aygün
712b50a939
final
2024-04-24 22:47:56 +03:00
Talha Aygün
ddeec05c17
finish.txt
2024-04-24 21:43:31 +03:00
noKetchup
118e643d39
Update spanish.txt
2024-04-23 22:15:09 -04:00
Talha Aygün
df3c37e78e
Update Turkish translations
2024-04-24 03:01:50 +03:00
Talha Aygün
fc7f55099b
Update Turkish translations
...
little adjustments
2024-04-24 02:53:45 +03:00
Talha Aygün
8ac9ea4510
Add Azerbaijanese translation
...
fixed
2024-04-24 02:02:02 +03:00
Talha Aygün
54024cded8
Add Azerbaijanese translation
2024-04-23 21:52:12 +03:00
Talha Aygün
13452b3297
Add Azerbaijanese translation
...
90% translated
2024-04-23 21:21:35 +03:00
Robert Müller
57d4715a9d
Merge pull request #8251 from def-/pr-gcov
...
Remove unused gcov flags
2024-04-23 17:02:22 +00:00
Dennis Felsing
54798f4e81
Merge pull request #8256 from GokturkTalha/patch-3
...
Add Azerbaijanese translation
2024-04-23 16:05:40 +00:00
Dennis Felsing
72112fbb5c
fix style
2024-04-23 23:47:09 +08:00
Talha Aygün
55ef2d5bfd
Add Azerbaijanese translation
2024-04-23 23:41:15 +08:00
Dennis Felsing
b1aa6e2f21
Merge pull request #8255 from GokturkTalha/patch-2
...
Add Azerbaijanese translation (by Gokturk)
2024-04-23 14:44:11 +00:00
Dennis Felsing
a899b7f68a
Add new file to CMakeLists.txt
2024-04-23 22:26:37 +08:00
Talha Aygün
dded0a6779
Add Azerbaijanese translation (by Gokturk)
...
Translation process is not ended yet. Not translated areas are filled with Turkish translation for now, Azerbaijanese and Turkish are 75-80% similar and they have a lot of words in common. People from Azerbaijan can understand Turkish I'll continue it when I have time.
2024-04-23 17:06:59 +03:00