Robert Müller
e134e4e488
Remove redundant conditions (always either true or false)
...
According to cppcheck's `knownConditionTrueFalse` error:
```
src\base\system.cpp:1776:11: style: The comparison 'bytes == 0' is always true. [knownConditionTrueFalse]
if(bytes == 0 && sock->ipv4sock >= 0)
^
src\base\system.cpp:1742:14: note: 'bytes' is assigned value '0' here.
int bytes = 0;
^
src\base\system.cpp:1776:11: note: The comparison 'bytes == 0' is always true.
if(bytes == 0 && sock->ipv4sock >= 0)
^
src\game\editor\io.cpp:887:33: style: Condition 'pSoundsItem->m_Version>=1' is always true [knownConditionTrueFalse]
if(pSoundsItem->m_Version >= 1)
^
src\game\editor\io.cpp:874:33: note: Assuming that condition 'pSoundsItem->m_Version<1' is not redundant
if(pSoundsItem->m_Version < 1 || pSoundsItem->m_Version > CMapItemLayerSounds::CURRENT_VERSION)
^
src\game\editor\io.cpp:887:33: note: Condition 'pSoundsItem->m_Version>=1' is always true
if(pSoundsItem->m_Version >= 1)
^
src\game\editor\io.cpp:914:33: style: Condition 'pSoundsItem->m_Version>=1' is always true [knownConditionTrueFalse]
if(pSoundsItem->m_Version >= 1)
^
src\game\editor\io.cpp:901:33: note: Assuming that condition 'pSoundsItem->m_Version<1' is not redundant
if(pSoundsItem->m_Version < 1 || pSoundsItem->m_Version > CMapItemLayerSounds::CURRENT_VERSION)
^
src\game\editor\io.cpp:914:33: note: Condition 'pSoundsItem->m_Version>=1' is always true
if(pSoundsItem->m_Version >= 1)
^
src\engine\client\backend\opengl\backend_opengl.cpp:207:68: style: Condition '*pStr=='\0'' is always false [knownConditionTrueFalse]
else if(LastWasNumber && (*pStr == '.' || *pStr == ' ' || *pStr == '\0'))
^
src\game\client\components\maplayers.cpp:851:110: style: Condition 'DoTextureCoords' is always true [knownConditionTrueFalse]
mem_copy_special(pUploadData + sizeof(vec2), pTmpTileTexCoords, sizeof(vec3), vtmpTiles.size() * 4, (DoTextureCoords ? (sizeof(vec2)) : 0));
^
src\game\client\components\maplayers.cpp:849:11: note: Assuming that condition 'DoTextureCoords' is not redundant
if(DoTextureCoords)
^
src\game\client\components\maplayers.cpp:851:110: note: Condition 'DoTextureCoords' is always true
mem_copy_special(pUploadData + sizeof(vec2), pTmpTileTexCoords, sizeof(vec3), vtmpTiles.size() * 4, (DoTextureCoords ? (sizeof(vec2)) : 0));
^
src\game\client\prediction\gameworld.cpp:567:5: style: Condition 'm_pParent' is always true [knownConditionTrueFalse]
if(m_pParent && m_pParent->m_pChild && m_pParent->m_pChild != this)
^
src\game\client\components\menu_background.cpp:271:7: style: Condition 'NeedImageLoading' is always true [knownConditionTrueFalse]
if(NeedImageLoading)
^
src\game\client\components\menu_background.cpp:268:23: note: Assignment 'NeedImageLoading=true', assigned value is 1
NeedImageLoading = true;
^
src\game\client\components\menu_background.cpp:271:7: note: Condition 'NeedImageLoading' is always true
if(NeedImageLoading)
^
src\game\editor\editor.cpp:4991:6: style: Condition 'pEnvelope' is always true [knownConditionTrueFalse]
if(pEnvelope)
^
```
2022-11-29 23:32:26 +01:00
Robert Müller
fd208eaa1a
Remove redundant variable assignments
...
The assigned values are never used, so the assignments can be removed or variable scopes can be reduced.
According to cppcheck's `unreadVariable` error.
2022-11-29 23:32:26 +01:00
Alexander Akulich
6d9284adc1
Port some code to str_copy() template
2022-07-09 19:40:58 +03:00
Chairn
a69dc599a9
Huge variable naming format
...
Fix pointer and pointer array variable naming
Huge renaming to match our rules
Used regex: (?!(return|delete)\b)\b\w+ (m_|ms_|g_|gs_|s_)[^a]\w+\[
(?!(return|delete)\b)\b\w+ (?!(m_|ms_|g_|gs_|s_))[^a]\w+\[
Further format static variables
Format almost all pointer names accordingly
Used regex: (?!(return)\b)\b\w+
\*(?!(m_p|p|s_p|m_ap|s_ap|g_p|g_ap|ap|gs_ap|ms_ap|gs_p|ms_p))\w+\b[^:\(p]
clang-format
Fix CI fail
Fix misnamed non pointer as pointer and non array as array
Used regex: (?!(return|delete)\b)\b\w+ (m_|ms_|g_|gs_|s_)p\w+\b
(?!return\b)\b\w+ (ms_|m_|g_|gs_|s_)a\w+\b[^\[]
clang-format
Revert to SCREAMING_SNAKE_CASE and reinstate dead code
2022-07-08 18:01:29 +02:00
c0d3d3v
0bfb854a0e
Rename TILE_CHECKPOINT_XXX to TILE_TIME_CHECKPOINT_XXX
2022-06-30 23:41:40 +02:00
c0d3d3v
281c766117
Add APPEARANCE Settings page
2022-06-29 16:28:19 +02:00
Robert Müller
4949645663
Organize game-shared includes
2022-06-17 17:39:25 +02:00
Chairn
c9345e7d32
More vector naming format
2022-06-15 19:37:37 +02:00
heinrich5991
b3a3604c36
Remove namespace tw
...
It didn't have a clear role, it just acted as a distinguisher between
two functions with the same name.
Rename `tw::time_get` to `time_get_nanoseconds` and delete the old
`time_get_nanoseconds`. Move `CCmdlineFix` and the typed
`net_socket_read_wait` function to the global namespace.
2022-06-13 18:07:29 +02:00
Chairn
01edaec628
Format vector variables names ( fixes #5209 )
2022-06-11 21:38:49 +02:00
Robert Müller
91d2ba1865
Organize game-client includes
2022-05-29 21:24:43 +02:00
def
c4377bb7d9
Always initialize vec2/3/4
...
Because no tools can detect it uninitialized well, tried Memory
Sanitizer (needs all libs including libc++ compiled with it), valgrind
(only detects in LTO build), compiler warnings. Might be related to
unions.
2022-05-22 12:18:32 +02:00
Jupeyy
3c597aff95
Switch to nanoseconds
2022-05-18 18:05:41 +02:00
Robert Müller
a1d092be27
Replace remaining usage of base/tl/string with std::string
2022-05-07 00:17:29 +02:00
Jupeyy
f7e3662cd7
Keep DDNet window responsive for loading tasks
2022-04-02 17:03:23 +02:00
Dennis Felsing
2da5d7d289
Add modernize-use-emplace
2022-02-15 00:15:06 +01:00
def
3f7befdd8b
Add some further readability checks, mostly redundancy
...
/media/ddnet/src/engine/server/databases/sqlite.cpp:232:55: warning: the address of ‘char* sqlite3_expanded_sql(sqlite3_stmt*)’ will never be NULL [-Waddress]
232 | if(m_pStmt != nullptr && sqlite3_expanded_sql != nullptr)
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
2022-01-22 17:22:01 +01:00
def
7aac8b5386
Add readability-container-size-empty
2022-01-22 13:54:25 +01:00
Robert Müller
1810ff3949
Move InitTilemapSkip to CLayers
2022-01-19 22:22:31 +01:00
ChillerDragon
3eb3dcd48b
Make use of IO_MAX_PATH_LENGTH
...
Inspired by
0a7d0fee7c
2021-09-13 12:14:50 +02:00
Jupeyy
8451775821
Make components member of CGameClient
2021-07-12 12:07:31 +02:00
def
59f1c2cbe6
Add New Year season theme by mind and use for 2 days
...
Map reduces my FPS from 60 to 45, mind can't optimize it further.
I'd release this as 15.2.5 in 1-2 days ideally with no other new changes in.
2020-12-28 17:45:04 +01:00
Jupeyy
c0dbd4a6f5
Fix leak, initialize UI Element Rect
2020-11-25 13:11:34 +01:00
def
165857a5a8
Fix variable names manually
2020-11-02 22:40:40 +01:00
def
b1f0fd8969
Enable modernize-loop-convert clang-tidy check
...
and run clang-format afterwards
https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html
2020-11-02 22:40:24 +01:00
Jupeyy
6eb6fad867
Fix offline client that is not in menu
2020-10-14 22:10:48 +02:00
Jupeyy
4c87b0cf05
Make menu background camera impl more robust
2020-10-13 15:37:34 +02:00
Jupeyy
58bd8dcbb6
Fix virtual call in Constructor
2020-10-10 12:16:27 +02:00
Jupeyy
0e71a47708
Add customization
2020-09-28 23:21:32 +02:00
def
3be8a592e5
Run clang-format
...
Purely automatic change. In case of conflict with this change, apply the
other change and rerun the formatting to restore it:
$ python scripts/fix_style.py
2020-09-26 21:50:15 +02:00
Jupeyy
8235df7752
Add menu background map
2020-09-23 23:38:28 +02:00
ChillerDragon