mirror of
https://github.com/ddnet/ddnet.git
synced 2024-10-21 08:18:18 +00:00
3e5daf0a68
6833: Support deleting/renaming demo folders, improve demo popups r=def- a=Robyt3 Support deleting and renaming folders in the demo browser. Only empty folders can be deleted. Ensure only files and folders in the save directory can be deleted and renamed. Also check if a folder with a demo rename/render filename already exists. Fix broken `m_DemolistSelectedIsDir` checks by using `m_vDemos[m_DemolistSelectedIndex].m_IsDir` instead. Append `.mp4` file extension only internally instead of appending it to the render filename lineinput, as this causes the file extension to appear when rendering doesn't start due an error message. Use more efficient `FileExists` instead of `FindFile` to check if rendered demo video file already exists. Change popup preconditions to assertions. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
|---|---|---|
| .. | ||
| components | ||
| prediction | ||
| animstate.cpp | ||
| animstate.h | ||
| component.cpp | ||
| component.h | ||
| gameclient.cpp | ||
| gameclient.h | ||
| laser_data.cpp | ||
| laser_data.h | ||
| lineinput.cpp | ||
| lineinput.h | ||
| pickup_data.cpp | ||
| pickup_data.h | ||
| projectile_data.cpp | ||
| projectile_data.h | ||
| race.cpp | ||
| race.h | ||
| render.cpp | ||
| render.h | ||
| render_map.cpp | ||
| skin.h | ||
| ui.cpp | ||
| ui.h | ||
| ui_listbox.cpp | ||
| ui_listbox.h | ||
| ui_rect.cpp | ||
| ui_rect.h | ||
| ui_scrollregion.cpp | ||
| ui_scrollregion.h | ||