mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-18 22:18:19 +00:00
ba7b82258e
6673: Clear Victim Team render info on skin changes r=Robyt3 a=Jupeyy fixes #6662 This should fix the issue, I guess, by simply clearing the render info. I can't find an easy way to restore the original skins of the team members as we don't save their IDs. I couldn't directly trigger the assert, but I could certainly see the skin getting invalid when killen the team and switch to "vanilla only skins". (Edit: When triggering it a few times I got the assert) The code generally looks a bit hacky. Maybe the original author can refactor it a bit ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 6676: Show GPU info (if available) in assert r=Robyt3 a=Jupeyy first part of #6672 ![image](https://github.com/ddnet/ddnet/assets/6654924/0e9aec5a-528a-4e7a-a3fa-93108e55597e) ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com> |
||
---|---|---|
.. | ||
client | ||
docs | ||
external | ||
gfx | ||
server | ||
shared | ||
antibot.h | ||
Cargo.toml | ||
client.h | ||
config.h | ||
console.h | ||
console.rs | ||
demo.h | ||
discord.h | ||
editor.h | ||
engine.h | ||
favorites.h | ||
friends.h | ||
ghost.h | ||
graphics.h | ||
input.h | ||
kernel.h | ||
keys.h | ||
lib.rs | ||
map.h | ||
message.h | ||
rust.h | ||
server.h | ||
serverbrowser.h | ||
sound.h | ||
sqlite.h | ||
steam.h | ||
storage.h | ||
textrender.h | ||
updater.h | ||
uuid.h | ||
warning.h |