mirror of
https://github.com/ddnet/ddnet.git
synced 2024-10-21 00:08:19 +00:00
0684d5e1a7
6820: Improve demo (video) renderer UX r=def- a=Kaffeine <!-- What is the motivation for the changes of this pull request? --> In this MR I want to address three issues with video recorder: 1. A bug: if I start a rendering with 0.25x speed and click on 'Increase the speed' during the rendering, I expect to get the next speed (0.5x) but as the speed index is not set (kept default `4`), the speed is boosted to 1.25x. 2. Usecase: I want to adjust the camera (change position, decrease zoom, etc) for the demos and I don't want to use extra video editor to cut the first frames with the unwanted camera moves/setups from the demo. I came to a simple solution: start the rendering pre-paused to do the needed adjustments before anything is added to the video. 3. NotABug: All recorded video files have double `.demo.mp4` extension which is ugly. Probably I have to change something to fit DDNet codebase. E.g. I don't know if `Localize("(paused)")` is acceptable here. <!-- Note that builds and other checks will be run for your change. Don't feel intimidated by failures in some of the checks. If you can't resolve them yourself, experienced devs can also resolve them before merging your pull request. --> ## Before ![image](https://github.com/ddnet/ddnet/assets/374839/7273dd5b-e3d1-4f73-87bd-e09493d106a0) ## After ![image](https://github.com/ddnet/ddnet/assets/374839/7d62028d-04bc-45af-babf-5a2e8cb243dc) ## Checklist - [x] Tested the change ingame - [x] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Alexander Akulich <akulichalexander@gmail.com> |
||
---|---|---|
.. | ||
components | ||
prediction | ||
animstate.cpp | ||
animstate.h | ||
component.cpp | ||
component.h | ||
gameclient.cpp | ||
gameclient.h | ||
laser_data.cpp | ||
laser_data.h | ||
lineinput.cpp | ||
lineinput.h | ||
pickup_data.cpp | ||
pickup_data.h | ||
projectile_data.cpp | ||
projectile_data.h | ||
race.cpp | ||
race.h | ||
render.cpp | ||
render.h | ||
render_map.cpp | ||
skin.h | ||
ui.cpp | ||
ui.h | ||
ui_listbox.cpp | ||
ui_listbox.h | ||
ui_rect.cpp | ||
ui_rect.h | ||
ui_scrollregion.cpp | ||
ui_scrollregion.h |