mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-18 22:18:19 +00:00
a38dea4454
6590: Make text containers bit safer r=Robyt3 a=Jupeyy From reading the code I couldn't understand how https://github.com/ddnet/ddnet/issues/5143#issuecomment-1546735484 could happen either (checked = not the case): - [x] teini used an outdated client - [ ] i am blind - [ ] it was a name/clan -plate, scoreboard entry - [ ] it leaked somewhere in text.cpp or similar impl - [ ] it happened because of an outside write. We don't really come further with this, so we should probably at least try it out? `@Robyt3` your opinion? We can still always remove it again ## Checklist - [ ] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Jupeyy <jupjopjap@gmail.com> |
||
|---|---|---|
| .. | ||
| backend | ||
| backend_sdl.cpp | ||
| backend_sdl.h | ||
| blocklist_driver.cpp | ||
| blocklist_driver.h | ||
| checksum.h | ||
| client.cpp | ||
| client.h | ||
| demoedit.cpp | ||
| demoedit.h | ||
| discord.cpp | ||
| favorites.cpp | ||
| friends.cpp | ||
| friends.h | ||
| ghost.cpp | ||
| ghost.h | ||
| graphics_defines.h | ||
| graphics_threaded.cpp | ||
| graphics_threaded.h | ||
| input.cpp | ||
| input.h | ||
| keynames.h | ||
| notifications.cpp | ||
| notifications.h | ||
| serverbrowser.cpp | ||
| serverbrowser.h | ||
| serverbrowser_http.cpp | ||
| serverbrowser_http.h | ||
| serverbrowser_ping_cache.cpp | ||
| serverbrowser_ping_cache.h | ||
| sound.cpp | ||
| sound.h | ||
| sqlite.cpp | ||
| steam.cpp | ||
| text.cpp | ||
| updater.cpp | ||
| updater.h | ||
| video.cpp | ||
| video.h | ||