DDraceNetwork, a free cooperative platformer game
Go to file
bors[bot] 8bd552d3b8
Merge #3884
3884: Make mouse pos calculation more robust against NaNs r=def- a=Jupeyy

1. Since the config didn't have a limit set, they could be negative, which directly caused bugs
2. If you set a min mouse distance, lets say 5, It can mathematically happen that you drag your mouse exactly so much that you hit the (0, 0) point and the if(.. < MinDistance) branch normalizes that point, which causes non restorable NaNs.
It's now safe, the min distance is later in code checked to be atleast 1, i "even" just made it safe enough, so there shouldn't be any change in behaviour:
07ab4d5356/src/game/client/components/controls.cpp (L298-L304)
Which casts the float to an int and checks the int, and this does not restore the mouse pos for NaNs, because nan to int is not 0
its some insanly high value int_max or smth

To reproduce both bugs "easily" on current master you can abuse a SDL limitation,
relative mouse mode seems to only move upto +-1 unit,
- so for 1. set the ingame mouse sens to 100000 and the max mouse distance to -1000 and move your mouse fast for a few seconds, happens relativly easy (Thanks to Souly how to reproduce it)
- for 2. set mouse sens to 100 and max distance to 1 and min distance to 5, this case is a bit harder to reprod in debug mode, probably bcs of the way mouse pos is later handled and also maybe bcs of floating point differences with signs that go close to 0... had to move the mouse few seconds but still got it relativly fast (with -0fast it happens almost instant)

it will exactly happen what i explained in 2. that the reported mouse movement negates the current mouse pos, resulting in mouse pos (0,0)

![screenshot_2021-06-06_21-55-18](https://user-images.githubusercontent.com/6654924/120938281-35bf4b80-c712-11eb-9b6b-7523e8b436bd.png)

This this was also a bug reported in #bugs channel, i think we could also add it to the release

## Checklist

- [x] Tested the change ingame
- [ ] Provided screenshots if it is a visual change
- [ ] Tested in combination with possibly related configuration options
- [ ] Written a unit test if it works standalone, system.c especially
- [ ] Considered possible null pointers and out of bounds array indexing
- [ ] Changed no physics that affect existing maps
- [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional)


Co-authored-by: Jupeyy <jupjopjap@gmail.com>
2021-06-07 08:28:24 +00:00
.github Work around CMake 3.20.0 bug, fix packaging on CI 2021-04-07 18:07:44 +02:00
cmake Search for both x264 and libx264 2021-03-25 17:17:14 -03:00
data Merge #3873 2021-06-04 14:28:24 +00:00
datasrc Adopt upstream refactoring: Mark several functions as 'const' 2021-02-23 18:26:16 +03:00
ddnet-libs@ae1277e0b3 Fix Windows Discord build 2021-01-31 10:17:21 +01:00
man Suggest installation of missing man generation dependencys 2019-03-06 02:12:22 +01:00
other Version 15.4 2021-03-25 07:58:27 +01:00
scripts Only use correct clang-format version 2021-04-17 20:24:57 +02:00
src Merge #3884 2021-06-07 08:28:24 +00:00
.clang-format Manual preparation for cleaner clang-format 2020-09-26 21:41:01 +02:00
.clang-tidy Update .clang-tidy file to 11 2020-12-22 12:28:37 +01:00
.gitattributes exclude external libs from github statistics (#740) 2017-04-15 00:36:43 +02:00
.gitignore Ignore map_optimize 2020-12-02 14:47:24 +01:00
.gitmodules Lazy developers 2017-07-25 23:50:50 +02:00
.pylintrc Add pylint 2020-12-09 10:40:28 +01:00
bors.toml Make bors also look at clang-format & clang-tidy 2020-11-03 13:52:44 +01:00
CMakeLists.txt Add japanese condensed font 2021-06-04 21:15:29 +08:00
Dockerfile Add OSX support 2018-04-03 18:40:54 +03:00
Doxyfile Add DoxyFile and document CUIRect 2020-08-18 12:50:25 +02:00
formatting-revs.txt Fix hash in formatting-revs.txt 2020-09-30 17:27:33 +02:00
license.txt Fix license 2021-02-11 01:57:21 +01:00
README.md Add gmock as dependency to README 2021-03-26 08:51:13 +01:00
storage.cfg OSX -> macOS 2021-02-12 13:41:41 +01:00
valgrind.supp some valgrind suppressions 2020-04-11 13:17:21 +02:00

DDraceNetwork

Our own flavor of DDRace, a Teeworlds mod. See the website for more information.

Development discussions happen on #ddnet on Quakenet (Webchat) or on Discord in the developer channel.

You can get binary releases on the DDNet website, find it on Steam or install from repository.

Cloning

To clone this repository with full history and external libraries (~350 MB):

git clone --recursive https://github.com/ddnet/ddnet

To clone this repository with full history when you have the necessary libraries on your system already (~220 MB):

git clone https://github.com/ddnet/ddnet

To clone this repository with history since we moved the libraries to https://github.com/ddnet/ddnet-libs (~40 MB):

git clone --shallow-exclude=included-libs https://github.com/ddnet/ddnet

To clone the libraries if you have previously cloned DDNet without them:

git submodule update --init --recursive

Dependencies on Linux

You can install the required libraries on your system, touch CMakeLists.txt and CMake will use the system-wide libraries by default. You can install all required dependencies and CMake on Debian or Ubuntu like this:

sudo apt install build-essential cmake git libcurl4-openssl-dev libssl-dev libfreetype6-dev libglew-dev libnotify-dev libogg-dev libopus-dev libopusfile-dev libpnglite-dev libsdl2-dev libsqlite3-dev libwavpack-dev python google-mock

Or on Arch Linux like this:

sudo pacman -S --needed base-devel cmake curl freetype2 git glew libnotify opusfile python sdl2 sqlite wavpack gmock

There is an AUR package for pnglite. For instructions on installing it, see AUR packages installation instructions on ArchWiki.

If you don't want to use the system libraries, you can pass the -DPREFER_BUNDLED_LIBS=ON parameter to cmake.

Building on Linux and macOS

To compile DDNet yourself, execute the following commands in the source root:

mkdir build
cd build
cmake ..
make -j$(nproc)

Pass the number of threads for compilation to make -j. $(nproc) in this case returns the number of processing units. DDNet requires additional libraries, that are bundled for the most common platforms (Windows, Mac, Linux, all x86 and x86_64). The bundled libraries are now in the ddnet-libs submodule.

The following is a non-exhaustive list of build arguments that can be passed to the cmake command-line tool in order to enable or disable options in build time:

  • -DCMAKE_BUILD_TYPE=[Release|Debug|RelWithDebInfo|MinSizeRel]
    An optional CMake variable for setting the build type. If not set, defaults to "Release" if -DDEV=ON is not used, and "Debug" if -DDEV=ON is used. See CMAKE_BUILD_TYPE in CMake Documentation for more information.

  • -DPREFER_BUNDLED_LIBS=[ON|OFF]
    Whether to prefer bundled libraries over system libraries. Setting to ON will make DDNet use third party libraries available in the ddnet-libs folder, which is the git-submodule target of the ddnet-libs repository mentioned above -- Useful if you do not have those libraries installed and want to avoid building them. If set to OFF, will only use bundled libraries when system libraries are not found. Default value is OFF.

  • -DWEBSOCKETS=[ON|OFF]
    Whether to enable WebSocket support for server. Setting to ON requires the libwebsockets-dev library installed. Default value is OFF.

  • -DMYSQL=[ON|OFF]
    Whether to enable MySQL/MariaDB support for server. Requires at least MySQL 8.0 or MariaDB 10.2. Setting to ON requires the libmariadbclient-dev, libmysqlcppconn-dev and libboost-dev libraries installed, which are also provided as bundled libraries for the common platforms. Default value is OFF.

    Note that the bundled MySQL libraries might not work properly on your system. If you run into connection problems with the MySQL server, for example that it connects as root while you chose another user, make sure to install your system libraries for the MySQL client and C++ connector. Make sure that the CMake configuration summary says that it found MySQL libs that were not bundled (no "using bundled libs").

  • -DAUTOUPDATE=[ON|OFF]
    Whether to enable the autoupdater. Packagers may want to disable this for their packages. Default value is ON for Windows and Linux.

  • -DCLIENT=[ON|OFF]
    Whether to enable client compilation. If set to OFF, DDNet will not depend on Curl, Freetype, Ogg, Opus, Opusfile, and SDL2. Default value is ON.

  • -DVIDEORECORDER=[ON|OFF]
    Whether to add video recording support using FFmpeg to the client. You can use command start_video and stop_video to start and stop conversion from demo to mp4. This feature is currently experimental and not enabled by default.

Dependencies needed on debian: libx264-dev libavfilter-dev libavdevice-dev libavformat-dev libavcodec-extra libavutil-dev

  • -DDOWNLOAD_GTEST=[ON|OFF]
    Whether to download and compile GTest. Useful if GTest is not installed and, for Linux users, there is no suitable package providing it. Default value is OFF.

  • -DDEV=[ON|OFF]
    Whether to optimize for development, speeding up the compilation process a little. If enabled, don't generate stuff necessary for packaging. Setting to ON will set CMAKE_BUILD_TYPE to Debug by default. Default value is OFF.

  • -DUPNP=[ON|OFF]
    Whether to enable UPnP support for the server. You need to install libminiupnpc-dev on Debian, miniupnpc on Arch Linux.

  • -GNinja
    Use the Ninja build system instead of Make. This automatically parallizes the build and is generally faster. Compile with ninja instead of make. Install Ninja with sudo apt install ninja-build on Debian, sudo pacman -S --needed ninja on Arch Linux.

Running tests (Debian/Ubuntu)

In order to run the tests, you need to install the following library libgtest-dev.

This library isn't compiled, so you have to do it:

sudo apt install libgtest-dev
cd /usr/src/gtest
sudo cmake CMakeLists.txt
sudo make -j8
 
# copy or symlink libgtest.a and libgtest_main.a to your /usr/lib folder
sudo cp *.a /usr/lib

To run the tests you must target run_tests with make: make run_tests

Using AddressSanitizer + UndefinedBehaviourSanitizer or Valgrind's Memcheck

ASan+UBSan and Memcheck are useful to find code problems more easily. Please use them to test your changes if you can.

For ASan+UBSan compile with:

CC=clang CXX=clang++ CXXFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" CFLAGS="-fsanitize=address,undefined -fsanitize-recover=address,undefined -fno-omit-frame-pointer" cmake -DCMAKE_BUILD_TYPE=Debug .
make

and run with:

UBSAN_OPTIONS=log_path=./SAN:print_stacktrace=1:halt_on_errors=0 ASAN_OPTIONS=log_path=./SAN:print_stacktrace=1:check_initialization_order=1:detect_leaks=1:halt_on_errors=0 ./DDNet

Check the SAN.* files afterwards. This finds more problems than memcheck, runs faster, but requires a modern GCC/Clang compiler.

For valgrind's memcheck compile a normal Debug build and run with: valgrind --tool=memcheck ./DDNet Expect a large slow down.

Building on Windows with Visual Studio

Download and install some version of Microsoft Visual Studio (as of writing, MSVS Community 2017) with C++ support, install Python 3 for all users and install CMake.

Start CMake and select the source code folder (where DDNet resides, the directory with CMakeLists.txt). Additionally select a build folder, e.g. create a build subdirectory in the source code directory. Click "Configure" and select the Visual Studio generator (it should be pre-selected, so pressing "Finish" will suffice). After configuration finishes and the "Generate" reactivates, click it. When that finishes, click "Open Project". Visual Studio should open. You can compile the DDNet client by right-clicking the DDNet project (not the solution) and select "Select as StartUp project". Now you should be able to compile DDNet by clicking the green, triangular "Run" button.

Cross-compiling on Linux to Windows x86/x86_64

Install MinGW cross-compilers of the form i686-w64-mingw32-gcc (32 bit) or x86_64-w64-mingw32-gcc (64 bit). This is probably the hard part. ;)

Then add -DCMAKE_TOOLCHAIN_FILE=../cmake/toolchains/mingw64.toolchain to the initial CMake command line.

Cross-compiling on Linux to macOS

Install osxcross, then add -DCMAKE_TOOLCHAIN_FILE=../cmake/toolchains/darwin.toolchain and -DCMAKE_OSX_SYSROOT=/path/to/osxcross/target/SDK/MacOSX10.11.sdk/ to the initial CMake command line.

Install dmg and hfsplus from libdmg-hfsplus and newfs_hfs from diskdev_cmds to unlock the package_dmg target that outputs a macOS disk image.

Importing the official DDNet Database

$ wget https://ddnet.tw/stats/ddnet-sql.zip
$ unzip ddnet-sql.zip
$ yaourt -S mariadb mysql-connector-c++
$ mysql_install_db --user=mysql --basedir=/usr --datadir=/var/lib/mysql
$ systemctl start mariadb
$ mysqladmin -u root password 'PW'
$ mysql -u root -p'PW'
MariaDB [(none)]> create database teeworlds; create user 'teeworlds'@'localhost' identified by 'PW2'; grant all privileges on teeworlds.* to 'teeworlds'@'localhost'; flush privileges;
# this takes a while, you can remove the KEYs in record_race.sql to trade performance in queries
$ mysql -u teeworlds -p'PW2' teeworlds < ddnet-sql/record_*.sql

$ cat mine.cfg
sv_use_sql 1
add_sqlserver r teeworlds record teeworlds "PW2" "localhost" "3306"
add_sqlserver w teeworlds record teeworlds "PW2" "localhost" "3306"

$ mkdir build
$ cd build
$ cmake -DMYSQL=ON ..
$ make -j8
$ ./DDNet-Server -f mine.cfg
Packaging status

Installation from Repository

Debian/Ubuntu

$ apt-get install ddnet

MacOS

$ brew install --cask ddnet

Fedora

$ dnf install ddnet

Arch Linux

$ yay -S ddnet

FreeBSD

$ pkg install DDNet

Benchmarking

DDNet is available in the Phoronix Test Suite. If you have PTS installed you can easily benchmark DDNet on your own system like this:

$ phoronix-test-suite benchmark ddnet