mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-11 10:38:20 +00:00
efde7523e4
3772: Add client-side HTTP server info r=def- a=heinrich5991 Summary ======= The idea of this is that clients will not have to ping each server for server infos which takes long, leaks the client's IP address even to servers the user does not join and is a DoS vector of the game servers for attackers. For the Internet, DDNet and KoG tab, the server list is entirely fetched from the master server, filtering out servers that don't belong into the list. The favorites tab is also supposed to work that way, except for servers that are marked as "also ping this server if it's not in the master server list". The LAN tab continues to broadcast the server info packet to find servers in the LAN. How does it work? ================= The client ships with a list of master server list URLs. On first start, the client checks which of these work and selects the fastest one. Querying the server list is a HTTP GET request on that URL. The response is a JSON document that contains server infos, server addresses as URLs and an approximate location. It can also contain a legacy server list which is a list of bare IP addresses similar to the functionality the old master servers provided via UDP. This allows us to backtrack on the larger update if it won't work out. Lost functionality ================== (also known as user-visible changes) Since the client doesn't ping each server in the list anymore, it has no way of knowing its latency to the servers. This is alleviated a bit by providing an approximate location for each server (continent) so the client only has to know its own location for approximating pings. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com> |
||
|---|---|---|
| .. | ||
| client | ||
| docs | ||
| external | ||
| server | ||
| shared | ||
| antibot.h | ||
| client.h | ||
| config.h | ||
| console.h | ||
| demo.h | ||
| discord.h | ||
| editor.h | ||
| engine.h | ||
| friends.h | ||
| ghost.h | ||
| graphics.h | ||
| input.h | ||
| kernel.h | ||
| keys.h | ||
| map.h | ||
| masterserver.h | ||
| message.h | ||
| server.h | ||
| serverbrowser.h | ||
| sound.h | ||
| sqlite.h | ||
| steam.h | ||
| storage.h | ||
| textrender.h | ||
| updater.h | ||
| uuid.h | ||
| warning.h | ||