mirror of
https://github.com/ddnet/ddnet.git
synced 2024-11-10 18:18:18 +00:00
482f15a711
5520: Warn about pnglite-incompatible PNGs on load r=def- a=heinrich5991 This allows a larger range of PNGs to be loaded while still maintaining backward compatibility with older clients by annoying the user. This warning can be enabled by the `warn-pnglite-incompatible-images` key in the https://info2.ddnet.tw/info JSON, if the key is not there or the JSON hasn't been obtained yet, the warning is disabled. Since the JSON is cached across restarts, it'll be effective for initially loaded images from the second start. ## Checklist - [x] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) 5624: Move message copy inside `SendPackMsgTranslate` r=def- a=Robyt3 Fix clang warning: Address of stack memory associated with local variable 'aBuf' is still referred to by the stack variable 'tmp' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape] Mark the input parameters as const pointers and mark the protocol message `Pack` methods as const. And remove a null check that only serves to hide programmer errors. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: heinrich5991 <heinrich5991@gmail.com> Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
|---|---|---|
| .. | ||
| client | ||
| docs | ||
| external | ||
| gfx | ||
| server | ||
| shared | ||
| antibot.h | ||
| client.h | ||
| config.h | ||
| console.h | ||
| demo.h | ||
| discord.h | ||
| editor.h | ||
| engine.h | ||
| favorites.h | ||
| friends.h | ||
| ghost.h | ||
| graphics.h | ||
| input.h | ||
| kernel.h | ||
| keys.h | ||
| map.h | ||
| message.h | ||
| server.h | ||
| serverbrowser.h | ||
| sound.h | ||
| sqlite.h | ||
| steam.h | ||
| storage.h | ||
| textrender.h | ||
| updater.h | ||
| uuid.h | ||
| warning.h | ||