edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-10-19 23:38:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
ddnet/src/engine
History
Robert Müller 65aa584b9f Remove redundant conditional expressions 
According to cppcheck's `redundantCondition` and `multiCondition` errors:

```
src\engine\client\backend\glsl_shader_compiler.cpp:70:39: style: Redundant condition: The condition '*(pBuff+1)' is redundant since '*(pBuff+1) == 'i'' is sufficient. [redundantCondition]
     if(*pBuff == ' ' && *(pBuff + 1) && *(pBuff + 1) == 'i' && *(pBuff + 2) == 'n')
                                      ^
src\engine\client\backend\glsl_shader_compiler.cpp:98:45: style: Redundant condition: The condition '*(pBuff+1)' is redundant since '*(pBuff+1) == 'u'' is sufficient. [redundantCondition]
      else if(*pBuff == 'o' && *(pBuff + 1) && *(pBuff + 1) == 'u' && *(pBuff + 2) == 't')
                                            ^

src\game\client\gameclient.cpp:1665:62: style: Redundant condition: m_aShowOthers[g_Config.m_ClDummy]!=SHOW_OTHERS_NOT_SET. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition]
 if(m_aShowOthers[g_Config.m_ClDummy] == SHOW_OTHERS_NOT_SET || (m_aShowOthers[g_Config.m_ClDummy] != SHOW_OTHERS_NOT_SET && m_aShowOthers[g_Config.m_ClDummy] != g_Config.m_ClShowOthers))
                                                             ^

src\game\client\prediction\entities\projectile.cpp:104:34: style: Redundant condition: pTargetChr. '!A || (A && B)' is equivalent to '!A || B' [redundantCondition]
  if(m_Explosive && (!pTargetChr || (pTargetChr && (!m_Freeze || (m_Type == WEAPON_SHOTGUN && Collide)))))
                                 ^

src\engine\client\backend\vulkan\backend_vulkan.cpp:6588:11: style: Expression is always true because 'else if' condition is opposite to previous condition at line 6578. [multiCondition]
  else if(!pCommand->m_ByResize)
          ^
src\engine\client\backend\vulkan\backend_vulkan.cpp:6578:14: note: first condition
  if(pCommand->m_ByResize)
             ^
src\engine\client\backend\vulkan\backend_vulkan.cpp:6588:11: note: else if condition is opposite to first condition
  else if(!pCommand->m_ByResize)
          ^
```
2022-11-29 23:32:28 +01:00
..
client Remove redundant conditional expressions 2022-11-29 23:32:28 +01:00
docs Merge #5918 2022-10-09 13:53:05 +00:00
external Update zlib to version 1.2.13 2022-10-14 14:53:24 +02:00
gfx Fix misspellings 2022-10-25 13:51:56 -03:00
server Remove redundant bitwise operand 2022-11-29 23:32:28 +01:00
shared Remove redundant bitwise operand 2022-11-29 23:32:28 +01:00
antibot.h Forgot to add target here 2021-07-22 00:22:12 +02:00
Cargo.toml Add support for Rust code in DDNet 2022-10-19 23:46:06 +02:00
client.h Constify snap more (inspired by upstream) 2022-10-09 15:12:12 +02:00
config.h Implement "reset" command 2021-12-27 01:13:11 +01:00
console.h Add support for Rust code in DDNet 2022-10-19 23:46:06 +02:00
console.rs Add support for Rust code in DDNet 2022-10-19 23:46:06 +02:00
demo.h Allow spectator mode to be changed while demo is paused 2022-08-28 17:52:49 +02:00
discord.h Only announce servers using Steam/Discord integration which are registered 2022-10-09 16:16:54 +02:00
editor.h Use bool for Load, Save, Append result, true on success 2022-11-03 20:17:06 +01:00
engine.h Mark virtual function as override using a script: 2022-05-17 23:47:32 +02:00
favorites.h Allow multiple addresses per server in the serverbrowser 2022-07-10 16:52:07 +02:00
friends.h Run clang-format 2020-09-26 21:50:15 +02:00
ghost.h Organize engine-shared includes 2022-05-29 20:02:22 +02:00
graphics.h Let CKernel clean-up. Use unused CSound::Shutdown 2022-09-16 16:50:19 +02:00
input.h Add IInput::ShiftIsPressed and IInput::AltIsPressed 2022-11-15 21:17:55 +01:00
kernel.h Fix misspellings 2022-10-25 13:51:56 -03:00
keys.h Add joystick support to engine 2022-06-13 20:40:36 +02:00
lib.rs Add support for Rust code in DDNet 2022-10-19 23:46:06 +02:00
map.h Huge variable naming format 2022-07-08 18:01:29 +02:00
message.h Run clang-format 2020-09-26 21:50:15 +02:00
rust.h Add support for Rust code in DDNet 2022-10-19 23:46:06 +02:00
server.h report extra player info to master http 2022-11-14 08:04:34 +01:00
serverbrowser.h Remove support for legacy 64 player info protocol 2022-10-12 16:12:02 +02:00
sound.h Let CKernel clean-up. Use unused CSound::Shutdown 2022-09-16 16:50:19 +02:00
sqlite.h Remove useless typedef in c++ 2022-06-25 21:05:54 +02:00
steam.h Only announce servers using Steam/Discord integration which are registered 2022-10-09 16:16:54 +02:00
storage.h Add TYPE_ALL_OR_ABSOLUTE and TYPE_SAVE_OR_ABSOLUTE storage types 2022-11-20 16:07:40 +01:00
textrender.h (A bit) safer interface for text containers 2022-07-08 19:19:37 +02:00
updater.h Overhauled job system 2017-11-23 15:47:38 +01:00
uuid.h Make sure headers compile standalone 2020-09-26 21:50:27 +02:00
warning.h Add block list for drivers 2020-11-05 21:07:14 +01:00