mirror of
https://github.com/ddnet/ddnet.git
synced 2024-09-21 18:14:19 +00:00
ccf0622984
5252: Use std::vector instead of array, remove base/tl/array.h, algorithm.h, allocator.h, range.h r=def- a=Robyt3 Replaces all usages of `array` with `std::vector`. I adjusted variable names of variables I changed to use the `v` prefix. Not so in the editor however, as there are already many changes due to clang-tidy enforcing the use of for-each loops. This allows us to remove all remaining `base/tl` headers except `threading.h`. Clang-tidy now finds `clang-analyzer-cplusplus.NewDelete` (Use of memory after it is freed), which is also fixed here, though it appears to be a false-positive. This last remaining usages of `goto` are also removed. ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test if it works standalone, system.c especially - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
|---|---|---|
| .. | ||
| auto_map.cpp | ||
| auto_map.h | ||
| editor.cpp | ||
| editor.h | ||
| explanations.cpp | ||
| io.cpp | ||
| layer_game.cpp | ||
| layer_quads.cpp | ||
| layer_sounds.cpp | ||
| layer_tiles.cpp | ||
| popups.cpp | ||