mirror of
https://github.com/ddnet/ddnet.git
synced 2024-09-20 17:44:18 +00:00
bd3b4f2d50
5942: Support unicode with ExcHndl, use upstream module offsets, handle errors r=def- a=Robyt3 Update Dr. Mingw (ExcHndl) to 0.9.8. Use the new `ExcHndlSetLogFileNameW` function to set the exception log file name using wide characters, to support paths containing unicode. It's not necessary to call `ExcHndlInit` explicitly after loading `exchndl.dll`, as the `DllMain` will already initialize the exception handler when the DLL is loaded. Module offsets are supported by upstream ExcHndl now, so we don't need to provide our own version that supplies the module offset to `ExcHndlInit` anymore. Upstream ExcHndl will also resolve the source code lines for addresses automatically, when the executable is build with debug information. Handle the cases that the exception handling module cannot be loaded and that the `ExcHndlSetLogFileNameW` function cannot be found in the module. Update `scripts/parse_drmingw.sh`: - Parse both old and new module offsets. - Use tabs instead of spaces consistently. - Reset the ANSI color after printing colored messages. Closes #5877. Needs https://github.com/ddnet/ddnet-libs/pull/34. Example crash logs: - [crash_debug_old.RTP.txt](https://github.com/ddnet/ddnet/files/9768008/crash_debug_old.RTP.txt) - [crash_debug_new.RTP.txt](https://github.com/ddnet/ddnet/files/9768011/crash_debug_new.RTP.txt) - [crash_release_old.RTP.txt](https://github.com/ddnet/ddnet/files/9768010/crash_release_old.RTP.txt) - [crash_release_new.RTP.txt](https://github.com/ddnet/ddnet/files/9768009/crash_release_new.RTP.txt) ## Checklist - [X] Tested the change ingame - [ ] Provided screenshots if it is a visual change - [ ] Tested in combination with possibly related configuration options - [ ] Written a unit test (especially base/) or added coverage to integration test - [ ] Considered possible null pointers and out of bounds array indexing - [ ] Changed no physics that affect existing maps - [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional) Co-authored-by: Robert Müller <robytemueller@gmail.com> |
||
---|---|---|
.. | ||
tl | ||
unicode | ||
bezier.cpp | ||
bezier.h | ||
color.h | ||
detect.h | ||
dynamic.h | ||
hash.cpp | ||
hash.h | ||
hash_bundled.cpp | ||
hash_ctxt.h | ||
hash_libtomcrypt.cpp | ||
hash_openssl.cpp | ||
lock_scope.h | ||
log.cpp | ||
log.h | ||
logger.h | ||
math.h | ||
system.cpp | ||
system.h | ||
types.h | ||
vmath.h |