Commit graph

20753 commits

Author SHA1 Message Date
Alexander Akulich 26b4a41c03 Extract 'six' content data structs to their own file 2023-10-06 18:14:15 +03:00
dobrykafe 5b609c8e06 extract CEditor::DoAudioPreview, also use in file dialog 2023-10-06 17:10:43 +02:00
dobrykafe 6e2ddfbeaf use nullptr instead of 0, add missing return statement 2023-10-06 17:09:20 +02:00
dobrykafe ca517f27b8 enhance editor toolbar sounds 2023-10-06 17:09:19 +02:00
Alexander Akulich c265969259 datasrc: Add m_Flag to CDataImage for compat with 'seven' struct 2023-10-06 17:39:21 +03:00
Alexander Akulich 487f0541b4 datasrc: Change 'seven' CDataSound m_Id type to int to match 'six' 2023-10-06 17:39:21 +03:00
Robert Müller 5a10ef049a Fix clang-tidy readability-static-accessed-through-instance
The crash that was occurring with this check was fixed in clang 15.
2023-10-06 14:07:02 +02:00
Robert Müller 4e31052821 Fix clang-tidy clang-analyzer-deadcode.DeadStores 2023-10-06 14:06:55 +02:00
Robert Müller fb7669ebb0 Fix clang-tidy modernize-use-override 2023-10-06 14:06:52 +02:00
Robert Müller 05ddf4a081 Fix clang-tidy performance-no-automatic-move 2023-10-06 14:06:47 +02:00
Robert Müller 6d71e119a2 Add suppression for clang-tidy bugprone-suspicious-realloc-usage
We generally don't handle memory allocation failures.
2023-10-06 14:06:33 +02:00
Robert Müller 59f4ae06d0 Fix clang-tidy clang-analyzer-optin.portability.UnixAPI
Assumes that `argc` is `0`, which is impossible.
2023-10-06 14:06:30 +02:00
Robert Müller 63a7063242 Fix clang-tidy readability-container-data-pointer 2023-10-06 14:06:27 +02:00
Robert Müller b81fb37f82 Fix clang-tidy modernize-use-emplace 2023-10-06 14:06:20 +02:00
Robert Müller cc5ae51cb6 Add suppression for clang-tidy misc-use-anonymous-namespace
We don't want to use anonymous namespaces instead of static functions.
2023-10-06 14:06:11 +02:00
Robert Müller 48a92f1eac
Merge pull request #7303 from Marmare314/refactor-env-editor
Refactor `CEnvelope` class
2023-10-06 11:29:08 +00:00
Dennis Felsing bdcf3e67f7
Merge pull request #7306 from Marmare314/component-single-member
store only pointer to editor in CEditorComponent
2023-10-06 11:25:16 +00:00
marmare314 73914b3cae store only pointer to editor in CEditorComponent 2023-10-06 12:46:56 +02:00
marmare314 c2adfc5628 make CEnvelope::m_PointsAccess private 2023-10-06 11:39:26 +02:00
marmare314 855ae8885c make CEnvelope::Resort private 2023-10-06 11:39:26 +02:00
marmare314 95528ca0b9 refactor CEnvelope::FindTopBottom
- rename to GetValueRange
- return pair of floats instead of storing them as members
2023-10-06 11:39:26 +02:00
marmare314 283226ef59 init member variables of CEnvelope on declaration 2023-10-06 11:39:26 +02:00
marmare314 08b825439e use type enum in CEnvelope 2023-10-06 11:39:22 +02:00
marmare314 073f208808 split implementations from CEnvelope class 2023-10-06 00:32:12 +02:00
Dennis Felsing 74383124da
Merge pull request #7301 from Robyt3/Demo-Browser-Search-Improvement
Fix selected demo index being desynced with selected demo name
2023-10-05 21:45:29 +00:00
Dennis Felsing 655902cf7f
Merge pull request #7302 from Robyt3/Cmdline-Fix-Leak
Fix leak of command line arguments on Windows
2023-10-05 21:45:26 +00:00
marmare314 1bd3e65c2a extract CEnvelope into seperate header 2023-10-05 22:42:24 +02:00
Robert Müller a42ca9f638 Fix leak of command line arguments on Windows
See https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-commandlinetoargvw#remarks
2023-10-05 22:37:12 +02:00
marmare314 1ccb83b2ae make IEnvelopePointAccess destructor virtual 2023-10-05 22:34:51 +02:00
Robert Müller c0b8bf313c Fix selected demo index being desynced with selected demo name
When using the demo filter and the selected demo name does not match any visible demo item, temporarily reset the selected demo index instead of keeping an incorrect demo index. This makes the behavior consistent with the server browser.
2023-10-05 21:29:34 +02:00
Robert Müller 48ba1f463a Ensure CDemoItem member variables are initialized
The variable `m_Valid` was not initialized in all cases.
2023-10-05 21:29:33 +02:00
JSaurusRex f1dd707c46 fixed clang formatting error 2023-10-05 20:10:52 +02:00
Dennis Felsing 2b115b92fa
Merge pull request #7300 from Robyt3/Demo-Render-Dialog-Fixes
Fix demo render complete popup opening on error, improve layout
2023-10-05 11:45:39 +00:00
Dennis Felsing d1cd0aeb20
Merge pull request #7287 from Marmare314/string-tooltip
store editor tooltip in optional string
2023-10-05 10:01:01 +00:00
Robert Müller 39057d7b87 Fix demo render complete popup opening on error, improve layout
The popup to show the completed demo rendering was also shown when the demo to be rendered could not be loaded or if the demo render popup was cancelled. Now the popup is only shown when the demo rendering was successful.

The layout of the popup is made consistent with other message popups. Long text is wrapped over multiple lines instead of decreasing the font size.
2023-10-05 11:58:48 +02:00
marmare314 25da78a00e store editor tooltip in optional string 2023-10-04 23:48:14 +02:00
Dennis Felsing b7de3d1e22
Merge pull request #7295 from Learath2/pr_fixfixfix
Vanilla tunings should be used for reckoning
2023-10-04 16:19:10 +00:00
Dennis Felsing a07679d33a
Merge pull request #6990 from Marmare314/project-onto
implement project-onto operation for envelopes
2023-10-04 14:30:01 +00:00
Edgar f5f57ee24c
Merge pull request #7283 from Robyt3/ImageLoader-Indexed-Fix
Fix images using indexed color palette not being loadable
2023-10-04 13:55:21 +00:00
Learath f865679cb4 Vanilla tunings should be used for reckoning 2023-10-04 15:21:10 +02:00
JSaurusRex 922a167c65 disable by default 2023-10-03 23:04:56 +02:00
Dennis Felsing 2e5ee8287e
Merge pull request #7008 from Robyt3/Datafile-String-Util
Add functions for reading/writing strings from/to datafile, minor refactoring of datafile/map reader
2023-10-03 20:54:40 +00:00
Dennis Felsing fb3c32a31f
Merge pull request #7292 from Robyt3/Client-Encapsulation
Encapsulate/move `IClient` member variables
2023-10-03 20:53:33 +00:00
Dennis Felsing 1c88adf4fd
Merge pull request #7294 from furo321/angle-paused
Don't use mouse position for angle if paused.
2023-10-03 20:53:11 +00:00
hardliner66 6c94e84e29 make sub-tick-aiming configurable 2023-10-03 21:08:03 +02:00
furo a08e306aa4 Don't use "direct input" if paused. 2023-10-03 20:59:12 +02:00
Edgar 3ff80f813f
Merge pull request #7293 from Learath2/pr_fixfix
Fix the fix to the fix to dead reckoning
2023-10-03 18:39:53 +00:00
Learath 3f8ca70eb3 Fix the fix to the fix to dead reckoning 2023-10-03 20:18:17 +02:00
hardliner66 6532d1be6f fix mouse position for hook/shots 2023-10-03 19:27:53 +02:00
Robert Müller 6f1e08b6f4 Encapsulate/move IClient member variables 2023-10-03 17:56:17 +02:00