Robert Müller
e9646ba157
Simplify usage of IClient::SnapGetItem function
...
Let the `IClient::SnapGetItem` function return an `IClient::CSnapItem` directly instead of passing it as a pointer. Add the item data pointer as a member variable to `IClient::CSnapItem` instead of returning it separately. Therefore, the separate data pointer of the class `CSnapEntities` is also not necessary anymore.
Consistently mark the snapshot items and data as `const`. The C-style cast to `void *` in the `IClient::SnapGetItem` function was previously implicitly casting away the `const` of the snapshot pointers.
2024-07-14 13:15:44 +02:00
Dennis Felsing
7014021909
Merge pull request #8585 from Robyt3/Tools-Demo-Extract-Chat-Snapshot-Cleanup
...
Cleanup snapshot member variables in `demo_extract_chat` tool
2024-07-13 22:10:28 +00:00
Robert Müller
a31d6a571a
Cleanup snapshot member variables in demo_extract_chat tool
...
Using `CSnapshotStorage::CHolder`s in the `demo_extract_chat` tool is not necessary, as only the member variable `m_pAltSnap` is being used in this tool. The regular snapshot data was copied into `m_pSnap` but never read. The other member variables were initialized but never read.
2024-07-13 22:51:31 +02:00
Dennis Felsing
9249b61f9f
Merge pull request #8582 from Robyt3/Android-Rust-Fix
...
Fix `--manifest-path` argument usage for Android build
2024-07-13 09:50:19 +00:00
Robert Müller
6c4b920f0a
Fix --manifest-path argument usage for Android build
...
Whereas `cargo` expects the `--manifest-path` argument after the `build` command, `cargo ndk` only supports arguments being specified before the `build` command, which was causing the Android build to fail with:
```
error: Failed loading manifest
error: No such file or directory (os error 2)
```
Regression from #8557 .
2024-07-13 11:31:40 +02:00
Dennis Felsing
888534e070
Merge pull request #8581 from Robyt3/Scoreboard-NonTeams-Blue-Size
...
Fix incorrect scoreboard size if blue team used without teams flag
2024-07-12 22:29:07 +00:00
Robert Müller
e277131cf8
Fix incorrect scoreboard size if blue team used without teams flag
...
When `GAMEFLAG_TEAMS` is not set, only the players of the red team are rendered in the scoreboard, but the size of the scoreboard was incorrectly calculated based on the size of the larger team (red or blue), which should only be done when `GAMEFLAG_TEAMS` is set.
2024-07-12 21:44:16 +02:00
Dennis Felsing
a21ff5b72e
Merge pull request #8578 from Robyt3/Gamecore-Cleanup
...
Minor cleanup of `gamecore.cpp/h`
2024-07-11 19:51:15 +00:00
Robert Müller
7cbfe1623d
Avoid duplicate distance calculation
...
Add variable `NewVelLength` to avoid calculating `length(NewVel)` twice.
2024-07-11 18:02:51 +02:00
Robert Müller
660c1de8f2
Remove unnecessary use of this
...
The same variable `m_HookHitDisabled` is also being accessed without `this`.
2024-07-11 18:02:24 +02:00
Robert Müller
998adfcefc
Remove redundant distance checks
...
The check `Distance > 0.0f` is redundant because the same check already exists in the outer if-statement and the variable `Distance` is never modified.
The check `D >= 0.0f` is redundant because mathematically any distance is greater or equal to zero.
2024-07-11 17:54:51 +02:00
Robert Müller
aeee2f561d
Remove dead code and obsolete TODO
...
It seems unlikely we that would want to introduce a variable to tweak the hook behavior at this point, so the TODO is removed.
2024-07-11 17:54:41 +02:00
Robert Müller
8e83049054
Merge pull request #8352 from ChillerDragon/pr_multi_cmd_helptext
...
Show help text when chaining multiple commands
2024-07-10 16:46:47 +00:00
heinrich5991
89992f2ce5
Merge pull request #8576 from def-/pr-mem-copy
...
Make FillAntibot faster
2024-07-10 13:24:15 +00:00
Dennis Felsing
108d0dc715
Make FillAntibot faster
2024-07-10 15:06:16 +02:00
Dennis Felsing
fa9f7b46cd
Merge pull request #8574 from Learath2/dd_pr_antibot_netaddr
...
net_addr_str only once
2024-07-09 19:04:48 +00:00
Learath
7fa0ef56f3
Include port
2024-07-09 20:27:40 +02:00
Learath
3cb390c6e6
net_addr_str only once
2024-07-09 20:17:34 +02:00
Dennis Felsing
076bfc68b0
Merge pull request #8573 from Robyt3/Server-Redirect-Multiple-Drop-Fix
...
Fix multiple redirected clients not dropped in the same tick
2024-07-09 16:33:56 +00:00
Robert Müller
350a57df60
Fix multiple redirected clients not dropped in the same tick
...
Closes #8551 .
2024-07-09 18:10:42 +02:00
Dennis Felsing
20d6add02f
Merge pull request #8572 from fokkonaut/entities
...
Update F-DDrace entities by Souly
2024-07-09 16:05:41 +00:00
Dennis Felsing
4ee5dfdbe6
Dilate new images
2024-07-09 17:47:55 +02:00
meloƞ
2c6eb73ed7
new lock indic. partially closes ddnet#8467
...
Co-Authored-by: catseyenebulous
2024-07-09 17:32:06 +02:00
fokkonaut
3e3017f557
Update F-DDrace entities
2024-07-09 16:27:12 +02:00
ChillerDragon
7b540ddb16
Remove support for space separation
2024-07-09 08:30:59 +08:00
Dennis Felsing
9143f2eac7
Merge pull request #8571 from Robyt3/Tools-Map-Extract-Refactoring
...
Improve `map_extract` tool: fix crash when opus file cannot be opened, improve logging, refactoring
2024-07-08 21:44:05 +00:00
Robert Müller
526251293c
Use static_cast and const pointers for map items
2024-07-08 22:21:51 +02:00
Robert Müller
4c702395db
Split map_extract tool into separate functions
...
Improve readability by splitting the `map_extract` tool into multiple functions.
2024-07-08 22:21:28 +02:00
Robert Müller
b81ac61556
Unload image and sound data in map_extract tool sooner
...
Reduce the memory footprint of the tool by unloading the map data as soon as possible instead of only implicitly when the `CDataFileReader` is destructed.
2024-07-08 22:21:14 +02:00
Robert Müller
c9467454d3
Improve logging of map_extract tool
...
Use `log_info` and `log_error` instead of `dbg_msg`.
Add error messages when output files cannot be opened for writing.
Move log messages regarding files being written so they are only printed when the files are actually being written.
2024-07-08 22:20:57 +02:00
Robert Müller
4c4b2e9edc
Fix map_extract tool crashing if opus file cannot be opened
2024-07-08 22:20:51 +02:00
heinrich5991
5645556bda
Merge pull request #8557 from Robyt3/Rust-Override-Fix
...
Fix rustup toolchain overrides not working with MSVC
2024-07-07 21:19:21 +00:00
Robert Müller
1b4e8ce3d3
Merge pull request #8553 from art0007i/test
...
add "/setjumps" practice command and "setjumps" rcon command
2024-07-07 15:07:28 +00:00
art0007i
03f934c81e
add "/setjumps" practice command and "setjumps" rcon command
2024-07-07 16:43:02 +02:00
Robert Müller
dc73da4514
Merge pull request #8497 from archimede67/teamcount-sb
...
Add team size indicator
2024-07-07 10:30:28 +00:00
Corantin H
816c64235c
Add team size indicator in scoreboard and through /team
2024-07-07 11:26:01 +02:00
Dennis Felsing
aee9c7222f
Merge pull request #8567 from archimede67/editor-fix-automapper-issues
...
[Editor] Fix various automapper issues
2024-07-06 21:22:29 +00:00
Corantin H
698603d63c
Fix various automapper issues
...
Fix invalid logic for skipping empty tiles in automapper
Fix partial default rule search
Fix reading from wrong layer when proceeding
2024-07-06 16:22:48 +02:00
Robert Müller
60ab717f03
Merge pull request #8564 from ChillerDragon/pr_clang_editor
...
Fix some clang warnings in the editor
2024-07-06 10:51:04 +00:00
ChillerDragon
d6cf127056
Fix some clang warnings in the editor
2024-07-06 17:53:10 +08:00
Robert Müller
bb7d42444f
Merge pull request #8565 from ChillerDragon/pr_more_clang_style
...
Improve clang variable naming checks
2024-07-06 08:15:11 +00:00
ChillerDragon
7553ea6297
Improve clang variable naming checks
...
Introduces checks for more variable types.
And fixes false positives in newer clang versions.
2024-07-06 10:10:00 +08:00
ChillerDragon
43a493445b
Also split commands on spaces
2024-07-06 07:59:52 +08:00
ChillerDragon
5d43d346e7
Also split commands on double quotes
2024-07-06 07:59:52 +08:00
ChillerDragon
6b0b49e414
Look at command under cursor not at the end of the line
2024-07-06 07:59:52 +08:00
ChillerDragon
54977d5745
Auto complete when chaining multiple commands
...
closed #7966
2024-07-06 07:59:51 +08:00
ChillerDragon
89437b7ef7
Fix console search with multiple commands
2024-07-06 07:59:51 +08:00
ChillerDragon
c8656635b9
Show help text when chaining multiple commands
2024-07-06 07:59:51 +08:00
Dennis Felsing
fb6a6ccc43
Merge pull request #8563 from Robyt3/Server-Random-Map-Crash
...
Fix server crash when starting with `random(_unfinished)_map`
2024-07-05 22:23:13 +00:00
Robert Müller
ecafa10dfa
Fix server crash when starting with random(_unfinished)_map
...
See #8559 .
2024-07-05 20:31:52 +02:00
ChillerDragon
