Robert Müller
c8f6811aba
Also print external module/symbol names in parse_drmingw.sh
...
Example output before this change:
```
Module offset: 0x00007FF7C8DE0000
Image base: 0x0000000140000000
0x0000000772cb5efc: ?? ??:0
0x000000077cd5c3e8: ?? ??:0
0x000000075d063cc3: ?? ??:0
0x000000075d2a3d61: ?? ??:0
0x000000075d0b7fde: ?? ??:0
0x000000075d2a5f18: ?? ??:0
0x000000075d2a6809: ?? ??:0
0x000000075d0b8140: ?? ??:0
0x000000075cf9d41b: ?? ??:0
0x000000014034b4c7: CCommandProcessorFragment_Vulkan::WaitFrame() at src/engine/client/backend/vulkan/backend_vulkan.cpp:2341
0x000000014034a1a5: CCommandProcessorFragment_Vulkan::NextFrame() at src/engine/client/backend/vulkan/backend_vulkan.cpp:2501
0x000000014032d5b6: CCommandProcessorFragment_Vulkan::RunCommand(CCommandBuffer::SCommand const*) at src/engine/client/backend/vulkan/backend_vulkan.cpp:6473
0x000000014001a7e6: CCommandProcessor_SDL_GL::RunBuffer(CCommandBuffer*) at src/engine/client/backend_sdl.cpp:335
0x00000001400168eb: CGraphicsBackend_Threaded::ThreadFunc(void*) at src/engine/client/backend_sdl.cpp:65
0x0000000140237f9a: CWindowsComLifecycle::~CWindowsComLifecycle() at src/base/system.cpp:4660
(inlined by) thread_run at src/base/system.cpp:796
0x00000007ea7e257d: ?? ??:0
0x00000007eb62aa48: ?? ??:0
```
Output for the same crash dump with this change:
```
Module offset: 0x00007FF7C8DE0000
Image base: 0x0000000140000000
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0x1f40c
atig6pxx.dll!AmdGetCallbackProcs+0x124
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0x57773
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0x297811
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0xaba8e
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0x2999c8
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0x29a2b9
amdvlk64.dll!vk_icdGetInstanceProcAddrSG+0xabbf0
amdvlk64.dll!IcdPresentBuffers+0xb8eb
0x000000014034b4c7: CCommandProcessorFragment_Vulkan::WaitFrame() at src/engine/client/backend/vulkan/backend_vulkan.cpp:2341
0x000000014034a1a5: CCommandProcessorFragment_Vulkan::NextFrame() at src/engine/client/backend/vulkan/backend_vulkan.cpp:2501
0x000000014032d5b6: CCommandProcessorFragment_Vulkan::RunCommand(CCommandBuffer::SCommand const*) at src/engine/client/backend/vulkan/backend_vulkan.cpp:6473
0x000000014001a7e6: CCommandProcessor_SDL_GL::RunBuffer(CCommandBuffer*) at src/engine/client/backend_sdl.cpp:335
0x00000001400168eb: CGraphicsBackend_Threaded::ThreadFunc(void*) at src/engine/client/backend_sdl.cpp:65
0x0000000140237f9a: CWindowsComLifecycle::~CWindowsComLifecycle() at src/base/system.cpp:4660
(inlined by) thread_run at src/base/system.cpp:796
KERNEL32.DLL!BaseThreadInitThunk+0x1d
ntdll.dll!RtlUserThreadStart+0x28
```
Also improve variable names in the script and add some comments.
2024-05-17 19:35:37 +02:00
archimede67
0f5b14c043
Merge pull request #8360 from Robyt3/UI-ButtonLogic-Consistency
...
Fix inconsistent behavior of scrollbars, key readers, edit boxes, value selectors and editor sound seekbars
2024-05-16 21:25:46 +00:00
archimede67
8a3635f243
Merge pull request #8371 from Robyt3/Scripts-CopyFix-Lint-Fix
...
Fix `possibly-used-before-assignment` in `copy_fix.py`
2024-05-16 21:23:55 +00:00
Robert Müller
e341c56c35
Fix possibly-used-before-assignment
in copy_fix.py
...
Always initialize the variables `local` and `supported` instead of initializing them conditionally, to fix the false-positive `possibly-used-before-assignment` pylint detection.
Closes #8369 .
2024-05-16 20:46:14 +02:00
heinrich5991
392fc0ba9a
str_from_int
→ str_format
2024-05-14 21:37:02 +02:00
Vlad
4532a64b2b
Add rescuemodes
...
May `/rescuemode` be case-insensitive
clang-tidy
conflicts
clang-tidy
`CMDFLAG_PRACTICE`
2024-05-14 09:19:50 +03:00
ChillerDragon
f3a686bc62
Show percentage of loaded rcon commands
...
closed #7769
2024-05-14 08:46:17 +08:00
heinrich5991
03b13cb9f5
Merge pull request #8355 from Patiga/fix-pixelart
...
Fix off-by-one error in map_create_pixelart
2024-05-13 22:37:13 +00:00
heinrich5991
3889bf89d8
Merge pull request #8344 from yrrrmmbl/master
...
add option to show only messages by team members
2024-05-13 17:36:30 +00:00
yrrrmmbl
a93ad48dce
add cl_show_chat_team to only show team members' messages
2024-05-13 19:18:41 +02:00
Robert Müller
f3bb5feffc
Merge pull request #8347 from Jupeyy/pr_vk_minirefactor
...
Fix segfault when swapchain images change (e.g. toggling Vsync)
2024-05-12 20:16:30 +00:00
Robert Müller
1c123f2324
Fix inconsistent button behavior of remaining UI elements
...
Fix edit boxes, scrollbars, value selectors and the editor sound seekbar being activated by holding the left mouse button from outside the UI element and then hovering it, which is inconsistent with the behavior of the `DoButtonLogic` function.
2024-05-12 18:16:06 +02:00
Robert Müller
d431a5cdeb
Fix inconsistent key reader button behavior
...
Use the `DoButtonLogic` function directly for the key reader buttons in the controls settings. Now, the key reader will only be activated when the left click is initiated and completed inside the key reader button. Previously, the key reader would be activated immediately when holding the left mouse button from outside and then hovering the key reader, and the key reader was already activated by the press-event, whereas now it will only be activated by the release event of the left mouse button. The active key reader UI ID is now tracked as a member variable of `CMenusKeyBinder` to avoid using static variables for this purpose.
2024-05-12 18:15:49 +02:00
Robert Müller
e822d6878b
Fix scrollregion scrollbar position offset after releasing handle
...
The scrollregion scrollbar was not being deactivated if the handle is continued to be hovered after releasing it, causing the handle to become offset with the position of the click on the next activation of the handle.
2024-05-12 18:15:39 +02:00
heinrich5991
0562be67f4
Merge pull request #8353 from Robyt3/Client-Demo-Seekbar-UX-Fixes
...
Fix demo seekbar tooltip not shown while seekbar is active, fix demo seekbar being activated by held button press
2024-05-12 01:45:33 +00:00
heinrich5991
acde8806db
Merge pull request #8354 from Robyt3/Menus-Settings-Controller-Size-Fix
...
Fix height of controller settings with exactly 1 controller
2024-05-12 01:26:08 +00:00
heinrich5991
0c66786fb6
Merge pull request #8349 from Robyt3/Mapitem-Image-Cleanup
...
Remove unused `CImageInfo::ImageFormatFromInt`
2024-05-12 01:16:45 +00:00
Patiga
4f62980541
Fix off-by-one error in map_create_pixelart
2024-05-11 19:53:56 +02:00
Robert Müller
b8cb67379c
Fix height of controller settings with exactly 1 controller
...
The controller name is also shown if there is only exactly one controller connected, but the height was not increased for the additional row.
2024-05-11 15:10:15 +02:00
Robert Müller
c6c8f2eab6
Fix demo seekbar being activated by held button press
...
The seekbar is immediately activated if the mouse button is held while moving the mouse over the seekbar, which is inconsistent with the general `DoButtonLogic` behavior. This is problematic on Android, where the first mouse button is always pressed while the mouse is being moved, causing the seekbar to steal focus immediately when hovered.
2024-05-11 12:29:33 +02:00
Robert Müller
7d0774a00d
Fix demo seekbar tooltip not shown while seekbar is active
...
The tooltip was not shown if the seekbar is the active item, i.e. when the first mouse button is held down and the seekbar is currently updating the demo player.
2024-05-11 12:26:46 +02:00
Robert Müller
74e2e04b7d
Remove unused CImageInfo::ImageFormatFromInt
...
Since the image format is not parsed from maps anymore, this function is unnecessary.
2024-05-10 21:44:49 +02:00
Robert Müller
d34fc96049
Merge pull request #8348 from furo321/map_create_pixelart
...
Fix issues with `map_create_pixelart`
2024-05-10 18:06:49 +00:00
furo
3491624184
Fix crash when not specifying optimize
, centralize
or invalid amount of arguments
2024-05-10 19:05:58 +02:00
Jupeyy
15afc50865
Don't recreate DescriptorSetLayouts if swapchain image count changes
2024-05-10 18:48:09 +02:00
Jupeyy
128302d726
Cleanup Vulkan now takes SwapchainCount
as explicit parameter.
...
This fixes a crash if the swapchain count changed.
fixes #8328
2024-05-10 18:48:09 +02:00
Jupeyy
2655627a4b
Rename m_CurFrames
to make clear it's about the sync objects.
...
Use one more sync object than there are inflight frames.
Remove unused memory sync objects.
2024-05-10 18:48:05 +02:00
furo
7cd9d8bbb4
Prevent using map_create_pixelart
with the same input and output path
2024-05-10 18:42:55 +02:00
furo
39dd6ea499
Fix wrong filename used in dbg_msg
2024-05-10 18:20:33 +02:00
furo
d5b06a4482
Use IO_MAX_PATH_LENGTH
instead of 64
2024-05-10 18:18:24 +02:00
heinrich5991
500b9c943b
Merge pull request #8346 from furo321/sqlite-timeout
...
Set sqlite3 `.timeout` in `integration_test.sh`
2024-05-10 16:09:01 +00:00
furo
6864fc171b
Include map_create_pixelart
in release
2024-05-10 18:07:20 +02:00
furo
b24f14d4f3
Set sqlite3 .timeout
in integration_test.sh
2024-05-10 17:48:44 +02:00
Dennis Felsing
02a4e58972
Merge pull request #8343 from Robyt3/Client-Chat-History-Size-Fix
...
Fix size of chat history entry allocation
2024-05-10 12:20:44 +00:00
Robert Müller
c80592063a
Fix size of chat history entry allocation
...
The `-1` in the size calculation for the ringbuffer allocation of chat history entries was incorrect, so the entries potentially didn't fit the zero terminator. Because `mem_copy` was used, the string was also not zero terminated explicitly.
2024-05-10 10:53:23 +02:00
heinrich5991
60dbd73ee3
Merge pull request #8333 from BlaiZephyr/change-time-timestamp-type
...
Change type from int to int64_t
2024-05-09 08:01:17 +00:00
heinrich5991
c0a6bb9c88
Merge pull request #8336 from gerdoe-jr/set_view_relative
...
Add `set_view_relative` (Closes #8335 )
2024-05-09 07:52:04 +00:00
meloƞ
aec0dc9e0e
Change type from int to int64_t
2024-05-09 08:42:19 +02:00
gerdoe-jr
4f0d8a5a1f
add set_view_relative
2024-05-09 06:28:55 +03:00
heinrich5991
3887eea18d
Merge pull request #8332 from heinrich5991/pr_ddnet_fix_token_7
...
Fix 0.7 tokens after #8322
2024-05-08 13:12:32 +00:00
heinrich5991
c211e874aa
Fix 0.7 tokens after #8322
...
They're also read as big-endian integers now.
Thanks to @ChillerDragon for noticing.
Fixes #8330 .
2024-05-08 14:17:02 +02:00
Dennis Felsing
f214c1101b
Merge pull request #8326 from heinrich5991/pr_ddnet_no_map_image_rgb
...
Remove RGB images from the map file format
2024-05-08 04:56:19 +00:00
Dennis Felsing
587b545ab1
Merge pull request #8327 from heinrich5991/pr_ddnet_revert_initialize_variables
...
Revert "Initialize all ghost item member (Closed #8297 )"
2024-05-08 04:56:16 +00:00
heinrich5991
8a64feabc3
Remove RGB images from the map file format
...
Cherry-picked from https://github.com/teeworlds/teeworlds/pull/2822 .
CC https://github.com/teeworlds/teeworlds/issues/2812
CC https://github.com/teeworlds/teeworlds/issues/962
Since DDNet never saved these kinds of images, this should cause no
issues.
2024-05-07 14:31:06 +02:00
heinrich5991
3a48b8e6cf
Revert "Initialize all ghost item member ( Closed #8297 )"
...
This reverts commit f319ed239a
.
Initializing these variables with junk data doesn't seem to be an
improvement over not initializing them. It hides potential Valgrind
warnings about data accesses to uninitialized memory though.
f319ed239a (r1590801501)
2024-05-07 14:25:29 +02:00
Dennis Felsing
df30321f52
Merge pull request #8324 from ewancg/chat-practice
...
Add chat commands for toggling weapons in practice mode
2024-05-07 05:42:38 +00:00
Dennis Felsing
edff7841e8
Merge pull request #8320 from ChillerDragon/pr_tidy_more
...
Enforce more styling with clang tidy
2024-05-07 04:45:34 +00:00
Dennis Felsing
ae2c9e2999
Merge pull request #8323 from Robyt3/Client-Particles-Smoke-Nudge
...
Fix smoke particles sometimes being stuck inside solid tiles
2024-05-07 01:21:37 +00:00
Ewan Green
87cab3ebd9
change GetPracticeCharacter() to not be static, fix solo checks
2024-05-06 15:06:42 -06:00
Ewan Green
ba5b39d294
change forgotten functions to use practice check
2024-05-06 14:08:51 -06:00