edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-19 06:28:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak of opus file structure

Browse source 
We were not calling `op_free` for `OggOpusFile *` after decoding opus files.
This commit is contained in:
Robert Müller 2024-04-25 20:28:07 +02:00
parent cfb5b15222
commit d0e27fdcd4
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/engine/client/sound.cpp
View file

@ -350,6 +350,7 @@ bool CSound::DecodeOpus(CSample &Sample, const void *pData, unsigned DataSize) c
if(NumChannels > 2) if(NumChannels > 2)
{ {
op_free(pOpusFile);
dbg_msg("sound/opus", "file is not mono or stereo."); dbg_msg("sound/opus", "file is not mono or stereo.");
return false; return false;
} }
@ -363,6 +364,7 @@ bool CSound::DecodeOpus(CSample &Sample, const void *pData, unsigned DataSize) c
if(Read < 0) if(Read < 0)
{ {
free(pSampleData); free(pSampleData);
op_free(pOpusFile);
dbg_msg("sound/opus", "op_read error %d at %d", Read, Pos); dbg_msg("sound/opus", "op_read error %d at %d", Read, Pos);
return false; return false;
} }
@ -371,6 +373,8 @@ bool CSound::DecodeOpus(CSample &Sample, const void *pData, unsigned DataSize) c
Pos += Read; Pos += Read;
} }
op_free(pOpusFile);
Sample.m_pData = pSampleData; Sample.m_pData = pSampleData;
Sample.m_NumFrames = Pos; Sample.m_NumFrames = Pos;
Sample.m_Rate = 48000; Sample.m_Rate = 48000;