From cd574d10a710dc90980ed8dc3167f15835bc3bca Mon Sep 17 00:00:00 2001 From: GreYFoXGTi Date: Sat, 12 Feb 2011 22:31:42 +0200 Subject: [PATCH] Added sv_vote_majority, 1 like vanilla, 0 Consider number of yes against Number of Yes + No --- src/engine/shared/config_variables.h | 3 +- src/game/server/gamecontext.cpp | 42 +++++++++++++++++----------- src/game/server/gamecontext.h | 1 + 3 files changed, 28 insertions(+), 18 deletions(-) diff --git a/src/engine/shared/config_variables.h b/src/engine/shared/config_variables.h index 978f8a46f..c73fc1bf5 100644 --- a/src/engine/shared/config_variables.h +++ b/src/engine/shared/config_variables.h @@ -129,11 +129,12 @@ MACRO_CONFIG_INT(SvInfoChangeDelay, sv_info_change_delay, 5, 0, 9999, CFGFLAG_SE MACRO_CONFIG_INT(SvVoteMapTimeDelay, sv_vote_map_delay,0,0,9999,CFGFLAG_SERVER, "The minimum time in seconds between map votes", 3) MACRO_CONFIG_INT(SvVoteDelay, sv_vote_delay, 3, 0, 9999, CFGFLAG_SERVER, "The time in seconds between any vote", 3) MACRO_CONFIG_INT(SvVoteKickTimeDelay, sv_vote_kick_delay, 0, 0, 9999, CFGFLAG_SERVER, "The minimum time in seconds between kick votes", 3) +MACRO_CONFIG_INT(SvVoteYesPercentage, sv_vote_yes_percentage, 50, 1, 100, CFGFLAG_SERVER, "The percent of people that need to agree or deny for the vote to succeed/fail", 4) +MACRO_CONFIG_INT(SvVoteMajority, sv_vote_majority, 0, 0, 1, CFGFLAG_SERVER, "Whether No. of Yes is compared to No. of No votes or to number of total Players ( Default is 0 Y compare N)", 4) MACRO_CONFIG_INT(SvSpectatorVotes, sv_spectator_votes, 1, 0, 1, CFGFLAG_SERVER, "Choose if spectators are allowed to start votes", 3) MACRO_CONFIG_INT(SvKillDelay, sv_kill_delay,3,0,9999,CFGFLAG_SERVER, "The minimum time in seconds between kills", 3) MACRO_CONFIG_INT(SvSuicidePenalty, sv_suicide_penalty,0,0,9999,CFGFLAG_SERVER, "The minimum time in seconds between kill or /kills and respawn", 3) -MACRO_CONFIG_INT(SvVotePercentage, sv_vote_percentage, 50, 1, 100, CFGFLAG_SERVER, "The percent of people that need to agree or deny for the vote to succeed/fail", 4) MACRO_CONFIG_INT(SvShotgunBulletSound, sv_shotgun_bullet_sound, 0, 0, 1, CFGFLAG_SERVER, "Crazy shotgun bullet sound on/off", 3) MACRO_CONFIG_INT(SvCheckpointSave, sv_checkpoint_save, 1, 0, 1, CFGFLAG_SERVER, "Whether to save checkpoint times to the score file", 3) diff --git a/src/game/server/gamecontext.cpp b/src/game/server/gamecontext.cpp index 51236e666..1fbb79272 100644 --- a/src/game/server/gamecontext.cpp +++ b/src/game/server/gamecontext.cpp @@ -495,12 +495,17 @@ void CGameContext::OnTick() No++; } - if(Yes > Total / (100.0 / g_Config.m_SvVotePercentage)) + if(Yes > Total / (100.0 / g_Config.m_SvVoteYesPercentage)) m_VoteEnforce = VOTE_ENFORCE_YES; - else if(No >= Total - Total / (100.0 / g_Config.m_SvVotePercentage)) + else if(No >= Total - Total / (100.0 / g_Config.m_SvVoteYesPercentage)) m_VoteEnforce = VOTE_ENFORCE_NO; + + m_VoteWillPass = Yes > (Yes + No) / (100.0 / g_Config.m_SvVoteYesPercentage); } + if(time_get() > m_VoteCloseTime && !g_Config.m_SvVoteMajority) + m_VoteEnforce = (m_VoteWillPass) ? VOTE_ENFORCE_YES : VOTE_ENFORCE_NO; + if(m_VoteEnforce == VOTE_ENFORCE_YES) { Console()->ExecuteLine(m_aVoteCommand, 4, -1, CServer::SendRconLineAuthed, Server(), SendChatResponseAll, this); @@ -513,21 +518,20 @@ void CGameContext::OnTick() else if(m_VoteEnforce == VOTE_ENFORCE_YES_ADMIN) { char aBuf[64]; - str_format(aBuf, sizeof(aBuf),"Vote passed enforced by '%s'",Server()->ClientName(m_VoteEnforcer)); + str_format(aBuf, sizeof(aBuf),"Vote passed enforced by '%s'", (m_VoteEnforcer < 0) ? "Server Administrator" : Server()->ClientName(m_VoteEnforcer)); Console()->ExecuteLine(m_aVoteCommand, 3, -1, CServer::SendRconLineAuthed, Server(), SendChatResponseAll, this); SendChat(-1, CGameContext::CHAT_ALL, aBuf); - dbg_msg("Vote","Due to vote enforcing, vote level has been set to 3"); EndVote(); m_VoteEnforcer = -1; } else if(m_VoteEnforce == VOTE_ENFORCE_NO_ADMIN) { char aBuf[64]; - str_format(aBuf, sizeof(aBuf),"Vote failed enforced by '%s'",Server()->ClientName(m_VoteEnforcer)); + str_format(aBuf, sizeof(aBuf),"Vote failed enforced by '%s'", (m_VoteEnforcer < 0) ? "Server Administrator" : Server()->ClientName(m_VoteEnforcer)); EndVote(); SendChat(-1, CGameContext::CHAT_ALL, aBuf); } - else if(m_VoteEnforce == VOTE_ENFORCE_NO || time_get() > m_VoteCloseTime) + else if(m_VoteEnforce == VOTE_ENFORCE_NO || (time_get() > m_VoteCloseTime && g_Config.m_SvVoteMajority)) { EndVote(); SendChat(-1, CGameContext::CHAT_ALL, "Vote failed"); @@ -1120,11 +1124,11 @@ void CGameContext::ConTuneParam(IConsole::IResult *pResult, void *pUserData, int { char aBuf[256]; str_format(aBuf, sizeof(aBuf), "%s changed to %.2f", pParamName, NewValue); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "tuning", aBuf); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "tuning", aBuf); pSelf->SendTuningParams(-1); } else - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "tuning", "No such tuning parameter"); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "tuning", "No such tuning parameter"); } void CGameContext::ConTuneReset(IConsole::IResult *pResult, void *pUserData, int ClientId) @@ -1133,7 +1137,7 @@ void CGameContext::ConTuneReset(IConsole::IResult *pResult, void *pUserData, int CTuningParams p; *pSelf->Tuning() = p; pSelf->SendTuningParams(-1); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "tuning", "Tuning reset"); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "tuning", "Tuning reset"); } void CGameContext::ConTuneDump(IConsole::IResult *pResult, void *pUserData, int ClientId) @@ -1201,7 +1205,7 @@ void CGameContext::ConSetTeamAll(IConsole::IResult *pResult, void *pUserData, in char aBuf[256]; str_format(aBuf, sizeof(aBuf), "moved all clients to team %d", Team); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); for(int i = 0; i < MAX_CLIENTS; ++i) if(pSelf->m_apPlayers[i]) @@ -1220,7 +1224,7 @@ void CGameContext::ConAddVote(IConsole::IResult *pResult, void *pUserData, int C { char aBuf[256]; str_format(aBuf, sizeof(aBuf), "skipped invalid option '%s'", pResult->GetString(0)); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); return; } @@ -1231,7 +1235,7 @@ void CGameContext::ConAddVote(IConsole::IResult *pResult, void *pUserData, int C { char aBuf[256]; str_format(aBuf, sizeof(aBuf), "option '%s' already exists", pString); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); return; } pOption = pOption->m_pNext; @@ -1251,7 +1255,7 @@ void CGameContext::ConAddVote(IConsole::IResult *pResult, void *pUserData, int C mem_copy(pOption->m_aCommand, pString, Len+1); char aBuf[256]; str_format(aBuf, sizeof(aBuf), "added option '%s'", pOption->m_aCommand); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); CNetMsg_Sv_VoteOption OptionMsg; OptionMsg.m_pCommand = pOption->m_aCommand; @@ -1262,7 +1266,7 @@ void CGameContext::ConClearVotes(IConsole::IResult *pResult, void *pUserData, in { CGameContext *pSelf = (CGameContext *)pUserData; - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "server", "cleared votes"); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "server", "cleared votes"); CNetMsg_Sv_VoteClearOptions VoteClearOptionsMsg; pSelf->Server()->SendPackMsg(&VoteClearOptionsMsg, MSGFLAG_VITAL, -1); pSelf->m_pVoteOptionHeap->Reset(); @@ -1273,16 +1277,20 @@ void CGameContext::ConClearVotes(IConsole::IResult *pResult, void *pUserData, in void CGameContext::ConVote(IConsole::IResult *pResult, void *pUserData, int ClientID) { CGameContext *pSelf = (CGameContext *)pUserData; + bool Private = false; if(str_comp_nocase(pResult->GetString(0), "yes") == 0) pSelf->m_VoteEnforce = CGameContext::VOTE_ENFORCE_YES_ADMIN; else if(str_comp_nocase(pResult->GetString(0), "no") == 0) pSelf->m_VoteEnforce = CGameContext::VOTE_ENFORCE_NO_ADMIN; else return; + if(str_comp_nocase(pResult->GetString(1), "yes") == 0) + Private = true; char aBuf[256]; str_format(aBuf, sizeof(aBuf), "forcing vote %s", pResult->GetString(0)); - pSelf->Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); - pSelf->m_VoteEnforcer = ClientID; + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "server", aBuf); + pSelf->Console()->PrintResponse(IConsole::OUTPUT_LEVEL_STANDARD, "info", "Due to vote enforcing, vote level has been set to 3"); + pSelf->m_VoteEnforcer = (Private) ? -1 : ClientID; } void CGameContext::ConchainSpecialMotdupdate(IConsole::IResult *pResult, void *pUserData, IConsole::FCommandCallback pfnCallback, void *pCallbackUserData) @@ -1317,7 +1325,7 @@ void CGameContext::OnConsoleInit() Console()->Register("addvote", "r", CFGFLAG_SERVER, ConAddVote, this, "", 4); Console()->Register("clear_votes", "", CFGFLAG_SERVER, ConClearVotes, this, "", 3); - Console()->Register("vote", "r", CFGFLAG_SERVER, ConVote, this, "", 3); + Console()->Register("vote", "s ?s", CFGFLAG_SERVER, ConVote, this, "Force the vote to yes or no?, Make the forcing of the vote private?", 3); #define CONSOLE_COMMAND(name, params, flags, callback, userdata, help, level) m_pConsole->Register(name, params, flags, callback, userdata, help, level); #include "game/ddracecommands.h" diff --git a/src/game/server/gamecontext.h b/src/game/server/gamecontext.h index 6cdd7e9a4..b2622810b 100644 --- a/src/game/server/gamecontext.h +++ b/src/game/server/gamecontext.h @@ -65,6 +65,7 @@ class CGameContext : public IGameServer void Construct(int Resetting); bool m_Resetting; + bool m_VoteWillPass; public: IServer *Server() const { return m_pServer; } class IConsole *Console() { return m_pConsole; }