3212: fix some skins r=def- a=l-ouis

some changes for skins
1. fix paladin border
old:
![screenshot_2020-10-29_21-22-53](https://user-images.githubusercontent.com/69405348/97653704-69751d00-1a2f-11eb-9247-f2b0fc1edcb5.png)
new:
![screenshot_2020-10-29_21-26-06](https://user-images.githubusercontent.com/69405348/97653705-6a0db380-1a2f-11eb-9c2f-82fac2502901.png)

~~2. fix capitalization on "Aoe4leg" and "PaladiN" to "aoe4leg" and "paladin". skin names should not start with a capital letter because it pushes it to the top of the skin list, messing up alphabetical order (maybe should fix this with the code, not with skin names)~~

3. remove terrorist skin - it is quite un-teeish and I don't think it belongs in the client-shipped skin list.

## Checklist

- [x] Tested the change ingame
- [x] Provided screenshots if it is a visual change
- [x] Tested in combination with possibly related configuration options
- [x] Written a unit test if it works standalone, system.c especially
- [x] Considered possible null pointers and out of bounds array indexing
- [x] Changed no physics that affect existing maps
- [x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional)

idk all this code checklist stuff I don't think I need to test since it's just file changes

also, idk how to use github so I probably forked the wrong repository or something idk


Co-authored-by: louis <69405348+l-ouis@users.noreply.github.com>
This commit is contained in:
bors[bot] 2020-10-30 09:15:22 +00:00 committed by GitHub
commit bf78847656
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 1 deletions

View file

@ -1184,7 +1184,6 @@ set(EXPECTED_DATA
shader/tile.vert
skins/Aoe4leg.png
skins/PaladiN.png
skins/Terrorist.png
skins/antiantey.png
skins/beast.png
skins/blacktee.png

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.7 KiB

After

Width:  |  Height:  |  Size: 7.9 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 14 KiB