edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 10:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix multi-line text selection not rendered correctly anymore

Browse source 
The `CTextCursor::m_LineCount` variable is only updated after the cursor is rendered. For calculating the selection quads we need to check `LineCount` instead, which is updated while the cursor is being rendered. Regression from #7733.
This commit is contained in:
Robert Müller 2024-01-13 23:09:20 +01:00
parent 84cbd362e8
commit a873485643
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/engine/client/text.cpp
View file

@ -1867,7 +1867,7 @@ public:
if(SelectionStarted && IsRendered) if(SelectionStarted && IsRendered)
{ {
if(!vSelectionQuads.empty() && SelectionQuadLine == pCursor->m_LineCount) if(!vSelectionQuads.empty() && SelectionQuadLine == LineCount)
{ {
vSelectionQuads.back().m_Width += SelWidth; vSelectionQuads.back().m_Width += SelWidth;
} }
@ -1877,7 +1877,7 @@ public:
const float SelectionY = DrawY + (1.0f - pCursor->m_SelectionHeightFactor) * SelectionHeight; const float SelectionY = DrawY + (1.0f - pCursor->m_SelectionHeightFactor) * SelectionHeight;
const float ScaledSelectionHeight = pCursor->m_SelectionHeightFactor * SelectionHeight; const float ScaledSelectionHeight = pCursor->m_SelectionHeightFactor * SelectionHeight;
vSelectionQuads.emplace_back(SelX, SelectionY, SelWidth, ScaledSelectionHeight); vSelectionQuads.emplace_back(SelX, SelectionY, SelWidth, ScaledSelectionHeight);
SelectionQuadLine = pCursor->m_LineCount; SelectionQuadLine = LineCount;
} }
} }