edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-13 03:28:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

More SQL fixes

Browse source 
Should help with some crashes
Still doesn't call thread_init
Still shares statements and connections between threads
This commit is contained in:
Dennis Felsing 2018-12-27 14:31:56 +01:00
parent 18d9e77d43
commit a58ade137d
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/engine/server/sql_server.cpp
View file

@ -36,7 +36,15 @@ CSqlServer::~CSqlServer()
try try
{ {
if (m_pResults) if (m_pResults)
{
delete m_pResults; delete m_pResults;
m_pResults = 0;
}
if (m_pStatement)
{
delete m_pStatement;
m_pStatement = 0;
}
if (m_pConnection) if (m_pConnection)
{ {
delete m_pConnection; delete m_pConnection;
@ -120,7 +128,7 @@ bool CSqlServer::Connect()
} }
m_pConnection = m_pDriver->connect(connection_properties); m_pConnection = m_pDriver->connect(connection_properties);
// Create Statement // Create statement
m_pStatement = m_pConnection->createStatement(); m_pStatement = m_pConnection->createStatement();
if (m_SetUpDB) if (m_SetUpDB)
@ -200,16 +208,20 @@ void CSqlServer::CreateTables()
void CSqlServer::executeSql(const char *pCommand) void CSqlServer::executeSql(const char *pCommand)
{ {
scope_lock LockScope(&m_SqlLock);
m_pStatement->execute(pCommand); m_pStatement->execute(pCommand);
} }
void CSqlServer::executeSqlQuery(const char *pQuery) void CSqlServer::executeSqlQuery(const char *pQuery)
{ {
scope_lock LockScope(&m_SqlLock);
if (m_pResults) if (m_pResults)
{
delete m_pResults; delete m_pResults;
// set it to 0, so exceptions raised from executeQuery can not make m_pResults point to invalid memory
m_pResults = 0;
}
// set it to 0, so exceptions raised from executeQuery can not make m_pResults point to invalid memory
m_pResults = 0;
m_pResults = m_pStatement->executeQuery(pQuery); m_pResults = m_pStatement->executeQuery(pQuery);
} }