edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-09-20 01:24:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix OOB access when stopping a sound that has invalid samples

Browse source
This commit is contained in:
Robert Müller 2022-06-26 22:38:47 +02:00
parent 9932bd76fb
commit 9390ae99b2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/game/client/components/sounds.cpp
View file

@ -228,10 +228,10 @@ void CSounds::Stop(int SetId)
if(m_WaitForSoundJob || SetId < 0 || SetId >= g_pData->m_NumSounds) if(m_WaitForSoundJob || SetId < 0 || SetId >= g_pData->m_NumSounds)
return; return;
CDataSoundset *pSet = &g_pData->m_aSounds[SetId]; const CDataSoundset *pSet = &g_pData->m_aSounds[SetId];
for(int i = 0; i < pSet->m_NumSounds; i++) for(int i = 0; i < pSet->m_NumSounds; i++)
Sound()->Stop(pSet->m_aSounds[i].m_Id); if(pSet->m_aSounds[i].m_Id != -1)
Sound()->Stop(pSet->m_aSounds[i].m_Id);
} }
bool CSounds::IsPlaying(int SetId) bool CSounds::IsPlaying(int SetId)