edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 10:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge #2767

Browse source 
2767: Don't lock SQL writes r=Zwelf a=def-

The slow query logs are full of this:

    # Time: 200906 21:03:43
    # User@Host: teeworlds[teeworlds] @ ger6.ddnet.tw [89.163.212.120]
    # Thread_id: 101540  Schema: teeworlds  QC_hit: No
    # Query_time: 11.012166  Lock_time: 0.000000  Rows_sent: 0  Rows_examined: 0
    # Rows_affected: 0  Bytes_sent: 67
    SET timestamp=1599419023;
    LOCK TABLES record_teamrace WRITE, record_teamrace AS r WRITE;

Do we really need these lock? See also
https://dev.mysql.com/doc/refman/5.7/en/table-locking.html

> InnoDB tables use row-level locking so that multiple sessions and
> applications can read from and write to the same table simultaneously,
> without making each other wait or producing inconsistent results. For
> this storage engine, avoid using the LOCK TABLES statement, because it
> does not offer any extra protection, but instead reduces concurrency.

Co-authored-by: def <dennis@felsin9.de>
This commit is contained in:
bors[bot] 2020-09-06 22:49:26 +00:00 committed by GitHub
parent 297f2764f7 f89766034c
commit 85f8095295
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/game/server/score.cpp
View file

@ -574,11 +574,6 @@ bool CScore::SaveTeamScoreThread(IDbConnection *pSqlServer, const ISqlData *pGam
for(unsigned int i = 0; i < pData->m_Size; i++)
aNames.push_back(pData->m_aNames[i]);
char aTable[512];
str_format(aTable, sizeof(aTable),
"%s_teamrace WRITE, %s_teamrace AS r WRITE",
pSqlServer->GetPrefix(), pSqlServer->GetPrefix());
pSqlServer->Lock(aTable);
std::sort(aNames.begin(), aNames.end());
str_format(aBuf, sizeof(aBuf),
"SELECT l.ID, Name, Time "
@ -645,8 +640,6 @@ bool CScore::SaveTeamScoreThread(IDbConnection *pSqlServer, const ISqlData *pGam
pSqlServer->Step();
}
}
pSqlServer->Unlock();
return true;
}