edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 10:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge #5189

Browse source 
5189: Fix 0 byte malloc in register.cpp (fixes #5187) r=heinrich5991 a=def-

<!-- What is the motivation for the changes of this pull request -->

## Checklist

- [ ] Tested the change ingame
- [ ] Provided screenshots if it is a visual change
- [ ] Tested in combination with possibly related configuration options
- [ ] Written a unit test if it works standalone, system.c especially
- [ ] Considered possible null pointers and out of bounds array indexing
- [ ] Changed no physics that affect existing maps
- [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional)


Co-authored-by: def <dennis@felsin9.de>
This commit is contained in:
bors[bot] 2022-05-23 07:15:54 +00:00 committed by GitHub
parent 344eeaf8aa 76efcc616b
commit 847454f3be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/engine/shared/http.h
View file

@ -1,6 +1,7 @@
#ifndef ENGINE_SHARED_HTTP_H #ifndef ENGINE_SHARED_HTTP_H
#define ENGINE_SHARED_HTTP_H #define ENGINE_SHARED_HTTP_H
#include <algorithm>
#include <atomic> #include <atomic>
#include <engine/shared/jobs.h> #include <engine/shared/jobs.h>
@ -105,7 +106,7 @@ public:
{ {
m_Type = REQUEST::POST; m_Type = REQUEST::POST;
m_BodyLength = DataLength; m_BodyLength = DataLength;
m_pBody = (unsigned char *)malloc(DataLength); m_pBody = (unsigned char *)malloc(std::max((size_t)1, DataLength));
mem_copy(m_pBody, pData, DataLength); mem_copy(m_pBody, pData, DataLength);
} }
void PostJson(const char *pJson) void PostJson(const char *pJson)