edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-09 09:38:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fifo: read() doesn't null-terminate!

Browse source 
valgrind found this with ChillerDragon's integration script extension
This commit is contained in:
def 2022-06-05 20:09:44 +02:00
parent 9a89e58a16
commit 735b0bdf4a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/engine/shared/fifo.cpp
View file

@ -61,9 +61,10 @@ void CFifo::Update()
return;
char aBuf[8192];
int Length = read(m_File, aBuf, sizeof(aBuf));
int Length = read(m_File, aBuf, sizeof(aBuf) - 1);
if(Length <= 0)
return;
aBuf[Length] = '\0';
char *pCur = aBuf;
for(int i = 0; i < Length; ++i)