edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-09-19 09:12:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

server: Disallow moving authed players to spec

Browse source
This commit is contained in:
Dennis Felsing 2024-08-12 19:33:50 +02:00
parent bd92dbddf2
commit 608fba82e0
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/game/server/gamecontext.cpp
View file

@ -2208,10 +2208,10 @@ void CGameContext::OnCallVoteNetMessage(const CNetMsg_Cl_CallVote *pMsg, int Cli
{ {
str_copy(aReason, pMsg->m_pReason, sizeof(aReason)); str_copy(aReason, pMsg->m_pReason, sizeof(aReason));
} }
int Authed = Server()->GetAuthedState(ClientId);
if(str_comp_nocase(pMsg->m_pType, "option") == 0) if(str_comp_nocase(pMsg->m_pType, "option") == 0)
{ {
int Authed = Server()->GetAuthedState(ClientId);
CVoteOptionServer *pOption = m_pVoteOptionFirst; CVoteOptionServer *pOption = m_pVoteOptionFirst;
while(pOption) while(pOption)
{ {
@ -2268,8 +2268,6 @@ void CGameContext::OnCallVoteNetMessage(const CNetMsg_Cl_CallVote *pMsg, int Cli
} }
else if(str_comp_nocase(pMsg->m_pType, "kick") == 0) else if(str_comp_nocase(pMsg->m_pType, "kick") == 0)
{ {
int Authed = Server()->GetAuthedState(ClientId);
if(!g_Config.m_SvVoteKick && !Authed) // allow admins to call kick votes even if they are forbidden if(!g_Config.m_SvVoteKick && !Authed) // allow admins to call kick votes even if they are forbidden
{ {
SendChatTarget(ClientId, "Server does not allow voting to kick players"); SendChatTarget(ClientId, "Server does not allow voting to kick players");
@ -2393,12 +2391,21 @@ void CGameContext::OnCallVoteNetMessage(const CNetMsg_Cl_CallVote *pMsg, int Cli
if(SpectateId < 0 || SpectateId >= MAX_CLIENTS || !m_apPlayers[SpectateId] || m_apPlayers[SpectateId]->GetTeam() == TEAM_SPECTATORS) if(SpectateId < 0 || SpectateId >= MAX_CLIENTS || !m_apPlayers[SpectateId] || m_apPlayers[SpectateId]->GetTeam() == TEAM_SPECTATORS)
{ {
SendChatTarget(ClientId, "Invalid client id to move"); SendChatTarget(ClientId, "Invalid client id to move to spectators");
return; return;
} }
if(SpectateId == ClientId) if(SpectateId == ClientId)
{ {
SendChatTarget(ClientId, "You can't move yourself"); SendChatTarget(ClientId, "You can't move yourself to spectators");
return;
}
int SpectateAuthed = Server()->GetAuthedState(SpectateId);
if(SpectateAuthed > Authed)
{
SendChatTarget(ClientId, "You can't move authorized players to spectators");
char aBufSpectate[128];
str_format(aBufSpectate, sizeof(aBufSpectate), "'%s' called for vote to move you to spectators", Server()->ClientName(ClientId));
SendChatTarget(SpectateId, aBufSpectate);
return; return;
} }
if(!Server()->ReverseTranslate(SpectateId, ClientId)) if(!Server()->ReverseTranslate(SpectateId, ClientId))