edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 10:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7482 from Robyt3/Client-Serverbrowser-CommunityIcon-Leak

Browse source 
Fix leak of community icons when jobs not finished
This commit is contained in:
heinrich5991 2023-11-16 21:06:00 +00:00 committed by GitHub
parent 55098cd313 32bd6f6526
commit 4116d78c6f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/game/client/components/menus.h
View file

@ -520,6 +520,7 @@ protected:
SHA256_DIGEST m_Sha256; SHA256_DIGEST m_Sha256;
CAbstractCommunityIconJob(CMenus *pMenus, const char *pCommunityId, int StorageType); CAbstractCommunityIconJob(CMenus *pMenus, const char *pCommunityId, int StorageType);
virtual ~CAbstractCommunityIconJob();
public: public:
const char *CommunityId() const { return m_aCommunityId; } const char *CommunityId() const { return m_aCommunityId; }

6
src/game/client/components/menus_browser.cpp
View file

@ -1799,6 +1799,12 @@ CMenus::CAbstractCommunityIconJob::CAbstractCommunityIconJob(CMenus *pMenus, con
str_format(m_aPath, sizeof(m_aPath), "communityicons/%s.png", pCommunityId); str_format(m_aPath, sizeof(m_aPath), "communityicons/%s.png", pCommunityId);
} }
CMenus::CAbstractCommunityIconJob::~CAbstractCommunityIconJob()
{
free(m_ImageInfo.m_pData);
m_ImageInfo.m_pData = nullptr;
}
int CMenus::CCommunityIconDownloadJob::OnCompletion(int State) int CMenus::CCommunityIconDownloadJob::OnCompletion(int State)
{ {
State = CHttpRequest::OnCompletion(State); State = CHttpRequest::OnCompletion(State);