edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 10:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Print database connection error that was previously unused

Browse source 
The string copied into `aError` was previously unused because the function immediately returns.

Now the error is logged to the console.
This commit is contained in:
Robert Müller 2023-01-28 14:11:57 +01:00
parent 854dc47cf7
commit 31bcc59a86
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/engine/server/databases/connection_pool.cpp
View file

@ -432,12 +432,12 @@ void CWorker::Print(IConsole *pConsole, CDbConnectionPool::Mode DatabaseMode)
/* static */ /* static */
bool CDbConnectionPool::ExecSqlFunc(IDbConnection *pConnection, CSqlExecData *pData, Write w) bool CDbConnectionPool::ExecSqlFunc(IDbConnection *pConnection, CSqlExecData *pData, Write w)
{ {
char aError[256] = "error message not initialized";
if(pConnection == nullptr) if(pConnection == nullptr)
{ {
str_format(aError, sizeof(aError), "No database given"); dbg_msg("sql", "No database given");
return false; return false;
} }
char aError[256] = "unknown error";
if(pConnection->Connect(aError, sizeof(aError))) if(pConnection->Connect(aError, sizeof(aError)))
{ {
dbg_msg("sql", "failed connecting to db: %s", aError); dbg_msg("sql", "failed connecting to db: %s", aError);