diff --git a/src/base/log.cpp b/src/base/log.cpp index 6814ab6a3..96f53cf36 100644 --- a/src/base/log.cpp +++ b/src/base/log.cpp @@ -5,6 +5,7 @@ #include #include +#include #if defined(CONF_FAMILY_WINDOWS) #define WIN32_LEAN_AND_MEAN @@ -423,18 +424,19 @@ std::unique_ptr log_logger_windows_debugger() } #endif -void CFutureLogger::Set(std::unique_ptr &&pLogger) +void CFutureLogger::Set(std::shared_ptr pLogger) { - ILogger *null = nullptr; + std::shared_ptr null; m_PendingLock.lock(); - ILogger *pLoggerRaw = pLogger.release(); - if(!m_pLogger.compare_exchange_strong(null, pLoggerRaw, std::memory_order_acq_rel)) + if(!std::atomic_compare_exchange_strong_explicit(&m_pLogger, &null, pLogger, std::memory_order_acq_rel, std::memory_order_acq_rel)) { dbg_assert(false, "future logger has already been set and can only be set once"); } + m_pLogger = std::move(pLogger); + for(const auto &Pending : m_vPending) { - pLoggerRaw->Log(&Pending); + m_pLogger->Log(&Pending); } m_vPending.clear(); m_vPending.shrink_to_fit(); @@ -443,7 +445,7 @@ void CFutureLogger::Set(std::unique_ptr &&pLogger) void CFutureLogger::Log(const CLogMessage *pMessage) { - ILogger *pLogger = m_pLogger.load(std::memory_order_acquire); + auto pLogger = std::atomic_load_explicit(&m_pLogger, std::memory_order_acquire); if(pLogger) { pLogger->Log(pMessage); @@ -456,7 +458,7 @@ void CFutureLogger::Log(const CLogMessage *pMessage) void CFutureLogger::GlobalFinish() { - ILogger *pLogger = m_pLogger.load(std::memory_order_acquire); + auto pLogger = std::atomic_load_explicit(&m_pLogger, std::memory_order_acquire); if(pLogger) { pLogger->GlobalFinish(); diff --git a/src/base/logger.h b/src/base/logger.h index 618a1d051..9624c8c12 100644 --- a/src/base/logger.h +++ b/src/base/logger.h @@ -202,7 +202,7 @@ std::unique_ptr log_logger_windows_debugger(); class CFutureLogger : public ILogger { private: - std::atomic m_pLogger; + std::shared_ptr m_pLogger; std::vector m_vPending; std::mutex m_PendingLock; @@ -211,7 +211,7 @@ public: * Replace the `CFutureLogger` instance with the given logger. It'll * receive all log messages sent to the `CFutureLogger` so far. */ - void Set(std::unique_ptr &&pLogger); + void Set(std::shared_ptr pLogger); void Log(const CLogMessage *pMessage) override; void GlobalFinish() override; }; diff --git a/src/engine/shared/engine.cpp b/src/engine/shared/engine.cpp index c46dc9fac..395cf7853 100644 --- a/src/engine/shared/engine.cpp +++ b/src/engine/shared/engine.cpp @@ -30,7 +30,7 @@ public: IStorage *m_pStorage; bool m_Logging; - std::shared_ptr m_pFutureLogger; + std::shared_ptr m_pFutureLogger; char m_aAppName[256]; @@ -115,7 +115,7 @@ public: void SetAdditionalLogger(std::shared_ptr &&pLogger) override { - m_pFutureLogger = pLogger; + m_pFutureLogger->Set(pLogger); } };