edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-09-20 09:34:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge #6710

Browse source 
6710: Use real instead of display string for number line inputs r=def- a=Robyt3

Set input string if it's not identical to the real input string instead of comparing to the display string, which would be incorrect for hidden number inputs.

## Checklist

- [X] Tested the change ingame
- [ ] Provided screenshots if it is a visual change
- [ ] Tested in combination with possibly related configuration options
- [ ] Written a unit test (especially base/) or added coverage to integration test
- [ ] Considered possible null pointers and out of bounds array indexing
- [ ] Changed no physics that affect existing maps
- [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undefinedbehavioursanitizer-or-valgrinds-memcheck) (optional)


Co-authored-by: Robert Müller <robytemueller@gmail.com>
This commit is contained in:
bors[bot] 2023-06-05 18:50:16 +00:00 committed by GitHub
parent aea45741a0 9ce76a1713
commit 23e7d18b29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/game/client/lineinput.cpp
View file

@ -677,7 +677,7 @@ void CLineInputNumber::SetInteger(int Number, int Base)
dbg_assert(false, "Base unsupported");
return;
}
if(str_comp(aBuf, GetDisplayedString()) != 0)
if(str_comp(aBuf, GetString()) != 0)
Set(aBuf);
}
@ -690,7 +690,7 @@ void CLineInputNumber::SetFloat(float Number)
{
char aBuf[32];
str_format(aBuf, sizeof(aBuf), "%.3f", Number);
if(str_comp(aBuf, GetDisplayedString()) != 0)
if(str_comp(aBuf, GetString()) != 0)
Set(aBuf);
}