edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-09-20 17:44:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass parameters by const reference instead of value when possible

Browse source 
According to cppcheck's `passedByValue` error.
This commit is contained in:
Robert Müller 2022-10-30 13:10:53 +01:00
parent 78876abd46
commit 0a0ddf2145
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/game/client/components/ghost.cpp
View file

@ -106,7 +106,7 @@ void CGhost::CGhostPath::SetSize(int Items)
m_NumItems = Items; m_NumItems = Items;
} }
void CGhost::CGhostPath::Add(CGhostCharacter Char) void CGhost::CGhostPath::Add(const CGhostCharacter &Char)
{ {
SetSize(m_NumItems + 1); SetSize(m_NumItems + 1);
*Get(m_NumItems - 1) = Char; *Get(m_NumItems - 1) = Char;

2
src/game/client/components/ghost.h
View file

@ -80,7 +80,7 @@ private:
void SetSize(int Items); void SetSize(int Items);
int Size() const { return m_NumItems; } int Size() const { return m_NumItems; }
void Add(CGhostCharacter Char); void Add(const CGhostCharacter &Char);
CGhostCharacter *Get(int Index); CGhostCharacter *Get(int Index);
}; };

12
src/tools/map_replace_area.cpp
View file

@ -43,12 +43,12 @@ bool AdaptVisiblePoint(const float[2][2][2], const float[2][2], const MapObject[
MapObject CreateMapObject(const CMapItemGroup *, int, int, int, int); MapObject CreateMapObject(const CMapItemGroup *, int, int, int, int);
void SetExtendedArea(MapObject &); void SetExtendedArea(MapObject &);
bool GetVisibleArea(const float[2][2], MapObject, float[2][2] = 0x0); bool GetVisibleArea(const float[2][2], const MapObject &, float[2][2] = 0x0);
bool GetReplaceableArea(const float[2][2], MapObject, float[2][2]); bool GetReplaceableArea(const float[2][2], const MapObject &, float[2][2]);
void GetGameAreaDistance(const float[2][2][2], const MapObject[2], const float[2][2][2], float[2]); void GetGameAreaDistance(const float[2][2][2], const MapObject[2], const float[2][2][2], float[2]);
void GetGameAreaDistance(const float[2][2][2], const MapObject[2], const float[2][2], float[2]); void GetGameAreaDistance(const float[2][2][2], const MapObject[2], const float[2][2], float[2]);
void GetSignificantScreenPos(MapObject, const float[2][2], const float[2][2], float[2]); void GetSignificantScreenPos(const MapObject &, const float[2][2], const float[2][2], float[2]);
void ConvertToTiles(const float[2][2], int[2][2]); void ConvertToTiles(const float[2][2], int[2][2]);
bool GetLineIntersection(const float[2], const float[2], float[2] = 0x0); bool GetLineIntersection(const float[2], const float[2], float[2] = 0x0);
@ -511,7 +511,7 @@ void SetExtendedArea(MapObject &Ob)
} }
} }
bool GetVisibleArea(const float aaGameArea[2][2], const MapObject Ob, float aaVisibleArea[2][2]) bool GetVisibleArea(const float aaGameArea[2][2], const MapObject &Ob, float aaVisibleArea[2][2])
{ {
if(IsInexistent((float *)Ob.m_aaExtendedArea, 4)) if(IsInexistent((float *)Ob.m_aaExtendedArea, 4))
return false; return false;
@ -543,7 +543,7 @@ bool GetVisibleArea(const float aaGameArea[2][2], const MapObject Ob, float aaVi
return true; return true;
} }
bool GetReplaceableArea(const float aaVisibleArea[2][2], const MapObject Ob, float aaReplaceableArea[2][2]) bool GetReplaceableArea(const float aaVisibleArea[2][2], const MapObject &Ob, float aaReplaceableArea[2][2])
{ {
SetInexistent((float *)aaReplaceableArea, 4); SetInexistent((float *)aaReplaceableArea, 4);
if(IsInexistent((float *)aaVisibleArea, 4)) if(IsInexistent((float *)aaVisibleArea, 4))
@ -599,7 +599,7 @@ void GetGameAreaDistance(const float aaaGameAreas[2][2][2], const MapObject aObs
GetGameAreaDistance(aaaGameAreas, aObs, aaaVisibleAreas, aDistance); GetGameAreaDistance(aaaGameAreas, aObs, aaaVisibleAreas, aDistance);
} }
void GetSignificantScreenPos(const MapObject Ob, const float aaVisibleArea[2][2], const float aaReplaceableArea[2][2], float aScreen[2]) void GetSignificantScreenPos(const MapObject &Ob, const float aaVisibleArea[2][2], const float aaReplaceableArea[2][2], float aScreen[2])
{ {
for(int i = 0; i < 2; i++) for(int i = 0; i < 2; i++)
{ {