edg-l/ddnet
1
0
Fork 0
mirror of https://github.com/ddnet/ddnet.git synced 2024-11-10 01:58:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use consistent case for error messages

Browse source 
Use the style introduced by @def- in
61e47422f6
This commit is contained in:
ChillerDragon 2021-08-03 16:14:54 +02:00
parent 3d3c190cd4
commit 02abc95c18
3 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
.github/workflows/style.yml vendored
View file

@ -36,6 +36,15 @@ jobs:
run: scripts/check_dilate.sh release data run: scripts/check_dilate.sh release data
- name: Shellcheck - name: Shellcheck
run: find . -type f -name '*.sh' -print0 | xargs -0 shellcheck run: find . -type f -name '*.sh' -print0 | xargs -0 shellcheck
- name: Check log error case
run: |
if grep -Eqr '(msg|Print).*\(.*"[Ee]rror:' src/;
then
echo "[!] Expect log erros to be in this format 'ERROR: error message'"
echo "[!] Found these non uppercased log errors:"
grep -Er '(msg|Print).*\(.*"[Ee]rror:' src/
exit 1
fi
- name: Pylint - name: Pylint
run: | run: |
pylint --version pylint --version

2
src/engine/client/backend/opengl/backend_opengl.cpp
View file

@ -190,7 +190,7 @@ void CCommandProcessorFragment_OpenGL::SetState(const CCommandBuffer::SState &St
} }
else else
{ {
dbg_msg("opengl", "Error: this call should not happen."); dbg_msg("opengl", "ERROR: this call should not happen.");
} }
} }
} }

6
src/engine/client/client.cpp
View file

@ -3691,7 +3691,7 @@ void CClient::Con_SaveReplay(IConsole::IResult *pResult, void *pUserData)
{ {
int Length = pResult->GetInteger(0); int Length = pResult->GetInteger(0);
if(Length <= 0) if(Length <= 0)
pSelf->m_pConsole->Print(IConsole::OUTPUT_LEVEL_STANDARD, "replay", "Error: length must be greater than 0 second."); pSelf->m_pConsole->Print(IConsole::OUTPUT_LEVEL_STANDARD, "replay", "ERROR: length must be greater than 0 second.");
else else
pSelf->SaveReplay(Length); pSelf->SaveReplay(Length);
} }
@ -3709,9 +3709,9 @@ void CClient::SaveReplay(const int Length)
} }
if(!DemoRecorder(RECORDER_REPLAYS)->IsRecording()) if(!DemoRecorder(RECORDER_REPLAYS)->IsRecording())
m_pConsole->Print(IConsole::OUTPUT_LEVEL_STANDARD, "replay", "Error: demorecorder isn't recording. Try to rejoin to fix that."); m_pConsole->Print(IConsole::OUTPUT_LEVEL_STANDARD, "replay", "ERROR: demorecorder isn't recording. Try to rejoin to fix that.");
else if(DemoRecorder(RECORDER_REPLAYS)->Length() < 1) else if(DemoRecorder(RECORDER_REPLAYS)->Length() < 1)
m_pConsole->Print(IConsole::OUTPUT_LEVEL_STANDARD, "replay", "Error: demorecorder isn't recording for at least 1 second."); m_pConsole->Print(IConsole::OUTPUT_LEVEL_STANDARD, "replay", "ERROR: demorecorder isn't recording for at least 1 second.");
else else
{ {
// First we stop the recorder to slice correctly the demo after // First we stop the recorder to slice correctly the demo after